[PATCH v2 1/7] doc: Add EchoCancelingNoiseReduction to Handsfree

This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to disable this feature in the audio gateway. The HFP spec defines the procedure to turn off echo canceling and noise reduction only. There are some modems that also allow to turn on

[PATCH v2 2/7] core: Add echo-canceling-and-noise-reduction

This patch adds echo-canceling-and-noise-reduction to Features property of the Handsfree interface. --- src/handsfree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 8a0374d..6d7f263 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -62,6 +62,9

[PATCH v2 4/7] core: Set EchoCancelingNoiseReduction to TRUE by default

According to Bluetooth HFP spec: By default, if the AG supports its own embedded echo canceling and/or noise reduction functions, it shall have them activated until the AT+NREC command is received. The configuration set by the HF shall by used by the AG while the Service Level Connection is

[PATCH v2 6/7] hfpmodem: Add EchoCancelingNoiseReduction

This patch adds echo canceling and noise reduction implementation to hfpmodem. --- drivers/hfpmodem/handsfree.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/hfpmodem/handsfree.c b/drivers/hfpmodem/handsfree.c index ce28de3..d7561e7 100644 ---

[PATCH v2 7/7] core: Add SetProperty for EchoCancelingNoiseReduction

This patch extends SetProperty method of the Handsfree interface allowing to disable echo canceling and noise reduction feature in the audio gateway through a D-Bus method call. Once disabled, it is not allowed to enable it using this procedure. --- src/handsfree.c | 56

Re: [PATCH 1/3] bluez5: Add bt_register_profile_full()

Hi Denis, On 03:46 Tue 23 Apr, Denis Kenzior wrote: Hi Vinicius, On 04/22/2013 12:54 PM, Vinicius Costa Gomes wrote: This function makes it easy to set up optional information in the profile service record. --- plugins/bluez5.c | 40 +---

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

Hi Vinicius, On 04/22/2013 05:53 PM, Vinicius Costa Gomes wrote: Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended Inquiry Response is supported. When the

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

Hi Denis, On Tue, Apr 23, 2013, Denis Kenzior wrote: On 04/22/2013 05:53 PM, Vinicius Costa Gomes wrote: Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

Hi Johan, Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended Inquiry Response is supported. When the device is paired, we receive the Paired

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

Hi Marcel, On Tue, Apr 23, 2013, Marcel Holtmann wrote: Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended Inquiry Response is supported. When the

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

Hi Johan, Even for outgoing pairing requests we may receive the UUIDs property changed after the device is paired and try to register it twice. The easiest way to reproduce this is when Extended Inquiry Response is supported. When the device is paired, we receive the Paired

[PATCH v3 1/7] doc: Add EchoCancelingNoiseReduction to Handsfree

This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to disable this feature in the audio gateway. The HFP spec defines the procedure to turn off echo canceling and noise reduction only, it is not allowed to enable this feature from the HF

[PATCH v3 2/7] core: Add echo-canceling-and-noise-reduction

This patch adds echo-canceling-and-noise-reduction to Features property of the Handsfree interface. --- src/handsfree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 8a0374d..6d7f263 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -62,6 +62,9

[PATCH v3 4/7] core: Set EchoCancelingNoiseReduction to TRUE by default

According to Bluetooth HFP spec: By default, if the AG supports its own embedded echo canceling and/or noise reduction functions, it shall have them activated until the AT+NREC command is received. The configuration set by the HF shall by used by the AG while the Service Level Connection is

[PATCH v3 7/7] core: Add SetProperty for EchoCancelingNoiseReduction

This patch extends SetProperty method of the Handsfree interface allowing to disable echo canceling and noise reduction feature in the audio gateway through a D-Bus method call. Once disabled, it is not allowed to enable it using this procedure. --- src/handsfree.c | 54

[PATCH v3 3/7] core: Add EchoCancelingNoiseReduction to GetProperties

This patch adds EchoCancelingNoiseReduction property to GetProperties method of Handsfree interface. --- src/handsfree.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/handsfree.c b/src/handsfree.c index 6d7f263..9e4fc6b 100644 --- a/src/handsfree.c +++ b/src/handsfree.c @@ -45,6

[PATCH v3 5/7] include: Add EchoCancelingNoiseReduction to handsfree driver

This patch extends the handsfree driver adding echo canceling and noise reduction callback to allow disabling this feature in the audio gateway. --- include/handsfree.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/handsfree.h b/include/handsfree.h index b5e0d5f..dde7000 100644

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

Hi Marcel, On Tue, Apr 23, 2013, Marcel Holtmann wrote: I don't completely understand the rationale of wanting to make BlueZ's clients so fragile. You could in theory get new services way after pairing if this is configurable on the remote side. You could also get the result of calling

Re: [PATCH] hfp_hf_bluez5: Fix re-registering a modem for a device

Hi, On 20:28 Tue 23 Apr, Johan Hedberg wrote: Hi Marcel, On Tue, Apr 23, 2013, Marcel Holtmann wrote: I don't completely understand the rationale of wanting to make BlueZ's clients so fragile. You could in theory get new services way after pairing if this is configurable on the

Re: [PATCH v3 1/7] doc: Add EchoCancelingNoiseReduction to Handsfree

Hi Claudio, On 04/23/2013 12:21 PM, Claudio Takahasi wrote: This patch adds echo canceling and noise reduction property to Handsfree interface, allowing the handsfree unit to disable this feature in the audio gateway. The HFP spec defines the procedure to turn off echo canceling and noise

[PATCH v2 2/3] hfp: Add defines for HFP SDP feature bits

--- src/hfp.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/hfp.h b/src/hfp.h index b54de56..0d36ae5 100644 --- a/src/hfp.h +++ b/src/hfp.h @@ -45,6 +45,24 @@ enum hfp_hf_feature { HFP_HF_FEATURE_CODEC_NEGOTIATION = 0x80, }; +enum hfp_sdp_hf_features

[PATCH v2 3/3] hfp_hf_bluez5: Register the SDP record with correct features

--- plugins/hfp_hf_bluez5.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c index 826796f..06b6fd3 100644 --- a/plugins/hfp_hf_bluez5.c +++ b/plugins/hfp_hf_bluez5.c @@ -636,10 +636,15 @@ static const GDBusMethodTable

[PATCH v2 1/3] bluez5: Unify bt_register_profile_* into a single function

It was a cause of confusion for little gain to have separate functions for registering profiles with extra information, for example role and features. We remove those helper functions in favor of a single one with more parameters, role and feature when NULL, will be ignored. --- dundee/bluez5.c