Re: [PATCH v3] atmodem: Query the list of supported s from the modem

2017-10-23 Thread Denis Kenzior
Hi Slava, On 10/23/2017 03:52 PM, Slava Monich wrote: Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 57 --- 1 file changed, 45 insertions(+), 12

Re: [PATCH] gatmux: Remove write watch source at shutdown

2017-10-23 Thread Denis Kenzior
Hi Slava, On 10/23/2017 04:05 PM, Slava Monich wrote: Otherwise write_watcher_destroy_notify can be invoked after GAtMux has been deallocated which results in write after free: ==3952== Invalid write of size 4 ==3952==at 0xABF54: write_watcher_destroy_notify (gatmux.c:285) ==3952==by

[PATCH] gatmux: Remove write watch source at shutdown

2017-10-23 Thread Slava Monich
Otherwise write_watcher_destroy_notify can be invoked after GAtMux has been deallocated which results in write after free: ==3952== Invalid write of size 4 ==3952==at 0xABF54: write_watcher_destroy_notify (gatmux.c:285) ==3952==by 0x4AF21E7: g_source_callback_unref (gmain.c:1561) ==3952==

[PATCH v3] atmodem: Query the list of supported s from the modem

2017-10-23 Thread Slava Monich
Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 57 --- 1 file changed, 45 insertions(+), 12 deletions(-) diff --git a/drivers/atmodem/sim.c

Re: [PATCH v2] atmodem: Query the list of supported s from the modem

2017-10-23 Thread Slava Monich
On 23/10/17 23:33, Denis Kenzior wrote: Hi Slava, On 10/23/2017 03:21 PM, Slava Monich wrote: Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. ---   drivers/atmodem/sim.c | 57

Re: [PATCH v2] atmodem: Query the list of supported s from the modem

2017-10-23 Thread Denis Kenzior
Hi Slava, On 10/23/2017 03:21 PM, Slava Monich wrote: Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 57 --- 1 file changed, 45 insertions(+), 12

Re: [PATCH] gatmux: Remove finalized watches from the list

2017-10-23 Thread Denis Kenzior
Hi Slava, On 10/23/2017 04:17 AM, Slava Monich wrote: Leaving them there may result in invalid reads like this: ==2312== Invalid read of size 4 ==2312==at 0xAB8C0: dispatch_sources (gatmux.c:134) ==2312==by 0xAC5D3: channel_close (gatmux.c:479) ==2312==by 0x4AE8885:

[PATCH v2] atmodem: Query the list of supported s from the modem

2017-10-23 Thread Slava Monich
Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 57 --- 1 file changed, 45 insertions(+), 12 deletions(-) diff --git a/drivers/atmodem/sim.c

Re: [PATCH] atmodem: Query the list of supported s from the modem

2017-10-23 Thread Denis Kenzior
Hi Slava, On 10/23/2017 12:57 PM, Slava Monich wrote: Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 69 ++- 1 file changed, 57 insertions(+), 12

[PATCH] atmodem: Query the list of supported s from the modem

2017-10-23 Thread Slava Monich
Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 69 ++- 1 file changed, 57 insertions(+), 12 deletions(-) diff --git a/drivers/atmodem/sim.c

Re: [PATCHv2] simauth: fixup adding more dbus return checks

2017-10-23 Thread Slava Monich
Hi James, On 16/10/17 19:06, James Prestwood wrote: --- src/sim-auth.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/src/sim-auth.c b/src/sim-auth.c index b9552b5..9ae5574 100644 --- a/src/sim-auth.c +++ b/src/sim-auth.c @@ -427,6 +427,7 @@

[PATCH] gatmux: Remove finalized watches from the list

2017-10-23 Thread Slava Monich
Leaving them there may result in invalid reads like this: ==2312== Invalid read of size 4 ==2312==at 0xAB8C0: dispatch_sources (gatmux.c:134) ==2312==by 0xAC5D3: channel_close (gatmux.c:479) ==2312==by 0x4AE8885: g_io_channel_shutdown (giochannel.c:523) ==2312==by 0x4AE8A1D: