[PATCH 1/2] include: Add ofono_voicecall_get_modem

--- include/voicecall.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/voicecall.h b/include/voicecall.h index 5b3da6a..a704b65 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -160,6 +160,8 @@ void ofono_voicecall_disconnected(struct ofono_voicecall *vc, int id, */

[PATCH 2/2] voicecall: Implement ofono_voicecall_get_modem

--- src/voicecall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/voicecall.c b/src/voicecall.c index e4f6a4c..7d4f6a1 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -3734,6 +3734,11 @@ void *ofono_voicecall_get_data(struct ofono_voicecall *vc) return

SV: SV: SV: Handling empty row from AT command

OK, thanks! I will talk to them :) Från: Denis Kenzior Skickat: den 20 juni 2018 16:28:12 Till: Mattias Månsson; ofono@ofono.org Ämne: Re: SV: SV: Handling empty row from AT command Hi Mattias, By the way, please no top-posting on this list. > Jun 20 13:44:03

Re: SV: SV: Handling empty row from AT command

Hi Mattias, By the way, please no top-posting on this list. Jun 20 13:44:03 lev-26e7jvbe ofonod[16440]: App> AT\r Jun 20 13:44:03 lev-26e7jvbe ofonod[16440]: App< \r\nOK\r\n Jun 20 13:44:03 lev-26e7jvbe ofonod[16440]: AppFinally woke up the modem Jun 20 13:44:03 lev-26e7jvbe ofonod[16440]:

SV: SV: Handling empty row from AT command

OK, I think the problem is not exactly as I described it. It is probably caused by the empty line, but the result is that the next AT command never completes. My sequence is started as this: g_at_chat_send(data->app, "AT+XSYSTRACE=30", none_prefix, trace_start_at_cb, data, NULL); then in

SV: SV: Handling empty row from AT command

I will do some experiments and come back to you with logs... Från: Denis Kenzior Skickat: den 20 juni 2018 15:30:00 Till: Mattias Månsson; ofono@ofono.org Ämne: Re: SV: Handling empty row from AT command Hi Mattias, On 06/20/2018 08:24 AM, Mattias Månsson

Re: SV: Handling empty row from AT command

Hi Mattias, On 06/20/2018 08:24 AM, Mattias Månsson wrote: It seems we already use that parser though: syntax = g_at_syntax_new_gsm_permissive(); chat = g_at_chat_new(channel, syntax); Not sure then. Permissive should be taking care of the issue you describe, e.g it skips any empty lines:

SV: Handling empty row from AT command

It seems we already use that parser though: syntax = g_at_syntax_new_gsm_permissive(); chat = g_at_chat_new(channel, syntax); Från: Denis Kenzior Skickat: den 20 juni 2018 15:20:13 Till: Mattias Månsson; ofono@ofono.org Ämne: Re: Handling empty row from AT

Re: Handling empty row from AT command

Hi Mattias, On 06/20/2018 02:34 AM, Mattias Månsson wrote: I'm integrating a new Cinterion module and have a small issue I haven't been able to solve nicely in Ofono. One of their commands responds with a list of stuff, followed by an OK but also after the OK there is an empty line. Which is

Handling empty row from AT command

I'm integrating a new Cinterion module and have a small issue I haven't been able to solve nicely in Ofono. One of their commands responds with a list of stuff, followed by an OK but also after the OK there is an empty line. Which is of course wrong, but it might not be solved for a while.