Hi Denis,
On Fri, Oct 12, 2018 at 5:56 AM Denis Kenzior wrote:
>
> Hi Giacinto,
>
> > +static void at_set_reg_info(const struct ofono_lte *lte,
> > + const struct ofono_lte_default_attach_info *info)
> > {
> > - struct cb_data *cbd = user_data;
> > - ofono_lte_cb_t
Hi,
What about this question?
On Wed, Oct 10, 2018 at 10:09 AM Giacinto Cifelli wrote:
>
> Dear all,
>
> I have a question for shared functions among atoms, but vendor-specific.
>
> For Gemalto, I have these two for now:
>
> gboolean gemalto_get_auth_command(struct ofono_modem *modem, int cid,
Hi Denis,
On Fri, Oct 12, 2018 at 6:10 AM Denis Kenzior wrote:
>
> Hi Giacinto,
>
> On 10/10/2018 01:54 AM, Giacinto Cifelli wrote:
> > ---
> > AUTHORS | 3 +++
> > 1 file changed, 3 insertions(+)
> >
>
> Please don't send me patches to AUTHORS. The maintainers will take care
> of it. If I
Hi Denis,
On Fri, Oct 12, 2018 at 6:06 AM Denis Kenzior wrote:
>
> Hi Giacinto,
>
> >> Reading through your patches, I'm missing an overarching explanation of
> >> why we need this. Do you really have an LTE network in range that
> >> requires authentication for the default APN?
> >
> > yes,
Hi Giacinto,
On 10/10/2018 01:54 AM, Giacinto Cifelli wrote:
---
AUTHORS | 3 +++
1 file changed, 3 insertions(+)
Please don't send me patches to AUTHORS. The maintainers will take care
of it. If I forget, send me a nudge to do so.
diff --git a/AUTHORS b/AUTHORS
index
Hi Giacinto,
Reading through your patches, I'm missing an overarching explanation of
why we need this. Do you really have an LTE network in range that
requires authentication for the default APN?
yes, quite a few of them actually.
And all private APN I have seen so far require
Hi Giacinto,
+static void at_set_reg_info(const struct ofono_lte *lte,
+ const struct ofono_lte_default_attach_info *info)
{
- struct cb_data *cbd = user_data;
- ofono_lte_cb_t cb = cbd->cb;
- struct ofono_error error;
+ struct lte_driver_data
Hi Giacinto,
@@ -69,19 +78,57 @@ static void lte_load_settings(struct ofono_lte *lte)
return;
}
- apn = g_key_file_get_string(lte->settings, SETTINGS_GROUP ,
- DEFAULT_APN_KEY, NULL);
- if (apn) {
+ apn =
Hi,
On Thu, Oct 11, 2018 at 10:19 PM Jonas Bonn wrote:
>
>
>
> On 10/10/18 08:54, Giacinto Cifelli wrote:
> > ---
> > src/modem.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/src/modem.c b/src/modem.c
> > index 9e254482..74dbe7ad 100644
> > --- a/src/modem.c
> > +++
Hi,
On Thu, Oct 11, 2018 at 10:07 PM Jonas Bonn wrote:
>
> Hi,
>
>
> On 10/10/18 08:54, Giacinto Cifelli wrote:
> > ---
> > src/lte.c | 242 +-
> > 1 file changed, 186 insertions(+), 56 deletions(-)
> >
> > diff --git a/src/lte.c b/src/lte.c
On Thu, Oct 11, 2018 at 9:51 PM Jonas Bonn wrote:
>
> Hi,
>
> I think this patch deserves a couple of lines of justification in the patch
> description. From the subject, it isn't obvious what this is about, and a
> quick glance at the diff only raises further questions. Try to explain in
>
Hi Jonas,
On Thu, Oct 11, 2018 at 9:07 PM Jonas Bonn wrote:
>
> Hi Giacinto,
>
> Reading through your patches, I'm missing an overarching explanation of
> why we need this. Do you really have an LTE network in range that
> requires authentication for the default APN?
yes, quite a few of them
On 10/10/18 08:54, Giacinto Cifelli wrote:
---
src/modem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/modem.c b/src/modem.c
index 9e254482..74dbe7ad 100644
--- a/src/modem.c
+++ b/src/modem.c
@@ -729,6 +729,8 @@ static void sim_state_watch(enum ofono_sim_state new_state,
Hi,
On 10/10/18 08:54, Giacinto Cifelli wrote:
---
src/lte.c | 242 +-
1 file changed, 186 insertions(+), 56 deletions(-)
diff --git a/src/lte.c b/src/lte.c
index 23fe8e1c..2412fcec 100644
--- a/src/lte.c
+++ b/src/lte.c
@@ -3,6 +3,7 @@
Hi,
I think this patch deserves a couple of lines of justification in the
patch description. From the subject, it isn't obvious what this is
about, and a quick glance at the diff only raises further questions.
Try to explain in the patch description what this is about, what problem
your
Hi Giacinto,
Reading through your patches, I'm missing an overarching explanation of
why we need this. Do you really have an LTE network in range that
requires authentication for the default APN? What happens if
authentication fails... are you connected to an alternative APN
automatically,
hi Denis, all,
any comments about my last patches and questions from 2 days ago?
Did they go to spam?
thank you,
Giacinto
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Nandini,
On 10/11/2018 06:23 AM, Nandini Rebello wrote:
Fix a missing char in the nation language set in single shift table
for a special character. Character set again validated.
Future language table to carry this fix.
---
src/util.c | 2 ++
1 file changed, 2 insertions(+)
Applied,
Fix a missing char in the nation language set in single shift table
for a special character. Character set again validated.
Future language table to carry this fix.
---
src/util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/util.c b/src/util.c
index 2f01cec..70d72d7 100644
---
19 matches
Mail list logo
