[PATCH 0/1] use g_timeout_add instead of usleep

2017-01-17 Thread Christophe Ronco
if you prefer a bigger wait before retry. Christophe Ronco (1): qmimodem: query_passwd_state can be retried drivers/qmimodem/sim.c | 95 ++ 1 file changed, 81 insertions(+), 14 deletions(-) -- 2.11.0

[PATCH 1/1] qmimodem: query_passwd_state can be retried

2017-01-12 Thread Christophe Ronco
Retry command QMI_UIM_GET_CARD_STATUS during query_passwd_state if a temporary error status has been detected. This happens with a MC7430 modem when query_passwd_state is called just after PIN is entered. --- drivers/qmimodem/sim.c | 74 -- 1 file

[PATCH 0/1] Patch #3 resubmitted

2017-01-12 Thread Christophe Ronco
I changed again gboolean for bool. Christophe Ronco (1): qmimodem: query_passwd_state can be retried drivers/qmimodem/sim.c | 74 -- 1 file changed, 60 insertions(+), 14 deletions(-) -- 2.11.0

[PATCH 1/1] qmimodem: get password state from modem

2017-01-11 Thread Christophe Ronco
Password state and number of retries asked to modem using QMI_UIM_GET_CARD_STATUS command rather than remembered after initial QMI_UIM_GET_CARD_STATUS command. --- drivers/qmimodem/sim.c | 178 + 1 file changed, 119 insertions(+), 59 deletions(-)

[PATCH 0/1] Correction of previous patch

2017-01-11 Thread Christophe Ronco
Hello Denis, Thanks again for code review. Here is another (I hope better) version of the patch. I changed gboolean for bool, because it is used more often than gboolean in repository code. Christophe Christophe Ronco (1): qmimodem: get password state from modem drivers/qmimodem/sim.c | 178

[PATCH 3/4] qmimodem: query_passwd_state can be retried

2017-01-10 Thread Christophe Ronco
Retry command QMI_UIM_GET_CARD_STATUS during query_passwd_state if a temporary error status has been detected. This happens with a MC7430 modem when query_passwd_state is called just after PIN is entered. --- drivers/qmimodem/sim.c | 75 -- 1 file

[PATCH 2/4] qmimodem: add pin_send feature

2017-01-10 Thread Christophe Ronco
Add ability to send PIN to a QMI modem using QMI_UIM_VERIFY_PIN command. This has been tested on MC7304 and MC7430 modems. --- drivers/qmimodem/sim.c | 65 ++ drivers/qmimodem/uim.h | 11 + 2 files changed, 76 insertions(+) diff --git

[PATCH 1/4] qmimodem: get password state from modem

2017-01-10 Thread Christophe Ronco
Password state and number of retries asked to modem using QMI_UIM_GET_CARD_STATUS command rather than remembered after initial QMI_UIM_GET_CARD_STATUS command. --- drivers/qmimodem/sim.c | 173 - 1 file changed, 115 insertions(+), 58 deletions(-)

[PATCH 4/4] udevng: Sierra modems use SIM driver

2017-01-10 Thread Christophe Ronco
--- plugins/udevng.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/plugins/udevng.c b/plugins/udevng.c index 933bf4fa..a2866b64 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -252,8 +252,6 @@ static gboolean setup_sierra(struct modem_info *modem) if (qmi != NULL && net

[PATCH 0/4] Add pin_send feature to qmimodem sim driver

2017-01-10 Thread Christophe Ronco
Previous patch broken down in 4 patches and aligned with current HEAD I hope I have fixed the coding rules problems present in my first patch version. Christophe Ronco (4): qmimodem: get password state from modem qmimodem: add pin_send feature qmimodem: query_passwd_state can be retried

[PATCH 1/2] sim: backup driver read_imsi by IMSI via EF read

2017-01-09 Thread Christophe Ronco
If read_imsi driver function fails, try to obtain IMSI via EF read --- src/sim.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/src/sim.c b/src/sim.c index edd7c763..66794305 100644 --- a/src/sim.c +++ b/src/sim.c @@ -1472,19 +1472,6 @@

[PATCH 0/2] Fix Read Imsi feature for MC7430 modem

2017-01-09 Thread Christophe Ronco
Done in 2 patches: - Backup read imsi modem driver funtion by IMSI via EF read (what is done now when read_insi is not defined in modem driver) - Implement read_imsi in qmimodem sim driver Christophe Ronco (2): sim: backup driver read_imsi by IMSI via EF read qmimodem: Add read_imsi

[PATCH 2/2] qmimodem: Add read_imsi to qmimodem sim driver

2017-01-09 Thread Christophe Ronco
Add read_imsi feature to qmimodem sim driver. This is based on DMS service. On MC7430, this is mandatory to be able to use this driver for GPRS connection because reading IMSI via EF reads fails. --- drivers/qmimodem/sim.c | 83 ++ 1 file changed,

Re: [PATCH 2/4] MC7430: add read_imsi feature to qmimodem sim driver

2017-01-06 Thread Christophe Ronco
Hello Denis, Thanks for reading my patches. I resend this mail (previous was sent with a wrong from address so it did not go to the list). On 12/31/2016 01:34 AM, Denis Kenzior wrote: Hi Christophe, On 12/28/2016 09:04 AM, Christophe Ronco wrote: drivers/qmimodem/sim.c Add read_imsi

[PATCH 0/1] add send_passwd feature to qmimodem sim driver

2017-01-03 Thread Christophe Ronco
rather than remembering initial value. A retry has been implemented on query_passwd_state command. This command is called just after PIN is entered and return a temporary error (seen on MC7430). Christophe Ronco (1): MC7430: Add send_passwd feature to qmimodem sim driver drivers/qmimodem/sim.c

[PATCH 1/1] MC7430: Add send_passwd feature to qmimodem sim driver

2017-01-03 Thread Christophe Ronco
drivers/qmimodem/sim.c Add send_passwd feature to qmimodem smi driver. Password state and number of retries asked using QMI_UIM_GET_CARD_STATUS command rather than remembered after initial QMI_UIM_GET_CARD_STATUS command. Retry implemented for query_passwd_state if temporary error detected.

[PATCH 2/4] MC7430: add read_imsi feature to qmimodem sim driver

2016-12-28 Thread Christophe Ronco
drivers/qmimodem/sim.c Add read_imsi feature to this driver. This is based on DMS service. This is mandatory to be able to use this driver for GPRS connection plugins/gobi.c DMS feature is needed for SIM driver (to be able to read IMSI) --- drivers/qmimodem/sim.c | 83

[PATCH 3/4] MC7430: fix get signal strength

2016-12-28 Thread Christophe Ronco
drivers/qmimodem/nas.h Get current signal strength (type: 0x01), not list of other signals strength (0x10) Without this fix: - I can't get a signal strength on MC7430 because list does not exist (only one signal strength). - On MC7304, result is wrong --- drivers/qmimodem/nas.h | 2 +- 1

[PATCH 1/4] MC7430: use qmimodem sim driver

2016-12-28 Thread Christophe Ronco
QMI modem sim-legacy driver uses a command not supported by MC7430 (QMI_DMS_GET_PIN_STATUS) plugins/udevng.c QMI Sierra modems use sim driver. drivers/qmimodem/sim.c In get_card_status_cb, call ofono_sim_register after ofono_sim_inserted_notify (as it is done in sim_legacy). Otherwise

[PATCH 4/4] MC7430: fix QMI notification messages handling

2016-12-28 Thread Christophe Ronco
QMI notification messages handlers are never called on MC7430 without this fix. drivers/qmimodem/qmi.c Do not test transaction id before calling notification handler. On MC7430, notification messages contain a not null transaction id (starts with 1, increased at each message for a particular

[PATCH 0/4] support MC7430 Sierra modem

2016-12-28 Thread Christophe Ronco
had some other problems fixed in following patches. With these patches I am able to see the MC7430 modem as a service in connman over ofono and to connect and disconnect it. Patch can be applied to ofono 1.19. Christophe Christophe Ronco (4): MC7430: use qmimodem sim driver MC7430: add

<    1   2