[PATCH v2 1/3] sms: store pending tx pdus on disk

Based on patch from Kristen Carlson Accardi kris...@linux.intel.com --- src/sms.c | 21 + src/smsutil.c | 28 src/smsutil.h |4 3 files changed, 53 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index

[PATCH] build: Do not fail when systemd is not installed

Use --with-systemdsystemunitdir instead of --enabled-systemd so it's possible to enable systemd even if systemd is not installed. --- configure.ac | 18 +++--- 1 files changed, 7 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index b034ff0..20a1fc6 100644

[PATCH v3 2/3] sms: delete sent sms messages from backup

Based on patch from Kristen Carlson Accardi kris...@linux.intel.com --- src/sms.c |8 src/smsutil.c | 47 +++ src/smsutil.h |6 ++ 3 files changed, 61 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index

[PATCH v3 0/3] Persist TX SMS messages

Third version. It includes some changes suggested by Denis: - Get rid of the oldpath field in struct txq_backup_entry - Store the encoded uuid in struct txq_backup_entry - Use SMS_MSGID_FMT to get the file name - Some more cleanups Lucas De Marchi (3): sms: store pending tx pdus on disk sms

[PATCH v3 1/3] sms: store pending tx pdus on disk

Based on patch from Kristen Carlson Accardi kris...@linux.intel.com --- src/sms.c | 21 + src/smsutil.c | 29 + src/smsutil.h |4 3 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index

[PATCH v3 3/3] sms: restore pending tx messages from backup

Based on patch from: Kristen Carlson Accardi kris...@linux.intel.com --- src/ofono.h |1 + src/sms.c | 62 +++ src/smsutil.c | 181 + src/smsutil.h |7 ++ 4 files changed, 251 insertions(+), 0 deletions(-)

[PATCH] smsutil: do not allow larger file names

If file name had anything in the name after addr-msgid, it would be parsed as well. This is not what we want, since there could be temporary files lying around. --- src/smsutil.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index

[PATCH] Don't use c++ keyword in public header files

--- include/sim.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/sim.h b/include/sim.h index 81df60e..6e93769 100644 --- a/include/sim.h +++ b/include/sim.h @@ -154,7 +154,7 @@ struct ofono_sim_driver { ofono_sim_lock_unlock_cb_t cb, void

[PATCH 1/3] sms: store pending tx pdus on disk

Based on patch from Kristen Carlson Accardi kris...@linux.intel.com --- src/sms.c | 16 src/smsutil.c | 25 + src/smsutil.h |3 +++ 3 files changed, 44 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7224bdf..5718bba

[PATCH 0/3] Persist TX SMS messages

approach. Feel free to change the author of the commits if you think this more appropriate. Lucas De Marchi (3): sms: store pending tx pdus on disk sms: delete sent sms messages from backup sms: restore pending tx messages from backup src/ofono.h |1 + src/sms.c | 107

[PATCH 3/3] sms: restore pending tx messages from backup

Based on patch from: Kristen Carlson Accardi kris...@linux.intel.com --- src/ofono.h |1 + src/sms.c | 83 +++ src/smsutil.c | 151 + src/smsutil.h |8 +++ 4 files changed, 243 insertions(+), 0

Re: [PATCH] Don't use c++ keyword in public header files

that includes sim.h And if you really wanna do that, then please not something cryptic like No, I don't want. If nobody will use C++, I'm fine the way it is. Then we might want to remove that ifdef, because it will not compile anyway. regards, Lucas De Marchi

Re: [PATCH] Don't use c++ keyword in public header files

++ -c -o cpp.o cpp.cpp In file included from cpp.cpp:2:0: c.h:5:25: error: expected ‘,’ or ‘...’ before ‘new’ regards Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] call-settings: use enum values

Use the enum values defined for CLIP, CNAP, CLIR, COLP and COLR. --- src/call-settings.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index 109f130..8dd2564 100644 --- a/src/call-settings.c +++

Re: [PATCH] doc: fix class information of UMTS band

).                                900           Operate only on 900 MHz, known -                                               as GSM (class VII). +                                               as GSM (class VIII). Good catch. This was my bad. Thanks Lucas De Marchi

Re: [PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

so ofono works with it flawlessly. regards, Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] huawei: do not set timer more than once

If a ^SYSINFO arrives after the timer for query_sim_locked() has been set up, it'd would set a new timer, signaling a sim state change more than once. --- plugins/huawei.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index

Re: [PATCH] huawei: do not set timer more than once

insertions(+), 1 deletions(-) patch looks fine to me and so I applied it. This fix the double AT+CPIN? command. There's still an issue with a double AT+CFUN=5 that I'm tracking down. I'll send a patch for this later. regards, Lucas De Marchi

[PATCH] huawei: do not query sim state on pre_sim

Sim state is already known after modem is enabled and there's no need to query it again. Before this patch, query_sim_state() was called upon huawei_enable() and huawei_pre_sim(). Both functions might call notify_sim_state() with a valid state. Hence we could eventually end up sending AT+CFUN=5

Re: Band selection issue

trying to set? Could you verify if it works by setting both GSM and UMTS frequencies to 'any' ? It might be a problem that this modem does not accept several frequencies together (currently we keep the GSM and UMTS values by making an OR and passing to modem) regards, Lucas De Marchi

Re: [PATCH 1/1] atmodem: add ifx support for pin retries query

() in this case. regards, Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] sim: check if lock is locked after code changing attempt

with GUI. You can use whatever client you want to write email. But for sending patches, git send-email is the best one since you won't need to copy and paste, nor attach anything. Give it a try and you'll regret not using it first. Lucas De Marchi ___ ofono

Re: [PATCH 8/9] doc: add CalledLinePresentation property to CallSettings

On Wed, Jan 12, 2011 at 9:27 AM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: ---  doc/call-settings-api.txt |   15 +++  1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/doc/call-settings-api.txt b/doc/call-settings-api.txt index b6dc1cc..44e0dbb 100644

Re: [PATCH] sim: check if lock is locked after code changing attempt

Hi Jussi, On Wed, Jan 12, 2011 at 5:39 AM, jussi.kan...@tieto.com wrote: Hi Lucas, On Tue, 2011-01-11 at 16:08 +0200, Lucas De Marchi wrote: Hi Jussi On Tue, Jan 11, 2011 at 10:17 AM,  jussi.kan...@tieto.com wrote: Hi, This is fix to Marit Henriksen's TODO item Check SIM pin status

[PATCH] Add CDIP support

With CDIP phonesim can tell the Called Line Identification within the RING comand according to 27.007 section 7.9. --- src/callmanager.cpp | 21 +++-- src/callmanager.h |8 +--- src/control.cpp |8 ++-- src/control.h |2 +-

[PATCH 0/9] Add cdip support

). Last patch is only a style fix. Lucas De Marchi (9): include: add cdip field in ofono_call voicecall: add support for cdip atmodem: add cdip to voicecall doc: add CalledLineIdentification property to voicecall include: add method for querying cdip support call-settings: add support

[PATCH 1/9] include: add cdip field in ofono_call

--- include/types.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/types.h b/include/types.h index 9fd174d..769b8f0 100644 --- a/include/types.h +++ b/include/types.h @@ -99,6 +99,7 @@ struct ofono_call { int status; ofono_bool_t mpty;

[PATCH 3/9] atmodem: add cdip to voicecall

--- drivers/atmodem/voicecall.c | 61 +- 1 files changed, 59 insertions(+), 2 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index 75e0c93..43989f2 100644 --- a/drivers/atmodem/voicecall.c +++

[PATCH 5/9] include: add method for querying cdip support

--- include/call-settings.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/call-settings.h b/include/call-settings.h index c1ff668..55300ab 100644 --- a/include/call-settings.h +++ b/include/call-settings.h @@ -48,6 +48,8 @@ struct ofono_call_settings_driver {

[PATCH 6/9] call-settings: add support for cdip

--- src/call-settings.c | 73 +- 1 files changed, 71 insertions(+), 2 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index 4dac2b6..0214abf 100644 --- a/src/call-settings.c +++ b/src/call-settings.c @@ -69,6 +69,13 @@ enum

[PATCH 7/9] atmodem: add cdip to call-settings

--- drivers/atmodem/call-settings.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/call-settings.c b/drivers/atmodem/call-settings.c index 3340d5a..2529c8e 100644 --- a/drivers/atmodem/call-settings.c +++

[PATCH 8/9] doc: add CalledLinePresentation property to CallSettings

--- doc/call-settings-api.txt | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/doc/call-settings-api.txt b/doc/call-settings-api.txt index b6dc1cc..44e0dbb 100644 --- a/doc/call-settings-api.txt +++ b/doc/call-settings-api.txt @@ -30,6 +30,21 @@ Properties

[PATCH 9/9] call-settings: apply rule M11 of coding style

--- src/call-settings.c | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index 0214abf..109f130 100644 --- a/src/call-settings.c +++ b/src/call-settings.c @@ -41,32 +41,32 @@ static GSList

[PATCH] test: show CalledLinePresentation property

--- test/test-call-settings |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/test-call-settings b/test/test-call-settings index 3258da7..f49ad0b 100755 --- a/test/test-call-settings +++ b/test/test-call-settings @@ -48,6 +48,8 @@ if __name__ == __main__:

Re: [PATCH] sim: check if lock is locked after code changing attempt

with retry counter solution introduced by Lucas De Marchi couple of tasks ago. That would seem however require some extra implementation in ste modem ( at least I was not able get the ofono show correct values without extra modifications ) and I think that isimodems don't have that sort

Re: [PATCH 2/2] Inform Huawei modem using ACCM 0xffffffff to trasmit package. Using my Huawei modem (EM770W) if set ACCM as 0x00000000, the RXJ- event will happend, and PPP link down, when IP package

blank line + the description of the patch. Please, refer to rule M5 of doc/coding-style. Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH v3 0/6] Query retry counters

. This change needed 2 more patches (the first ones) in order to make it work. - space cleanup - use memcmp to compare the pin_retries array instead of a loop Lucas De Marchi (6): atmodem: check for VENDOR_HUAWEI on sim atom huawei: use VENDOR_HUAWEI quirk on sim creation include: add method

[PATCH v3 2/6] huawei: use VENDOR_HUAWEI quirk on sim creation

--- plugins/huawei.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 0b958ec..d6a9d68 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -618,7 +618,7 @@ static void huawei_pre_sim(struct ofono_modem *modem) DBG(%p,

[PATCH v3 1/6] atmodem: check for VENDOR_HUAWEI on sim atom

--- drivers/atmodem/sim.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 1653ede..33f756d 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -143,8 +143,10 @@ static void at_sim_read_info(struct

[PATCH v3 3/6] include: add method to query pin Retries

--- include/sim.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 7860e24..830322a 100644 --- a/include/sim.h +++ b/include/sim.h @@ -108,6 +108,9 @@ typedef void (*ofono_sim_passwd_cb_t)(const struct ofono_error *error,

[PATCH v3 4/6] sim: query remaining pin retries

Check the remaining pin retries after each operation that might have changed it, i.e. locking, unlocking, reseting or changing pin. --- src/sim.c | 90 + 1 files changed, 90 insertions(+), 0 deletions(-) diff --git a/src/sim.c

[PATCH v3 5/6] doc: detail Retries property

--- doc/sim-api.txt | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index 89c321e..65c920d 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -145,3 +145,15 @@ Properties boolean Present [readonly]

[PATCH v3 6/6] atmodem: implement query for remaining pin retries

Implement query method for the remaining pin retries on huawei modem. --- drivers/atmodem/sim.c | 91 + 1 files changed, 91 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 33f756d..63dcbe1 100644 ---

[PATCH 1/2] atmodem: implement query for remaining pin retries

Implement query method for the remaining pin retries on huawei modem. --- drivers/atmodem/sim.c | 96 + 1 files changed, 96 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 33f756d..5fd15d2 100644 ---

[PATCH 2/2] TODO: mark 'SIM PIN retry counter' task as done

extensions for SIM PIN retry counter. Most vendors - provide an extension commands to obtain such a retry counter for PINs and - PUKs. Need to enable this as a property in oFono. - - Priority: Low - Complexity: C2 - Owner: Lucas De Marchi lucas.demar...@profusion.mobi - - Add support for SIM

Re: [PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

On Thu, Jan 6, 2011 at 7:54 AM, Xu, Martin martin...@intel.com wrote: Using the old version of gcc 4.4.2 I did not meet the issue, but using 4.5.1, we have warning. Humn, gcc 4.5.2 here and I don't get the warning. IMHO, this warning doesn't make sense. Lucas De Marchi

[PATCH v3 0/4] Query retry counters

Difference from previous version is that now the pin_retries field is no more a GSList because it's not allowed to be on public header files. So, it's now passed from drivers to core and stored there as an array of ints. Lucas De Marchi (4): include: add method to query pin Retries sim: query

[PATCH v3 2/4] sim: query remaining pin retries

Check the remaining pin retries after each operation that might have changed it, i.e. locking, unlocking, reseting or changing pin. --- src/sim.c | 97 + 1 files changed, 97 insertions(+), 0 deletions(-) diff --git a/src/sim.c

[PATCH v3 1/4] include: add method to query pin Retries

--- include/sim.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 7860e24..830322a 100644 --- a/include/sim.h +++ b/include/sim.h @@ -108,6 +108,9 @@ typedef void (*ofono_sim_passwd_cb_t)(const struct ofono_error *error,

[PATCH v3 4/4] atmodem: implement query for remaining pin retries

Implement query method for the remaining pin retries on huawei modem. --- drivers/atmodem/sim.c | 90 + 1 files changed, 90 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 1653ede..98fb195 100644 ---

[PATCH v3 3/4] doc: detail Retries property

--- doc/sim-api.txt | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index 89c321e..65c920d 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -145,3 +145,15 @@ Properties boolean Present [readonly]

Re: [PATCH v3 4/4] atmodem: implement query for remaining pin retries

Hi Denis, On Tue, Jan 4, 2011 at 8:22 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: Implement query method for the remaining pin retries on huawei modem. ---  drivers/atmodem/sim.c |   90 +  1 files changed, 90 insertions(+), 0

[PATCH] dbus: fix appending on dict for types other than string

According to dbus documentation, dbus_message_iter_append_basic() expects a const char** if type is string and a simple pointer for other types. Since we a iterating an array, the value passed is already a pointer. --- src/dbus.c | 20 ++-- 1 files changed, 18 insertions(+), 2

Re: [PATCH v3 2/4] sim: query remaining pin retries

Hi, Denis On Wed, Jan 5, 2011 at 3:20 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: Check the remaining pin retries after each operation that might have changed it, i.e. locking, unlocking, reseting or changing pin. ---  src/sim.c |   97

[PATCH] dbus: fix appending on dict for types other than string

According to dbus documentation, dbus_message_iter_append_basic() expects a const char** if type is string and a simple pointer for other types. Since we a iterating an array, the value passed is already a pointer. --- src/dbus.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-)

[PATCH v2 0/4] Query retry counters

to EnterPin(), LockPin(), UnlockPin() and so on. The dict has the form { pin = 3, puk = 10, ... }. The driver implementation for huawei modem is done using its proprietary command, which returns 4 counters: {SimManager} [/huawei0] Retries = { pin2 = 3, puk2 = 10, pin = 3, puk = 10 } Lucas De Marchi (4

[PATCH v2 1/4] include: add method to query pin Retries

--- include/sim.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 7860e24..bf4aaf9 100644 --- a/include/sim.h +++ b/include/sim.h @@ -77,6 +77,11 @@ enum ofono_sim_state { OFONO_SIM_STATE_READY, }; +struct

[PATCH v2 2/4] sim: query remaining pin retries

Check the remaining pin retries after each operation that might have changed it, i.e. locking, unlocking, reseting or changing pin. --- src/sim.c | 102 + 1 files changed, 102 insertions(+), 0 deletions(-) diff --git a/src/sim.c

[PATCH v2 3/4] doc: detail Retries property

--- doc/sim-api.txt | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index 89c321e..65c920d 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -145,3 +145,15 @@ Properties boolean Present [readonly]

Re: [PATCH] dbus: fix appending on dict for types other than string

** to dbus_message_iter_append_basic that will be dereferenced accordingly inside dbus to get the type you told it. Then, bad things will happen. I've just tested here with my patches for the retry counter, where this call is needed. regards, Lucas De Marchi ___ ofono mailing list ofono

Re: [PATCH] dbus: fix appending on dict for types other than string

.. Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] dbus: fix appending on dict for types other than string

in that function. So it is different since normally it is the caller that has to give the right pointer in the first place. Yeah, true... But if we don't differentiate the types here I'd need to cast an uint8 to void* that is not even allowed by our warning flags Lucas De Marchi

[PATCH 1/3] call-settings: fix getting CNAP property

--- src/call-settings.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index b6c3924..aea4991 100644 --- a/src/call-settings.c +++ b/src/call-settings.c @@ -870,7 +870,7 @@ static DBusMessage

[PATCH 3/3] doc: rename CalledLine* properties in call-settings

--- doc/call-settings-api.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/call-settings-api.txt b/doc/call-settings-api.txt index a454621..b6dc1cc 100644 --- a/doc/call-settings-api.txt +++ b/doc/call-settings-api.txt @@ -42,7 +42,7 @@ Propertiesstring

Re: [PATCH 2/3] call-settings: rename CalledLine* properties

. Oh! Right... There was a typo in the commit message too. I'll fix that and re-send. Thanks, Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 2/4] call-settings: rename CalledLine* properties

COLP and COLR are better named respectively as ConnectedLinePresentation and ConnectedLineRestriction as stated in 27.007 sections 7.8 and 7.31. CalledLine* name will be used in future for CDIP. --- src/call-settings.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH 1/4] call-settings: fix getting CNAP property

--- src/call-settings.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index b6c3924..aea4991 100644 --- a/src/call-settings.c +++ b/src/call-settings.c @@ -870,7 +870,7 @@ static DBusMessage

[PATCH 3/4] doc: rename CalledLine* properties

--- doc/call-settings-api.txt |4 ++-- doc/supplementaryservices-api.txt |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/call-settings-api.txt b/doc/call-settings-api.txt index a454621..b6dc1cc 100644 --- a/doc/call-settings-api.txt +++

[PATCH 4/4] test: use new names for CalledLine* properties

--- test/test-call-settings |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test-call-settings b/test/test-call-settings index 60fe3ba..3258da7 100755 --- a/test/test-call-settings +++ b/test/test-call-settings @@ -42,14 +42,14 @@ if __name__ == __main__:

[PATCH 2/2] Mark 'Frequency Band Selection' task as done

. Add frequency band selection capability to the - RadioSettings atom. - Owner: Lucas De Marchi lucas.demar...@profusion.mobi - - This feature is not discussed in 27.007, thus manufacturer specific commands - are required. - - Complexity: C2 - Priority: Low - - PolicyKit support. Add support

[PATCH 1/2] huaweimodem: add frequency band selection support

--- drivers/huaweimodem/radio-settings.c | 206 +- 1 files changed, 200 insertions(+), 6 deletions(-) diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c index 30961da..10d46e9 100644 ---

[PATCH] coding-style: mention preferred line wrap

--- doc/coding-style.txt | 43 +++ 1 files changed, 39 insertions(+), 4 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index 9d7131d..c267b6b 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -75,10 +75,11 @@ Example:

[PATCH] TODO: add owner to 'Called Line Identification' task

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 463f74c..b752f2a 100644 --- a/TODO +++ b/TODO @@ -226,6 +226,7 @@ Supplementary Services Priority: Low Complexity: C4 + Owner: Lucas De Marchi lucas.demar...@profusion.mobi - CPHS

[PATCH 2/2] huawei: fix SIM state notification when locked

When SIM is locked, huawei modem does not send any notification about SIM state change because it does not differentiate 'invalid' from 'locked'. In order to be able to unlock the sim, this patch forces a notification of a valid state after a timeout. --- plugins/huawei.c | 40

[PATCH 1/4] sim: add method to query SIM Retry Counter

--- include/sim.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 7860e24..50529bb 100644 --- a/include/sim.h +++ b/include/sim.h @@ -108,6 +108,9 @@ typedef void (*ofono_sim_passwd_cb_t)(const struct ofono_error *error,

[PATCH 2/4] sim: add PinRetries property

--- src/sim.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index 6217a25..8c05900 100644 --- a/src/sim.c +++ b/src/sim.c @@ -62,6 +62,8 @@ struct ofono_sim { enum ofono_sim_password_type pin_type;

[PATCH 3/4] doc: detail PinRetries property

--- doc/sim-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index d4d2b1b..c7d1faa 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -145,3 +145,13 @@ Properties boolean Present [readonly]

[PATCH 4/4] atmodem: implement method to query PIN Retry Counter

PIN retry counter is implemented for huaweimodem and it'd be very similar for other vendors. --- drivers/atmodem/sim.c | 70 + 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index

[PATCH 0/4] Add SIM Retry Counter

Counter that is the same as the one being requested in PinRequired property. Another approach was to read all the counters (e.g. huawei exports counters for PIN, PIN2, PUK and PUK2), but the Dbus API to expose to user was not so clear to me if I used this approach. What do you think? Lucas De Marchi

[PATCH 2/6] huaweimodem: Add support for radio settings

--- Makefile.am |3 +- drivers/huaweimodem/huaweimodem.c|2 + drivers/huaweimodem/huaweimodem.h|3 + drivers/huaweimodem/radio-settings.c | 218 ++ 4 files changed, 225 insertions(+), 1 deletions(-) create mode 100644

[PATCH 3/6] huawei: Add support for radio settings

--- plugins/huawei.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..3c58c7f 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -43,6 +43,7 @@ #include ofono/gprs.h #include ofono/gprs-context.h #include

[PATCH 1/6] test: add scripts for setting frequency band

--- Makefile.am|4 +++- test/set-gsm-band | 25 + test/set-umts-band | 25 + 3 files changed, 53 insertions(+), 1 deletions(-) create mode 100755 test/set-gsm-band create mode 100755 test/set-umts-band diff --git a/Makefile.am

[PATCH 4/6] huaweimodem: cache mode in radio settings

Save the current and pending modes in radio_settings_data, so we can access them later. This patch also splits the parsing of ^SYSCFG response from the callback call. Then, it's possible to have more properties that use the same command as is the case of frequency band selection. ---

[PATCH 5/6] huaweimodem: always cache ^SYSCFG values when supported

When modem is supported, we need to cache the current values returned by ^SYSCFG command early on initialization. This will be used in future for frequency band selection that depends on the value of 'mode' property. --- drivers/huaweimodem/radio-settings.c | 21 - 1 files

[PATCH 6/6] huaweimodem: add frequency band selection support

--- drivers/huaweimodem/radio-settings.c | 172 - 1 files changed, 166 insertions(+), 6 deletions(-) diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c index 1281d8b..d72a82c 100644 --- a/drivers/huaweimodem/radio-settings.c

Re: [PATCH 1/2] huaweimodem: Add support for radio settings

On Wed, Dec 8, 2010 at 2:17 PM, Denis Kenzior denk...@gmail.com wrote: Hi Lucas, On 11/30/2010 12:41 PM, Lucas De Marchi wrote: ---  Makefile.am                          |    3 +-  drivers/huaweimodem/huaweimodem.c    |    2 +  drivers/huaweimodem/huaweimodem.h    |    3 +  drivers

[RFC PATCH 0/3] radio-settings: add frequency band selection

and the previous one about adding radio-settings atom to huawei are accepted. Lucas De Marchi (3): radio-settings: add frequency band selection methods radio-settings: add frequency band selection properties doc: document frequency band selection doc/radio-settings-api.txt | 43 include/radio

[RFC PATCH 1/3] radio-settings: add frequency band selection methods

--- include/radio-settings.h | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/include/radio-settings.h b/include/radio-settings.h index 45e88e7..e839231 100644 --- a/include/radio-settings.h +++ b/include/radio-settings.h @@ -35,6 +35,24 @@

[RFC PATCH 2/3] radio-settings: add frequency band selection properties

--- src/radio-settings.c | 250 +- 1 files changed, 248 insertions(+), 2 deletions(-) diff --git a/src/radio-settings.c b/src/radio-settings.c index ff6934b..8c82e29 100644 --- a/src/radio-settings.c +++ b/src/radio-settings.c @@ -41,8 +41,12 @@

[RFC PATCH 3/3] doc: document frequency band selection

--- doc/radio-settings-api.txt | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/doc/radio-settings-api.txt b/doc/radio-settings-api.txt index e073d1d..311759d 100644 --- a/doc/radio-settings-api.txt +++

[PATCH] HACKING: add guidelines to patch submission

--- HACKING | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/HACKING b/HACKING index e825185..3322554 100644 --- a/HACKING +++ b/HACKING @@ -91,3 +91,22 @@ Other debugging settings that can be toggled: - Environment variable OFONO_AT_DEBUG (set to

Re: [RFC PATCH 3/3] doc: document frequency band selection

+                     has an imediate effect on modem only if +                     TechnologyPreference is set to gsm. Should be Setting this property has an imediate effect on modem only if TechnologyPreference is set to umts. Thanks, fixed. Lucas De Marchi

Re: [RFC PATCH 1/3] radio-settings: add frequency band selection methods

, it might be because of other things. But I agree with your comment. Thanks, fixed. Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH v2 2/3] radio-settings: add frequency band selection properties

--- src/radio-settings.c | 250 +- 1 files changed, 248 insertions(+), 2 deletions(-) diff --git a/src/radio-settings.c b/src/radio-settings.c index ff6934b..51158ef 100644 --- a/src/radio-settings.c +++ b/src/radio-settings.c @@ -41,8 +41,12 @@

[PATCH v2 3/3] doc: document frequency band selection

--- doc/radio-settings-api.txt | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/doc/radio-settings-api.txt b/doc/radio-settings-api.txt index e073d1d..216f534 100644 --- a/doc/radio-settings-api.txt +++

[PATCH 1/2] huaweimodem: Add support for radio settings

From: Marcel Holtmann marcel.holtm...@intel.com --- Makefile.am |3 +- drivers/huaweimodem/huaweimodem.c|2 + drivers/huaweimodem/huaweimodem.h|3 + drivers/huaweimodem/radio-settings.c | 212 ++ 4 files changed, 219

Re: [PATCH 1/2] huaweimodem: Add support for radio settings

On Tue, Nov 30, 2010 at 4:25 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c new file mode 100644 index 000..7f0b223 --- /dev/null +++ b/drivers/huaweimodem/radio-settings.c @@ -0,0 +1,212

[PATCH 2/2] huawei: Add support for radio settings

--- plugins/huawei.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..3c58c7f 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -43,6 +43,7 @@ #include ofono/gprs.h #include ofono/gprs-context.h #include

[PATCH 1/2] huaweimodem: Add support for radio settings

--- Makefile.am |3 +- drivers/huaweimodem/huaweimodem.c|2 + drivers/huaweimodem/huaweimodem.h|3 + drivers/huaweimodem/radio-settings.c | 212 ++ 4 files changed, 219 insertions(+), 1 deletions(-) create mode 100644

[PATCH 3/9] unit: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- unit/test-caif.c|2 +- unit/test-mux.c |2 +- unit/test-simutil.c |4 ++-- 3 files changed, 4

<    1   2   3   >