Re: ConnectionContext creation for LTE PDN Connection.

Hi Remi, as I mentioned before, please do NOT break threading. > > why would bringing an interface up interfere? We are doing this right > > now. Just the IP assignment is done by ConnMan, but the interface > > up/down status is controlled by oFono or even BlueZ in case of > > Bluetooth. > > Log

Re: [PATCH] Add voice call boolean property for MO/MT distinction

Hi Remi, do me a favor and try not to break the threading next time. > > > * At Nokia, we also have some non-standard commands for internal use. > > > * Some operators require some funky AT commands of their own. It might > > not be > > > possible to open-source them, even if we want to. > > > >

Re: ConnectionContext creation for LTE PDN Connection.

Hi Remi, > > Or should oFono automatically create a Connection Context? > > > > Furthermore, should oFono automatically proceed and > > set Active=true, bind the connection to a network interface > > and set network interface in state UP, > > Definitely not. This would interfere with any other e

Re: [PATCH] Add voice call boolean property for MO/MT distinction

Hi Remi, > > > This becomes a problem if we have more than one application "managing" > > > voice calls. And I expect that will _be_ the most common case. You have > > > the main call UI, but you also have the Bluetooth headset/carkit, the > > > USB AT commands port, and possibly some third party

Re: [PATCH 2/3] Use %m instead of strerror() in syslog messages

Hi Remi, > > > strerror() is not thread-safe, nor in the glibc implementation, > > > nor in the POSIX specification. In my experience, it will infrequently > > > crash when another thread uses locale data in any way, including > > > string formatting and such... > > > > > > Since the Huawei drive

Re: [PATCH] configure: do not hard-code the C run-time library name

Hi Remi, > Since oFono does (obviously) not use -nostdlib, this only broke support > for alternative C run-times. > --- > configure.ac |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) looks good enough to me. Patch has been applied. Regards Marcel ___

Re: [PATCH] Mark ofono/*.h symbolink links as built sources

Hi Remi, > This forces automake/make to build them first if needed (as before). > But it avoids marking every single header as a dependency of every > single object. Thus we do not need a bogus full rebuild of the tree > everytime a header is added. I had this before, but it caused problems with

Re: [PATCH 2/3] Use %m instead of strerror() in syslog messages

Hi Remi, > strerror() is not thread-safe, nor in the glibc implementation, > nor in the POSIX specification. In my experience, it will infrequently > crash when another thread uses locale data in any way, including > string formatting and such... I have no problem with this ... > Since the Huawe

RE: How to get the OMA DRM right object file coming from WAP Push?

Hi Aki, > > Can the two methods help me to handle files from WAP push? > > Yes. You need to implement the PushNotificationAgent interface, and > register this object with oFono using the RegisterAgent() method. there is actually a test/test-push-notification Python example in the code base that

Re: [RERESEND] [PATCH 2/2] Update the network documentation

Hi Remi, > doc/network-api.txt |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/doc/network-api.txt b/doc/network-api.txt > index 083e918..9fb9974 100644 > --- a/doc/network-api.txt > +++ b/doc/network-api.txt > @@ -125,8 +125,9 @@ Propertiesstring Mode [

RE: [PATCH] TODO: Add vCard export to SM/ME stores

Hi Jaakko, > > To be honest, the more and more I think about this, the more my > > conclusion is to not support phonebook export. It is a bad idea. It is > > highly complex and it is not a feature that will be used anyway. > > Ok, got it. Do you have any insight if MeeGo still wants this > (http

RE: [PATCH] TODO: Add vCard export to SM/ME stores

Hi Jaakko, > > no index number. We will never use them. It is either the full > > phonebook > > at once or nothing. The write function has to empty out left over > > entries. > ... > > Actually I prefer we use proper Dict field names. We never use anything > > literally from the specifications in

RE: [PATCH] TODO: Add vCard export to SM/ME stores

Hi Jaako, > > > Is there already a specification/draft of the format of this dict? If > > not, I would be tempted to use the 27.007 +CPBR/W field names as keys > > (e.g. index, number, type, text, adnumber, secondtext, sip_uri, etc.) > > > > there is not. So you need to propose one here. > > For

Re: [PATCH] build: Update glib version in configure.ac

Hi George, > function g_mkstemp_full in src/storage.c > requires glib version 2.22 or higher > --- > configure.ac |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) patch looks good, but your subject line has a ^I character in it and I prefer not to figure out what git does with it.

RE: [PATCH] ifxmodem: Adding fast dormancy support to Infineon modem

Hi Waldo, > > "Trigger Fast Dormancy +XFDOR > > This command triggers fast dormancy if all conditions are passed successful > > it will be send > > towards the network. There will be no confirmation if the request was > > executed or not as in the > > last extend the full execution belongs to

Re: [PATCH 1/3] Add TTY (hearing impaired) support

Hi Lucas, > Makefile.am |5 +- > include/dbus.h |1 + > include/text-telephony.h | 71 ++ > src/modem.c |1 + > src/ofono.h |2 + > src/text-telephony.c | 333 > ++ > 6 fil

Re: [PATCH] ifxmodem: Adding fast dormancy support to Infineon modem

Hi Robertino, > Initial patch to add fast dormancy to Infineon modem. Timeout is not > supported yet. > > Thanks, > -- r. > > --- > drivers/ifxmodem/radio-settings.c | 40 > - > 1 files changed, 39 insertions(+), 1 deletions(-) > > diff --git a/drivers/if

Re: [RFC] plugin/ste: Use D-Bus API from Modem Init Daemon for autoconfig.

Hi Sjur, > >> We definitely need a synchronization mechanism between Modem Init Daemon > >> and the other services, so we decided to use a D-Bus API for the > >> Modem Init Daemon to expose the modem state and an API for initiating > >> power-off, upgrade and reboot. > > > > do you have a link to

Re: [PATCH 0/4] Emergency Calls (3rd round)

Hi Andras, > I found a small issue in these patches, resulting into improper handling > of the emergency calls for the non-SIM cases, but now that has been > fixed and I am going to create a new set of patches. > > The answer to your question is yes, emergency calls will be also > possible wit

RE: [PATCH] TODO: Add vCard export to SM/ME stores

Hi Waldo, > > To support this feature then first we need to convert the current > > feature into returning a dict. And then have this feature using a dict > > as input. > > Does this mean that support for writing to the phonebook is expected to > be added to the phonebook modem API as part of ofo

Re: [RFC PATCH 5/5] Makefile: add call counters to the build

Hi Andras, > Makefile.am |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index f841b4c..a1c6097 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -295,6 +295,9 @@ builtin_modules += example_nettime > builtin_sources += examples/netti

Re: [PATCH 0/5] Call Counters

Hi Andras, > Here a proposal for call counters implementation for keeping track > of the total incoming and outgoing call duration counters. Each > established call instance is contributing to either of the call > duration counters. The 2 counters are updated periodically when > there is an establ

Re: [PATCH v5b 2/3] stemodem: Create network interfaces statically

Hi Sjur, > static void ste_eppsd_down_cb(gboolean ok, GAtResult *result, > @@ -191,7 +189,7 @@ static void ste_eppsd_down_cb(gboolean ok, GAtResult > *result, > ofono_gprs_context_cb_t cb = cbd->cb; > struct ofono_gprs_context *gc = cbd->user; > struct gprs_context_data *gcd =

Re: [PATCH v5b 1/3] stemodem: Fix for error handling, memleak and changed some defines

Hi Sjur, > * renamed MAX_LEN to IP_ADDR_LEN > * removed memory leak from unneeded strdup when parsing xml response. > * better handling of AT error responses > * reduced number of caif interfaces to 4 > --- > drivers/stemodem/gprs-context.c | 54 ++ > 1 files

Re: [PATCH v5] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

Hi Sjur, > Makefile.am |2 + > drivers/stemodem/caif_rtnl.c | 340 > ++ > drivers/stemodem/caif_rtnl.h | 29 > 3 files changed, 371 insertions(+), 0 deletions(-) > create mode 100644 drivers/stemodem/caif_rtnl.c > create mode

RE: [PATCH] TODO: Add vCard export to SM/ME stores

Hi Jaakko, > > To support this feature then first we need to convert the current > > feature into returning a dict. And then have this feature using a dict > > as input. > > Is there already a specification/draft of the format of this dict? If not, I > would be tempted to use the 27.007 +CPBR/W

Re: [PATCH] TODO: Add vCard export to SM/ME stores

Hi Jaakko, > TODO | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/TODO b/TODO > index bf2305b..9dcb43f 100644 > --- a/TODO > +++ b/TODO > @@ -496,3 +496,14 @@ Miscellaneous > >Priority: Low >Complexity: C4 > + > +- Enable exporting contact infor

Re: [PATCH] doc: Add Location Services API

Hi Denis, > > As requested, this is our initial proposal for a minimal API > > in order to support E911, based on the 27.007 defined AT > > commands. > > > > We've discussed internally different names for this API: > > AGNSSManager or AssistedGlobalNavigationSatelliteSystem, > > but ended up with

RE: [PATCH v4 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

Hi Sjur, > > what happens for network triggered deactivation. Some networks here > > disconnect the GPRS context used MMS. Has some funny behavior that need > > to be taken into account. > > Good question! When code reading with this in mind I realize that > we missed to mark the conn_info->inter

RE: [PATCH] voicecall: Add EmergencyCall property.

Hi John, please do not top post on this mailing list. I am really serious with the fact that I am going to ignore people from now on that do that. > Will change the property name to Emergency and resend the patch. This was a question open for discussion. What would be the appropriate property na

Re: [PATCH] voicecall: Add EmergencyCall property.

Hi John, > doc/voicecall-api.txt |4 > src/voicecall.c | 34 +- > 2 files changed, 37 insertions(+), 1 deletions(-) > > diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt > index f0ba316..60c692c 100644 > --- a/doc/voicecall-api.txt > +++

Re: isigen: enabled multiple PDP contexts

Hi Mika, > Here's the patch to enable multiple PDP contexts in isigen. > Turns out that probing the context count is not feasible, > so we just default to four. you might wanna ask your modem firmware guys to add something like this. For me it would sounds like a good idea to know how many active

RE: [PATCH 4/4] isigen: make number of PDP contexts configurable

Hi Mika, > > why to do you bother making this a configurable option? What isthe > > benefit here? > > The maximum context count is a compile time option for the ISI modem. Having > this option in oFono makes it possible to optimize the APE side resource > usage instead of overallocating drivers

RE: [RFC] plugin/ste: Use D-Bus API from Modem Init Daemon for autoconfig.

Hi Sjur, > > > This patch introduces auto discovery of ST-Ericsson modems. > > > ST-Ericsson modems are managed by a Modem Init Daemon which > > > is responsible for start/stop/restart flashing etc. The > > > STE plugin monitors the modem state exposed from the > > > Modem Init Damon Dbus API. Whe

Re: [PATCH v4 2/2] stemodem: Update gprs-context to use rtnl to create/remove interfaces.

Hi Sjur, > drivers/stemodem/gprs-context.c | 207 > +-- > 1 files changed, 135 insertions(+), 72 deletions(-) > > diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c > index 9f59579..4260d31 100644 > --- a/drivers/stemodem/gprs-con

Re: [PATCH v4 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

Hi Sjur, > I'm sorry about the formatting for the v3 version of this patch. > I used git send-email via my gmail account, and ended up with base64 > MIME content encoding. I dont' know what went wrong :-( > > I think I have closed most of your review comments so far. I kept using > sendto as I d

RE: [RFC v2 3/3] ifxmodem: adding modem API to support agps

Hi Waldo, > The error handling in ifx_agps_inject_time_cb needs to have a call to > CALLBACK_WITH_FAILURE. < snip> > In ifx_agps_send_lcs_frame the raw_frame isn't hex encoded before it gets > inserted into the AT command. this mailing list does NOT allow top posting and you know this. Still

Re: [RFC PATCH 2/3] modem: add EmergencyMode property

Hi Denis, > >> Here you should turn the radio off if it was off before starting the > >> emergency call. > >> > >> > > > > The rationale behind leaving the radio on after emergency calls > > was to have the theoretical possibility the emergency call center > > to call you back (when SIM card

Re: [PATCH 4/4] isigen: make number of PDP contexts configurable

Hi Mika, > plugins/isigen.c | 23 +-- > plugins/udev.c |6 +- > 2 files changed, 22 insertions(+), 7 deletions(-) > @@ -434,6 +434,10 @@ static void add_isi(struct ofono_modem *modem, > if (addr != NULL) > ofono_modem_set_integer(modem, "Add

Re: [PATCH] Add test/reset-pin

Hi Pekka, > > --- > > test/reset-pin | 23 +++ > > 1 files changed, 23 insertions(+), 0 deletions(-) > > create mode 100755 test/reset-pin > > > > Patch has been applied, thanks. I saw that Denis fixed the Makefile.am for you. Please keep in mind to ensure that test scri

Re: [RFC PATCH 1/3] modem: add modem online-offline watch

Hi Andras, > Signed-off-by: Andras Domokos please redo the patches without the Signed-off-by line. It is mentioned in doc/coding-style.txt that we do not use this. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinf

Re: [PATCH] Add vid/pid for Ericsson F5521gw

Hi Torgny, > plugins/ofono.rules |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/2] Added Nokia CS-17 to udev rules.

Hi Hannu, > The stick has to be initialized with usb_modeswitch, though. > --- > plugins/ofono.rules |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.or

Re: [PATCH 1/2] Fixes segfault when removing Nokia Datacard.

Hi Hannu, > plugins/nokia.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

RE: [RFC 1/3] doc: addidng documentation for basic assisted gps

Hi Waldo, > > oFono is strict CamelCase, even for abbreviations. You do this > > correctly above (AgpsManager) but not here. Please be consistent. And > > it might be a good idea to not have abbreviations at all. What does LCS > > stand for in this case? > > It refers to terminology from 3GPP

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

Hi Denis, > >>> So in general I'm currently against introducing this API as oFono > >>> official API. I suggest prefixing this with an IFX specific identifier. > >>> Maybe modem.ifx.AgpsManager. > >> > >> I would actually go one step further and call this com.infineon.Agps or > >> something like

Re: [PATCH] sim: Check SIM pin status after changing pin.

Hi Marit, as Denis mentioned and I stated many times, please don't top post on this mailing list. It is against our mailing list etiquette. > OK, I can see that this approach was rather too simplistic... Maybe checking > the returned CME error would be a better idea? > I’m a bit unsure how (or if

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

Hi Denis, > > doc/assistedgps-manager-api.txt | 114 > > +++ > > 1 files changed, 114 insertions(+), 0 deletions(-) > > create mode 100644 doc/assistedgps-manager-api.txt > > > > diff --git a/doc/assistedgps-manager-api.txt > > b/doc/assistedgps-manager-ap

Re: [PATCH] todo: ifxmodem apgs support

Hi Robertino, > TODO |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/TODO b/TODO > index a5196f7..7ee7920 100644 > --- a/TODO > +++ b/TODO > @@ -484,3 +484,8 @@ Miscellaneous > >Priority: Low >Complexity: C4 > + > +- Modem support: adding support for

RE: [PATCH] sim: use mask for check of sim file status

Hi Guillaume, > I've tested your changes and all is ok :) thanks for testing this. But please refrain from top posting on this mailing list. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] TODO: Add owner of provide local info task

Hi Yang, > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCHv2] isigen: increase offline timeout

Hi Pekka, > The modem deregisters from network before response to MTC_STATE_REQ is > returned. Deregistering can take up to 6 seconds. > --- > drivers/isimodem/mtc.h |1 + > plugins/isigen.c |2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) patch has been applied. Regards

Re: [RFC] plugin/ste: Use D-Bus API from Modem Init Daemon for autoconfig.

Hi Sjur, > This patch introduces auto discovery of ST-Ericsson modems. > ST-Ericsson modems are managed by a Modem Init Daemon which > is responsible for start/stop/restart flashing etc. The > STE plugin monitors the modem state exposed from the > Modem Init Damon Dbus API. When the modem is in st

Re: [PATCH v4] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.

Hi Marit, > When adding the use of pin event *EPEV also to at_pin_send_puk_cb, > it becomes identical to at_pin_send_cb, and can be removed. > --- > Again, thank you for your patience, I really hope it's OK this time:) > > drivers/atmodem/sim.c | 34 +- > 1 file

Re: [PATCH v3] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.

Hi Marit, > From: Marit except that I can not merge it like this. The From: address line should contain the full name and not an abbreviation. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

RE: [RFC] AGPS Support

Hi Waldo, > > > For other modems sending the raw RRC/RRLP frames I guess the transcoding > > > to XML > > > would need to happen in the ofono driver or in ofono core if you want > > > to expose an > > > oFono XML API. > > > so here is my take on XML. If we have to parse it, then in general that

Re: [PATCH] isigen: increase offline timeout

Hi Pekka, > The modem deregisters from network before response to MTC_STATE_REQ is > returned. Deregistering can take at least 8 seconds. > --- > plugins/isigen.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/isigen.c b/plugins/isigen.c > index 493d926..0

Re: [PATCH] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.

Hi Marit, > When adding the use of pin event *EPEV also to at_pin_send_puk_cb, > it becomes identical to at_pin_send_cb, and can be removed. > --- > New patch, this one should apply:) please also do [PATCH v2] so we know which version it is. git am will strip these nicely away from us. > driver

Re: [PATCH] TODO: Update Read/Write EFcfis description

Hi Jeevaka, > TODO |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

RE: [PATCHv2 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

Hi Sjur, > > > +static GSList *pending_requests; > > > +static GIOChannel *channel; > > > +static guint32 rtnl_seqnr; > > > +static guint rtnl_watch; > > > > To be fair, you don't need both, the GIOChannel and the watch. You can > > just add the watch and then unref the GIOChannel and set it to

Re: [PATCH] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.

Hi Marit, > When adding the use of pin event *EPEV also to at_pin_send_puk_cb, > it becomes identical to at_pin_send_cb, and can be removed. > --- > drivers/atmodem/sim.c | 44 +--- > 1 files changed, 1 insertions(+), 43 deletions(-) I am fine with this

Re: [RFC] AGPS Support

Hi Sjur, > >> > On positioning framework side, XML containers encoding/decoding does not > >> > seem to be yet widely used, while the support of RRC and RRLP framing is > >> > common, thanks to the support of SUPL. > >> > > >> > Using XML and 27.007 format would be great as long as long as ofono

Re: [RFC] [CHANGE 2/2] ifxmodem: adding modem API to support agps

Hi Robertino, > This patch is RFC for Infenion modem API to support agps implementation of > ofono. same rules as in the other email apply here. > drivers/ifxmodem/agps.c | 438 > +++ > include/agps.h | 157 + > 2 files ch

Re: [RFC] [CHANGE 1/2] Addidng initial documentation for basic assisted gps

Hi Robertino, > This is first attempt to send out RFC for a-gps dbus documentation. It fill > be followed by RFC for Infineon modem API implementation. > > Thank you for your comments in advance. :-) as explained in the other email, some general rules on submission needs to be fulfilled. Use g

Re: [PATCH 1/1] Add option to support version

Hi Yang, > Makefile.am |2 +- > bootstrap|2 +- > configure.ac |1 + > src/main.cpp | 11 +-- > 4 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index f124b08..dd54c42 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -50

Re: [RFC] AGPS Support

Hi Sjur, > > On positioning framework side, XML containers encoding/decoding does not > > seem to be yet widely used, while the support of RRC and RRLP framing is > > common, thanks to the support of SUPL. > > > > Using XML and 27.007 format would be great as long as long as ofono is not > > ob

Re: [PATCH 2/2] atmodem: Add use of pin event *EPEV after sending PUK.

Hi Denis, > >> The MBM/STE modems send the unsolicited result code *EPEV to report when > >> the PIN code has been inserted and accepted. > > > > I almost thought so, but I was not sure when adapting this for IFX. > > > >> diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c > >> index 94

Re: [PATCH 2/2] atmodem: Add use of pin event *EPEV after sending PUK.

Hi Marit, > The MBM/STE modems send the unsolicited result code *EPEV to report when > the PIN code has been inserted and accepted. I almost thought so, but I was not sure when adapting this for IFX. > diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c > index 94658f2..3abd1d8 100644 >

RE: [PATCHv2 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

Hi Sjur, > > You don't really have to play this append/remove game. You can just > > append it after send_rtnl_req succeed. The read goes via the mainloop > > anyway and we are a single threaded program. So the order is > > guaranteed. > > I'm not sure about this. I need to keep track of what > c

Re: [PATCHv2 1/2] stemodem: Add RTNL functionality managing CAIF Network Interfaces.

Hi Sjur, > Makefile.am |2 + > drivers/stemodem/caif_rtnl.c | 365 > ++ > drivers/stemodem/caif_rtnl.h | 40 + > 3 files changed, 407 insertions(+), 0 deletions(-) > create mode 100644 drivers/stemodem/caif_rtnl.c > create mod

Re: [PATCH 2/4] stemodem: Add RTNL functionality for CAIF Netw Interface.

Hi Sjur, > Add file rtnl.c for creating and deleting CAIF network > interfaces using the RTNL protocol. The interface is > asynchronous. > > Only RTNL NEWLINK and DELLINK commands are implemented. > CAIF requires NEWLINK to contain channel-id and ip-type > (ipv4/ipv6) as arguments. > > --- > dr

Re: [PATCH 4/4] stemodem: Add rtnl to Makefile.

Hi Sjur, > From: Sjur Brændeland > > --- > Makefile.am |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) this one need to come before you actually use that code of course ;) And it is so simple, just feed it into the initial patch adding the RTNL support. Regards Marcel __

Re: [PATCH] TODO: update owner of see/cancel pending SMS task

Hi Yang, > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/2] main: add capabilities for phonet

Hi Mika, > Phonet sockets require CAP_SYS_ADMIN and SO_BINDTODEVICE socket > option requires CAP_NET_RAW. and I so thought that we get away with lower capabilities :( > --- > src/main.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Patch has been applied. Regards Marcel __

Re: [PATCH 1/2] isigen: fix phonet address initialization

Hi Mika, > plugins/isigen.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

RE: [RFC PATCH 2/3] voicecall: emergency call handling added

Hi Mika, > > > To give you a more complex example, it might well be that the gprs > > > connection needs to be torn down when making an emergency call in > > > 2G mode, there are such networks out there that prevents you from > > > making an emergency call if your device is attached to a > > PDP

Re: Infineon modem API to support aGPS

Hi Robertino, > This is the first attempt to add aGPS support for Infineon modem. Patch > contains modem API per Waldo's RFC and suggestions. > > DBUS API in ofono core are just place holders (not implemented), in this > patch. please send patches as patches and introduction email as a separate

Re: [RFC PATCH 2/3] voicecall: emergency call handling added

Hi Andras, > > In general I think that the emergency_watch is unnecessary. Having a > > reference counted emergency tracking inside the modem object and a modem > > online state watch should be sufficient. > > > > > The idea with the emergency watch is that any subsystem can get the > notific

Re: [PATCH] TODO: Owner of Read / Write EFcfis

Hi Jeevaka, > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/4] doc: Add ModemAccessTechnology property

Hi Rajesh, > doc/modem-api.txt |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/doc/modem-api.txt b/doc/modem-api.txt > index c48375e..f5a3026 100644 > --- a/doc/modem-api.txt > +++ b/doc/modem-api.txt > @@ -43,6 +43,15 @@ Properties boolean Powered [readwrit

Re: [PATCH] Fix string array memory leaks during plugin loading

Hi Johan, > src/plugin.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Document Proxy-CSCF setting.

Hi Pekka, > Proxy-CSCF is a SIP proxy for IMS connections. > --- > doc/connman-api.txt |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) I am not going to apply this patch right now. Things with IMS are still not really certain to me. And until there is an implementation that goes

Re: [PATCH] Document ims connection type

Hi Pekka, > doc/connman-api.txt |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] gprs-context: add IMS connection type

Hi Pekka, > include/gprs-context.h |1 + > src/gprs.c |6 ++ > 2 files changed, 7 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/of

RE: [PATCH 2/6] stemodem: add default case

his is not consistent. I > > would prefer > > if that never happens, but somethings things slip through even close > > code review. If you know other cases, please let me know and > > we fix them > > as well here. > > All the other drivers implementing radio set

Re: [PATCH] ifxmodem: Notify core about commands handled in modem.

Hi Andrew, > + /* > + * A proactive command starts with a Proactive UICC Command BER-TLV > + * short tag (0xd0) with optional pad bytes, a Terminal Response > + * starts with the Command Details CTLV tag (0x81). > + */ > + if (pdu[0] != 0x81) > + ofono_stk_p

RE: [PATCH 2/6] stemodem: add default case

Hi Mika, > > > diff --git a/drivers/stemodem/radio-settings.c > > b/drivers/stemodem/radio-settings.c > > > index 5b16ec0..a345975 100644 > > > --- a/drivers/stemodem/radio-settings.c > > > +++ b/drivers/stemodem/radio-settings.c > > > @@ -90,7 +90,7 @@ static gboolean > > ofono_mode_to_ste_mode

Re: [PATCH 2/6] stemodem: add default case

Hi Mika, > --- > drivers/stemodem/radio-settings.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/stemodem/radio-settings.c > b/drivers/stemodem/radio-settings.c > index 5b16ec0..a345975 100644 > --- a/drivers/stemodem/radio-settings.c > +++ b/drivers/ste

Re: [PATCH 6/6] AUTHORS: add myself

Hi Mika, > --- > AUTHORS |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) nobody should need to add themselves to the AUTHORS file. I apologize for this oversight. You are added now. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH 3/6] test: add scripts to enable and disable fast dormancy

Hi Mika, > Makefile.am|4 +++- > test/disable-fast-dormancy | 20 > test/enable-fast-dormancy | 20 > 3 files changed, 43 insertions(+), 1 deletions(-) > create mode 100755 test/disable-fast-dormancy > create mode 100755 test/en

Re: [PATCH 2/6] radio settings: document FastDormancy property

Hi Mika, > doc/radio-settings-api.txt | 59 ++- > 1 files changed, 41 insertions(+), 18 deletions(-) sounds good to me. And I just went ahead and applied this patch. Regards Marcel ___ ofono mailing list of

Re: [PATCH 1/6] radio settings: add FastDormancy property

Hi Mika, > include/radio-settings.h | 11 > src/radio-settings.c | 134 + > 2 files changed, 133 insertions(+), 12 deletions(-) > > diff --git a/include/radio-settings.h b/include/radio-settings.h > index d41ec0b..a6b19d0 100644 > --- a/inc

Re: Call counters proposal (TODO patch)

Hi Andras, > I am proposing adding Call counters to Voicecall. Here is the TODO patch: > > diff --git a/TODO b/TODO > index d9a6580..89e180c 100644 > --- a/TODO > +++ b/TODO > @@ -329,6 +329,15 @@ Voicecall > Complexity: C2 > Owner: Pekka Pessi > > +- Call counters. Provide total outgoi

Re: [PATCH] hso: Set modem name based on udev network interface name

Hi Benoit, please fix your mail client. You keep breaking threading every single time you respond. That is pretty annoying. > > the friendly modem name is for devices that do have a friendly name, > > like Bluetooth headsets. Why do you wanna misuse the interface name > > here. I am a bit against

Re: [PATCH] hso: Set modem name based on udev network interface name

Hi Benoit, > Subject: [PATCH] hso: Set modem name based on udev network interface name > > Useful if you have multiple identical modems and you need a way > to know which modem you're talking to. > --- > plugins/hso.c |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --

Re: A way of polling SIM status

Hi Andrew, > >> Unfortunately some modems report CPIN: READY even though they're not > >> ready. The only reliable way to poll for this is to poll the IMSI, then > >> the phonebook and the sms store and report ready only once all of them > >> can be manipulated. > > > > I seems to me that Caiwen

Re: A way of polling SIM status

Hi Caiwen, > Due to some other tasks, it a long time did not take part in the > discussion > Here. I see there are much discussion about how to polling SIM status. > > Maybe we can start to polling the SIM status with AT+CPIN? when the > probe > function of SIM atom driver is invoke. If it ret

Re: [PATCH] TODO: Add CDMA support to SMS stack

Hi Rajesh, > TODO | 26 ++ > 1 files changed, 26 insertions(+), 0 deletions(-) patch has been applied. However keep in mind that you have to update the TODO description with correct details when it becomes clear on how we wanna integrate it. Regards Marcel

Re: [RFC sim-ready-v1 PATCH 0/3] ofono_sim_ready_notify

Hi Pekka, > Here is my 2nd stab at the ofono_sim_ready_notify(). > > Main difference from Denis's and Kristen's patch is that the modem > driver now has a way to indicate that is ready or not: if SIM is not > ready, the ofono_sim_driver indicates that with query_passwd_state > callback returning

[PATCH] atmodem: Add SIM ready quirk for IFX when entering PUK

For the Infineon modem, also the PUK entering needs to be extended with a quirk to wait for the SIM ready notification. --- drivers/atmodem/sim.c | 60 ++-- 1 files changed, 47 insertions(+), 13 deletions(-) diff --git a/drivers/atmodem/sim.c b/driver

<    3   4   5   6   7   8   9   10   11   12   >