Re: [VPATH PATCH 2/2] Fix $(INCLUDE) in Makefile.am

Hi Marcel, On Tue, 2011-08-30 at 11:39 -0700, ext Marcel Holtmann wrote: what problem is this patch fixing? The problem was that things like #include gisi/iter.h did not work with VPATH. --Pekka ___ ofono mailing list ofono@ofono.org

[VPATH PATCH 1/2] Fix generating links in Makefile.am

From: Pekka Pessi pekka.pe...@nokia.com In case relative dependency is in $(srcdir), $ already includes path to $(srcdir). --- Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 5019b7d..832c8ac 100644 --- a/Makefile.am +++ b

[VPATH PATCH 0/2] Fix Makefile.am when using VPATH

Hi, I noticed there are some problems building with VPATH (if builddir and srcdir are different from each other). E.g., make checkdist worked only by accident. The following patches are supposed to fix the problems. --Pekka ___ ofono mailing list

Re: [PATCH] isimodem: use a specific call id when answering

Hi Denis, 2011/4/28 Denis Kenzior denk...@gmail.com: ' +     for (id = 1; id = 7; id++) { +             switch (ivc-calls[id].status) { +             case CALL_STATUS_COMING: +             case CALL_STATUS_MT_ALERTING: +             case CALL_STATUS_WAITING: oFono expects answer to only

[PATCH] gisi: log normal responses in a less confusing way

From: Pekka Pessi pekka.pe...@nokia.com --- gisi/modem.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gisi/modem.c b/gisi/modem.c index 384983d..070cb9c 100644 --- a/gisi/modem.c +++ b/gisi/modem.c @@ -163,7 +163,8 @@ static void pending_remove_and_dispatch

[PATCH] isimodem: use a specific call id when answering

From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/voicecall.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 333f9b8..4d4e16b 100644 --- a/drivers/isimodem/voicecall.c

[PATCH] isiusb: wait for MTC transitions, too

From: Pekka Pessi pekka.pe...@nokia.com --- plugins/isiusb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isiusb.c b/plugins/isiusb.c index ad24fc9..82d2cc5 100644 --- a/plugins/isiusb.c +++ b/plugins/isiusb.c @@ -352,7 +352,7 @@ static void mtc_state_cb

[PATCH] isimodem: fix call_create_resp handling

From: Pekka Pessi pekka.pe...@nokia.com In case of call creation failure modem may return a valid call id in order to send CALL_SERVICE_DENIED_IND which we do not handle. Fixes MeeGo bug#15855. --- drivers/isimodem/voicecall.c | 39 +-- 1 files changed, 33

[PATCH] isimodem: notify sms-status-reports, too

From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/sms.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c index 6f6b247..40dfa1d 100644 --- a/drivers/isimodem/sms.c +++ b/drivers/isimodem/sms.c @@ -564,6

Re: [RFC PATCH v3] gprs: add function to handle activated context

Hi Arun, 2011/4/6 Arun Ravindran ext-arun.1.ravind...@nokia.com: According to this, the cid of user initiated context and network initiated context doesn't overlap. The problem is, the initial EPS context is initiated by mobile, not by the network. The mobile sends a piggybacked PDN

[PATCH 1/2] isimodem/sim: added PIN and SIM state handling

From: Pekka Pessi pekka.pe...@nokia.com Using PN_SECURITY resource to obtain PIN statuses. Using ofono_sim_ready_notify() aka __ofono_sim_recheck_pin() to report the ready state. --- drivers/isimodem/debug.c | 59 + drivers/isimodem/debug.h |6 + drivers/isimodem/sim.c | 584

[PATCH 2/2] TODO: remove me from ofono_sim_ready_notify()

From: Pekka Pessi pekka.pe...@nokia.com __ofono_sim_recheck_pin() is fine by me --- TODO |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index fc65b35..f8926a3 100644 --- a/TODO +++ b/TODO @@ -70,7 +70,6 @@ SIM / SIM File system Priority: High

Re: [RFCv3] doc: Proposal for LTE/IMS API

Hi Sjur, 2011/2/11 Sjur Brændeland sjurb...@gmail.com: With latest changes the P-CSCF addresses from ISIM can be read from the IpMultimediaIdentity objects and the P-CSCF addresses returned as dynamic parameters for the PDN Connection are avilable in the ConnectionContext object. I have

Re: [sim-ready-nofify-v5 PATCH 2/3] atmodem/sim: use ofono_sim_ready_notify

Hi Denis, 2011/2/10 Denis Kenzior denk...@gmail.com: So all this logic seems to work by luck. AFAIK that is the way you wanted it. Continue initialization after 1) pin query returns None, and 2) notify is called after that. If notify is called when pin is not None, recheck pin.  oFono

[sim-ready-notify RFC 1/2] atmodem/sim: use ofono_sim_ready_notify

From: Pekka Pessi pekka.pe...@nokia.com Call ofono_sim_ready_notify if pin code query returns SIM READY, unless there is a vendor quirk for SIM status indications. Schedule calls to ofono_sim_ready_notify() from vendor-specific status indications: - IFX: register unsolicated +XSIM result code

[sim-ready-notify RFC 2/2] ifx: sim driver follows +XSIM

From: Pekka Pessi pekka.pe...@nokia.com --- plugins/ifx.c | 61 + 1 files changed, 1 insertions(+), 60 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 527a8c4..ddfb4af 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -98,8

ANNOUNCE: telepathy-ring 2.1.3

Telepathy-Ring 2.1.3 (I wish it need not have happened in my time) is now available for download from: http://telepathy.freedesktop.org/releases/telepathy-ring/telepathy-ring-2.1.3.tar.gz md5sum: 292d132ca62051398e8087d3721dedbb telepathy-ring-2.1.3.tar.gz sha1sum:

[sim-ready-nofify-v5 PATCH 3/3] isimodem/sim: added PIN and SIM state handling

From: Pekka Pessi pekka.pe...@nokia.com Using PN_SECURITY resource to obtain PIN statuses. Using ofono_sim_ready_notify() to report the ready state. --- drivers/isimodem/debug.c | 59 + drivers/isimodem/debug.h |6 + drivers/isimodem/sim.c | 574

[sim-ready-nofify-v5 PATCH 1/3] sim: add ofono_sim_ready_notify

From: Pekka Pessi pekka.pe...@nokia.com The sim atom waits for ofono_sim_ready_notify() after the callback to query_passwd_state. Upon call to ofono_sim_ready_notify(), SIM atom either continues initialization or rechecks if the SIM still requires a pin code. Based on patches by Kristen Accardi

[sim-ready-nofify-v5 PATCH 2/3] atmodem/sim: use ofono_sim_ready_notify

From: Pekka Pessi pekka.pe...@nokia.com Schedule a call to ofono_sim_ready_notify after pin code query returns SIM READY. Vendor quirks: - IFX: register unsolicated +XSIM result code - MBM: register unsolicated *EPEV result code --- drivers/atmodem/sim.c | 166

[sim-ready-nofify-v5 PATCH 0/3] ofono_sim_ready_notify

Hi all, The missing bitwise-not has been added to the sim, and the patches has been rebased to current master. A call to ofono_sim_ready_notify() is now always expected after call to query_passwd_state. When ofono_sim_ready_notify() is invoked, it checks that the call is expected and if needed,

Re: [PATCH 2/2] voicecall: try harder to avoid Dial mismatches

Hi Denis, 2011/2/2 Denis Kenzior denk...@gmail.com: On 02/01/2011 04:22 PM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com There were some cases where Dial returned an incorrect call object, e.g., after oFono crash and recover. ---  src/voicecall.c |   15

Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Arun, 2011/1/28 Arun Ravindran ext-arun.1.ravind...@nokia.com:  +        boolean ImsVoiceOverPs [readonly, optional]  +  +            IMS voice is enabled by network  +            Related AT command: AT+CIREP.  + Which specification details this AT command, searched in 27.007 rel 10,

Re: Ofono has too tight limits for SIM lock code lengths

Moro Jussi, 2011/1/27 Jussi Kangas jussi.kan...@tieto.com: so every single enum has kept some sort of proper namespacing. And I would really prefer to not break this for ofono_sim_password_type. I suppose u are talking about parameter name here? and OFONO_PASSWORD_PIN_TYPE_NET is somehow

[ss-notify FYI 4/6] call-barring: remove CSSU notifications

From: Pekka Pessi pekka.pe...@nokia.com The CSSU notifications are better handled within voicecall. They indicate the reason why a call is rejected and augment the DisconnectReason. According to the 24.088 section 2.1, the SS notification for barring of incoming calls is sent when callee has

Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Sjur, 2011/1/26 Sjur Brændeland sjurb...@gmail.com: Features: - The QoS information is presented as an array of QoS settings with  an associated list IP Packet Filters. Only the QoS data for  connection context of type IMS will be reported.  The assumption is that QoS is only going to be

Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Sjur, 2011/1/27 Sjur Brændeland sjurb...@gmail.com: I think we need these in ConnectionContext, or perhaps a separate DedicatedContext interface would be better. Yes, as I mentioned earlier I considered this as well. But do you see other scenarios than IMS where the NW will set up

[sim-auth PATCHv2 3/3] Add doc/gba-authentication.txt

From: Pekka Pessi pekka.pe...@nokia.com --- Makefile.am|4 +- doc/gba-authentication.txt | 67 2 files changed, 69 insertions(+), 2 deletions(-) create mode 100644 doc/gba-authentication.txt diff --git a/Makefile.am b

[sim-auth PATCHv2 1/3] Add doc/sim-authentication-api.txt

From: Pekka Pessi pekka.pe...@nokia.com The authentication suites include SIM authentication (basic A8 authentication used with GSM) and AKA authentication on USIM. The SIM and AKA can be used to implement EAP, AKA Digest and GBA authentication algorithms. --- Makefile.am

ANNOUNCE: Telepathy-Ring 2.1.2

Telepathy-Ring 2.1.2 (I do love maps! I have quite a collection of them) is now available for download from: http://telepathy.freedesktop.org/releases/telepathy-ring/telepathy-ring-2.1.2.tar.gz md5sum: 519011d5666930b1636edfc0a717f664 telepathy-ring-2.1.2.tar.gz sha1sum:

[PATCH 3/3] doc: fix a kill-yank error

From: Pekka Pessi pekka.pe...@nokia.com --- doc/smartmessaging-api.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/smartmessaging-api.txt b/doc/smartmessaging-api.txt index 36065b4..637a5ef 100644 --- a/doc/smartmessaging-api.txt +++ b/doc/smartmessaging-api.txt

[PATCH 1/3] message-waiting: check for NULL argument

From: Pekka Pessi pekka.pe...@nokia.com --- src/message-waiting.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/message-waiting.c b/src/message-waiting.c index d8bfe34..0e376b6 100644 --- a/src/message-waiting.c +++ b/src/message-waiting.c @@ -926,11

[PATCH 2/3] message-waiting: add allocation checks

From: Pekka Pessi pekka.pe...@nokia.com --- src/message-waiting.c | 45 ++--- 1 files changed, 30 insertions(+), 15 deletions(-) diff --git a/src/message-waiting.c b/src/message-waiting.c index 0e376b6..5d1126b 100644 --- a/src/message-waiting.c +++ b

Re: [PATCH 4/4] atmodem: sim-auth atom driver.

Hi Denis, 2011/1/20 Denis Kenzior denk...@gmail.com: My view is that checking mallocs of small structures is pretty much pointless on Linux. The glib functions that ofono uses extensively don't do any malloc checking, and it makes checking on the ofono side bit pointless. If malloc fails,

[offline-atoms PATCHv2] Make gprs atom offline-safe.

From: Pekka Pessi pekka.pe...@nokia.com Allow use of GPRS atom both in online and offline (post_sim) states. The GPRS now considers the removal of the netreg atom as implicit detach and registration change to NOT_REGISTERED. --- src/gprs.c | 15 +-- 1 files changed, 13 insertions

[sim-auth PATCH 4/5] Add doc/gba-authentication.txt

From: Pekka Pessi pekka.pe...@nokia.com --- doc/gba-authentication.txt | 70 1 files changed, 70 insertions(+), 0 deletions(-) create mode 100644 doc/gba-authentication.txt diff --git a/doc/gba-authentication.txt b/doc/gba-authentication.txt new

[sim-auth PATCH 3/5] Add GBA_U to SIM authentication API

From: Pekka Pessi pekka.pe...@nokia.com --- doc/sim-authentication-api.txt | 90 1 files changed, 90 insertions(+), 0 deletions(-) diff --git a/doc/sim-authentication-api.txt b/doc/sim-authentication-api.txt index 27090e7..2db80bb 100644 --- a/doc/sim

[sim-auth PATCH 0/5] SIM Authentication D-Bus API

From: Pekka Pessi pekka.pe...@nokia.com Hi all, Here is my proposed SIM authentication API, marked as experimental. First two patches are hopefully easy to swallow. The uglier GBA_U part and some generic GBA blather can be found in last three patches. Unfortunately the IMS support requires

[sim-auth PATCH 5/5] Add doc/gba-authentication.txt to dist

From: Pekka Pessi pekka.pe...@nokia.com --- Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 65b488a..462b05f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -396,8 +396,8 @@ doc_files = doc/overview.txt doc/ofono-paper.txt

[sim-auth PATCH 2/5] Add doc/sim-authentication-api.txt to dist

From: Pekka Pessi pekka.pe...@nokia.com --- Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index c1c34ca..65b488a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -394,6 +394,7 @@ doc_files = doc/overview.txt doc/ofono-paper.txt doc

[sim-auth PATCH 1/5] Add doc/sim-authentication-api.txt

From: Pekka Pessi pekka.pe...@nokia.com The authentication suites include SIM authentication (basic A8 authentication used with GSM) and AKA authentication on USIM. The SIM and AKA can be used to implement EAP, AKA Digest and GBA authentication algorithms. --- doc/sim-authentication-api.txt

Re: [offline-atoms PATCH 1/2] Make gprs atom offline-safe.

Hi Denis, 2011/1/19 Denis Kenzior denk...@gmail.com: +     if (gprs-netreg == NULL) { +             gprs_netreg_removed(gprs); +             return; +     } + I'm having trouble visualizing why this chunk is necessary.  We reset netreg to NULL only when shutting down the atom or when

[PATCH 2/3] TODO: add GBA_U suite

From: Pekka Pessi pekka.pe...@nokia.com --- TODO |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index af872c5..bc01d90 100644 --- a/TODO +++ b/TODO @@ -116,6 +116,11 @@ SIM / SIM File system Complexity: C4 Owner: Pekka Pessi pekka.pe...@nokia.com

[PATCH 1/3] TODO: add SIM authentication API

From: Pekka Pessi pekka.pe...@nokia.com --- TODO |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index af22844..af872c5 100644 --- a/TODO +++ b/TODO @@ -110,6 +110,13 @@ SIM / SIM File system Complexity: C1 Owner: Aki Niemi aki.ni...@nokia.com

Re: [gisi-notify-fix PATCH 2/4] gisi: simplify handling of pending

Hi, 2011/1/18 Aki Niemi a...@protocolpolice.com: -void g_isi_pending_remove(GIsiPending *operation); +void g_isi_pending_own(GIsiPending *op, gpointer owner); +void g_isi_remove_all_my_pending(GIsiModem *modem, uint8_t resource, +                                       gpointer owner);

Re: Ofono CF states not always correct

HI Denis, 2011/1/18 Denis Kenzior denk...@gmail.com: Ok, so I'm convinced we're not handling this properly.  Based on your testing and my own independent testing setting the Unconditional CF rule does indeed 'hide' all other rules so they appear inactive. So do you care to come up with a

[gisi-notify-fix PATCHv2 1/2] gisi: simplify pending management

From: Pekka Pessi pekka.pe...@nokia.com Client or server mark their pending objects with the function g_isi_pending_set_owner(). When client or server get destroyed or reset the pending objects are removed with the function g_isi_remove_pending_by_owner(). As a client or server always uses only

[gisi-notify-fix PATCHv2 2/2] gisi: remove g_isi_pending_from_msg()

From: Pekka Pessi pekka.pe...@nokia.com --- gisi/modem.c |9 - gisi/modem.h |2 -- 2 files changed, 0 insertions(+), 11 deletions(-) diff --git a/gisi/modem.c b/gisi/modem.c index f80d671..8750367 100644 --- a/gisi/modem.c +++ b/gisi/modem.c @@ -156,8 +156,6 @@ static void

Re: Ofono CF states not always correct

Hi Denis, 2011/1/18 Denis Kenzior denk...@gmail.com: I think we can track the cached flag for conditional CFs independently from CFU.  The question is really whether the networks allow us to modify conditional CFs when CFU is active.  In my testing the answer is No. You can erase (##67#) or

Re: Ofono CF states not always correct

Hi Denis, 2011/1/18 Denis Kenzior denk...@gmail.com: 2011/1/18 Denis Kenzior denk...@gmail.com: I think we can track the cached flag for conditional CFs independently from CFU.  The question is really whether the networks allow us to modify conditional CFs when CFU is active.  In my testing

Re: [RFC PATCH] gprs: add function to handle activated context

Hi all, 2011/1/7 Denis Kenzior denk...@gmail.com: Considering that from a modem standpoint the CID race condition can be resolved, some modem implementation may not have reserved a range of CID for their own purpose, or may not provide a mechanism to reserve a range of CID. If the

Re: [PATCH 1/2] Add sim driver call for applications discovery.

Hi Denis and Andrzej, 2011/1/13 Denis Kenzior denk...@gmail.com: +     void (*list_apps)(struct ofono_sim *sim, ofono_sim_apps_cb_t cb, +                     void *data);  }; Do you think this belongs on a separate atom?  E.g. something like Pekka's SimAuthentication ? I think the

[PATCH] Fix crash in isimodem call forwarding.

From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/call-forwarding.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/isimodem/call-forwarding.c b/drivers/isimodem/call-forwarding.c index 2fafb26..89a03dc 100644 --- a/drivers/isimodem/call

Re: [RFC PATCH 0/3] Long phone numbers

Hi Rafael, 2011/1/17 Rafael Ignacio Zurita rafael.zur...@profusion.mobi: This is a proposal for the long phone number task (80 digits max length). It changes OFONO_MAX_PHONE_NUMBER_LENGTH and splits common:valid_phone_number_format(), to make sure long numbers are handled appropriately for

Re: [RFC PATCH] gprs: add function to handle activated context

Hi Sjur, 2011/1/17 Sjur Brændeland sjurb...@gmail.com: The 27.007 for release 9 (from version 9.3.0 onwards) says: NOTE 1: The cids for network-initiated PDP contexts will have values outside the ranges indicated for the cid in the test form of the commands +CGDCONT and +CGDSCONT. The

[offline-atoms PATCH 0/2]

Hi all, Here are patches that make gprs and sim atom online-agnostic. The atoms follow the network registration status and they can be added in post_sim. The intention is to allow GPRS context to be configured and short messages to be queued while in offline. The patches has been tested with

[offline-atoms PATCH 1/2] Make gprs atom offline-safe.

From: Pekka Pessi pekka.pe...@nokia.com Allow use of GPRS atom both in online and offline (post_sim) states. The GPRS now considers the removal of the netreg atom as implicit detach and registration change to NOT_REGISTERED. --- src/gprs.c | 20 ++-- 1 files changed, 18

[offline-atoms PATCH 2/2] Make sms atom offline-safe

From: Pekka Pessi pekka.pe...@nokia.com Allow use of SMS atom both in online and offline (post_sim) states. SMS atom now watches network registration atom and state. Thmessages are queued but not sent if not registered to a network. Errors occurring when a short message is being sent while

[PATCH] Clarify voicecall driver hold_all_active() semantics.

From: Pekka Pessi pekka.pe...@nokia.com --- include/voicecall.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index e37d73b..f3c2bf4 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -76,7 +76,8 @@ struct

[PATCH] isimodem: fix return from call control requests

From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/voicecall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index c19e64d..6f866a5 100644 --- a/drivers/isimodem/voicecall.c +++ b/drivers/isimodem

[gisi-notify-fix PATCH 2/4] gisi: simplify handling of pending

From: Pekka Pessi pekka.pe...@nokia.com Client or server mark their pending objects with g_isi_pending_own(). The g_isi_remove_all_my_pending() is used to remove pending objects by client or server when they get destroyed or reset. --- gisi/client.c | 199

[gisi-notify-fix PATCH 0/4]

Hi Aki, Here are patches simplifying the gisi client/server implementation and also making it more robust. --Pekka ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[gisi-notify-fix PATCH 4/4] isimodem: fix crash in gprs

From: Pekka Pessi pekka.pe...@nokia.com There was a crash if gprs was removed while creating context. --- drivers/isimodem/gprs.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/gprs.c b/drivers/isimodem/gprs.c index e614ac9..1550f24 100644

[gisi-notify-fix PATCH 3/4] gisi: remove g_isi_pending_from_msg()

From: Pekka Pessi pekka.pe...@nokia.com --- gisi/modem.c |9 - gisi/modem.h |2 -- 2 files changed, 0 insertions(+), 11 deletions(-) diff --git a/gisi/modem.c b/gisi/modem.c index ba79a31..0d19acd 100644 --- a/gisi/modem.c +++ b/gisi/modem.c @@ -156,8 +156,6 @@ static void

[gisi-notify-fix PATCH 1/4] gisi: remove before notify

From: Pekka Pessi pekka.pe...@nokia.com Just in case, remove pending operations before calling notifys. The notify function can remove client, service or modem. --- gisi/client.c |6 ++-- gisi/modem.c | 71 + 2 files changed, 49

[sim-ready-nofify-v4 PATCH 1/3] sim: add ofono_sim_ready_notify

From: Pekka Pessi pekka.pe...@nokia.com The sim atom waits for ofono_sim_ready_notify() after the callback to query_passwd_state. Upon call to ofono_sim_ready_notify(), SIM atom either continues initialization or rechecks if the SIM still requires a pin code. Based on patches by Kristen Accardi

[sim-ready-nofify-v4 PATCH 2/3] atmodem/sim: use ofono_sim_ready_notify

From: Pekka Pessi pekka.pe...@nokia.com Schedule a call to ofono_sim_ready_notify after pin code query returns SIM READY. Vendor quirks: - IFX: register unsolicated +XSIM result code - MBM: register unsolicated *EPEV result code --- drivers/atmodem/sim.c | 166

[sim-ready-nofify-v4 PATCH 0/3] ofono_sim_ready_notify()

Hi all, Here is my 5th stab at the ofono_sim_ready_notify(). The main difference to the patches submitted 16th December last year is that the isimodem sim driver has been refactored to the new SIM API. The AT modem driver and core has been rebased to current master, too. The

[sim-auth RFCv2 4/4] Include doc/sim-authentication-api.txt in dist.

From: Pekka Pessi pekka.pe...@nokia.com --- Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4dec90a..f3afb20 100644 --- a/Makefile.am +++ b/Makefile.am @@ -380,6 +380,7 @@ doc_files = doc/overview.txt doc/ofono-paper.txt doc

[sim-auth RFCv2 2/4] Added doc/sim-authentication-api.txt.

From: Pekka Pessi pekka.pe...@nokia.com The authentication mechanisms include SIM authentication (basic A8 authentication used with GSM), AKA authentication and UICC-based GBA authentication. The SIM and AKA can be used to implement EAP and GBA authentication algorithms. The interface can

[sim-auth RFCv2 1/4] TODO: add SIM authentication

From: Pekka Pessi pekka.pe...@nokia.com --- TODO |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 6ad972e..11330b6 100644 --- a/TODO +++ b/TODO @@ -97,6 +97,12 @@ SIM / SIM File system Complexity: C1 Owner: Marit Henriksen marit.henrik

[sim-auth RFCv2 3/4] Add GBA documents to doc/standards.txt

From: Pekka Pessi pekka.pe...@nokia.com --- doc/standards.txt | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/doc/standards.txt b/doc/standards.txt index 2b85cb0..e8ec19f 100644 --- a/doc/standards.txt +++ b/doc/standards.txt @@ -55,6 +55,19 @@ Describes

Re: [RFC sim-authenticate PATCH 2/3] Added doc/sim-authentication-api.txt.

Hi Marcel, 2011/1/3 Marcel Holtmann mar...@holtmann.org: yep, that is similar to what I was thinking about. I'll update the proposal. Andrew is currently looking on how to do SIM application discovery. So I like to get his input on this as well. The AT+CUAD looks straightforward enough.

Announce: telepathy-ring 2.1.1

Telepathy-Ring 2.1.1 (too little butter over too much bread) is now available for download from: http://telepathy.freedesktop.org/releases/telepathy-ring/telepathy-ring-2.1.1.tar.gz md5sum: f2ae9dd104cc16eec548884beead85a7 telepathy-ring-2.1.1.tar.gz sha1sum:

[RFC sim-authenticate PATCH 1/3] TODO: add SIM authentication

From: Pekka Pessi pekka.pe...@nokia.com --- TODO |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 12f313b..8cd5ada 100644 --- a/TODO +++ b/TODO @@ -105,6 +105,12 @@ SIM / SIM File system Complexity: C1 Owner: Marit Henriksen marit.henrik

[RFC sim-authenticate PATCH 0/3]

Hi all, Here is first proposal for SIM authentication API. The API provides access to ordinary SIM authentication methods. The first two methods are intended for implementing EAP authentication using cellular authentication mechanisms, the third one for implementing AKA authentication algorithm

[RFC sim-authenticate PATCH 2/3] Added doc/sim-authentication-api.txt.

From: Pekka Pessi pekka.pe...@nokia.com The EAP applications on SIM should be handled separately. The EapSimAuthenticate and EapAkaAuthenticate do not require a special EAP application on SIM, but they use ordinary cellular authentication. --- doc/sim-authentication-api.txt | 66

[RFC sim-authenticate PATCH 3/3] Include doc/sim-authentication-api.txt in dist.

From: Pekka Pessi pekka.pe...@nokia.com --- Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8a8555d..1f79fff 100644 --- a/Makefile.am +++ b/Makefile.am @@ -367,6 +367,7 @@ doc_files = doc/overview.txt doc/ofono-paper.txt doc

Re: [RFC sim-authenticate PATCH 2/3] Added doc/sim-authentication-api.txt.

Hi Marcel, 2011/1/3 Marcel Holtmann mar...@holtmann.org: The EAP applications on SIM should be handled separately. The EapSimAuthenticate and EapAkaAuthenticate do not require a special EAP application on SIM, but they use ordinary cellular authentication. ---  doc/sim-authentication-api.txt

Re: [PATCH] smsutil: do not hardcode TP-ValidityPeriod

Hi Denis, 2010/12/17 Denis Kenzior denk...@gmail.com: Can I get a bit more of an explanation from you as to why the 'absent' validity period is better than hardcoding this to 24 hours? If there is an explicit validity period, it overrides the default validity period set by operator. I'd rather

[PATCH] zte: poll sim before sim_inserted_notify

From: Pekka Pessi pekka.pe...@nokia.com Ensure that SIM is ready before calling ofono_sim_inserted_notify(). --- plugins/zte.c | 57 - 1 files changed, 52 insertions(+), 5 deletions(-) diff --git a/plugins/zte.c b/plugins/zte.c index

[sim-ready PATCHv3 1/3] sim: add ofono_sim_ready_notify

From: Pekka Pessi pekka.pe...@nokia.com The sim atom waits for ofono_sim_ready_notify() after the callback to query_passwd_state. Upon call to ofono_sim_ready_notify(), SIM atom either continues initialization or rechecks if the SIM still requires a pin code. Based on patches by Kristen Accardi

[sim-ready PATCHv3 0/3] ofono_sim_ready_notify

From: Pekka Pessi pekka.pe...@nokia.com Hi all, Here is my 4th stab at the ofono_sim_ready_notify(). The ofono_sim_ready_notify() is now always expected after call to query_passwd_state. When ofono_sim_ready_notify() is invoked, it checks that the call is expected and if needed, retries

[sim-ready PATCHv3 2/3] atmodem/sim: use ofono_sim_ready_notify

From: Pekka Pessi pekka.pe...@nokia.com Schedule a call to ofono_sim_ready_notify after pin code query returns SIM READY. Vendor quirks: - IFX: register unsolicated +XSIM result code - MBM: register unsolicated *EPEV result code --- drivers/atmodem/sim.c | 166

[PATCH] TODO: add SIM authentication

From: Pekka Pessi pekka.pe...@nokia.com --- TODO |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 8d771d6..894b748 100644 --- a/TODO +++ b/TODO @@ -141,6 +141,12 @@ SIM / SIM File system Complexity: C1 Owner: Marit Henriksen marit.henrik

[PATCH] smsutil: do not hardcode TP-ValidityPeriod

From: Pekka Pessi pekka.pe...@nokia.com --- src/smsutil.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index f4eee24..59faaf7 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -3162,11 +3162,10 @@ GSList *sms_datagram_prepare(const

[fix-isi-voicecall PATCHv5 2/4] isi/voicecall: add call id to queued requests

From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/voicecall.c | 89 +++--- 1 files changed, 57 insertions(+), 32 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index b89cbb3..e7126a8 100644 --- a/drivers

[fix-isi-voicecall PATCHv5 4/4] isi/voicecall: fix handling of waiting calls

From: Pekka Pessi pekka.pe...@nokia.com Also, do not retrieve calls after isi_release_all_active() because retrieving is now only an unwanted side-effect . --- drivers/isimodem/voicecall.c | 114 - 1 files changed, 56 insertions(+), 58 deletions(-) diff

[fix-isi-voicecall PATCHv5 1/4] isi/voicecall: fix status reporting

From: Pekka Pessi pekka.pe...@nokia.com Do not report incoming calls to the oFono core until they can be answered. Report MT_RELEASED or MO_RELEASED via ofono_voicecall_notify(), TERMINATED calls via ofono_voicecall_disconnected(). --- drivers/isimodem/voicecall.c | 387

[fix-isi-voicecall PATCHv5 0/4] Call state fixes

Hi all, Here are the isi voicecall patches again, rebased with the NULL fixes. --Pekka ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] TODO: add blacklisting

From: Pekka Pessi pekka.pe...@nokia.com --- TODO |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index a421a99..558c1d2 100644 --- a/TODO +++ b/TODO @@ -305,6 +305,14 @@ Voicecall Complexity: C2 Owner: Pekka Pessi pekka.pe...@nokia.com

[PATCH] coding-style M14: parenthesis around sizeof arg

From: Pekka Pessi pekka.pe...@nokia.com --- doc/coding-style.txt | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index 9dfdc09..9d7131d 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -230,6

Re: [PATCH] Add voice call boolean property for MO/MT distinction

Hi Marcel, 2010/11/29 Marcel Holtmann mar...@holtmann.org: Only because someone wants to shoehorn this into something nasty, doesn't mean we should do it. I'd say it fits with oFono's overall strategy of following 27.007 whenever possible. And I am not going to scarifies the simplicity of

[PATCHv4] voicecall: fix dial result handling

From: Pekka Pessi pekka.pe...@nokia.com The existing call will be automatically put on hold if there is an existing active call when dialing. On some modems the dial request returns only after the dialed call is active and the existing call has been put on hold. However, on isimodem driver

[isi-voicecall-fix PATCHv4 3/4] isi/voicecall: avoid side-effects of release

From: Pekka Pessi pekka.pe...@nokia.com If a call was held automatically when an another call was dialed or answered, it gets retrieved when the other call is released unless auto change features is explicitly disabled. Drop cause_type parameter because it is never used. Use cause code for busy

[isi-voicecall-fix PATCHv4 1/4] isi/voicecall: fix status reporting

From: Pekka Pessi pekka.pe...@nokia.com Do not report incoming calls to the oFono core until they can be answered. Report MT_RELEASED or MO_RELEASED via ofono_voicecall_notify(), TERMINATED calls via ofono_voicecall_disconnected(). --- drivers/isimodem/voicecall.c | 386

[isi-voicecall-fix PATCHv4 2/4] isi/voicecall: add call id to queued requests

From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/voicecall.c | 89 +++--- 1 files changed, 57 insertions(+), 32 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 84751b0..cc2a829 100644 --- a/drivers

[isi-voicecall-fix PATCHv4 4/4] isi/voicecall: fix handling of waiting calls

From: Pekka Pessi pekka.pe...@nokia.com Also, do not retrieve calls after isi_release_all_active() because retrieving is now only an unwanted side-effect . --- drivers/isimodem/voicecall.c | 114 - 1 files changed, 56 insertions(+), 58 deletions(-) diff

Re: [isi-voicecall-fix PATCHv3 2/6] isi/voicecall: fix status reporting

Hi Denis, +enum clcc_status { +     CLCC_STATUS_ACTIVE = 0, +     CLCC_STATUS_HOLD = 1, +     CLCC_STATUS_DIALING = 2, +     CLCC_STATUS_ALERTING = 3, +     CLCC_STATUS_INCOMING = 4, +     CLCC_STATUS_WAITING = 5, +     CLCC_STATUS_DISCONNECTED = 6, /* Nonstandard */ +}; Please follow

Re: [isi-voicecall-fix PATCHv3 1/6] voicecall: fix dial result handling

Hi Denis, 2010/11/22 Denis Kenzior denk...@gmail.com: If there is an existing active call when dialing the existing call will be automatically put on hold. The dialing result handling depended on the voicecall driver putting the call on hold before the dial command callback is called.

  1   2   3   4   >