[PATCH v5 6/8] plugins/modemconf.c add support for Interface for STE plugin.

--- plugins/modemconf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/plugins/modemconf.c b/plugins/modemconf.c index 3747cd9..d7b1354 100644 --- a/plugins/modemconf.c +++ b/plugins/modemconf.c @@ -138,6 +138,7 @@ static struct { { "g1", set_device }

[PATCH v5 7/8] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification.

--- plugins/ste.c | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 16ddbe1..479d85c 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include @

[PATCH v5 5/8] plugins/ste: Add Radio-Settings

--- drivers/stemodem/radio-settings.c |5 + plugins/ste.c |2 ++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index bcf2704..16ddbe1 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -54,6 +54,7 @@ #include #include

[PATCH v5 4/7] stemodem: Add Radio Settings to STE Modem

--- Changes: o Changed order of files in Makefile o Fixed missing empty line in copyright o Formatted enum better o Removed default is switches o Removed ste in function names Makefile.am |2 + drivers/stemodem/radio-settings.c | 230

[PATCH v5 3/8] plugins/ste: Add AT Channel configurations

--- plugins/ste.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index fcf4d15..bcf2704 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -216,7 +216,8 @@ static int ste_enable(struct ofono_modem *modem) if (getenv("OFONO_AT_DEBUG")

[PATCH v5 2/8] stemodem: Add polling for SIM ready.

Interim solution until support for SIM 'ready' notification is supported. --- Change: AT-channel configuration is moved to separate patch. plugins/ste.c | 52 ++-- 1 files changed, 50 insertions(+), 2 deletions(-) diff --git a/plugins/ste.c b/plu

[PATCH v5 0/8] Resubmitting STE Driver Patches.

Resubmitting same changes as last patch set, but some of the patches are split up in smaller parts. The RTNL patch is removed and replaced by a separate RFC. Sjur Brændeland (8): plugins/ste: SIM - STE registers as MBM to utilize mbm quirks. stemodem: Add polling for SIM ready. plugins/ste:

[PATCH v5 1/8] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

--- Change: This time the right line is hopefully being edited. plugins/ste.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 5b34704..ef375ea 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -213,7 +213,7 @@ static void ste_pre_sim(

[PATCH v4 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification.

From: Sjur Brændeland --- plugins/modem.conf |5 + plugins/modemconf.c |1 + plugins/ste.c | 20 +++- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/plugins/modem.conf b/plugins/modem.conf index 66bf932..b577114 100644 --- a/plugins

[PATCH v4 6/7] stemodem: Use RTNL for creating CAIF interface

From: Sjur Brændeland CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h | 24 +++ 3 files changed, 380

[PATCH v4 5/7] plugins/ste: Add Radio-Settings

From: Sjur Brændeland --- plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index f1535e3..eeaa324 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -54,6 +54,7 @@ #include #include #include +#include #include

[PATCH v4 4/7] stemodem: Add Radio Settings to STE Modem

From: Sjur Brændeland --- Makefile.am |3 +- drivers/stemodem/radio-settings.c | 225 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |2 + 4 files changed, 231 insertions(+), 1 deletions

[PATCH v4 3/7] stemodem: Add polling for SIM ready.

From: Sjur Brændeland Interim solution until support for SIM 'ready' notification is supported. --- Changes: o Fixed style issues (tabs and newlines) plugins/ste.c | 55 --- 1 files changed, 52 insertions(+), 3 deletions(-) di

[PATCH v4 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

From: Sjur Brændeland --- Marcel Holtmann wrote: ... >do we really wanna create another vendor quirk here. If both modems >behave identical then just pass OFONO_VENDOR_MBM in the SIM atom >registration and be done with it. Re-use the MBM quirk rather than adding STE quirks in atmo

[PATCH v4 1/7] plugins/ste: Include STK support from MBM driver.

From: Sjur Brændeland --- Marcel Holtmann wrote: >>> ... The build system builds the plugins >>> properly and you can cross reference modem drivers from your modem >>> plugin without any problems. >> >>Simply refering to MBM driver from ste.c >>

[PATCH v3 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification.

From: Sjur Brændeland --- plugins/modem.conf |5 + plugins/modemconf.c |1 + plugins/ste.c | 20 +++- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/plugins/modem.conf b/plugins/modem.conf index 66bf932..b577114 100644 --- a/plugins

[PATCH v3 5/7] plugins/ste: Add Radio-Settings

From: Sjur Brændeland --- plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 5fecd5e..5a71945 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -55,6 +55,7 @@ #include #include #include +#include #include

[PATCH v3 6/7] stemodem: Use RTNL for creating CAIF interface

From: Sjur Brændeland CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h | 24 +++ 3 files changed, 380

[PATCH v3 4/7] stemodem: Add Radio Settings to STE Modem

From: Sjur Brændeland --- Makefile.am |3 +- drivers/stemodem/radio-settings.c | 225 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |2 + 4 files changed, 231 insertions(+), 1 deletions

[PATCH v3 3/7] stemodem: Add polling for SIM ready.

From: Sjur Brændeland Interim solution until support for SIM 'ready' notification is supported. --- Changes: o Fixed style issues (tabs and newlines) plugins/ste.c | 55 --- 1 files changed, 52 insertions(+), 3 deletions(-) di

[PATCH v3 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

From: Sjur Brændeland --- Marcel Holtmann wrote: ... >do we really wanna create another vendor quirk here. If both modems >behave identical then just pass OFONO_VENDOR_MBM in the SIM atom >registration and be done with it. Re-use the MBM quirk rather than adding STE quirks in atmo

[PATCH v3 1/7] plugins/ste: Include STK support from MBM driver.

From: Sjur Brændeland --- Marcel Holtmann wrote: > ... The build system builds the plugins > properly and you can cross reference modem drivers from your modem > plugin without any problems. Simply refering to MBM driver from ste.c plugins/ste.c |2 ++ 1 files changed, 2 inserti

Re: [PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem

Marcel Holtmann wrote: > Hi Sjur, > >> Changes since last patch set: >> o Moved updates to plugins/ste to separate patch. >> o Updated error handling. >> o Style issues. >> >> >>  Makefile.am                       |    4 +- >>  drivers/stemodem/radio-settings.c |  223 >> +

Re: [PATCHv2 1/7] stemodem: Add support for STK by including MBM implementation.

Marcel Holtmann wrote: > all the magic above is not needed. The build system builds the plugins > properly and you can cross reference modem drivers from your modem > plugin without any problems. Sure, I'll change this. Regards Sjur ___ ofono mailing l

[PATCHv2 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification.

--- plugins/modem.conf |5 + plugins/modemconf.c |1 + plugins/ste.c | 20 +++- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/plugins/modem.conf b/plugins/modem.conf index 66bf932..b577114 100644 --- a/plugins/modem.conf +++ b/plugins/modem.co

[PATCHv2 6/7] stemodem: Use RTNL for creating CAIF interface

CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- Makefile.am |4 +- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h | 24 +++ 4 fi

[PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem

--- Changes since last patch set: o Moved updates to plugins/ste to separate patch. o Updated error handling. o Style issues. Makefile.am |4 +- drivers/stemodem/radio-settings.c | 223 + drivers/stemodem/stemodem.c |2 + d

[PATCHv2 5/7] plugins/ste: Add Radio-Settings

--- plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index e1ca06c..1e3ed9d 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -55,6 +55,7 @@ #include #include #include +#include #include #include @@ -292,6 +293,7 @@

[PATCHv2 3/7] stemodem: Add polling for SIM ready.

Interim solution until support for SIM 'ready' notification is supported. --- Changes: o Fixed style issues (tabs and newlines) plugins/ste.c | 55 --- 1 files changed, 52 insertions(+), 3 deletions(-) diff --git a/plugins/ste.c b/plugins/s

[PATCHv2 2/7] atmodem: Enable STE usage of AT*EPEV and AT*EPEE for PIN handling.

--- drivers/atmodem/sim.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index eb40ad7..8e7c403 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -567,10 +567,12 @@ static void at_pin_send_cb(gboolean o

[PATCHv2 0/7] Resubmitting STE Driver patches.

Resubmitting based on rebase comments from Denis K. Changes: o SIM-ready and Radio-Settings are now split in two parts, one patch for driver and one for plugin. o Use MBM stk driver implementation (avoid copying code). o Updated error handling for Radio Settings. o Various Style issues (n

[PATCHv2 1/7] stemodem: Add support for STK by including MBM implementation.

--- Changes: o Use MBM stk driver implementation (avoid copying code). Note: stemodm.h has to declare the mbm_stk_init/exit functions because importing mbmdriver causes compile errors due to duplicated declarations. drivers/stemodem/stemodem.c |2 ++ drivers/stemodem/st

Re: Terminating emergency calls

Denis Kenzior wrote: > Hi Sjur, > I have to verify this with some of my colleagues, but I am pretty sure emergency calls cannot be applied to the AT+CHLD command. i.e. they cannot be part of mpty. >> >> Initial testing on STE modem indicates that emergency call cannot >> participate

Re: Terminating emergency calls

Zhang, Zhenhua wrote: >> Denis Kenzior wrote: I thought of one more issue with voice calls. I don't think it is safe to to terminate emergency calls using release_specific, AT+CHLD=1X. At least this don't work for STE modems. I suggest calls in state active should b

[PATCH 6/6] stemodem: Use RTNL for creating CAIF interface

CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- Makefile.am |4 +- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 313 +++ drivers/stemodem/rtnl.h | 24 +++ 4 fi

[PATCH 4/6] stemodem: Add SIM/PIN polling and SIM events.

Copied SIM/PIN handling from MBM. o Poll SIM status when initializing o STE modem uses PIN entry quirk for mbm as well --- drivers/atmodem/sim.c |9 +-- plugins/ste.c | 56 ++-- 2 files changed, 59 insertions(+), 6 deletions(-) diff --

[PATCH 5/6] stemodem: Add Radio Settings to STE Modem

--- Makefile.am |3 +- drivers/stemodem/radio-settings.c | 217 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |3 + plugins/ste.c |2 + 5 files changed, 226 insertions(+), 1

[PATCH 3/6] stemodem: Add support for STK.

Copy and rename stk.c from mbmmodem.c Original author: Andrzej Zaborowski --- Makefile.am |3 +- drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |2 + drivers/stemodem/stk.c | 245 +++ plugins/ste.c

[PATCH 2/6] stemodem: Copy if_caif.h from 2.6.36 release candidate.

--- drivers/stemodem/if_caif.h | 48 +-- 1 files changed, 6 insertions(+), 42 deletions(-) diff --git a/drivers/stemodem/if_caif.h b/drivers/stemodem/if_caif.h index ad3686b..5e7eed4 100644 --- a/drivers/stemodem/if_caif.h +++ b/drivers/stemodem/if_caif.h

[PATCH 1/6] bugfix: distcheck fail due to rename of dataconnectionmanager-api.txt

--- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 83aa8f3..2f0b745 100644 --- a/Makefile.am +++ b/Makefile.am @@ -301,7 +301,7 @@ doc_files = doc/overview.txt doc/ofono-paper.txt \ doc/call-forwarding-a

Re: Terminating emergency calls

Denis Kenzior wrote: >> I thought of one more issue with voice calls. >> I don't think it is safe to to terminate emergency calls using >> release_specific, AT+CHLD=1X. >> At least this don't work for STE modems. >> >> I suggest calls in state active should be terminated using hangup_all >> or han

Terminating emergency calls

Hi Denis. I thought of one more issue with voice calls. I don't think it is safe to to terminate emergency calls using release_specific, AT+CHLD=1X. At least this don't work for STE modems. I suggest calls in state active should be terminated using hangup_all or hangup_active. What do you think?

[PATCH 3/3] stedriver: Copy if_caif.h from 2.6.36 release candidate.

From: Sjur Brændeland --- drivers/stemodem/if_caif.h | 48 +-- 1 files changed, 6 insertions(+), 42 deletions(-) diff --git a/drivers/stemodem/if_caif.h b/drivers/stemodem/if_caif.h index ad3686b..5e7eed4 100644 --- a/drivers/stemodem/if_caif.h +++ b

[PATCH 2/3] stedriver: Copy caif_socket.h from 2.6.36 release candidate.

From: Sjur Brændeland Copied include/linux/caif/caif_socket.h and added AF_CAIF, PF_CAIF and SOL_CAIF definitions found in linux/include/socket.h. --- drivers/stemodem/caif_socket.h | 207 1 files changed, 123 insertions(+), 84 deletions(-) diff --git

[PATCH 1/3] stedriver: remove unsupported CAIF socket IOCTLs.

From: Sjur Brændeland --- drivers/stemodem/gprs-context.c | 48 +- 1 files changed, 2 insertions(+), 46 deletions(-) diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index 2e54f9f..29ee446 100644 --- a/drivers/stemodem/gprs

[PATCH resend 3/3] voicecall: manager_hangup_all should not terminate waiting calls.

From: Sjur Brændeland --- src/voicecall.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 49b9c79..4341d29 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -758,15 +758,21 @@ static void

[PATCH resend 2/3] voicecall: Add support for function hangup_all

From: Sjur Brændeland This patch fixes problem for modems that cannot terminate DIALING/ALERTING calls with CHUP=1X. The main change is that voicecall-callback function hangup is split into the functions hangup_all and hangup_active. Changes: o In cases where hangup previously was used

[PATCH resend 1/3] voicecall: Rename cb-function hangup to hangup_active in core and drivers.

From: Sjur Brændeland --- drivers/atmodem/voicecall.c |4 ++-- drivers/calypsomodem/voicecall.c |2 +- drivers/hfpmodem/voicecall.c |2 +- drivers/isimodem/voicecall.c |2 +- drivers/stemodem/voicecall.c |2 +- include/voicecall.h |2 +- 6

[PATCH 3/3] voicecall: manager_hangup_all should not terminate waiting calls.

From: Sjur Brændeland --- src/voicecall.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 49b9c79..4341d29 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -758,15 +758,21 @@ static void

[PATCH 2/3] voicecall: Add support for function hangup_all

From: Sjur Brændeland This patch fixes problem for modems that cannot terminate DIALING/ALERTING calls with CHUP=1X. The main change is that voicecall-callback function hangup is split into the functions hangup_all and hangup_active. Changes: o In cases where hangup previously was used

[PATCH 1/3] voicecall: Rename cb-function hangup to hangup_active in core and drivers.

From: Sjur Brændeland --- drivers/atmodem/voicecall.c |4 ++-- drivers/calypsomodem/voicecall.c |2 +- drivers/hfpmodem/voicecall.c |2 +- drivers/isimodem/voicecall.c |2 +- drivers/stemodem/voicecall.c |2 +- include/voicecall.h |2 +- 6

Re: [RFCv2] STE-driver: Terminating voice call in state DIALING/ALERTING.

Hi Denis. ... >> +static void at_hangup_active(struct ofono_voicecall *vc, >> +                     ofono_voicecall_cb_t cb, void *data) >> +{ >> +     /* Hangup  currently active call */ > > It might be safer to only implement hangup_active in the generic driver. >  However, since this driver is o

[RFCv2] STE-driver: Terminating voice call in state DIALING/ALERTING.

From: Sjur Brændeland This patch fixes problem with terminating calls in state DIALING/ALERTING for STE-modem. The main change is that voicecall-callback function hangup is split into the functions hangup_all and hangup_active. CHANGES: include/voicecall.h: o hangup is replaced with

Re: [RFC] STE-driver: Terminating voice call in state DIALING/ALERTING.

Hi Denis, Denis Kenzior wrote: >> I'm picking up a really old thread here... >Yes a really old thread ;) Better late than never, right? :-) ... >> However, I think we can solve this even simpler if we just >> call hangup for any ALERTING/DIALING call.. >This is a real gray area. On some devices

[RFC] STE-driver: Terminating voice call in state DIALING/ALERTING.

From: Sjur Brændeland This patch splits the callback hangup into hangup_all and hangup_active. --- Hi Denis, I'm picking up a really old thread here... > Denis Kenzior wrote: >>>> c) If you have an call on hold and initiate a new call, but want to >>>> te

RE: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Denis. We have done some testing with the STE modem for call termination, and this is the result: TC |Call #1 | Call #2 | Call #3 | Command | Result ---| 1 |ACTIVE | ACTIVE | .. | ATH | call 1, 2 terminate

RE: [PATCH 2/2] Fix: Check if interface exists before creating it.

Hi Marcel. Marcel Holtmann wrote: > Hi Sjur, > >> diff --git a/drivers/stemodem/gprs-context.c >> b/drivers/stemodem/gprs-context.c index c178fb6..79e697b 100644 >> --- a/drivers/stemodem/gprs-context.c >> +++ b/drivers/stemodem/gprs-context.c >> @@ -187,9 +187,11 @@ static gboolean caif_if_creat

RE: [PATCH 1/2] Fix: Username and Password must be set after context is created.

Hi Marcel. Marcel Holtmann wrote: >> len = sprintf(buf, "AT+CGDCONT=%u,\"IP\"", ctx->cid); >> >> if (ctx->apn) >> snprintf(buf + len, sizeof(buf) - len - 3, ",\"%s\"", >> ctx->apn); >> >> +/* Set username and password. Must be done after context creation */ >> +

FW: FW: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Denis. We have done some testing with the STE modem for call termination, and this is the result: TC |Call #1 | Call #2 | Call #3 | Command | Result ---| 1 |ACTIVE | ACTIVE | .. | ATH | call 1, 2 termin

Re: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Denis. Sorry if you get this mail twice, something went wrong when posting this last time so I'm resending it. We have done some testing with the STE modem for call termination, and this is the result: TC |Call #1 | Call #2 | Call #3 | Command | Result ---|---

RE: FW: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Denis: Denis Kenzior wrote: > Hi Sjur, > >>> All of this logic needs to go away. The core already handles all of >>> this, including selection of ATH/CHLD, waiting/held. Please review >>> src/voicecall.c. If the core logic is not sufficient or does not >>> properly handle a certain case, then

FW: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Denis. Denis Kenzior wrote: >> +static void ste_release_specific(struct ofono_voicecall *vc, int id, >> +ofono_voicecall_cb_t cb, void *data) { >> +struct voicecall_data *vd = ofono_voicecall_get_data(vc); >> +struct release_id_req *req = g_try_new0(struct r

RE: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Marcel. Thank you for lots of feedback on patches. Marit who has done most of the implementation is gone for a few days so we'll have to wait until end of next week with the next oFono patch-set. Marcel Holtmann wrote: + /* Need to change to gsm_permissive syntax in order to + *

RE: [RFC 3/3] STE-plugin: Adding STE plugin

ing polling with CLCC, but are using our proprietary call events. This impacts most functions. The functions reusable from "atmodem" are "remove", "swap_without_accept", and "send_tones". I guess we could copy the three common functions from "atmodem" into "stemodem" voicecall.c if you prefer this. For Network Registration we have almost identical implementation, the difference is that for signal strength reporting we are using "AT+CIND" instead of "CSQ" and "CIEV". "CSQ" is not working for WCDMA in our case. I see that in the initialization function there is a switch on vendor. I guess we could go for this approach if you think this is better. > >> +/* Create a CAIF socket for AT Service */ >> +fd = socket(AF_CAIF, SOCK_SEQPACKET, CAIFPROTO_AT); + >> +/* Connect to the AT Service at the modem */ >> +connect(fd, (struct sockaddr *) &addr, sizeof(addr)); >> +channel = g_io_channel_unix_new(fd); > > You need to check the results of socket() and connect() calls. Sure, will fix this. Regards Sjur Brændeland ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

<    1   2