[PATCH 1/9] Add parser for network measurement results objects

--- src/stkutil.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 437dcdb..9a02658 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -619,6 +619,30 @@ static gboolean parse_dataobj_help_request(struct

[PATCH 2/9] Add parser for items next action indicator objects

--- src/stkutil.c | 38 ++ src/stkutil.h |5 + 2 files changed, 43 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 9a02658..b997752 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -67,6 +67,34 @@ static gboolean

[PATCH 3/9] Add parser for event list objects

--- src/stkutil.c | 10 ++ src/stkutil.h | 24 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index b997752..ecd5639 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -679,6 +679,14 @@ static gboolean

[PATCH 4/9] Add parser for cause objects

--- src/stkutil.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ecd5639..8f4ff39 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -687,6 +687,39 @@ static gboolean parse_dataobj_event_list(

[PATCH 5/9] Add parser for location status objects

--- src/stkutil.c | 30 ++ src/stkutil.h |6 ++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 8f4ff39..3aae6bf 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -67,6 +67,26 @@ static gboolean

[PATCH 6/9] Add parser for transaction identifier objects

--- src/stkutil.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 3aae6bf..d573430 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -748,6 +748,14 @@ static gboolean parse_dataobj_location_status(

[PATCH 7/9] Add parser for call control requested action objects

--- src/stkutil.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index d573430..6619bc3 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -756,6 +756,14 @@ static gboolean parse_dataobj_transaction_id(

[PATCH 8/9] Add the macro for icon qualifier

--- src/stkutil.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index b85592c..08a5355 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -296,6 +296,11 @@ enum stk_service_state { STK_NO_SERVICE =0x02 }; +enum

[PATCH 9/9] Add parser for item icon identifier list objects

--- src/stkutil.c | 31 +++ src/stkutil.h |7 +++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 6619bc3..71899b9 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -786,6 +786,35 @@ static gboolean

[PATCH 0/1] Patch Description

is about the existed code. There is a hashtable messages in struct ofono_sms. Can we store the state in the tx_queue_entry, and remove the hashtable thoroughly to make the code more simple? Yang Gu (1): sms: Cancel pending message include/history.h |1 + src/sms.c | 132

[PATCH 1/1] sms: Cancel pending message

--- include/history.h |1 + src/sms.c | 132 ++--- 2 files changed, 106 insertions(+), 27 deletions(-) diff --git a/include/history.h b/include/history.h index c1c4aa1..756097e 100644 --- a/include/history.h +++ b/include/history.h @@

[PATCH] test-stkutil: Modify the check logic of time zone

--- unit/test-stkutil.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 868d54b..666f4eb 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -245,7 +245,11 @@ static void check_gsm_sms(const struct sms

[PATCH] Simulate provide local info command in sim app

--- src/simapplication.cpp | 68 src/simapplication.h |2 + 2 files changed, 70 insertions(+), 0 deletions(-) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index 62bbe9d..388b2ce 100644 --- a/src/simapplication.cpp +++

[PATCH] Simulate provide local info command in sim app

--- src/simapplication.cpp | 68 src/simapplication.h |2 + 2 files changed, 70 insertions(+), 0 deletions(-) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index 05ae21f..bc96a8c 100644 --- a/src/simapplication.cpp +++

[PATCH 1/3] smsutil: Change the range of time zone

--- src/smsutil.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index b06e9bf..644e3e0 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -51,6 +51,13 @@ #define SMS_ADDR_FMT %24[0-9A-F] #define SMS_MSGID_FMT %40[0-9A-F] +/* +

[PATCH 2/3] Make timezone an optional field

--- src/smsutil.c | 11 ++- src/smsutil.h |1 + src/stkutil.c | 13 ++--- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 644e3e0..20af30a 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -346,7 +346,8 @@ gboolean

[PATCH 3/3] stk: Handle provide local info proactive command

--- src/stk.c | 77 + 1 files changed, 77 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index a4abb7d..08353f2 100644 --- a/src/stk.c +++ b/src/stk.c @@ -26,6 +26,7 @@ #define _GNU_SOURCE #include string.h

[PATCH v2 3/3] stk: Handle provide local info proactive command

--- src/stk.c | 85 + 1 files changed, 85 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index a4abb7d..53eca78 100644 --- a/src/stk.c +++ b/src/stk.c @@ -26,6 +26,7 @@ #define _GNU_SOURCE #include string.h

[PATCH 3/3] test-stk: Add provide local info

--- test/test-stk-menu | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/test/test-stk-menu b/test/test-stk-menu index 916a527..db3f8b7 100755 --- a/test/test-stk-menu +++ b/test/test-stk-menu @@ -134,6 +134,42 @@ class

[PATCH 0/3] Patch Description

- 1900; Yang Gu (3): network: Use bit as size instead of byte stk: Handle provide local info proactive command test-stk: Add provide local info src/network.c |4 +- src/smsutil.c |6 +- src/stk.c | 113 ++ src/stkagent.c

[PATCH 1/3] network: Use bit as size instead of byte

--- src/network.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network.c b/src/network.c index d203bee..83014bb 100644 --- a/src/network.c +++ b/src/network.c @@ -129,7 +129,7 @@ static char **network_operator_technologies(struct network_operator_data *opd)

[PATCH] Simulate provide local info command

--- src/simapplication.cpp | 263 src/simapplication.h |2 + 2 files changed, 265 insertions(+), 0 deletions(-) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index 7dc580f..901c5b9 100644 --- a/src/simapplication.cpp +++

[PATCH 2/2] network: Use bit as size instead of byte

--- src/network.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network.c b/src/network.c index 481ece8..5320f8d 100644 --- a/src/network.c +++ b/src/network.c @@ -129,7 +129,7 @@ static char **network_operator_technologies(struct network_operator_data *opd)

[PATCH] TODO: Add owner of provide local info task

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 0d04208..a5196f7 100644 --- a/TODO +++ b/TODO @@ -362,6 +362,7 @@ Sim Toolkit Priority: High Complexity: C2 + Owner: Yang Gu yang...@intel.com Emergency Calls -- 1.7.2.3

[PATCH 0/1] Patch Description

Sometimes we need to know the version of phonesim via a command. This patch is to add this support. By the way, oFono introduces a file named version.h.in for the macro OFONO_VERSION. Can we use VERSION directly so that this file can be removed? Yang Gu (1): Add option to support version

[PATCH 1/1] Add option to support version

--- Makefile.am |2 +- bootstrap|2 +- configure.ac |1 + src/main.cpp | 11 +-- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index f124b08..dd54c42 100644 --- a/Makefile.am +++ b/Makefile.am @@ -50,7 +50,7 @@

[PATCH v2] Add option to support version

--- src/main.cpp |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index d7de416..d601ac2 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -28,7 +28,7 @@ static void usage() { qWarning() Usage:

[PATCH 2/2] coding_style: Add case for enum as switch variable

--- doc/coding-style.txt | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index 9e5a811..6fa355e 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -173,6 +173,38 @@ enum animal_type {

[PATCH 1/2] coding_style: Fix enum name

--- doc/coding-style.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index 95ed50b..9e5a811 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -167,7 +167,7 @@ enum animal_type { If the enum contents have

[PATCH] TODO: update owner of see/cancel pending SMS task

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index a01960e..5968c08 100644 --- a/TODO +++ b/TODO @@ -70,6 +70,7 @@ SMS Priority: High Complexity: C2 + Owner: Yang Gu yang...@intel.com - Persist outgoing SMS messages. Currently oFono

[PATCH v3 4/4] cf: Handle send ss proactive command

--- src/call-forwarding.c | 262 +--- src/ofono.h | 28 + src/stk.c | 130 src/ussd.c| 145 +++ 4 files changed, 548 insertions(+), 17 deletions(-) diff --git

[PATCH v3 1/4] Add macro for general result and additional info

--- src/stkutil.h | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index 2d98185..5c75524 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -254,6 +254,8 @@ enum stk_result_type {

[PATCH v3 2/4] stk: Support send ss response

--- src/stkutil.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 82da079..cdd66bd 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -5455,6 +5455,8 @@ const unsigned char *stk_pdu_from_response(const struct stk_response *response,

[PATCH v3 3/4] ss: Use errno for ssc handling functions

--- src/call-barring.c| 63 ++-- src/call-forwarding.c | 63 +--- src/call-settings.c | 34 -- src/ussd.c| 55 -- 4

[PATCH 2/2] doc: Describe the scriptable feature

--- doc/scriptable.txt | 55 1 files changed, 55 insertions(+), 0 deletions(-) create mode 100644 doc/scriptable.txt diff --git a/doc/scriptable.txt b/doc/scriptable.txt new file mode 100644 index 000..670bd21 --- /dev/null +++

[PATCH v2 2/3] Some instances in ControlWidget need to be deleted

--- src/control.cpp |6 ++ src/control.h |1 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index 458ee43..9e2c1f0 100644 --- a/src/control.cpp +++ b/src/control.cpp @@ -89,6 +89,12 @@ void ControlWidget::closeEvent(QCloseEvent

[PATCH v2 0/3] Patch Description

=org.phonesim/ allow send_destination=org.phonesim/ /policy policy at_console=true allow send_destination=org.phonesim/ /policy policy context=default deny send_destination=org.phonesim/ /policy /busconfig Comments are welcome! Yang Gu (3): Move def of class

[PATCH v2 1/3] Move def of class ControlWidget to header file

Currently any modification on control.cpp will result in some unrelated obj to be regenerated, because the definition of class ControlWidget is in this .cpp file. This patch wants to fix this problem. --- Makefile.am |5 +--- src/control.cpp | 69

[PATCH v2 3/3] Enable Qt Script

This patch is to enable Qt script so that GUI can be controlled using JavaScript. In the meantime, D-Bus support is added for the sake of test automation. --- configure.ac|2 +- src/control.cpp | 90 +++ src/control.h | 35

[PATCH 1/1] Enable Qt Script

From: Yang Gu yang...@intel.com --- configure.ac|2 +- src/control.cpp | 60 +++ 2 files changed, 61 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 4d10494..d5d674e 100644 --- a/configure.ac +++ b

[PATCH 0/1] Patch Description

into the specific directory, oFono will get an incoming message. Don't know if this is the best way to make Phonesim support test automation. So comments are welcome:) - Yang Gu (1): Enable Qt Script configure.ac|2 +- src/control.cpp | 60

[PATCH 1/5] Add macro for general result and additional info

--- src/stkutil.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index 36b18f0..645daf8 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -254,6 +254,8 @@ enum stk_result_type {

[PATCH 0/5] Patch Description

This series of patches are to handle send ss proactive command by splitting the path of D-Bus and stk request. In this version, only call-forwarding is handled, but others (call-barring, call-settings) would be quite similar. Comments are welcome! -- Yang Gu (5): Add macro for general

[PATCH 2/5] stk: Support send ss response

--- src/stkutil.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index cdd6b4e..d35094b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -5449,6 +5449,8 @@ const unsigned char *stk_pdu_from_response(const struct stk_response *response,

[PATCH 4/5] ss: Use errno for ssc handling functions

--- src/call-barring.c| 63 ++-- src/call-forwarding.c | 63 +--- src/call-settings.c | 34 -- src/ussd.c| 56 -- 4

[PATCH] Enable some atoms for hso modem

--- plugins/hso.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/plugins/hso.c b/plugins/hso.c index 25ca157..bfc5c47 100644 --- a/plugins/hso.c +++ b/plugins/hso.c @@ -36,6 +36,7 @@ #include ofono/modem.h #include ofono/devinfo.h #include ofono/netreg.h

[PATCH 0/1] Patch Description

I just got a new Option modem (iCON 452), and this patch is to enable several atoms for it. The stk support is still not avaiable, for I couldn't find any appropriate manual for this part. If you happen to know this, please kindly share the info. Yang Gu (1): Enable some atoms for hso modem

[PATCH 1/1] Enable some atoms for hso modem

--- plugins/hso.c | 34 -- 1 files changed, 32 insertions(+), 2 deletions(-) diff --git a/plugins/hso.c b/plugins/hso.c index 25ca157..1fbde58 100644 --- a/plugins/hso.c +++ b/plugins/hso.c @@ -34,14 +34,23 @@ #define OFONO_API_SUBJECT_TO_CHANGE #include

[PATCH] stk: Handle send ss proactive command

--- src/call-barring.c| 168 ++--- src/call-forwarding.c | 155 +- src/call-settings.c | 220 +++-- src/ofono.h | 15 +++- src/stk.c | 98

Currently when sending a supplementary service control string via D-Bus, a

From Yang Gu yang...@intel.com # This line is ignored. From: Yang Gu yang...@intel.com Subject: In-Reply-To: ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH v2 1/1] Simulate send ss command in sim app

--- src/simapplication.cpp | 672 src/simapplication.h | 16 ++ 2 files changed, 688 insertions(+), 0 deletions(-) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index 6ca03d9..4af510b 100644 --- a/src/simapplication.cpp +++

[PATCH] Simulate send ss command in sim app

--- src/simapplication.cpp | 700 src/simapplication.h | 16 ++ 2 files changed, 716 insertions(+), 0 deletions(-) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index 6ca03d9..dad9635 100644 --- a/src/simapplication.cpp +++

[PATCH] Check if ussd is busy when doing ss

It's still not clear how ss and ussd interfere with each other. Current decision is each ss (call-barring, call-forwarding, etc.) has interference with ussd, but there is no interference within these ss. That is, call-barring has interference with ussd, but call-barring has no interference with

[PATCH v3 1/1] sim: Read EFsst

--- src/sim.c | 40 +-- src/simutil.c | 18 src/simutil.h | 63 + 3 files changed, 118 insertions(+), 3 deletions(-) diff --git a/src/sim.c b/src/sim.c index fd9b412..ff559a9 100644

[PATCH] sim: Ensure to call sim_pin_check

In current code, sim_pin_check() is called inside sim_efpl_read_cb(). However, there may be a chance it would never be called, thus the modem won't be initialized correctly. --- src/sim.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sim.c b/src/sim.c index

[PATCH] sim: Read EFsst

--- src/sim.c | 31 +++- src/simutil.c | 18 src/simutil.h | 63 + 3 files changed, 111 insertions(+), 1 deletions(-) diff --git a/src/sim.c b/src/sim.c index 9bc9906..1491edd 100644 ---

[PATCH 2/2] sim: Read EFust and EFest

--- src/sim.c | 75 +++- src/simutil.c | 18 ++ src/simutil.h | 105 + 3 files changed, 196 insertions(+), 2 deletions(-) diff --git a/src/sim.c b/src/sim.c index d2ed780..235f457 100644

[PATCH 1/2] Make function reset_available() return void

This change is to dispel compiler's complaint. --- src/network.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index f5b9a5e..190eba9 100644 --- a/src/network.c +++ b/src/network.c @@ -1175,7 +1175,7 @@ static void

[PATCH 1/4] Add coding style document

--- doc/coding_style.txt | 151 ++ 1 files changed, 151 insertions(+), 0 deletions(-) create mode 100644 doc/coding_style.txt diff --git a/doc/coding_style.txt b/doc/coding_style.txt new file mode 100644 index 000..f6c58f2 --- /dev/null +++

[PATCH 3/4] Add git commit header and description check

--- test/checkpatch.pl | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/test/checkpatch.pl b/test/checkpatch.pl index 2d5ece7..767670d 100755 --- a/test/checkpatch.pl +++ b/test/checkpatch.pl @@ -1260,6 +1260,24 @@ sub process {

[PATCH 4/4] Dont check Signed-off-by by default

--- test/checkpatch.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/checkpatch.pl b/test/checkpatch.pl index 767670d..2a4faa0 100755 --- a/test/checkpatch.pl +++ b/test/checkpatch.pl @@ -16,7 +16,7 @@ use Getopt::Long qw(:config no_auto_abbrev); my $quiet = 0;

[PATCH 1/3] Make fetch command function as external

--- Makefile.am|1 + drivers/atmodem/sim-poll.c | 55 +-- drivers/atmodem/stk.c | 51 drivers/atmodem/stk.h | 22 + 4 files changed, 76 insertions(+), 53

[PATCH 3/3] Use specific vendor for phonesim stk

--- plugins/phonesim.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index d0cd7f3..9c5b2cb 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -289,7 +289,7 @@ static void phonesim_pre_sim(struct ofono_modem *modem)

[PATCH 1/3] Make fetch command function as external

--- Makefile.am|1 + drivers/atmodem/sim-poll.c | 56 ++- drivers/atmodem/stk.c | 53 + drivers/atmodem/stk.h | 22 + 4 files changed, 79 insertions(+), 53

[PATCH 3/3] Interpret Alpha Id as empty data object

There needs to be a way to distinguish between no alphaid and empty data object because on some occasions they have different meanings. In the Call Control envelope, no Alpha Identifier means the terminal can inform the user about the call being modified by SIM while empty data object means no

[PATCH] Add init phonesim stk support

--- Makefile.am | 28 ++-- drivers/phonesimmodem/phonesimmodem.c | 48 + drivers/phonesimmodem/phonesimmodem.h | 26 +++ drivers/phonesimmodem/stk.c | 316 + plugins/phonesim.c|2 +- 5 files

[PATCH 1/2] Support option --disable-optimization

--- configure.ac |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 887c91a..a85fda3 100644 --- a/configure.ac +++ b/configure.ac @@ -14,6 +14,13 @@ PKG_PROG_PKG_CONFIG AC_PROG_CXX AC_PROG_INSTALL +AC_ARG_ENABLE(optimization,

[PATCH 2/2] Change sw2 only when cmd is not empty

--- src/phonesim.cpp |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/phonesim.cpp b/src/phonesim.cpp index d5d7d87..8210f51 100644 --- a/src/phonesim.cpp +++ b/src/phonesim.cpp @@ -923,9 +923,10 @@ bool SimRules::simCsimOk( const QByteArray payload ) if (

[PATCH 1/5] stk: Add parser for send ussd commands

--- src/stkutil.c | 61 + src/stkutil.h |9 2 files changed, 70 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 44a8eff..f03b25c 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -585,6 +585,24

[PATCH 2/5] teststk: Add test for send ussd parser

--- src/smsutil.c | 44 ++ src/smsutil.h |2 + unit/test-stkutil.c | 1319 +++ 3 files changed, 1365 insertions(+), 0 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 95eca06..5fa4be5 100644 --- a/src/smsutil.c +++

[PATCH 3/5] Modify ussd parser

* Original code doesn't call unpack_7bit(), which seems not correct. * An utility function is used to handle it, which supports 8-bit and ucs2 besides 7-bit character. * Status is assigned with correct value when error occurs --- drivers/atmodem/ussd.c | 32 +--- 1

[PATCH 4/5] Refactor ussd parser

--- drivers/isimodem/ussd.c | 35 ++- 1 files changed, 6 insertions(+), 29 deletions(-) diff --git a/drivers/isimodem/ussd.c b/drivers/isimodem/ussd.c index 8be20b6..7002d09 100644 --- a/drivers/isimodem/ussd.c +++ b/drivers/isimodem/ussd.c @@ -73,44 +73,21 @@

[PATCH 03/12] stk: Add parser for send ussd commands

--- Makefile.am|5 ++- src/stkutil.c | 66 src/stkutil.h |9 ++ src/ussdutil.c | 83 src/ussdutil.h | 22 +++ 5 files changed, 183 insertions(+), 2

[PATCH 05/12] Modify ussd parser

* Original code doesn't call unpack_7bit(), which seems not correct. * An utility function is used to handle it, which supports 8-bit and ucs2 besides 7-bit character. * Status is assigned with correct value when error occurs --- drivers/atmodem/ussd.c | 33 ++--- 1

[PATCH 10/12] stk: Add parser for timing advance objects

--- src/stkutil.c | 22 ++ src/stkutil.h | 28 ++-- unit/test-stkutil.c |2 +- 3 files changed, 41 insertions(+), 11 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 1631610..35d9be6 100644 --- a/src/stkutil.c +++

[PATCH 07/12] Add several proactive command parsers

--- src/stkutil.c | 473 + src/stkutil.h | 93 +++ 2 files changed, 566 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index d2c8522..268d686 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3107,6

[PATCH 11/12] stk: Add parser for PDP activation param objects

--- src/stkutil.c | 23 +++ src/stkutil.h |6 ++ 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 35d9be6..696e2e0 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -1623,6 +1623,27 @@ static gboolean

[PATCH 1/2] stk: Constraint the appearance of empty item

If empty item turns out, it must be the only item in the list. So the following situations are deemed as invalid: 1. Two empty items 2. Valid item + empty item 3. empty + valid item --- src/stkutil.c | 40 1 files changed, 28 insertions(+), 12

[PATCH 2/2] stktest: Add negative cases for setup menu

--- unit/test-stkutil.c | 64 +++ 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 7793f3a..b4a5618 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -4893,6 +4893,31 @@

[PATCH 1/8] stk: Make parse_dataobj not consume extra data

--- src/stkutil.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 016bde9..fd5b7c6 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2023,6 +2023,7 @@ static gboolean parse_dataobj(struct comprehension_tlv_iter *iter,

[PATCH 2/8] stk: Add parser for launch browser commands

--- src/stkutil.c | 103 + src/stkutil.h | 16 + 2 files changed, 119 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index fd5b7c6..12af7fc 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2865,6

[PATCH 3/8] teststk: Add check of len in byte array

--- unit/test-stkutil.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 173ab2d..e01cb17 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -82,6 +82,7 @@ static inline void check_common_byte_array( }

[PATCH 5/8] stk: Fix the parser of send sms

--- src/stkutil.c | 52 +++- 1 files changed, 43 insertions(+), 9 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 12af7fc..3adb9e3 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -61,11 +61,15 @@ typedef gboolean

[PATCH 6/8] teststk: Add cases for send sms parser

--- src/smsutil.c |3 + unit/test-stkutil.c | 1767 ++- 2 files changed, 1748 insertions(+), 22 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 6f8e9c5..29bd881 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -1276,6

[PATCH 7/8] teststk: Add test for launch browser parser

--- unit/test-stkutil.c | 790 +++ 1 files changed, 790 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 77e05c4..2637ec0 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -397,6 +397,49 @@

[PATCH 2/8] test-stk: Add test for setup idle mode text parser

--- unit/test-stkutil.c | 793 +++ 1 files changed, 793 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 0daf7f9..7b75e1a 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -,6 +,724 @@

[PATCH 1/8] stk: Add parser for setup idle mode text commands

--- src/stkutil.c | 40 src/stkutil.h |8 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index e053e2c..3b1e957 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2710,6 +2710,43 @@ static

[PATCH 4/8] test-stk: Add test for run at command parser

--- unit/test-stkutil.c | 834 +++ 1 files changed, 834 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 7b75e1a..1195d6d 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -286,6 +286,12 @@

[PATCH 5/8] stk: Add parser for send dtmf commands

--- src/stkutil.c | 42 ++ src/stkutil.h |9 + 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 9b08e8a..c0242cd 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2786,6 +2786,45 @@ static

[PATCH 6/8] test-stk: Add test for send dtmf parser

--- unit/test-stkutil.c | 742 +++ 1 files changed, 742 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 1195d6d..b236e59 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -299,6 +299,12 @@

[PATCH 3/8] stk: Add parser for run at command commands

--- src/stkutil.c | 42 ++ src/stkutil.h |9 + 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 3b1e957..9b08e8a 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2747,6 +2747,45 @@ static

[PATCH 8/8] teststk: Add test for language notification parser

--- unit/test-stkutil.c | 61 +++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index b236e59..97f3c47 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -305,6 +305,12 @@

[PATCH 02/27] test-stkutil: Add test for poll interval parser

--- unit/test-stkutil.c | 46 ++ 1 files changed, 46 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 1b24df3..4cce0f5 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -3883,6 +3883,49 @@ static

[PATCH 07/27] test-stkutil: Use dedicated functions to check

--- unit/test-stkutil.c | 50 +- 1 files changed, 41 insertions(+), 9 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 2fa449d..8ec380f 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -71,6 +71,12 @@ static

[PATCH 06/27] test-stkutil: Add test for select item parser

--- unit/test-stkutil.c | 2035 +++ 1 files changed, 2035 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index dc33183..2fa449d 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -87,6 +87,13 @@

[PATCH 08/27] test-stkutil: Refactor test for send sms parser

--- unit/test-stkutil.c | 132 -- 1 files changed, 84 insertions(+), 48 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 8ec380f..82df2e3 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -71,6 +71,27 @@ static

[PATCH 04/27] test-stkutil: Add test for setup menu parser

--- unit/test-stkutil.c | 1616 +++ 1 files changed, 1616 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 4cce0f5..dc33183 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -35,6 +35,8 @@

[PATCH 05/27] stkutil: Add select item proactive command parser

--- src/stkutil.c | 67 + src/stkutil.h | 13 +++ 2 files changed, 80 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 1698321..1b2297d 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2382,6

[PATCH 09/27] stk: Adjust the sequence of dataobj

--- src/stkutil.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index d017dc9..0c9fd50 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -872,10 +872,10 @@ struct stk_command { struct stk_command_get_inkey get_inkey;

[PATCH 14/27] stkutil: Add polling off proactive command parser

--- src/stkutil.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 2227d31..3aaab37 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2594,6 +2594,18 @@ static gboolean parse_refresh(struct stk_command *command,

  1   2   3   >