Re: [PATCH] Fix: simplify isimodem call-barring driver.

2010-03-29 Thread Denis Kenzior
Hi Pekka, > From: Pekka Pessi > > Add support for lock codes AG and AC (MMI codes 333 and 353, > respectively). Use decimal MMI codes in . > --- > drivers/isimodem/call-barring.c | 153 > --- drivers/isimodem/ss.h | > 142 ++--

Re: [PATCH] Fix: simplify isimodem call-barring driver.

2010-03-29 Thread Pekka Pessi
2010/3/23 Denis Kenzior : >> Add support for lock codes AG and AC (MMI codes 333 and 353. respectively). > > First of all, please keep your commit messages less than 72 characters long > and headings less than 50 characters long. Is there any git setting or nice filter which could complain automat

[PATCH] Fix: simplify isimodem call-barring driver.

2010-03-29 Thread ppessi
From: Pekka Pessi Add support for lock codes AG and AC (MMI codes 333 and 353, respectively). Use decimal MMI codes in . --- drivers/isimodem/call-barring.c | 153 --- drivers/isimodem/ss.h | 142 ++-- 2 files change

[PATCH] Fix: simplify isimodem call-barring driver.

2010-03-29 Thread ppessi
From: Pekka Pessi Add support for lock codes AG and AC (MMI codes 333 and 353. respectively). Use decimal MMI codes in . --- drivers/isimodem/call-barring.c | 153 --- drivers/isimodem/ss.h | 142 ++-- 2 files change

Re: [PATCH] Fix: simplify isimodem call-barring driver.

2010-03-24 Thread Aki Niemi
ti, 2010-03-23 kello 22:53 +0100, ext Denis Kenzior kirjoitti: > Secondly, please keep your patches whitespace clean, there are several cases > of spaces being used instead of tabs for indentation. Pekka is an emacs guy, and emacs likes syntactic indentation a lot. I'm using this custom mode with

Re: [PATCH] Fix: simplify isimodem call-barring driver.

2010-03-23 Thread Denis Kenzior
Hi Pekka, > From: Pekka Pessi > > Add support for lock codes AG and AC (MMI codes 333 and 353. respectively). First of all, please keep your commit messages less than 72 characters long and headings less than 50 characters long. Secondly, please keep your patches whitespace clean, there are s

[PATCH] Fix: simplify isimodem call-barring driver.

2010-03-23 Thread ppessi
From: Pekka Pessi Add support for lock codes AG and AC (MMI codes 333 and 353. respectively). --- drivers/isimodem/call-barring.c | 153 --- drivers/isimodem/ss.h | 28 2 files changed, 63 insertions(+), 118 deletions(-) diff --git a/dri