Re: [PATCH 1/3] sim800: add sim800 support

2018-11-14 Thread Denis Kenzior
Hi Clement, On 11/13/2018 11:19 AM, Clement Viel wrote: --- plugins/sim900.c | 77 ++-- 1 file changed, 69 insertions(+), 8 deletions(-) Patch has been applied, thanks. I did fix up a bunch of style issues though. Regards, -Denis

[PATCH 1/3] sim800: add sim800 support

2018-11-13 Thread Clement Viel
--- plugins/sim900.c | 77 ++-- 1 file changed, 69 insertions(+), 8 deletions(-) diff --git a/plugins/sim900.c b/plugins/sim900.c index a7728cd..ace02a5 100644 --- a/plugins/sim900.c +++ b/plugins/sim900.c @@ -24,6 +24,7 @@ #endif #include

Re: [PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Clement Viel
On Tue, Nov 13, 2018 at 05:53:56PM +0100, Jonas Bonn wrote: > Hi, > > On 13/11/2018 16:33, Clement Viel wrote: > >--- > > plugins/sim900.c | 91 > > ++-- > > 1 file changed, 82 insertions(+), 9 deletions(-) > > > >diff --git a/plugins/sim900.c

Re: [PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Jonas Bonn
Hi, On 13/11/2018 16:33, Clement Viel wrote: --- plugins/sim900.c | 91 ++-- 1 file changed, 82 insertions(+), 9 deletions(-) diff --git a/plugins/sim900.c b/plugins/sim900.c index a7728cd..f280e5e 100644 --- a/plugins/sim900.c +++

[PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Clement Viel
--- plugins/sim900.c | 91 ++-- 1 file changed, 82 insertions(+), 9 deletions(-) diff --git a/plugins/sim900.c b/plugins/sim900.c index a7728cd..f280e5e 100644 --- a/plugins/sim900.c +++ b/plugins/sim900.c @@ -24,6 +24,7 @@ #endif #include

Re: [PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Clement Viel
On Tue, Nov 13, 2018 at 04:11:07PM +0100, Jonas Bonn wrote: Hi Jonas, > Hi Clement, > > I already provided review for this patch. This submission addresses none of > my earlier comments... > > On 13/11/2018 10:29, Clement Viel wrote: > >--- > > plugins/sim900.c | 91 > >

Re: [PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Jonas Bonn
Hi Clement, I already provided review for this patch. This submission addresses none of my earlier comments... On 13/11/2018 10:29, Clement Viel wrote: --- plugins/sim900.c | 91 ++-- 1 file changed, 82 insertions(+), 9 deletions(-)

Re: [PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Marcel Holtmann
Hi Clement, >>> --- >>> plugins/sim900.c | 91 >>> ++-- >>> 1 file changed, 82 insertions(+), 9 deletions(-) >>> >>> diff --git a/plugins/sim900.c b/plugins/sim900.c >>> index a7728cd..bf7b9ec 100644 >>> --- a/plugins/sim900.c >>> +++

Re: [PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Clement Viel
On Tue, Nov 13, 2018 at 12:59:47PM +0100, Giacinto Cifelli wrote: > Hi Clement, > > On Tue, Nov 13, 2018 at 10:29 AM Clement Viel wrote: > > > > --- > > plugins/sim900.c | 91 > > ++-- > > 1 file changed, 82 insertions(+), 9 deletions(-) > >

Re: [PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Giacinto Cifelli
Hi Clement, On Tue, Nov 13, 2018 at 10:29 AM Clement Viel wrote: > > --- > plugins/sim900.c | 91 > ++-- > 1 file changed, 82 insertions(+), 9 deletions(-) > > diff --git a/plugins/sim900.c b/plugins/sim900.c > index a7728cd..bf7b9ec 100644 >

[PATCH 1/3] sim800: add sim800 support.

2018-11-13 Thread Clement Viel
--- plugins/sim900.c | 91 ++-- 1 file changed, 82 insertions(+), 9 deletions(-) diff --git a/plugins/sim900.c b/plugins/sim900.c index a7728cd..bf7b9ec 100644 --- a/plugins/sim900.c +++ b/plugins/sim900.c @@ -24,6 +24,7 @@ #endif #include