Re: [PATCH 1/5] Refactor the command parsing framework

2010-03-25 Thread Denis Kenzior
Hi Zhenhua, --- gatchat/gatserver.c | 182 +++--- gatchat/gatserver.h | 7 ++- 2 files changed, 133 insertions(+), 56 deletions(-) - at_command_notify(server, buf, prefix, type); + notify = at_node_new(server, buf, prefix, type);

RE: [PATCH 1/5] Refactor the command parsing framework

2010-03-25 Thread Zhang, Zhenhua
Hi Denis, Denis Kenzior wrote: Hi Zhenhua, --- gatchat/gatserver.c | 182 +++--- gatchat/gatserver.h | 7 ++- 2 files changed, 133 insertions(+), 56 deletions(-) -at_command_notify(server, buf, prefix, type); +notify =

Re: [PATCH 1/5] Refactor the command parsing framework

2010-03-25 Thread Denis Kenzior
Hi Zhenhua Err, OK stop right there. This is really way too complicated. How about we simply set a flag before calling at_command_notify. If after executing it send_final or send_ext_final response has been sent, then we continue processing, otherwise we restart when send_ext_final or