Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-24 Thread Aki Niemi
Hi Jukka, 2011/1/24 Jukka Saunamaki jukka.saunam...@nokia.com: Then how about something like this: Lets make provisioning API synchronous (so that plugins do not need to care about SIM or other safety). In stead, if in gprs atom ofono_gprs_register() we notice the need for provisioning,  

Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-24 Thread Aki Niemi
Hi Denis, 2011/1/21 Denis Kenzior denk...@gmail.com: How exactly are you guaranteeing that 'nothing bad should happen'? There is no cancellation mechanism that I see.  Not to mention that the current ofono_sim_read API is not even safe either.  For exactly the same reasons. This is a problem

Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-21 Thread Denis Kenzior
Hi Jukka, On 01/21/2011 01:39 AM, Jukka Saunamaki wrote: Hi On Thu, 2011-01-20 at 15:51 -0600, Denis Kenzior wrote: So I don't really see the point in an asynchronous provisioning driver. If you want to do this over D-Bus or something then you might as well provision via the

[PATCH 1/6] gprs-provision: add driver API header

2011-01-20 Thread Jukka Saunamaki
--- Makefile.am |2 +- include/gprs-provision.h | 74 ++ 2 files changed, 75 insertions(+), 1 deletions(-) create mode 100644 include/gprs-provision.h diff --git a/Makefile.am b/Makefile.am index c1c34ca..7a03f08 100644 ---

Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-20 Thread Denis Kenzior
Hi Jukka, +/* + * Callback from provisioning plugin. + */ +typedef void (*ofono_gprs_provision_cb_t)( + const struct ofono_gprs_provision_data settings[], + int count, void *user_data); + +struct ofono_gprs_provision_driver { + const char

Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-20 Thread Jukka Saunamaki
Hi On Thu, 2011-01-20 at 15:51 -0600, Denis Kenzior wrote: So I don't really see the point in an asynchronous provisioning driver. If you want to do this over D-Bus or something then you might as well provision via the ConnectionManager interface. The other problem with being async is that