Re: [PATCH 17/20] stkutil: Add the Event Download envelope builder

2010-06-11 Thread Denis Kenzior
Hi Andrew, Hi, On 10 June 2010 03:06, Denis Kenzior denk...@gmail.com wrote: Hi Andrew, /* Network Byte Order */ - unsigned int ipv4; + guint32 ipv4; Why? int has no guranteed size except at the ABI level. So the SysV r4 ABIs for x86,

Re: [PATCH 17/20] stkutil: Add the Event Download envelope builder

2010-06-09 Thread Denis Kenzior
Hi Andrew, /* Network Byte Order */ - unsigned int ipv4; + guint32 ipv4; Why? @@ -799,7 +909,9 @@ struct stk_frame_layout { */ struct stk_frames_info { unsigned char id; - unsigned char list[126]; + struct { + unsigned

Re: [PATCH 17/20] stkutil: Add the Event Download envelope builder

2010-06-09 Thread Marcel Holtmann
Hi Denis, /* Network Byte Order */ - unsigned int ipv4; + guint32 ipv4; Why? actually unsigned int on 64-bit has a different size than on 32-bit. However I prefer we use uint32_t and not the guint32 types. Regards Marcel

Re: [PATCH 17/20] stkutil: Add the Event Download envelope builder

2010-06-09 Thread Denis Kenzior
Hi Marcel, Hi Denis, /* Network Byte Order */ - unsigned int ipv4; + guint32 ipv4; Why? actually unsigned int on 64-bit has a different size than on 32-bit. However I prefer we use uint32_t and not the guint32 types. Err, no it doesn't. You must be

[PATCH 17/20] stkutil: Add the Event Download envelope builder

2010-06-07 Thread Andrzej Zaborowski
--- src/stkutil.c | 556 - src/stkutil.h | 196 - 2 files changed, 746 insertions(+), 6 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index f8e7568..26af066 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@