Re: [PATCH 3/4] quectel: rework sim detection

2019-09-30 Thread Martin Hundebøll
Hi Denis, On 27/09/2019 00.10, Denis Kenzior wrote: On 9/26/19 2:27 PM, Martin Hundebøll wrote: Simplify sim handling by querying cpin state directly from quectel_pre_sim(). Don't initiate commands from pre_sim/post_sim/post_online callbacks please.  There's almost never a reason to. Ok.

Re: [PATCH 3/4] quectel: rework sim detection

2019-09-26 Thread Denis Kenzior
Hi Martin, On 9/26/19 2:27 PM, Martin Hundebøll wrote: Simplify sim handling by querying cpin state directly from quectel_pre_sim(). Don't initiate commands from pre_sim/post_sim/post_online callbacks please. There's almost never a reason to. The query is conducted by issuing a

[PATCH 3/4] quectel: rework sim detection

2019-09-26 Thread Martin Hundebøll
Simplify sim handling by querying cpin state directly from quectel_pre_sim(). The query is conducted by issuing a AT+CPIN?, where only CME errors are catched by the command response handler. The +CPIN: response is instead catched by a listener. The CME handler allows proper handling of the