Hi Rajesh,
On 01/05/2011 02:34 PM, ext rajesh.naga...@elektrobit.com wrote:
HI Lei,
My comments inline
+
+/* 3GPP2 C.S0015-B v2.0, Table 3.4-1 */ enum cdma_sms_tp_msg_type {
+ CDMA_SMS_P2P = 0,
+ CDMA_SMS_BCAST =1,
+ CDMA_SMS_ACK = 2
+};
1.Coding style
Hi Lei,
>> So it looks to me like this function takes arbitrary bit fields from a
>> stream. Is this a 'peculiarity' of the address field or will this be
>> used elsewhere?
>>
> Yes, your interpretation of the function is correct.
>
> Actually, cross CDMA SMS spec (and also other CDMA protocol s
HI Lei,
My comments inline
> +
> +/* 3GPP2 C.S0015-B v2.0, Table 3.4-1 */ enum cdma_sms_tp_msg_type {
> + CDMA_SMS_P2P = 0,
> + CDMA_SMS_BCAST =1,
> + CDMA_SMS_ACK = 2
> +};
1.Coding style M11 not followed.
If enum type name is cdma_sms_tp_msg_type, then en
Hi Denis,
On 01/04/2011 01:17 PM, ext Denis Kenzior wrote:
Hi Lei,
On 12/21/2010 06:02 PM, Lei Yu wrote:
---
Makefile.am|3 +-
src/cdma-smsutil.c | 484
src/cdma-smsutil.h | 264
3 files change
Hi Lei,
On 12/21/2010 06:02 PM, Lei Yu wrote:
> ---
> Makefile.am|3 +-
> src/cdma-smsutil.c | 484
>
> src/cdma-smsutil.h | 264
> 3 files changed, 750 insertions(+), 1 deletions(-)
> create mode 10
---
Makefile.am|3 +-
src/cdma-smsutil.c | 484
src/cdma-smsutil.h | 264
3 files changed, 750 insertions(+), 1 deletions(-)
create mode 100644 src/cdma-smsutil.c
create mode 100644 src/cdma-smsutil.h
