RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread mikhail.zabaluev
Hi, -Original Message- From: ext Denis Kenzior [mailto:denk...@gmail.com] Sent: Thursday, February 03, 2011 6:12 PM To: ofono@ofono.org Cc: Zabaluev Mikhail (Nokia-MS/Helsinki) Subject: Re: [RFC 2/2] doc: Add description for history agent interface I am not really getting what

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread mikhail.zabaluev
Hi Marcel, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of ext Marcel Holtmann Sent: Friday, February 04, 2011 2:59 PM To: ofono@ofono.org Subject: RE: [RFC 2/2] doc: Add description for history agent interface one of the really

Re: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread Denis Kenzior
Hi Mikhail, I totally agree. But it means that you have code in oFono to reliably store an ordered collection of stuff in a filesystem. I wouldn't like MeeGo developers to maintain very similar code in a different component, just for API adaptation reasons. No we do not. We have code to

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread Marcel Holtmann
Hi Mikhail, one of the really early design choices was to not expose TPDU outside of oFono core. We do not give TPDUs to history nor do we hand them out over D-Bus. That is a fundamental design decision and even after over 2 years that is still the right one. I totally agree. But

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread mikhail.zabaluev
Hi, -Original Message- From: ext Denis Kenzior [mailto:denk...@gmail.com] Sent: Friday, February 04, 2011 7:06 PM To: ofono@ofono.org Cc: Zabaluev Mikhail (Nokia-MS/Helsinki) Subject: Re: [RFC 2/2] doc: Add description for history agent interface I totally agree. But it means

Re: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread Denis Kenzior
Hi Mikhail, On 02/04/2011 12:52 PM, mikhail.zabal...@nokia.com wrote: Hi, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of ext Marcel Holtmann Sent: Friday, February 04, 2011 8:13 PM To: ofono@ofono.org Subject: RE: [RFC 2/2] doc: Add

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread Marcel Holtmann
Hi Mikhail, Why, you already cache fragments by their respective message refs efficiently. The only thing missing is a thin API to provide a view on complete messages. we are not storing the complete message. We give it to the history API. Somehow we never got to the because

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread mikhail.zabaluev
Hi, -Original Message- From: ext Denis Kenzior [mailto:denk...@gmail.com] Sent: Friday, February 04, 2011 8:27 PM To: Zabaluev Mikhail (Nokia-MS/Helsinki) Cc: ofono@ofono.org Subject: Re: [RFC 2/2] doc: Add description for history agent interface Moreover, you have to realize

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread Marcel Holtmann
Hi Mikhail, In the text message case we already provide the history plugin with _everything_ that it needs. If you want to implement a particular API, then history is the right avenue to do so. There is no inherent benefit of having oFono core do so and we do not want to introduce the

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread mikhail.zabaluev
Hi, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of ext Marcel Holtmann Sent: Friday, February 04, 2011 9:02 PM To: ofono@ofono.org Subject: RE: [RFC 2/2] doc: Add description for history agent interface And the failure mode

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-04 Thread Marcel Holtmann
Hi Mikhail, And the failure mode of the agent disconnecting is... to drop events on the floor??? Who said that? D-Bus is an asynchronous message bus with a method call and a method return message. Where do you see events being dropped? When you receive a callback on

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-03 Thread mikhail.zabaluev
Hi Denis, -Original Message- From: ext Denis Kenzior [mailto:denk...@gmail.com] Sent: Wednesday, February 02, 2011 9:23 PM To: ofono@ofono.org Cc: Zabaluev Mikhail (Nokia-MS/Helsinki) Subject: Re: [RFC 2/2] doc: Add description for history agent interface This has been discussed

Re: [RFC 2/2] doc: Add description for history agent interface

2011-02-03 Thread Denis Kenzior
: Add description for history agent interface This has been discussed to death a bazillion times. So lets recap very quickly: AT modems have two ways of delivering SMS messages: - CMTI - CMT CMTI delivery means the message goes to the SIM / ME store first, and then signaled up. The modem

Re: [RFC 2/2] doc: Add description for history agent interface

2011-02-03 Thread Denis Kenzior
Hi Mikhail, I am not really getting what you are saying. oFono will reassembly the message for you piece by piece. And we are making sure fragments are stored reliably. However once the message is complete we give it to history for further processing. Mainly to get it stored in the database.

Re: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Denis Kenzior
Hi Mikhail, Am I right in assuming that the SMS history roundtrip is not performed before acking the constituent TPDUs to the network? If it is, we have problems even regardless of D-Bus method call timeouts. This has been discussed to death a bazillion times. So lets recap very

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Kai.Vehmanen
Hello Marcel, On 02 Feb 2011, Marcel Holtmann wrote: - This relates to another TODO - persistant storage of RX-TPDUs for incomplete messages. If we've acked a TPDU to network, we must have stored it to persistant storage. Where are we not doing this. We do store the

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Kai.Vehmanen
Hi Denis, On 02 Feb 2011, Denis Kenzior wrote: Another fun fact about CMT delivery is that if you do not ack in a 'reasonable' amount of time, the modem _silently_ turns off SMS delivery. So putting acks over D-Bus is simply a bad idea. ack, very much agreed. And now that I realized RX

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Marcel Holtmann
Hi Kai, So yes, there might be conditions where you crash before fsync really completes and you lose the SMS. However, there's nothing in the world you can do about this case anyway, since both the write and the fsync succeeded. I think this is perfectly reasonable. Even if some

[RFC 2/2] doc: Add description for history agent interface

2011-02-01 Thread Marcel Holtmann
--- doc/history-agent-api.txt | 83 + 1 files changed, 83 insertions(+), 0 deletions(-) create mode 100644 doc/history-agent-api.txt diff --git a/doc/history-agent-api.txt b/doc/history-agent-api.txt new file mode 100644 index 000..373974d ---