Hi Denis.
We have done some testing with the STE modem for call termination, and this is
the result:
TC |Call #1 | Call #2 | Call #3 | Command | Result
---|
1 |ACTIVE | ACTIVE | .. | ATH | call 1, 2 terminate
Hi Sjur,
> Hi Denis.
>
> We have done some testing with the STE modem for call termination, and this
> is the result:
>
> TC |Call #1 | Call #2 | Call #3 | Command | Result
> ---|
> 1 |ACTIVE | ACTIVE | .. | ATH
Hi Denis.
We have done some testing with the STE modem for call termination,
and this is the result:
TC |Call #1 | Call #2 | Call #3 | Command | Result
---|
1 |ACTIVE | ACTIVE | .. | ATH | call 1, 2 termin
Hi Denis.
Sorry if you get this mail twice, something went wrong when posting this last
time so
I'm resending it.
We have done some testing with the STE modem for call termination, and this is
the result:
TC |Call #1 | Call #2 | Call #3 | Command | Result
---|---
Hi Sjur,
> > oFono already takes care of this for single calls (see src/voicecall.c
> > voicecall_hangup.) So this is only an issue in the case of three way
> > calls, is this what you're referring to here?
>
> Kind of. This is very good, it takes care of the situation with emergency
> call whi
Hi Denis:
Denis Kenzior wrote:
> Hi Sjur,
>
>>> All of this logic needs to go away. The core already handles all of
>>> this, including selection of ATH/CHLD, waiting/held. Please review
>>> src/voicecall.c. If the core logic is not sufficient or does not
>>> properly handle a certain case, then
Hi Sjur,
> > All of this logic needs to go away. The core already handles all of
> > this, including selection of ATH/CHLD, waiting/held. Please review
> > src/voicecall.c.
> > If the core logic is not sufficient or does not properly handle a
> > certain case, then lets see if we can fix the cor
Hi Denis.
Denis Kenzior wrote:
>> +static void ste_release_specific(struct ofono_voicecall *vc, int id,
>> +ofono_voicecall_cb_t cb, void *data) {
>> +struct voicecall_data *vd = ofono_voicecall_get_data(vc);
>> +struct release_id_req *req = g_try_new0(struct r
Hi Marcel.
Thank you for lots of feedback on patches. Marit who has done most of the
implementation is gone for a few days so we'll have to wait until end of
next week with the next oFono patch-set.
Marcel Holtmann wrote:
+ /* Need to change to gsm_permissive syntax in order to
+ *
Hi Marcel.
Thank you for your feedback. We hope to get new patch-set out tomorrow
with most of your comments fixed.
Marcel Holtmann wrote:
> Hi Sjur,
>
> review. I am thinking of something the like this; one per network
> registration, one per voice call, one per GPRS.
>
> You are making some
Hi Sjur,
> diff --git a/drivers/stemodem/network-registration.c
> b/drivers/stemodem/network-registration.c new file mode 100644
> index 000..4eeb239
> --- /dev/null
> +++ b/drivers/stemodem/network-registration.c
> +static void ciev_notify(GAtResult *result, gpointer user_data)
> +{
> +
Hi Sjur,
> Thank you for your feedback. We hope to get new patch-set out tomorrow
> with most of your comments fixed.
sounds great.
> > It might make sense to have a local copy of the required structure
> > and constants to allow an easier complication. Of course this depends
> > on having CAIF
From: Sjur Brandeland
Added implementation for STE modem; STE modem driver, and STE specific
drivers for gprs, network registration and voice call.
This patch uses CAIF sockets. CAIF patch for net-next-2.6 will be
contributed on net...@vger.kernel.org soon.
---
Makefile.am
Hi Sjur,
> Added implementation for STE modem; STE modem driver, and STE specific
> drivers for gprs, network registration and voice call.
>
> This patch uses CAIF sockets. CAIF patch for net-next-2.6 will be
> contributed on net...@vger.kernel.org soon.
can you please split these into smaller
14 matches
Mail list logo
