Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-17 Thread Sjur Brændeland
Hi Pekka. Pekka Pessi wrote: >> I'm not sure we have any problems with Network Initiated Connection in oFono, >> unless someone is planning to add support for Network Initiated >> Primary Contexts / PDN Connections. > > AFAIK the initial LTE default bearer context can be network-initiated, > and

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-17 Thread Pekka Pessi
Hi Sjur, 2011/1/17 Sjur Brændeland : >> The 27.007 for release 9 (from version 9.3.0 onwards) says: >> >> NOTE 1: The s for network-initiated PDP contexts will have values >> outside the ranges indicated for the >> in the test form of the commands +CGDCONT and +CGDSCONT. >> >> The change was prop

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-17 Thread Sjur Brændeland
Hi, So far we have been discussing CID races, but if we solve the CID issue, we still might end up with two "identical" Connections activated with the same connection properties (APN, Username, Password), one initiated by the modem in the LTE Combined Attach procedure and the other being a "normal

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-17 Thread Sjur Brændeland
Hi, Pekka Pessi wrote: > The 27.007 for release 9 (from version 9.3.0 onwards) says: > > NOTE 1: The s for network-initiated PDP contexts will have values > outside the ranges indicated for the > in the test form of the commands +CGDCONT and +CGDSCONT. > > The change was proposed by STE last Feb

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-17 Thread Pekka Pessi
Hi all, 2011/1/7 Denis Kenzior : >> Considering that from a modem standpoint the CID race condition can be >> resolved, >> some modem implementation may not have reserved a range of CID for their own >> purpose, >> or may not provide a mechanism to reserve a range of CID. > > If the CGDCONT race

RE: [RFC PATCH] gprs: add function to handle activated context

2011-01-11 Thread Soum, RedouaneX
Hi Denis, > > Considering that from a modem standpoint the CID race condition can > be resolved, > > some modem implementation may not have reserved a range of CID for > their own purpose, > > or may not provide a mechanism to reserve a range of CID. > > > > If the CGDCONT race is guaranteed to b

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Denis Kenzior
Hi Rémi, On 01/07/2011 02:52 AM, Rémi Denis-Courmont wrote: > On Thursday 06 January 2011 02:17:09 ext Denis Kenzior, you wrote: If such context is not found create a new one with "Internet" type. >>> >>> I don't really agree that we should create a context if no match is >>> found. I think t

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Denis Kenzior
Hi Fred, >>> The collision can only occur if the +CGDCONT (or +CGDSCONT) command from >>> Ofono is sent at the same time as PDP >>context activation URC from the >>> modem, and both use the same CID. >>> >>> But in that case, the modem should not reply "OK" to the PDP context >>> configuration

RE: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Joly, Frederic
Hi Sjur, >-Original Message- >From: Sjur Brændeland [mailto:sjurb...@gmail.com] >Sent: Friday, January 07, 2011 4:39 PM >To: ofono@ofono.org; Joly, Frederic >Subject: Re: [RFC PATCH] gprs: add function to handle activated context > >Hi Fred, > >Frederic wrot

RE: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Joly, Frederic
-Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Rémi Denis-Courmont Sent: Friday, January 07, 2011 9:52 AM To: ofono@ofono.org Subject: Re: [RFC PATCH] gprs: add function to handle activated context On Thursday 06 January 2011 02:17:09 ext

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Sjur Brændeland
Hi Fred, Frederic wrote: > The collision can only occur if the +CGDCONT (or +CGDSCONT) command  from > Ofono is sent at the same time as PDP context activation URC from the modem, > and both use the same CID. > > But in that case, the modem should not reply "OK" to the PDP context > configurati

RE: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Joly, Frederic
Hi, My two cents on context activation race: the collision between a network initiated context activation and UE initiated context activation. There is a potential issue if the modem and ofono try to assign the same CID at the same time Basically the sequence of AT commands looks like the foll

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Aki Niemi
Hi, 2011/1/7 Rémi Denis-Courmont : > On Thursday 06 January 2011 02:12:01 ext Marcel Holtmann, you wrote: >> > If such context is not found create a new one with "Internet" type. >> >> I don't really agree that we should create a context if no match is >> found. I think the better sensible strateg

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Rémi Denis-Courmont
On Thursday 06 January 2011 02:17:09 ext Denis Kenzior, you wrote: > >> If such context is not found create a new one with "Internet" type. > > > > I don't really agree that we should create a context if no match is > > found. I think the better sensible strategy is to hold this information > > in

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Rémi Denis-Courmont
On Thursday 06 January 2011 02:12:01 ext Marcel Holtmann, you wrote: > > If such context is not found create a new one with "Internet" type. > > I don't really agree that we should create a context if no match is > found. I think the better sensible strategy is to hold this information > internall

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Denis Kenzior
Hi Sjur, On 01/06/2011 11:45 AM, Sjur Brændeland wrote: > Hi Marcel and Denis. > >> I thought that we came to the conclusion that CID=0 is pretty much a >> really bad idea. So I would prefer that your modem is actually not using >> CID=0 ever. > Yea, I know you or Denis said so, but I'm not sure

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Marcel Holtmann
Hi Sjur, > > I thought that we came to the conclusion that CID=0 is pretty much a > > really bad idea. So I would prefer that your modem is actually not using > > CID=0 ever. > Yea, I know you or Denis said so, but I'm not sure we understood your > concern... I really thought it became pretty mu

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Sjur Brændeland
Hi Marcel and Denis. > I thought that we came to the conclusion that CID=0 is pretty much a > really bad idea. So I would prefer that your modem is actually not using > CID=0 ever. Yea, I know you or Denis said so, but I'm not sure we understood your concern... Regards, Sjur _

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Marcel Holtmann
Hi Sjur, > > +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) > > +{ > > + idmap_take(gprs->cid_map, id); > > +} > > + > How do we assure that this CID is not already in use? > I think the M7400 is going to use CID=0 and M700 uses CID=1. > Perhaps we should make sure CID=

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Sjur Brændeland
Hi, > From my understanding the ID in the core is an internal ID for oFono core, > even if today we usually have a mapping 1 to 1 between oFono core ID and > modems CID. > Denis, Marcel could you confirm ? Negative, to my understanding the CID is allocated in src/gprs.c and used when activating

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Denis Kenzior
Hi Redouane, On 01/06/2011 08:59 AM, Soum, RedouaneX wrote: > Hi Sjur, > > >>> +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) >>> +{ >>> + idmap_take(gprs->cid_map, id); >>> +} >>> + >> How do we assure that this CID is not already in use? >> I think the M7400 is goin

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Denis Kenzior
Hi Sjur, On 01/06/2011 06:02 AM, Sjur Brændeland wrote: > Hi Redouane, > ... >> +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) >> +{ >> + idmap_take(gprs->cid_map, id); >> +} >> + > How do we assure that this CID is not already in use? > I think the M7400 is going to us

RE: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Soum, RedouaneX
Hi Sjur, > > +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) > > +{ > > +       idmap_take(gprs->cid_map, id); > > +} > > + > How do we assure that this CID is not already in use? > I think the M7400 is going to use CID=0 and M700 uses CID=1. > Perhaps we should make sure CID

RE: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Soum, RedouaneX
Hi Marcel, > > Behavior of the function : > > > > List all the context and try to find correct APN > > we have to be careful to only match against APN==APN and Username=="" + > Password=="". > > The username and password option is pretty much pointless, but it is > present and we do support it.

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-06 Thread Sjur Brændeland
Hi Redouane, ... > +static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id) > +{ > +       idmap_take(gprs->cid_map, id); > +} > + How do we assure that this CID is not already in use? I think the M7400 is going to use CID=0 and M700 uses CID=1. Perhaps we should make sure CID=0 is a le

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-05 Thread Denis Kenzior
Hi Marcel, > >> If such context is not found create a new one with "Internet" type. > > I don't really agree that we should create a context if no match is > found. I think the better sensible strategy is to hold this information > internally and only map it to a context once the user or provisi

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-05 Thread Marcel Holtmann
Hi Redouane, > gprs: add function to handle activated context > ofono_gprs_context_activated : this function is symetric to > ofono_gprs_context_deactivated. > This function must be call by any gprs-context driver when a context has been > activated without explicit request. > > Behavior of the

[RFC PATCH] gprs: add function to handle activated context

2011-01-05 Thread Soum, RedouaneX
gprs: add function to handle activated context ofono_gprs_context_activated : this function is symetric to ofono_gprs_context_deactivated. This function must be call by any gprs-context driver when a context has been activated without explicit request. Behavior of the function : List all the co