Re: [patch 1/6] Add PPP protocol support with HDLC framing

2010-03-20 Thread Marcel Holtmann
Hi Kristen, This patch implements the basic PPP protocol. LCP, NCP etc. are handled in a different patch. --- Makefile.am |4 gatchat/gatppp.c | 133 gatchat/gatppp.h | 59 +++ gatchat/ppp.c| 455

[patch 1/6] Add PPP protocol support with HDLC framing

2010-03-19 Thread Kristen Carlson Accardi
This patch implements the basic PPP protocol. LCP, NCP etc. are handled in a different patch. --- Makefile.am |4 gatchat/gatppp.c | 133 gatchat/gatppp.h | 59 +++ gatchat/ppp.c| 455 +++ gatchat/ppp.h

Re: [patch 1/6] Add PPP protocol support with HDLC framing

2010-03-15 Thread Kristen Carlson Accardi
On Thu, 11 Mar 2010 20:17:49 -0600 Denis Kenzior denk...@gmail.com wrote: + } else { + /* store last flag character */ + link-buffer[link-index++] = data[pos]; + frame = ppp_decode(link,

Re: [patch 1/6] Add PPP protocol support with HDLC framing

2010-03-15 Thread Denis Kenzior
Hi Kristen, On Thu, 11 Mar 2010 20:17:49 -0600 Denis Kenzior denk...@gmail.com wrote: + } else { + /* store last flag character */ + link-buffer[link-index++] = data[pos]; + frame =

[patch 1/6] Add PPP protocol support with HDLC framing

2010-03-11 Thread kristen
This patch implements the basic PPP protocol. LCP, NCP etc. are handled in a different patch. Index: ofono/Makefile.am === --- ofono.orig/Makefile.am 2010-03-10 16:58:09.915955860 -0800 +++ ofono/Makefile.am 2010-03-10

Re: [patch 1/6] Add PPP protocol support with HDLC framing

2010-03-11 Thread Denis Kenzior
Hi Kristen, This patch implements the basic PPP protocol. LCP, NCP etc. are handled in a different patch. Index: ofono/Makefile.am === --- ofono.orig/Makefile.am2010-03-10 16:58:09.915955860 -0800 +++ ofono/Makefile.am

Re: [patch 1/6] Add PPP protocol support with HDLC framing

2010-03-11 Thread Denis Kenzior
Hi Kristen, +struct ppp_link * g_at_ppp_new(GIOChannel *modem); +void g_at_ppp_open(struct ppp_link *link); +void g_at_ppp_set_connect_function(struct ppp_link *link, +GAtPPPConnectFunc callback, gpointer user_data); +void g_at_ppp_set_disconnect_function(struct

Re: [patch 1/6] Add PPP protocol support with HDLC framing

2010-03-11 Thread Marcel Holtmann
Hi Denis, +struct ppp_link * g_at_ppp_new(GIOChannel *modem); +void g_at_ppp_open(struct ppp_link *link); +void g_at_ppp_set_connect_function(struct ppp_link *link, + GAtPPPConnectFunc callback, gpointer user_data); +void g_at_ppp_set_disconnect_function(struct