Adds IPCP support, and creates a TUN interface for sending/receiving IP
packets.
---
Makefile.am |2 +-
gatchat/gatppp.c |1 +
gatchat/ppp.c |1 +
gatchat/ppp.h | 12 ++
gatchat/ppp_net.c | 356 +
5 files changed, 37
Implement IPCP support. Creates a tun interface to pass IP traffic.
---
Makefile.am |2
gatchat/gatppp.c |1
gatchat/ppp.c |1
gatchat/ppp.h | 12 +
gatchat/ppp_net.c | 356 ++
5 files changed, 371 insertions(+)
On Thu, 18 Mar 2010 12:26:15 +0100
Marcel Holtmann wrote:
> Hi Kristen,
>
> > > > +static guint32 bytes_to_32(guint8 *bytes)
> > > > +{
> > > > + union addr {
> > > > + guint8 bytes[4];
> > > > + guint32 word;
> > > > + } a;
> > > > +
> > > > + memcp
Hi Kristen,
> > > +static guint32 bytes_to_32(guint8 *bytes)
> > > +{
> > > + union addr {
> > > + guint8 bytes[4];
> > > + guint32 word;
> > > + } a;
> > > +
> > > + memcpy(a.bytes, bytes, 4);
> > > + return(ntohl(a.word));
> > > +}
> >
> > This works, but is pretty ugly.
> >
>
On Tue, 16 Mar 2010 23:38:33 -0700
Marcel Holtmann wrote:
> > +static guint32 bytes_to_32(guint8 *bytes)
> > +{
> > + union addr {
> > + guint8 bytes[4];
> > + guint32 word;
> > + } a;
> > +
> > + memcpy(a.bytes, bytes, 4);
> > + return(ntohl(a.word));
> > +}
>
> This
Hi Kristen,
> Signed-off-by: Kristen Carlson Accardi
we don't do signed-off-by statements inside oFono. So please skip these
and fix your .gitconfig.
> Implement IPCP support. Creates a tun interface to pass IP traffic.
Also even if we would be doing signed-off-by statements, you messed them
Hi Kristen,
> > > +/** IPCP support /
> > > +enum {
> > > + /* supported codes */
> > > + IPCP_SUPPORTED_CODES= (1 << CONFIGURE_REQUEST) |
> > > + (1 << CONFIGURE_ACK) |
> > > + (1 << CONFIGURE_NAK) |
> > > +
Signed-off-by: Kristen Carlson Accardi
Implement IPCP support. Creates a tun interface to pass IP traffic.
---
Makefile.am |2
gatchat/gatppp.c |2
gatchat/gatppp_internal.h | 12 +
gatchat/gatpppnet.c | 369 +++
On Sun, 14 Mar 2010 13:22:37 -0700
Marcel Holtmann wrote:
> > +/** IPCP support /
> > +enum {
> > + /* supported codes */
> > + IPCP_SUPPORTED_CODES= (1 << CONFIGURE_REQUEST) |
> > + (1 << CONFIGURE_ACK) |
> > + (1
Hi Kristen,
> Implement IPCP support. Creates a tun interface to pass IP traffic.
this is not a proper review of the patch, just some general comments I
found by looking through the whole series.
> ===
> --- ofono.orig/gatchat/gatp
Implement IPCP support. Creates a tun interface to pass IP traffic.
Index: ofono/Makefile.am
===
--- ofono.orig/Makefile.am 2010-03-10 17:03:01.695955140 -0800
+++ ofono/Makefile.am 2010-03-10 17:04:30.034088637 -0800
@@ -59,7
11 matches
Mail list logo
