RE: [PATCH 1/2] Fix: Username and Password must be set after context is created.

2010-02-03 Thread Sjur Brændeland
Hi Marcel. Marcel Holtmann wrote: len = sprintf(buf, AT+CGDCONT=%u,\IP\, ctx-cid); if (ctx-apn) snprintf(buf + len, sizeof(buf) - len - 3, ,\%s\, ctx-apn); +/* Set username and password. Must be done after context creation */ +len = strlen(buf); +

Re: [PATCH 1/2] Fix: Username and Password must be set after context is created.

2010-02-01 Thread Marcel Holtmann
Hi Sjur, diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index 6743aba..c178fb6 100644 --- a/drivers/stemodem/gprs-context.c +++ b/drivers/stemodem/gprs-context.c @@ -416,7 +416,7 @@ static void ste_gprs_activate_primary(struct ofono_gprs_context *gc, {

RE: [PATCH 1/2] Fix: Username and Password must be set after context is created.

2010-02-01 Thread Marcel Holtmann
Hi Sjur, len = sprintf(buf, AT+CGDCONT=%u,\IP\, ctx-cid); if (ctx-apn) snprintf(buf + len, sizeof(buf) - len - 3, ,\%s\, ctx-apn); + /* Set username and password. Must be done after context creation */ + len = strlen(buf); + sprintf(buf+len,

Re: [PATCH 1/2] Fix: Username and Password must be set after context is created.

2010-02-01 Thread Denis Kenzior
Hi Marcel, And we might wanna check if MBM cards behave similar and ensure that STE and MBM cards use a similar code flow. When testing this EIAAUW fails if there are no prior PDP context on the modem. Most likely this is the case with the MBM module as well, but I have not tested

Re: [PATCH 1/2] Fix: Username and Password must be set after context is created.

2010-02-01 Thread Marcel Holtmann
Hi Denis, And we might wanna check if MBM cards behave similar and ensure that STE and MBM cards use a similar code flow. When testing this EIAAUW fails if there are no prior PDP context on the modem. Most likely this is the case with the MBM module as well, but I have not