Re: [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue

2011-01-21 Thread Denis Kenzior
Hi Martin, You still forgot to apply my earlier comment. The recv ACCM should be set to what is acked by the peer. e.g.: That is not this patch want to resolve. This patch is just used to fix the mixing up of setting recv ACCM and transit ACCM, And fix Huawei modem issue. 1. Currently,

Re: [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue

2011-01-20 Thread Denis Kenzior
Hi Martin, On 01/19/2011 11:45 PM, martin...@intel.com wrote: From: Martin Xu martin...@intel.com Tramsmit ACCM and receive ACCM is mixed up. According to RFC1662 Section 7.1, ACCM Configuration Option is used to inform the peer which control characters MUST remain mapped when the peer

RE: [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue

2011-01-20 Thread Xu, Martin
Hi Denis: -Original Message- From: Denis Kenzior [mailto:denk...@gmail.com] Sent: Friday, January 21, 2011 3:09 AM To: ofono@ofono.org Cc: Xu, Martin Subject: Re: [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue Hi Martin, On 01/19/2011 11:45 PM, martin