RE: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-22 Thread Joly, Frederic
Hi gentelmen, I apologise for this very comment. -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Marcel Holtmann Sent: Friday, November 05, 2010 9:47 PM To: ofono@ofono.org Cc: Ahmed, Suhail Subject: RE: [RFC 1/3] doc: addidng

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-05 Thread Denis Kenzior
Hi Robertino, On 11/05/2010 12:55 PM, Robertino Benis wrote: --- doc/assistedgps-manager-api.txt | 114 +++ 1 files changed, 114 insertions(+), 0 deletions(-) create mode 100644 doc/assistedgps-manager-api.txt diff --git

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-05 Thread Marcel Holtmann
Hi Denis, doc/assistedgps-manager-api.txt | 114 +++ 1 files changed, 114 insertions(+), 0 deletions(-) create mode 100644 doc/assistedgps-manager-api.txt diff --git a/doc/assistedgps-manager-api.txt b/doc/assistedgps-manager-api.txt new

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-05 Thread Sjur Brændeland
Hi, So in general I'm currently against introducing this API as oFono official API.  I suggest prefixing this with an IFX specific identifier.  Maybe modem.ifx.AgpsManager. I would actually go one step further and call this com.infineon.Agps or something like that. As I stated this many

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-05 Thread Denis Kenzior
Hi Sjur, On 11/05/2010 03:21 PM, Sjur Brændeland wrote: Hi, So in general I'm currently against introducing this API as oFono official API. I suggest prefixing this with an IFX specific identifier. Maybe modem.ifx.AgpsManager. I would actually go one step further and call this

RE: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-05 Thread Bastian, Waldo
oFono is strict CamelCase, even for abbreviations. You do this correctly above (AgpsManager) but not here. Please be consistent. And it might be a good idea to not have abbreviations at all. What does LCS stand for in this case? It refers to terminology from 3GPP TS 04.31: RRLP - Radio

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-05 Thread Marcel Holtmann
Hi Denis, So in general I'm currently against introducing this API as oFono official API. I suggest prefixing this with an IFX specific identifier. Maybe modem.ifx.AgpsManager. I would actually go one step further and call this com.infineon.Agps or something like that. As I

RE: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-05 Thread Marcel Holtmann
Hi Waldo, oFono is strict CamelCase, even for abbreviations. You do this correctly above (AgpsManager) but not here. Please be consistent. And it might be a good idea to not have abbreviations at all. What does LCS stand for in this case? It refers to terminology from 3GPP TS