Re: [RFC 3/3] STE-plugin: Adding STE plugin

2010-02-02 Thread Denis Kenzior
Hi Sjur, Hi Denis. We have done some testing with the STE modem for call termination, and this is the result: TC |Call #1 | Call #2 | Call #3 | Command | Result ---| 1 |ACTIVE | ACTIVE | .. | ATH |

RE: [RFC 3/3] STE-plugin: Adding STE plugin

2010-01-20 Thread Sjur Brændeland
Hi Marcel. Thank you for lots of feedback on patches. Marit who has done most of the implementation is gone for a few days so we'll have to wait until end of next week with the next oFono patch-set. Marcel Holtmann wrote: + /* Need to change to gsm_permissive syntax in order to + * parse

RE: [RFC 3/3] STE-plugin: Adding STE plugin

2010-01-18 Thread Marcel Holtmann
Hi Sjur, Thank you for your feedback. We hope to get new patch-set out tomorrow with most of your comments fixed. sounds great. It might make sense to have a local copy of the required structure and constants to allow an easier complication. Of course this depends on having CAIF at

Re: [RFC 3/3] STE-plugin: Adding STE plugin

2010-01-18 Thread Denis Kenzior
Hi Sjur, diff --git a/drivers/stemodem/network-registration.c b/drivers/stemodem/network-registration.c new file mode 100644 index 000..4eeb239 --- /dev/null +++ b/drivers/stemodem/network-registration.c +static void ciev_notify(GAtResult *result, gpointer user_data) +{ + struct

RE: [RFC 3/3] STE-plugin: Adding STE plugin

2010-01-18 Thread Sjur Brændeland
Hi Marcel. Thank you for your feedback. We hope to get new patch-set out tomorrow with most of your comments fixed. Marcel Holtmann wrote: Hi Sjur, review. I am thinking of something the like this; one per network registration, one per voice call, one per GPRS. You are making some core

Re: [RFC 3/3] STE-plugin: Adding STE plugin

2010-01-17 Thread Marcel Holtmann
Hi Sjur, Added implementation for STE modem; STE modem driver, and STE specific drivers for gprs, network registration and voice call. This patch uses CAIF sockets. CAIF patch for net-next-2.6 will be contributed on net...@vger.kernel.org soon. can you please split these into smaller