Re: [PATCH 1/2] include: Add ofono_modem_get_voicecall

2018-07-02 Thread Denis Kenzior
Hi Slava, I kind of like these getters for type safety but it's all up to you of course. Right, I can see value in getters for the common ones like sim, gprs & voicecall. But I don't really want to have 20-30 of these functions (one for each atom.) So at some point we have to draw the

Re: [PATCH 1/2] include: Add ofono_modem_get_voicecall

2018-07-02 Thread Slava Monich
On 02/07/18 18:34, Denis Kenzior wrote: Hi Slava, On 06/29/2018 08:57 AM, Slava Monich wrote: ---   include/modem.h | 2 ++   1 file changed, 2 insertions(+) diff --git a/include/modem.h b/include/modem.h index 005a42e..bed46c2 100644 --- a/include/modem.h +++ b/include/modem.h @@ -31,6 +31,7

Re: [PATCH 1/2] include: Add ofono_modem_get_voicecall

2018-07-02 Thread Denis Kenzior
Hi Slava, On 06/29/2018 08:57 AM, Slava Monich wrote: --- include/modem.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/modem.h b/include/modem.h index 005a42e..bed46c2 100644 --- a/include/modem.h +++ b/include/modem.h @@ -31,6 +31,7 @@ extern "C" { struct ofono_modem;