[PATCH] stk: Handle send ss proactive command

2010-09-13 Thread Yang Gu
--- src/call-barring.c| 168 ++--- src/call-forwarding.c | 155 +- src/call-settings.c | 220 +++-- src/ofono.h | 15 +++- src/stk.c | 98

Currently when sending a supplementary service control string via D-Bus, a

2010-09-13 Thread Yang Gu
From Yang Gu yang...@intel.com # This line is ignored. From: Yang Gu yang...@intel.com Subject: In-Reply-To: ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 0/1] stk: Handle send ss proactive command

2010-09-13 Thread Gu, Yang
Hi, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Yang Gu Sent: Monday, September 13, 2010 4:36 PM To: ofono@ofono.org Subject: Currently when sending a supplementary service control string via D-Bus, a From Yang Gu yang...@intel.com #

Re: [PATCH] Check if ussd is busy when doing ss

2010-09-13 Thread Pekka Pessi
Hi Yang, 2010/9/6 Yang Gu yang...@intel.com: It's still not clear how ss and ussd interfere with each other. Current decision is each ss (call-barring, call-forwarding, etc.) has interference with ussd, but there is no interference within these ss. That is, call-barring has interference with

Re: [PATCH 5/6] dun_gw: Add DUN server plugin for oFono

2010-09-13 Thread Denis Kenzior
Hi Zhenhua, + if (g_str_equal(property, Online) == TRUE) { + const char *path = dbus_message_get_path(msg); + struct ofono_modem *modem; + struct ofono_atom *gprs; + gboolean online; + + if (!dbus_message_iter_next(iter)) +

Added UCS2 handling and review comments incorporated

2010-09-13 Thread Jeevaka Badrappan
Hi all, Following patches adds the missing UCS2 handling for received USSD data, Denis's review comments incorporated and also test added for testing the newly added utility functions. All the changes are done for adding support for the Send USSD proactive command Thanks and Regards,

[PATCH 2/8] util: Add UCS2 to GSM 7bit converion function

2010-09-13 Thread Jeevaka Badrappan
--- src/util.c | 108 src/util.h | 10 + 2 files changed, 118 insertions(+), 0 deletions(-) diff --git a/src/util.c b/src/util.c index bb90f6c..b2a9321 100644 --- a/src/util.c +++ b/src/util.c @@ -1261,3 +1261,111 @@ unsigned

[PATCH 3/8] test-util: Add function for validating UCS2 to GSM bit conversion

2010-09-13 Thread Jeevaka Badrappan
--- unit/test-util.c | 80 ++ 1 files changed, 80 insertions(+), 0 deletions(-) diff --git a/unit/test-util.c b/unit/test-util.c index de62848..9df61dd 100644 --- a/unit/test-util.c +++ b/unit/test-util.c @@ -38,6 +38,10 @@ const unsigned

[PATCH 4/8] USSD atom driver changes to read current character setting

2010-09-13 Thread Jeevaka Badrappan
--- drivers/atmodem/ussd.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/ussd.c b/drivers/atmodem/ussd.c index 1e1fc25..30145ad 100644 --- a/drivers/atmodem/ussd.c +++ b/drivers/atmodem/ussd.c @@ -44,12 +44,25 @@ static const char

[PATCH 1/8] smsutil: Add USSD encoding function

2010-09-13 Thread Jeevaka Badrappan
--- src/smsutil.c | 29 + src/smsutil.h |1 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 26c7951..0d68d33 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -4179,3 +4179,32 @@ char *ussd_decode(int dcs, int

[PATCH 6/8] Add __ofono_ussd_initiate internal api for Sending USSD

2010-09-13 Thread Jeevaka Badrappan
--- src/ofono.h |7 + src/ussd.c | 86 ++- 2 files changed, 92 insertions(+), 1 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index f1c0973..8ab6a2e 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -258,6 +258,9 @@ typedef

[PATCH 5/8] Internal and Driver API changes for Send USSD

2010-09-13 Thread Jeevaka Badrappan
--- drivers/atmodem/ussd.c | 112 +++ drivers/isimodem/ussd.c | 42 +++-- include/ussd.h |8 ++- src/ussd.c | 61 + 4 files changed, 120 insertions(+), 103 deletions(-) diff --git

[PATCH 8/8] stkutil: Add handling of error case scenario in build USSD data object

2010-09-13 Thread Jeevaka Badrappan
--- src/stkutil.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 3cfe06a..95d2f9b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -4177,6 +4177,9 @@ static gboolean build_dataobj_ussd_text(struct stk_tlv_builder *tlv,

[PATCH] Fix common misspellings

2010-09-13 Thread Lucas De Marchi
Apply to all files the list of common misspellings found at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution found the following misspellings: accomodate-accommodate fomr-from priviledge-privilege

Re: [PATCH] Fix common misspellings

2010-09-13 Thread Lucas De Marchi
On Mon, Sep 13, 2010 at 10:35 PM, Marcel Holtmann mar...@holtmann.org wrote: no signed-off-by please. We don't use it. Sorry, I forgot this project follows the same rules as for connman. While in general I am all for fixing spelling mistakes, but you need to break this down into logical

Re: [PATCH] Fix common misspellings

2010-09-13 Thread Denis Kenzior
Hi Lucas, On 09/13/2010 09:32 PM, Lucas De Marchi wrote: On Mon, Sep 13, 2010 at 10:35 PM, Marcel Holtmann mar...@holtmann.org wrote: no signed-off-by please. We don't use it. Sorry, I forgot this project follows the same rules as for connman. While in general I am all for fixing spelling

[PATCH 1/6] Fix common misspellings in documentation

2010-09-13 Thread Lucas De Marchi
Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspellings: accomodate-accommodate targetted-targeted transfering-transferring

[PATCH 2/6] Fix common misspellings in drivers

2010-09-13 Thread Lucas De Marchi
Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspellings: subsidary(-ies)-subsidiary(-ies) transfering-transferring ---

[PATCH 3/6] Fix common misspellings in gatchat

2010-09-13 Thread Lucas De Marchi
Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspellings: priviledge-privilege succeded-succeeded --- gatchat/gatppp.c |2

[PATCH 4/6] Fix common misspelling in gisi

2010-09-13 Thread Lucas De Marchi
Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspelling: fomr-from --- gisi/client.c |2 +- gisi/server.c |2 +- 2 files

[PATCH 6/6] Fix common misspelling in source files

2010-09-13 Thread Lucas De Marchi
Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspelling: reponsible-responsible --- src/util.c |2 +- 1 files changed, 1

Re: [PATCH 2/6] Fix common misspellings in drivers

2010-09-13 Thread Marcel Holtmann
Hi Lucas, - * Copyright (C) 2010 Nokia Corporation and/or its subsidary(-ies). + * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). for these kind of changes, I prefer if you have buy in from the Nokia guys. Some companies have strict rules on the copyright header. I know