RE: [PATCH 3/4] radio settings: document FastDormancy property
Hi, so how does the future prediction is suppose to work. Are we shipping a time machine together with oFono ;) I would say the heuristic is system dependent. Typical way would be to monitor events from different input devices. If no events arrive for a specified time the user is assumed to be inactive. The user might also have some explicit way to do this, such as locking the display and keys. MikaL ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [fix-isi-udev PATCH 0/3] Improve udev with isi
On 07.10.2010 22:41, ext Aki Niemi wrote: [fix-isi-udev PATCH 3/3] ofono.rules: assign isigen driver by USB ids This one was left dangling; let's see if we can come up with a better way to match the modems driven by cdc_phonet. (Although, admittedly this same approach is already used with some AT modems.) I suppose you could match by usb interface class and subclass? (02 and 254 respectively - the first is standardized, but the second seems to be just made up by Nokia at some point, so we better keep the vendor id too) Alex ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
[PATCH] TODO: long phone numbers
From: Pekka Pessi pekka.pe...@nokia.com --- TODO |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 5589bb1..a96c187 100644 --- a/TODO +++ b/TODO @@ -285,11 +285,18 @@ Voicecall Complexity: C1 Owner: Pekka Pessi pekka.pe...@nokia.com +- Long phone numbers. According to 3GPP TS 24.008, the callee address + can be up to 80 digits long. + + Priority: Medium + Complexity: C2 + - Dial strings. Include CLIR prefixes and 2nd stage dial strings in the DialString call property. Add dialstring accessor method to C API. Priority: Medium Complexity: C4 + Owner: Pekka Pessi pekka.pe...@nokia.com - Provide feedback of sent DTMF tones. Emit SendingTones signal if modem can provide approximate starting and stopping times for DTMF tones. Signal -- 1.7.0.4 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [fix-isi-udev PATCH 3/3] ofono.rules: assign isigen driver by USB ids
On Mon, 4 Oct 2010 16:11:06 +0300, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com Now using the USB vendor and product IDs like the rest of the oFono drivers. For reasons left unclear, the SUBSYSTEMS rule did not work consistently in Ubuntu 10.04. The network device is not part of the USB subsystem, only its parent device. +# Nokia default (with PC Suite) +ATTRS{idVendor}==0421, ENV{OFONO_DRIVER}=isigen, ENV{OFONO_ISI_ADDRESS}=16 + This will match the whole USB gadget. How do you get the Phonet interface from that? I would simply match on Ethernet type 820 and kernel name usbpnXXX. -- Rémi Denis-Courmont http://www.remlab.net http://fi.linkedin.com/in/remidenis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
huawei e1550
Hi all. I have a huawei 1550 GSM-modem. When i plug it to usb /usr/lib/ofono/test/list-modems [ /huawei0 ] Features = sim Powered = 1 Interfaces = org.ofono.SupplementaryServices org.ofono.CallBarring org.ofono.CallSettings org.ofono.CallForwarding org.ofono.MessageWaiting org.ofono.AudioSettings org.ofono.VoiceCallManager org.ofono.SimManager Online = 1 Model = E1550 Manufacturer = huawei Serial = 353142033084081 Revision = 11.608.12.00.143 [ org.ofono.SupplementaryServices ] State = idle [ org.ofono.CallBarring ] VoiceOutgoing = disabled VoiceIncoming = disabled [ org.ofono.CallSettings ] All fine. In UX-interface i see section 3G but modem cant find operator's network I compare with HUAWEI E620 USB modem When i plug it in UX i see my network Megafon and can connect. If use ppp+usb_modeswitch modem working and can dial. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [fix-isi-udev PATCH 3/3] ofono.rules: assign isigen driver by USB ids
Hi, 2010/10/8 Rémi Denis-Courmont r...@remlab.net: Now using the USB vendor and product IDs like the rest of the oFono drivers. For reasons left unclear, the SUBSYSTEMS rule did not work consistently in Ubuntu 10.04. The network device is not part of the USB subsystem, only its parent device. Yes, the last S in SUBSYSTEMS refer to a SUBSYSTEM of a parent. +# Nokia default (with PC Suite) +ATTRS{idVendor}==0421, ENV{OFONO_DRIVER}=isigen, ENV{OFONO_ISI_ADDRESS}=16 + This will match the whole USB gadget. That is the point. We don't want one modem with at command tty and another with phonet interface. How do you get the Phonet interface from that? I would simply match on Ethernet type 820 and isi_add() does the Ethernet type matching. For a reason or another Lucid udev rules fails to match the type sysattr when enumerating existing devices. kernel name usbpnXXX. The interface name is ignored as an expert earlier advised. ;) -- Pekka.Pessi mail at nokia.com ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: huawei e1550
В Птн, 08/10/2010 в 16:20 +0400, Alexander A Khryukin пишет: Hi all. I have a huawei 1550 GSM-modem. When i plug it to usb /usr/lib/ofono/test/list-modems [ /huawei0 ] Features = sim Powered = 1 Interfaces = org.ofono.SupplementaryServices org.ofono.CallBarring org.ofono.CallSettings org.ofono.CallForwarding org.ofono.MessageWaiting org.ofono.AudioSettings org.ofono.VoiceCallManager org.ofono.SimManager Online = 1 Model = E1550 Manufacturer = huawei Serial = 353142033084081 Revision = 11.608.12.00.143 [ org.ofono.SupplementaryServices ] State = idle [ org.ofono.CallBarring ] VoiceOutgoing = disabled VoiceIncoming = disabled [ org.ofono.CallSettings ] All fine. In UX-interface i see section 3G but modem cant find operator's network I compare with HUAWEI E620 USB modem When i plug it in UX i see my network Megafon and can connect. If use ppp+usb_modeswitch modem working and can dial. Hm, now network visible but when i press Connect ofonod put in log that modem was removed and then process still loopback http://pastie.org/1207567 plugins/udev.c:add_modem() /devices/pci:00/:00:1d.7/usb1/1-3/1-3:1.1/ttyUSB1/tty/ttyUSB1 (huawei) ofonod[3510]: plugins/udev.c:add_huawei() modem 0x88b0cf8 ofonod[3510]: src/modem.c:get_modem_property() modem 0x88b0cf8 property ModemRegistered ... ... ... ... plugins/udev.c:remove_modem() /devices/pci:00/:00:1d.7/usb1/1-3/1-3:1.1/ttyUSB1/tty/ttyUSB1 ofonod[3510]: plugins/udev.c:remove_modem() /devices/pci:00/:00:1d.7/usb1/1-3/1-3:1.2/ttyUSB2/tty/ttyUSB2 Remove and adding modem repeating and repeaing again. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
[please ignore] testing
___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
[RFC ssn PATCH 3/4] isimodem/ssn: add common notifications
From: Pekka Pessi pekka.pe...@nokia.com Add notifications on hold, retrieve, multiparty, call waiting, barrings, and various notifications on call forwarding. Note that driver uses the CUG index parameter to pass call IDs to core. --- drivers/isimodem/call.h | 12 +++ drivers/isimodem/ssn.c | 224 +-- 2 files changed, 227 insertions(+), 9 deletions(-) diff --git a/drivers/isimodem/call.h b/drivers/isimodem/call.h index 2901971..9a8ba39 100644 --- a/drivers/isimodem/call.h +++ b/drivers/isimodem/call.h @@ -402,6 +402,18 @@ enum { CALL_DTMF_DISABLE_TONE_IND_SEND = 0x02 }; +enum { + CALL_GSM_SSI_CALL_IS_WAITING = 0x01, + CALL_GSM_SSI_MPTY = 0x02, + CALL_GSM_SSI_CLIR_SUPPR_REJ = 0x04, +}; + +enum { + CALL_GSM_SSN_INCOMING_IS_FWD = 0x01, + CALL_GSM_SSN_INCOMING_FWD = 0x02, + CALL_GSM_SSN_OUTGOING_FWD = 0x04, +}; + #ifdef __cplusplus }; #endif diff --git a/drivers/isimodem/ssn.c b/drivers/isimodem/ssn.c index def3b0c..1e1f659 100644 --- a/drivers/isimodem/ssn.c +++ b/drivers/isimodem/ssn.c @@ -1,7 +1,7 @@ /* * This file is part of oFono - Open Source Telephony * - * Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies). + * Copyright (C) 2009-2010 Nokia Corporation and/or its subsidiary(-ies). * * Contact: Aki Niemi aki.ni...@nokia.com * @@ -32,42 +32,248 @@ #include errno.h #include glib.h +#include arpa/inet.h #include gisi/client.h +#include gisi/iter.h #include ofono/log.h #include ofono/modem.h #include ofono/ssn.h #include isimodem.h +#include call.h +#include ss.h -#define PN_SS 0x06 - -struct ssn_data { +struct isi_ssn { GIsiClient *client; }; +static void isi_ssn_ss_code(struct ofono_ssn *ssn, uint16_t ss_code) +{ + int cssi; + + DBG(ss_code=%u, ss_code); + + /* ss-code is MMI code from 22.030 */ + + switch (ss_code) { + case SS_GSM_FORW_UNCONDITIONAL: + case SS_GSM_ALL_FORWARDINGS: + /* 3GPP TS 22.082 clause 1.1.1 */ + cssi = OFONO_SS_MO_UNCONDITIONAL_FORWARDING; + break; + + case SS_GSM_FORW_NO_REPLY: + case SS_GSM_FORW_NO_REACH: + case SS_GSM_FORW_BUSY: + case SS_GSM_ALL_COND_FORWARDINGS: + /* 3GPP TS 22.082 clauses 2.1.1, 3.1.1, 4.1.1 */ + cssi = OFONO_SS_MO_CONDITIONAL_FORWARDING; + break; + + case SS_GSM_BARR_ALL_OUT: + case SS_GSM_OUTGOING_BARR_SERV: + case SS_GSM_BARR_OUT_INTER: + case SS_GSM_BARR_OUT_INTER_EXC_HOME: + /* 3GPP TS 22.088 clause 1.1 */ + cssi = OFONO_SS_MO_OUTGOING_BARRING; + break; + + case SS_GSM_INCOMING_BARR_SERV: + case SS_GSM_BARR_ALL_IN: + case SS_GSM_BARR_ALL_IN_ROAM: + /* 3GPP TS 22.088 clause 2.1 */ + /* Called subscriber has barred incoming calls */ + cssi = OFONO_SS_MO_INCOMING_BARRING; + break; + + default: + return; + } + + ofono_ssn_cssi_notify(ssn, cssi, 0); +} + +static void isi_ssn_ss_notification(struct ofono_ssn *ssn, int id, + uint8_t ss_notification) +{ + int code; + + struct ofono_phone_number number = { }; + + /* See SS-Notification in TS 22.080 clause 4.4.2 */ + + if (ss_notification (1 2)) { + /* Call is forwarded indication to A-subscriber */ + /* 3GPP TS 22.082 clauses 1.1.3, 2.1.3, 3.1.3, 4.1.3 */ + code = OFONO_SS_MO_CALL_FORWARDED; + ofono_ssn_cssi_notify(ssn, code, id); + } else if (ss_notification (1 1)) { + /* Call is forwarded indication to B subscriber */ + /* 3GPP TS 24.082 clauses 2.1.1, 3.1.1 */ + code = OFONO_SS_MT_OTHER_CALL_FORWARDED; + ofono_ssn_cssu_notify(ssn, code, 0, number); + /* A subscriber address is not relayed to mobile */ + } else if (ss_notification (1 0)) { + /* Call is forwarded indication to C subscriber */ + /* 3GPP TS 22.082 clauses 1.1.2, 2.1.2, 3.1.2, 4.1.2 */ + code = OFONO_SS_MT_CALL_FORWARDED; + ofono_ssn_cssu_notify(ssn, code, id, number); + /* The redirecting address is not part of notifySS */ + /* However, it is available in CALL_COMING_IND */ + } +} + +static void isi_ssn_notify_indicator(struct ofono_ssn *ssn, int id, + uint8_t ss_indicators, + struct ofono_phone_number *number) +{ + DBG(); + + if (ss_indicators CALL_GSM_SSI_CALL_IS_WAITING) { + ofono_ssn_cssi_notify(ssn, + OFONO_SS_MO_CALL_WAITING, id); + } + + if (ss_indicators
[RFC ssn PATCH 2/4] ssn: add ssn code argument to ssn notify callbacks
From: Pekka Pessi pekka.pe...@nokia.com Including the ssn code as an argument in notify callbacks allows handling of multiple notifications in single function. --- src/call-barring.c | 33 +++-- src/ofono.h|4 ++-- src/ssn.c |8 ++-- 3 files changed, 19 insertions(+), 26 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 7a17479..e2de404 100644 --- a/src/call-barring.c +++ b/src/call-barring.c @@ -993,33 +993,22 @@ static GDBusSignalTable cb_signals[] = { { } }; -static void call_barring_incoming_enabled_notify(int idx, void *userdata) +static void call_barring_notify(int code, int idx, void *userdata) { struct ofono_call_barring *cb = userdata; DBusConnection *conn = ofono_dbus_get_connection(); const char *path = __ofono_atom_get_path(cb-atom); + char const *member; - g_dbus_emit_signal(conn, path, OFONO_CALL_BARRING_INTERFACE, - IncomingBarringInEffect, DBUS_TYPE_INVALID); -} - -static void call_barring_outgoing_enabled_notify(int idx, void *userdata) -{ - struct ofono_call_barring *cb = userdata; - DBusConnection *conn = ofono_dbus_get_connection(); - const char *path = __ofono_atom_get_path(cb-atom); - DBusMessage *signal; - - signal = dbus_message_new_signal(path, OFONO_CALL_BARRING_INTERFACE, - OutgoingBarringInEffect); - - if (!signal) { - ofono_error(Unable to allocate new %s.OutgoingBarringInEffect -signal, OFONO_CALL_BARRING_INTERFACE); + if (code == OFONO_SS_MO_INCOMING_BARRING) + member = IncomingBarringInEffect; + else if (code == OFONO_SS_MO_OUTGOING_BARRING) + member = OutgoingBarringInEffect; + else return; - } - g_dbus_send_message(conn, signal); + g_dbus_emit_signal(conn, path, OFONO_CALL_BARRING_INTERFACE, + member, DBUS_TYPE_INVALID); } int ofono_call_barring_driver_register(const struct ofono_call_barring_driver *d) @@ -1132,11 +1121,11 @@ static void ssn_watch(struct ofono_atom *atom, cb-incoming_bar_watch = __ofono_ssn_mo_watch_add(cb-ssn, OFONO_SS_MO_INCOMING_BARRING, - call_barring_incoming_enabled_notify, cb, NULL); + call_barring_notify, cb, NULL); cb-outgoing_bar_watch = __ofono_ssn_mo_watch_add(cb-ssn, OFONO_SS_MO_OUTGOING_BARRING, - call_barring_outgoing_enabled_notify, cb, NULL); + call_barring_notify, cb, NULL); } static void ussd_watch(struct ofono_atom *atom, diff --git a/src/ofono.h b/src/ofono.h index 6c7f649..1cbc935 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -243,8 +243,8 @@ void __ofono_cbs_sim_download(struct ofono_stk *stk, const struct cbs *msg); #include ofono/ssn.h -typedef void (*ofono_ssn_mo_notify_cb)(int index, void *user); -typedef void (*ofono_ssn_mt_notify_cb)(int index, +typedef void (*ofono_ssn_mo_notify_cb)(int index, int mo_code, void *user); +typedef void (*ofono_ssn_mt_notify_cb)(int index, int mt_code, const struct ofono_phone_number *ph, void *user); diff --git a/src/ssn.c b/src/ssn.c index b886dba..8a4ad70 100644 --- a/src/ssn.c +++ b/src/ssn.c @@ -118,12 +118,14 @@ void ofono_ssn_cssi_notify(struct ofono_ssn *ssn, int code1, int index) GSList *l; ofono_ssn_mo_notify_cb notify; + DBG(ssn %p, code %u, index %u, (void *)ssn, code1, index); + for (l = ssn-mo_handler_list-items; l; l = l-next) { h = l-data; notify = h-item.notify; if (h-code == code1) - notify(index, h-item.notify_data); + notify(index, code1, h-item.notify_data); } } @@ -134,12 +136,14 @@ void ofono_ssn_cssu_notify(struct ofono_ssn *ssn, int code2, int index, GSList *l; ofono_ssn_mt_notify_cb notify; + DBG(ssn %p, code %u, index %u, (void *)ssn, code2, index); + for (l = ssn-mt_handler_list-items; l; l = l-next) { h = l-data; notify = h-item.notify; if (h-code == code2) - notify(index, ph, h-item.notify_data); + notify(index, code2, ph, h-item.notify_data); } } -- 1.7.0.4 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
[RFC ssn PATCH 1/4] Supplementary Service Notifications
Hello all, I've been working on supplementary service notifications (iow, trying to decipher notifySS usage from 24.080 and related specifications). SSN atom is not used much, so I ended up modifying the current notifier API to include the SSN notification codes as a parameter of the notify function. I also wrote an isimodem driver for the SSNs. As for the D-Bus API, the modifications I propose are in the patch 4. There is no implementation in src/voicecall.c or src/call-forwarding.c, as I'd like to get the D-Bus API agreed first. I'd move the barring notifications to voicecall API, as they just provide additional information on the reason why the call was rejected. IncomingBarringInEffect is not about your barring services but barring services for callee. Most of the CSSI and CSSU indications are no-brainers (once you match the 27.007 language and various bits and pieces from 24.08* specifications) from the API point-of-view but these really require a call ID along with them: - call has been put on hold (+CSSU: 2) - call has been retrieved (+CSSU: 3), and - joining call to a multiparty conference (+CSSU: 4) The problem here is that the AT CSSI/CSSU notifications conveniently strip away indication which call is put on hold, retrieved or joined to a multiparty call. I'd reuse the index with non-CUG codes (as I did in isimodem driver patch) or add an extra call-id parameter to the notifiers. If the driver does not know call-id or there is no call-id for the call, it can pass 0 to the core and let the core to select a convenient victim. --Pekka ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
[RFC ssn PATCH 4/4] D-Bus API for Supplementary Service Notifications
From: Pekka Pessi pekka.pe...@nokia.com --- doc/call-barring-api.txt | 10 --- doc/call-forwarding-api.txt |9 +++ doc/voicecall-api.txt| 55 +- doc/voicecallmanager-api.txt |5 4 files changed, 68 insertions(+), 11 deletions(-) diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt index 41ae4b1..1534494 100644 --- a/doc/call-barring-api.txt +++ b/doc/call-barring-api.txt @@ -37,16 +37,6 @@ Signals PropertyChanged(string property, variant value) Signal is emitted whenever a property has changed. The new value is passed as the signal argument. - IncomingBarringInEffect() - - Signal is emitted when a call is made and an - incoming call barring supplementary service is in use. - - OutgoingBarringInEffect() - - Signal is emitted when a call is made and an - outgoing call barring supplementary service is in use. - Properties string VoiceIncoming [readwrite] Contains the value of the barrings for the incoming diff --git a/doc/call-forwarding-api.txt b/doc/call-forwarding-api.txt index 067531a..a97165b 100644 --- a/doc/call-forwarding-api.txt +++ b/doc/call-forwarding-api.txt @@ -26,6 +26,15 @@ Signals PropertyChanged(string property, variant value) Signal is emitted whenever a property has changed. The new value is passed as the signal argument. + ForwardingInEffect(string condition) + + This informational signal is emitted when an outgoing + call is made. It indicates that a voice call + forwarding for incoming calls is in use. Condition can + be either of: + unconditional - VoiceUnconditional is active + conditional - A conditional rule is active + Properties string VoiceUnconditional [readwrite] Contains the value of the voice unconditional call diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt index f0ba316..a6c0b42 100644 --- a/doc/voicecall-api.txt +++ b/doc/voicecall-api.txt @@ -73,6 +73,54 @@ Signals PropertyChanged(string property, variant value) of this signal as optional. This signal will be emitted before the PropertyChanged signal. + JoinedMultiparty() + + Signal is emitted when remote party joins the + call into a multiparty conference. + + Note that there is no corresponding event when + remote party splits call from the multiparty + conference. + + Waiting() + + Signal is emitted when an outgoing call is waiting. + + OutgoingBarred() + + Signal is emitted when caller's outgoing barring + services prevent call from being connected. + + This signal can be emitted while call is being + disconnected or while a recorded announcement is + played. + + IngomingBarred() + + Signal is emitted when callee's incoming barring + services prevent call from being connected. + + This signal can be emitted while call is being + disconnected or while a recorded announcement is + played. + + IncomingRedirected(string) + + Signal is emitted when network indicates that an + incoming call has been redirected. The value + contains the phone number of the party that + redirected the call if available. + + OutgoingRedirected() + + Signal is emitted when an outgoing call has been + redirected. + + CallerIDRestrictionRejected() + + Signal is emitted when caller requested Caller + ID Restriction but network rejects it. + Properties string LineIdentification [readonly] Contains the Line Identification information returned @@ -90,7 +138,7 @@ Properties string LineIdentification [readonly] boolean Multiparty [readonly] Contains the indication if the voice call is part - of a multiparty call or not. + of a multiparty call set up by user or not. Notifications if a call becomes part or leaves a multipart call are sent. @@ -115,6
[RFC ssn PATCH 1/4] ssn: include ssn codes in public API
From: Pekka Pessi pekka.pe...@nokia.com Include +CSSI and +CSSU codes in include/ssn.h and prefix them with OFONO_. Added CSSU code 10, OFONO_SS_MT_OTHER_CALL_FORWARDED, which is sent to mobile if call was forwarded while mobile was engaged with other call(s). --- include/ssn.h | 29 - src/call-barring.c |4 ++-- src/common.h | 26 -- 3 files changed, 30 insertions(+), 29 deletions(-) diff --git a/include/ssn.h b/include/ssn.h index d640cad..4e6d65c 100644 --- a/include/ssn.h +++ b/include/ssn.h @@ -36,8 +36,35 @@ struct ofono_ssn_driver { void (*remove)(struct ofono_ssn *ssn); }; -/* SSN notifications (CSSI and CSSU). */ +/* TS 27.007 Supplementary service notifications +CSSN (CSSI and CSSU) */ +enum ofono_ssn_cssi { + OFONO_SS_MO_UNCONDITIONAL_FORWARDING= 0, + OFONO_SS_MO_CONDITIONAL_FORWARDING = 1, + OFONO_SS_MO_CALL_FORWARDED = 2, + OFONO_SS_MO_CALL_WAITING= 3, + OFONO_SS_MO_CUG_CALL= 4, + OFONO_SS_MO_OUTGOING_BARRING= 5, + OFONO_SS_MO_INCOMING_BARRING= 6, + OFONO_SS_MO_CLIR_SUPPRESSION_REJECTED = 7, + OFONO_SS_MO_CALL_DEFLECTED = 8, +}; + void ofono_ssn_cssi_notify(struct ofono_ssn *ssn, int code, int index); + +enum ofono_ssn_cssu { + OFONO_SS_MT_CALL_FORWARDED = 0, + OFONO_SS_MT_CUG_CALL= 1, + OFONO_SS_MT_VOICECALL_ON_HOLD = 2, + OFONO_SS_MT_VOICECALL_RETRIEVED = 3, + OFONO_SS_MT_MULTIPARTY_VOICECALL= 4, + OFONO_SS_MT_VOICECALL_HOLD_RELEASED = 5, + OFONO_SS_MT_FORWARD_CHECK_SS_MESSAGE= 6, + OFONO_SS_MT_VOICECALL_IN_TRANSFER = 7, + OFONO_SS_MT_VOICECALL_TRANSFERRED = 8, + OFONO_SS_MT_CALL_DEFLECTED = 9, + OFONO_SS_MT_OTHER_CALL_FORWARDED= 10, +}; + void ofono_ssn_cssu_notify(struct ofono_ssn *ssn, int code, int index, const struct ofono_phone_number *number); diff --git a/src/call-barring.c b/src/call-barring.c index f89602e..7a17479 100644 --- a/src/call-barring.c +++ b/src/call-barring.c @@ -1131,11 +1131,11 @@ static void ssn_watch(struct ofono_atom *atom, cb-ssn = __ofono_atom_get_data(atom); cb-incoming_bar_watch = - __ofono_ssn_mo_watch_add(cb-ssn, SS_MO_INCOMING_BARRING, + __ofono_ssn_mo_watch_add(cb-ssn, OFONO_SS_MO_INCOMING_BARRING, call_barring_incoming_enabled_notify, cb, NULL); cb-outgoing_bar_watch = - __ofono_ssn_mo_watch_add(cb-ssn, SS_MO_OUTGOING_BARRING, + __ofono_ssn_mo_watch_add(cb-ssn, OFONO_SS_MO_OUTGOING_BARRING, call_barring_outgoing_enabled_notify, cb, NULL); } diff --git a/src/common.h b/src/common.h index c43e46d..7a148b5 100644 --- a/src/common.h +++ b/src/common.h @@ -89,32 +89,6 @@ enum ss_control_type { SS_CONTROL_TYPE_ERASURE, }; -/* TS 27.007 Supplementary service notifications +CSSN */ -enum ss_cssi { - SS_MO_UNCONDITIONAL_FORWARDING = 0, - SS_MO_CONDITIONAL_FORWARDING= 1, - SS_MO_CALL_FORWARDED= 2, - SS_MO_CALL_WAITING = 3, - SS_MO_CUG_CALL = 4, - SS_MO_OUTGOING_BARRING = 5, - SS_MO_INCOMING_BARRING = 6, - SS_MO_CLIR_SUPPRESSION_REJECTED = 7, - SS_MO_CALL_DEFLECTED= 8, -}; - -enum ss_cssu { - SS_MT_CALL_FORWARDED= 0, - SS_MT_CUG_CALL = 1, - SS_MT_VOICECALL_ON_HOLD = 2, - SS_MT_VOICECALL_RETRIEVED = 3, - SS_MT_MULTIPARTY_VOICECALL = 4, - SS_MT_VOICECALL_HOLD_RELEASED = 5, - SS_MT_FORWARD_CHECK_SS_MESSAGE = 6, - SS_MT_VOICECALL_IN_TRANSFER = 7, - SS_MT_VOICECALL_TRANSFERRED = 8, - SS_MT_CALL_DEFLECTED= 9, -}; - enum pin_type { PIN_TYPE_NONE, PIN_TYPE_PIN, -- 1.7.0.4 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
[PATCH] TODO: long phone numbers
From: Pekka Pessi pekka.pe...@nokia.com --- TODO |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 5589bb1..f963954 100644 --- a/TODO +++ b/TODO @@ -285,6 +285,12 @@ Voicecall Complexity: C1 Owner: Pekka Pessi pekka.pe...@nokia.com +- Long phone numbers. According to 3GPP TS 24.008, the callee address + can be up to 80 digits long. + + Priority: Medium + Complexity: C2 + - Dial strings. Include CLIR prefixes and 2nd stage dial strings in the DialString call property. Add dialstring accessor method to C API. -- 1.7.0.4 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: huawei e1550
Hi Alexander, Alexander A Khryukin alexan...@mezon.ru writes: В Птн, 08/10/2010 в 16:20 +0400, Alexander A Khryukin пишет: Hi all. I have a huawei 1550 GSM-modem. When i plug it to usb [...] Hm, now network visible but when i press Connect ofonod put in log that modem was removed and then process still loopback http://pastie.org/1207567 Sorry, I wasn't able to immeadiately say from the logs what went wrong. Can you get a log which includes AT commands? It would help a lot. Just run this command to get the logs: OFONO_AT_DEBUG=1 /usr/sbin/ofonod -n What's the exact version of ofono you are using? Huawei has had some changes lately. Also is the SIM configured to ask for PIN or not? I'm guessing no from the log, but can't be sure. -- Kalle Valo ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] TODO: long phone numbers
Hi Pekka, TODO |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] TODO: long phone numbers
Hi Pekka, +- Long phone numbers. According to 3GPP TS 24.008, the callee address + can be up to 80 digits long. Is the goal here to only enable this on ATD or are we also talking about using EFext chaining here? Either way, a better description of the task scope might be helpful. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono