Re: [PATCH 3/5 v3] nettime: DBUS and compilation configuration

Hi Marcel, 2011/1/18 Marcel Holtmann mar...@holtmann.org: please don't implement org.ofono interface in timed. Just implement a timed specific (com.nokia.time) interface and punch the whole for that in the timed D-Bus policy. I think there is some disconnect here. The intention is to

[PATCH 2/3] sim: getters for mcc and mnc definition

--- include/sim.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 830322a..81df60e 100644 --- a/include/sim.h +++ b/include/sim.h @@ -178,6 +178,8 @@ void ofono_sim_set_data(struct ofono_sim *sim, void *data); void

Ofono has too tight limits for SIM lock code lengths

Hi, I've been testing SIM locks with Ofono and it looks to me that method is_valid_pin in src/common.c has somewhat too tight rules for PIN lenghts. SIM or subsidy lock codes can be longer than 8 digits (as dictated in 22.022 chapter 14) There are several ways to fix this. My current favourite

[PATCH] voicecall: Fix emergency number handling

If the SIM is present but doesn't contain any emergency numbers, the set of emergency numbers needs to be reset to the default list. This patch fixes the list shown in the SIM present case by removing numbers from the list that are for the no-SIM case only. --- src/voicecall.c | 19

[PATCH 1/6] Distinguish HSUPA and HSDPA

--- src/common.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common.c b/src/common.c index 4d93488..d4e567b 100644 --- a/src/common.c +++ b/src/common.c @@ -702,9 +702,9 @@ const char *registration_tech_to_string(int tech) case

[PATCH 3/6] Declaration for packet switched bearer notifications

--- include/gprs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/gprs.h b/include/gprs.h index ad7925c..157a6f9 100644 --- a/include/gprs.h +++ b/include/gprs.h @@ -59,6 +59,7 @@ void ofono_gprs_status_notify(struct ofono_gprs *gprs, int status); void

[PATCH 4/6] Core support for packet switched bearer reporting

--- src/gprs.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 0e86bdf..7ef81d5 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -67,6 +67,7 @@ struct ofono_gprs { ofono_bool_t suspended; int status;

[PATCH 2/6] Define packet switched bearers

--- src/common.c | 23 +++ src/common.h | 13 + 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/src/common.c b/src/common.c index d4e567b..2dd0da0 100644 --- a/src/common.c +++ b/src/common.c @@ -714,6 +714,29 @@ const char

[PATCH 6/6] atmodem: packet switch bearer support

--- drivers/atmodem/gprs.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c index defb154..daa3933 100644 --- a/drivers/atmodem/gprs.c +++ b/drivers/atmodem/gprs.c @@ -200,6 +200,37 @@ static

[PATCH 5/6] GPRS: document bearer property

--- doc/connman-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/connman-api.txt b/doc/connman-api.txt index 22e02e5..13f622c 100644 --- a/doc/connman-api.txt +++ b/doc/connman-api.txt @@ -77,6 +77,16 @@ Properties boolean Attached [readonly]

DUN client questions

Hi All, I have applied Gustavos patches from 09/11/2010 to the current git version of ofono and besides a problem with the cid range (min = max = 2, but my mobile (Nokia N82) only has one context) I was able to get a connection until the point where the ip and the dns addresses where written to

[PATCH 1/2] Use standard pkginclude directory

automake automatically defines includedir to the base include directory and pkgincludedir to ./@PACKAGE@ from there. So lets use the later one instead of overriding automake. --- Makefile.am |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am

[PATCH v3] bluetooth: Add reference count for bluetooth utils

Add bluetooth_ref()/bluetooth_unref() to support reference count in bluetooth utils. --- plugins/bluetooth.c | 59 ++- 1 files changed, 44 insertions(+), 15 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index

Re: [PATCH 1/2] Use standard pkginclude directory

Hi Remi, automake automatically defines includedir to the base include directory and pkgincludedir to ./@PACKAGE@ from there. So lets use the later one instead of overriding automake. --- Makefile.am |9 - 1 files changed, 4 insertions(+), 5 deletions(-) nice trick. I did not

Re: [PATCH] voicecall: Fix emergency number handling

Self, 2011/1/19 Aki Niemi aki.ni...@nokia.com: @@ -2095,11 +2095,11 @@ static void ecc_g2_read_cb(int ok, int total_length, int record,        DBG(%d, ok);        if (!ok) -               return; +               goto check;        if (total_length 3) {                

[PATCHv2] voicecall: Fix emergency number handling

If the SIM is present but doesn't contain any emergency numbers, the set of emergency numbers needs to be reset to the default list. This patch fixes the list shown in the SIM present case by removing numbers from the list any ENs that are for the no-SIM case only. --- src/voicecall.c |7

Re: [PATCH v3] bluetooth: Add reference count for bluetooth utils

* Frédéric Danis frederic.da...@linux.intel.com [2011-01-19 12:17:51 +0100]: Add bluetooth_ref()/bluetooth_unref() to support reference count in bluetooth utils. --- plugins/bluetooth.c | 59 ++- 1 files changed, 44 insertions(+), 15

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Denis, 2011/1/18 Denis Kenzior denk...@gmail.com: I'm fine with forced-auto, but we might want to add a new error type to ofono.h (maybe something like ManualRegistrationNotAllowed) and return that error when trying to use Scan or NetworkOperator.Register. I was reusing the

[PATCH 2/2] Allow distcheck to work without bluetooth

--- Makefile.am |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index c1c34ca..e93076a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@ DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles +if

[PATCH] huawei: do not set timer more than once

If a ^SYSINFO arrives after the timer for query_sim_locked() has been set up, it'd would set a new timer, signaling a sim state change more than once. --- plugins/huawei.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index

Re: [PATCH 2/2] Allow distcheck to work without bluetooth

Hi Remi, diff --git a/Makefile.am b/Makefile.am index c1c34ca..e93076a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@ DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles +if !BLUETOOTH +DISTCHECK_CONFIGURE_FLAGS +=

Re: [PATCH] huawei: do not set timer more than once

Hi Lucas, If a ^SYSINFO arrives after the timer for query_sim_locked() has been set up, it'd would set a new timer, signaling a sim state change more than once. --- plugins/huawei.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) patch looks fine to me and so I applied it.

Re: [PATCH 2/2] Allow distcheck to work without bluetooth

On Wednesday 19 January 2011 15:20:58 ext Marcel Holtmann, you wrote: diff --git a/Makefile.am b/Makefile.am index c1c34ca..e93076a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@ DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles

Re: [PATCH] huawei: do not set timer more than once

On Wed, Jan 19, 2011 at 11:22 AM, Marcel Holtmann mar...@holtmann.org wrote: Hi Lucas, If a ^SYSINFO arrives after the timer for query_sim_locked() has been set up, it'd would set a new timer, signaling a sim state change more than once. ---  plugins/huawei.c |    3 ++-  1 files changed, 2

Re: [offline-atoms PATCH 1/2] Make gprs atom offline-safe.

Hi Denis, 2011/1/19 Denis Kenzior denk...@gmail.com: +     if (gprs-netreg == NULL) { +             gprs_netreg_removed(gprs); +             return; +     } + I'm having trouble visualizing why this chunk is necessary.  We reset netreg to NULL only when shutting down the atom or when

[PATCH v3 2/2] atmodem: add ifx support for pin retries query

This patch also makes use of the helper function introduce in atutil for parsing the huawei and ifx pin retry count at command result. --- drivers/atmodem/sim.c | 79 +++- 1 files changed, 25 insertions(+), 54 deletions(-) diff --git

[PATCH v3 0/2] add ifx support for querying remaining pin entries

Hi, Following patch adds ifx support for querying remaining pin entries. This patch also introduces a utility function for parsing the pin retry count at command result. Regards, Jeevaka Jeevaka Badrappan (2): atutil: add pin retry count parser function atmodem: add ifx support for pin

[PATCH 2/3] TODO: add GBA_U suite

From: Pekka Pessi pekka.pe...@nokia.com --- TODO |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index af872c5..bc01d90 100644 --- a/TODO +++ b/TODO @@ -116,6 +116,11 @@ SIM / SIM File system Complexity: C4 Owner: Pekka Pessi pekka.pe...@nokia.com

[PATCH 1/3] TODO: add SIM authentication API

From: Pekka Pessi pekka.pe...@nokia.com --- TODO |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index af22844..af872c5 100644 --- a/TODO +++ b/TODO @@ -110,6 +110,13 @@ SIM / SIM File system Complexity: C1 Owner: Aki Niemi aki.ni...@nokia.com

[PATCH] huawei: do not query sim state on pre_sim

Sim state is already known after modem is enabled and there's no need to query it again. Before this patch, query_sim_state() was called upon huawei_enable() and huawei_pre_sim(). Both functions might call notify_sim_state() with a valid state. Hence we could eventually end up sending AT+CFUN=5

Re: [PATCH 2/2] Allow distcheck to work without bluetooth

Hi Remi, diff --git a/Makefile.am b/Makefile.am index c1c34ca..e93076a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -550,6 +550,9 @@ gatchat_test_qcdm_LDADD = @GLIB_LIBS@ DISTCHECK_CONFIGURE_FLAGS = --disable-datafiles +if !BLUETOOTH +DISTCHECK_CONFIGURE_FLAGS +=

Re: [PATCH] huawei: do not query sim state on pre_sim

Hi Lucas, Sim state is already known after modem is enabled and there's no need to query it again. Before this patch, query_sim_state() was called upon huawei_enable() and huawei_pre_sim(). Both functions might call notify_sim_state() with a valid state. Hence we could eventually end up

Re: [PATCH 1/3] TODO: add SIM authentication API

Hi Pekka, TODO |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) all three patches have been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [offline-atoms PATCH 1/2] Make gprs atom offline-safe.

Hi Pekka, On 01/19/2011 07:33 AM, Pekka Pessi wrote: Hi Denis, 2011/1/19 Denis Kenzior denk...@gmail.com: + if (gprs-netreg == NULL) { + gprs_netreg_removed(gprs); + return; + } + I'm having trouble visualizing why this chunk is necessary. We reset

[PATCH v4 0/1] ifx support for querying remaining pin entries

Hi, Following patch adds ifx support for querying remaining pin entries Regards, Jeevaka Jeevaka Badrappan (1): atmodem: add ifx support for pin retry count drivers/atmodem/sim.c | 96 +++-- 1 files changed, 69 insertions(+), 27 deletions(-)

[PATCH v4 1/1] atmodem: add ifx support for pin retry count

--- drivers/atmodem/sim.c | 96 +++-- 1 files changed, 69 insertions(+), 27 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 8d89d53..7617d99 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -56,6 +56,7

[PATCH v4] ifx: Adding modem selftest for Infineon modem

Hi all, This patch summarize changes that triggers Infineon modem selftest during ofono boot. Patch addresses issues raised by Marcel from the privious submissions. Thank you, -- r. --- plugins/ifx.c | 130 1 files changed, 111

[PATCH 1/4] Remove initialisers for enum ofono_atom_type.

They have no effect, enum already ensures the values are unique. --- src/ofono.h | 48 1 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 77567c2..badc2ee 100644 --- a/src/ofono.h +++ b/src/ofono.h @@

[PATCH 1/2] simutil: SIM applications directory decoding utils.

--- src/simutil.c | 57 + src/simutil.h |8 2 files changed, 65 insertions(+), 0 deletions(-) diff --git a/src/simutil.c b/src/simutil.c index 8abf3d5..b3e2f52 100644 --- a/src/simutil.c +++ b/src/simutil.c @@ -1465,3

[PATCH 2/2] unit: Add a test for applications directory decoding utility.

--- unit/test-simutil.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/unit/test-simutil.c b/unit/test-simutil.c index 7cb5c10..1f350f6 100644 --- a/unit/test-simutil.c +++ b/unit/test-simutil.c @@ -444,6 +444,36 @@ static void

[PATCH 3/4] Add the sim-auth atom.

Add dummy SIM authentication atom. --- Makefile.am|2 +- src/ofono.h|2 + src/sim-auth.c | 134 3 files changed, 137 insertions(+), 1 deletions(-) create mode 100644 src/sim-auth.c diff --git a/Makefile.am b/Makefile.am

[PATCH 4/4] atmodem: sim-auth atom driver.

--- Makefile.am|3 +- drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/sim-auth.c | 162 4 files changed, 169 insertions(+), 1 deletions(-) create mode 100644 drivers/atmodem/sim-auth.c

[PATCH 2/4] Add SIM authentication atom's driver definitions.

Structures and function declarations for the SIM authentication atom as proposed by Pekka Pessi, with just one method at the moment. --- Makefile.am|2 +- include/sim-auth.h | 64 2 files changed, 65 insertions(+), 1 deletions(-)

Re: [PATCH v4 1/1] atmodem: add ifx support for pin retry count

Hi Jeevaka, On 01/19/2011 12:34 PM, Jeevaka Badrappan wrote: --- drivers/atmodem/sim.c | 96 +++-- 1 files changed, 69 insertions(+), 27 deletions(-) Patch has been applied, thanks. Regards, -Denis

[PATCH 0/6] Deprecate the Deregister() method

Hi All, This set of patches removes the Deregister() method from the netreg atom. This method serves no purpose, since the Online property is used to control oFono's radio on/off state. Cheers, Aki ___ ofono mailing list ofono@ofono.org

[PATCH 2/6] isimodem: Remove deregister implementation

--- drivers/isimodem/network-registration.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/isimodem/network-registration.c b/drivers/isimodem/network-registration.c index 47aaeb1..6518968 100644 --- a/drivers/isimodem/network-registration.c +++

[PATCH 1/6] netreg: Deprecate the deregister method

--- src/network.c | 37 ++--- 1 files changed, 2 insertions(+), 35 deletions(-) diff --git a/src/network.c b/src/network.c index ae0f334..1f66f34 100644 --- a/src/network.c +++ b/src/network.c @@ -43,8 +43,6 @@ enum network_registration_mode {

[PATCH 4/6] api: Remove deregister from modem driver API

--- include/netreg.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/netreg.h b/include/netreg.h index a88301d..26a3442 100644 --- a/include/netreg.h +++ b/include/netreg.h @@ -84,8 +84,6 @@ struct ofono_netreg_driver { void (*register_manual)(struct

[PATCH 3/6] atmodem: Remove deregister implementation

--- drivers/atmodem/network-registration.c | 20 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c index e11c974..4b8cc34 100644 --- a/drivers/atmodem/network-registration.c +++

[PATCH 6/6] test: Remove deregister support from test script

--- test/test-network-registration |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/test/test-network-registration b/test/test-network-registration index a8bd141..0c25885 100755 --- a/test/test-network-registration +++ b/test/test-network-registration @@ -18,8 +18,6

[PATCH 5/6] doc: Remove deregister method documentation

--- doc/network-api.txt |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/doc/network-api.txt b/doc/network-api.txt index 3e705e6..75187cd 100644 --- a/doc/network-api.txt +++ b/doc/network-api.txt @@ -30,12 +30,6 @@ Methods dict GetProperties()

Re: [PATCH v4] ifx: Adding modem selftest for Infineon modem

Hi Robertino, This patch summarize changes that triggers Infineon modem selftest during ofono boot. Patch addresses issues raised by Marcel from the privious submissions. Thank you, -- r. so git works the way that it takes the subject of the email and the body as commit messages. So you

[PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package

From: Martin Xu martin...@intel.com Using my Huawei EM770W modem, if set ACCM as 0x, RXJ- event breaks PPP link, after IP package transmit for a while. Using default ACCM, the issue can be fixed. I tested it at China Unicom networks. --- gatchat/ppp_lcp.c |9 ++--- 1 files

[PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue

From: Martin Xu martin...@intel.com Tramsmit ACCM and receive ACCM is mixed up. According to RFC1662 Section 7.1, ACCM Configuration Option is used to inform the peer which control characters MUST remain mapped when the peer sends them. --- gatchat/ppp_lcp.c | 16 ++-- 1 files

[PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

From: Martin Xu martin...@intel.com Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP connection can't work --- plugins/ofono.rules |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index 111f071..7dec243 100644