[PATCH] isiusb: add message-waiting

2011-03-03 Thread Jukka Saunamaki
--- plugins/isiusb.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/plugins/isiusb.c b/plugins/isiusb.c index c036604..cf31756 100644 --- a/plugins/isiusb.c +++ b/plugins/isiusb.c @@ -54,6 +54,7 @@ #include ofono/radio-settings.h #include ofono/gprs.h #include

[PATCH v2] ste: Add support for multiple AT channels

2011-03-03 Thread Lasse Kunnasluoto
--- Hi, Updated according to valuable comments from Denis. BR, Lasse plugins/ste.c | 145 - 1 files changed, 92 insertions(+), 53 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index b786571..488a3e2 100644 --- a/plugins/ste.c

[PATCH] ste: enable multiple oFono runs without restarting the oFono

2011-03-03 Thread Jussi Kangas
--- Hi, This enables SIM detection in workstation after disabling and enabling the modem without rebooting the oFono. Br, Jussi plugins/ste.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index b786571..d2a6cc1 100644 ---

Re: [RFCv3] doc: Proposal for LTE/IMS API

2011-03-03 Thread Arun Ravindran
Hi Sjur, I have a doubt on this interface + void Register(array{string} types) + + Registers an IMS Application. It must register + with at least one of the types: voice or messaging. + In future video

Re: [PATCH v2 09/18] isimodem: clip colp clir colr wgmodem2.5

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call-settings.c |  711 +-  drivers/isimodem/call.h          |    9 +  drivers/isimodem/debug.c         |    4 +  

Re: [PATCH v2 10/18] isimodem: wgmodem2.5 added to voicecall

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call.h      |   82 -  drivers/isimodem/voicecall.c |  218 +-  2 files changed, 253

Re: [PATCH v2 12/18] isimodem: SS_GSM_BARRING_INFO added

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com SS_GSM_BSC_INFO added. ---  drivers/isimodem/call-barring.c |   99 ++  1 files changed, 88 insertions(+), 11 deletions(-) Patch was

Re: [PATCH v2 14/18] isimodem: wgmodem2.5 added to ssn

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call-forwarding.c |    1 -  drivers/isimodem/ssn.c             |  406 +++-  2 files changed, 401 insertions(+), 6

Re: [PATCH v2 13/18] isimodem: wgmodem2.5 added to call-forwarding

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin andreas.wes...@stericsson.com: From: Jessica Nilsson jessica.j.nils...@stericsson.com ---  drivers/isimodem/call-forwarding.c |   29 +  1 files changed, 25 insertions(+), 4 deletions(-) Patch has been applied. Some refactoring after

[PATCH 0/3] Voice call SS notifications (3rd version)

2011-03-03 Thread Andras Domokos
Implementation proposal for handling some of the voice call related Supplementary Services (SS) notifications. Implementation details: - removed SSN atom - (re)implemented voice call SS notification handling framework - added voice call SS notification handling to AT modem driver (+CSSU and

[RFC PATCH 1/3] ssn: remove SSN atom completely

2011-03-03 Thread Andras Domokos
--- Makefile.am |6 +- drivers/atmodem/atmodem.c |2 - drivers/atmodem/atmodem.h |3 - drivers/atmodem/ssn.c | 147 - drivers/isimodem/isimodem.c |2 - drivers/isimodem/isimodem.h |3 - drivers/isimodem/ssn.c | 95

[RFC PATCH 2/3] voicecall: add SSN handling functions

2011-03-03 Thread Andras Domokos
--- include/types.h |2 + include/voicecall.h |6 ++ src/voicecall.c | 156 +++ 3 files changed, 164 insertions(+), 0 deletions(-) diff --git a/include/types.h b/include/types.h index d25f409..b639c8a 100644 --- a/include/types.h

[RFC PATCH 3/3] atmodem: add SSN handling

2011-03-03 Thread Andras Domokos
--- drivers/atmodem/voicecall.c | 61 +++ 1 files changed, 61 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index ee055da..7d70c85 100644 --- a/drivers/atmodem/voicecall.c +++

Re: [PATCH] gisi: Consumer functions for ISI message iterator

2011-03-03 Thread Aki Niemi
Hi Antti, 2011/3/3 Antti Paila antti.pa...@nokia.com: snip  struct _GIsiSubBlockIter { +       uint8_t cursor;        uint8_t *start;        uint8_t *end;        gboolean longhdr; The cursor actually needs to be 16 bits, because when the long header format is in use, that is what subblock

[PATCH] mbmmodem: don't let chat open after fd is sent

2011-03-03 Thread Lucas De Marchi
Instead of using a GAtChat, just use a GIOChannel and close it as soon as its fd is sent to core. Moreover, when oFono exits it's just a matter of checking if there's an idle callback scheduled to control if we need to close the GIOChannel. --- Hi Denis, Following patch implements what the

Re: [PATCH] isiusb: add message-waiting

2011-03-03 Thread Aki Niemi
Hi Jukka, 2011/3/3 Jukka Saunamaki jukka.saunam...@nokia.com: ---  plugins/isiusb.c |    5 +  1 files changed, 5 insertions(+), 0 deletions(-) Pushed, thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org

Re: [PATCH] mbmmodem: don't let chat open after fd is sent

2011-03-03 Thread Marcel Holtmann
Hi Lucas, struct gps_data { GAtChat *chat; - GAtChat *data_chat; + + struct { + GIOChannel *channel; + guint idle_source; + gsize written; + ofono_location_reporting_enable_cb_t cb; + void *cb_data; + }

Re: [PATCH] mbmmodem: don't let chat open after fd is sent

2011-03-03 Thread Lucas De Marchi
On Thu, Mar 3, 2011 at 2:21 PM, Marcel Holtmann mar...@holtmann.org wrote: Hi Lucas,  struct gps_data {       GAtChat *chat; -     GAtChat *data_chat; + +     struct { +             GIOChannel *channel; +             guint idle_source; +             gsize written; +            

Re: [PATCH] mbmmodem: don't let chat open after fd is sent

2011-03-03 Thread Marcel Holtmann
Hi Lucas, struct gps_data { GAtChat *chat; - GAtChat *data_chat; + + struct { + GIOChannel *channel; + guint idle_source; + gsize written; + ofono_location_reporting_enable_cb_t cb; + void *cb_data; +

Re: [PATCH v2] ste: Add support for multiple AT channels

2011-03-03 Thread Denis Kenzior
Hi Lasse, On 03/03/2011 05:21 AM, Lasse Kunnasluoto wrote: --- Hi, Updated according to valuable comments from Denis. BR, Lasse plugins/ste.c | 145 - 1 files changed, 92 insertions(+), 53 deletions(-) Patch has been

Re: [PATCH] ste: enable multiple oFono runs without restarting the oFono

2011-03-03 Thread Denis Kenzior
Hi Jussi, On 03/03/2011 05:45 AM, Jussi Kangas wrote: --- Hi, This enables SIM detection in workstation after disabling and enabling the modem without rebooting the oFono. Br, Jussi plugins/ste.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Patch has been

Re: [RFC PATCH 1/3] ssn: remove SSN atom completely

2011-03-03 Thread Denis Kenzior
Hi Andras, On 03/03/2011 10:48 AM, Andras Domokos wrote: --- Makefile.am |6 +- drivers/atmodem/atmodem.c |2 - drivers/atmodem/atmodem.h |3 - drivers/atmodem/ssn.c | 147 - drivers/isimodem/isimodem.c |2 -

Re: [RFC PATCH 2/3] voicecall: add SSN handling functions

2011-03-03 Thread Denis Kenzior
Hi Andras, On 03/03/2011 10:48 AM, Andras Domokos wrote: --- include/types.h |2 + include/voicecall.h |6 ++ src/voicecall.c | 156 +++ 3 files changed, 164 insertions(+), 0 deletions(-) Please make sure to split this

Re: [PATCH 3/5] cell-info: Atom for neighbor cell info

2011-03-03 Thread Aki Niemi
Hi Antti, 2011/2/14 Antti Paila antti.pa...@nokia.com: ---  src/cell-info.c |  475 +++  1 files changed, 475 insertions(+), 0 deletions(-)  create mode 100644 src/cell-info.c diff --git a/src/cell-info.c b/src/cell-info.c new file mode

[PATCH] mbmmodem: don't let chat open after fd is sent

2011-03-03 Thread Lucas De Marchi
Instead of using a GAtChat, just use a GIOChannel and close it as soon as its fd is sent to core. --- drivers/mbmmodem/location-reporting.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c

Re: [PATCH] mbmmodem: don't let chat open after fd is sent

2011-03-03 Thread Denis Kenzior
Hi Lucas, On 03/03/2011 04:23 PM, Lucas De Marchi wrote: Instead of using a GAtChat, just use a GIOChannel and close it as soon as its fd is sent to core. --- drivers/mbmmodem/location-reporting.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-)

RE: patch to fix BMC #13679 Huawei EM770: ofonod crash when disable/enable 3G technology

2011-03-03 Thread Xu, Martin
Hi Denis: struct ofono_gprs *gprs; struct ofono_gprs_context *gc; gboolean voice; + gboolean online; I don't think you really need this one, you can use the presence of gprs atom instead. Gprs atom is not reliable here. Because gprs will be flushed when entering offline

[PATCH] Fix huawei_disconnect function issue

2011-03-03 Thread martin . xu
From: Martin Xu martin...@intel.com huawei_disconnect is used to recovery the io and gprs context when io error happends, see commit 39382730d7758b093ca6271f4e9dea875fa04b3a However, io error not only happends at PPP disconnect, in theory it can happends at any situation. I also observed that it