[PATCH] common: Fix parsing SS control string

It's not possible to be both greater than '9' and less than '0'. This would lead to accepting things like "#$33#" as activation and "*$33#" as deactivation, even though the string makes no sense. --- src/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common.c b/sr

Re: [PATCH] common: Fix parsing SS control string

On Wed, May 22, 2013 at 6:28 PM, Lucas De Marchi wrote: > It's not possible to be both greater than '9' and less than '0'. This > would lead to accepting things like "#$33#" as activation and "*$33#" as > deactivation, even though the string makes no sense. > --- > src/common.c | 2 +- > 1 file c

[PATCH 2/2] gitignore: Ignore file generated by Automake 1.13

Automake >= 1.13 enables parallel-tests option by default which uses a test-driver script (copied by automake). Ignore this file and the files generated by this script. --- .gitignore | 4 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 91668c7..b9c23a0 100644 ---

[PATCH 1/2] stk: Fix sizeof on memcpy

src/stk.c: In function ‘__ofono_cbs_sim_download’: src/stk.c:283:45: error: argument to ‘sizeof’ in ‘memcpy’ call is the same expression as the source; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess] memcpy(&e.cbs_pp_download.page, msg, sizeof(msg));

Re: [PATCH 1/2] stk: Fix sizeof on memcpy

Hi Lucas, On 05/22/2013 06:01 PM, Lucas De Marchi wrote: src/stk.c: In function ‘__ofono_cbs_sim_download’: src/stk.c:283:45: error: argument to ‘sizeof’ in ‘memcpy’ call is the same expression as the source; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess] memcpy(&e.cbs_pp_

Re: [PATCH 2/2] gitignore: Ignore file generated by Automake 1.13

Hi Lucas, On 05/22/2013 06:01 PM, Lucas De Marchi wrote: Automake >= 1.13 enables parallel-tests option by default which uses a test-driver script (copied by automake). Ignore this file and the files generated by this script. --- .gitignore | 4 1 file changed, 4 insertions(+) Patch h

Re: [PATCH] common: Fix parsing SS control string

Hi Lucas, On 05/22/2013 04:28 PM, Lucas De Marchi wrote: It's not possible to be both greater than '9' and less than '0'. This would lead to accepting things like "#$33#" as activation and "*$33#" as deactivation, even though the string makes no sense. --- src/common.c | 2 +- 1 file changed,