Re: [RFC 3/3] build: Add Gemalto plugin in Makefile

2017-01-13 Thread Denis Kenzior
Hi Vincent, On 01/12/2017 11:06 AM, Vincent Cesson wrote: From: vcesson --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) Please squash this patch into patch 1/3. Since that patch adds the a new .c file to plugins/ it should also add it to the build

Re: [RFC 1/3] plugins: Add Gemalto plugin for Cinterion P-family

2017-01-13 Thread Denis Kenzior
Hi Vincent, On 01/12/2017 11:06 AM, Vincent Cesson wrote: From: vcesson Please update your Author info. Actual cinterion plugin is not compliant with newer Gemalto modems. Gemalto plugin is based on cinterion with a custom struct to handle the interfaces

Re: [RFC 2/3] udevng: Add Gemalto P-family detection

2017-01-13 Thread Denis Kenzior
On 01/12/2017 11:06 AM, Vincent Cesson wrote: From: vcesson Please update your Author info. Add a new function setup, based on telit, to handle Gemalto P-family discovery. The setup look for USB interfaces: application=/dev/ttyUSB2 gps=/dev/ttyUSB1

Re: [PATCH 1/1] qmimodem: query_passwd_state can be retried

2017-01-13 Thread Denis Kenzior
Hi Christophe, All of the patch looks fine, except: @@ -436,16 +458,36 @@ static void query_passwd_state_cb(struct qmi_result *result, { struct cb_data *cbd = user_data; ofono_sim_passwd_cb_t cb = cbd->cb; + struct ofono_sim *sim = cbd->user; + struct sim_data

Re: Regarding multiple APN support in ofono/connman

2017-01-13 Thread Daniel Wagner
Hi Denis, On 01/12/2017 12:26 AM, Denis Kenzior wrote: > On 01/11/2017 01:39 PM, Naveen Kumar Danturi wrote: >> Hi Ofono team, >> Is there a support in ofono for multiple PDN connections in parallel ? >> If so what interfaces/API's it exposes to connman to manage multiple >> APN's ? If so, I have

[PATCH 1/1] atmodem: Fix CGDCONT result parsing.

2017-01-13 Thread Vincent Cesson
CGDCONT result parsing fails if first list contains several ranges. For example with modem Cinterion PHS8: AT+CGDCONT=? +CGDCONT: (1-17,101-116),"IP",,,(0),(0-4) Solution: read first range and jump to second list instead of trying to close the brackets. --- drivers/atmodem/gprs.c | 2 +- 1

Re: [PATCH 1/1] atmodem: Fix CGDCONT result parsing.

2017-01-13 Thread Denis Kenzior
Hi Vincent, On 01/13/2017 07:27 AM, Vincent Cesson wrote: CGDCONT result parsing fails if first list contains several ranges. For example with modem Cinterion PHS8: AT+CGDCONT=? +CGDCONT: (1-17,101-116),"IP",,,(0),(0-4) Solution: read first range and jump to second list instead of trying to