Re: [PATCH 09/10] quectel: add basic support for serial connected modems

2019-07-09 Thread Denis Kenzior

Hi Martin,

On 07/09/2019 01:50 AM, Martin Hundebøll wrote:

Hi Denis,

On 08/07/2019 18.12, Denis Kenzior wrote:
However, there is still the fundamental issue of not being able to 
correlate the created ttys to the original one...  If we can fix that 
in the kernel, then a strong argument can be made to drop GAtMux 
entirely. Which is actually what I would prefer as it would make 
conversion to ell much easier.


Let's see how it goes:
https://lore.kernel.org/patchwork/patch/1098922/


That looks quite reasonable, so hopefully it gets picked up soon.



It won't make it in until v5.4, so either we support both n_gsm and 
gatmux, or we fall back to /dev/gsmtty1 as base if GSMIOC_GETBASE isn't 
defined.


Nah, I don't think there is a need to support both if everyone is happy 
to use the kernel multiplexer.  Can we come up with some common place 
where to put the kernel multiplexer setup?  This is something that will 
be relevant to more than quectel driver...


Something like atutil? .. Or maybe even ell?  E.g. we need an equivalent 
of g_at_mux_setup_gsm0710() and perhaps something that would open all 
the DLCs requested?


E.g. something like:

mux_setup(GAtChat *master, n_dlcs, callback, userdata, destroy);

callback(size_t n_dlcs, GAtChat *dlcs, userdata)

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono


Re: [PATCH 09/10] quectel: add basic support for serial connected modems

2019-07-09 Thread Martin Hundebøll

Hi Denis,

On 08/07/2019 18.12, Denis Kenzior wrote:
However, there is still the fundamental issue of not being able to 
correlate the created ttys to the original one...  If we can fix that in 
the kernel, then a strong argument can be made to drop GAtMux entirely. 
Which is actually what I would prefer as it would make conversion to ell 
much easier.


Let's see how it goes:
https://lore.kernel.org/patchwork/patch/1098922/

It won't make it in until v5.4, so either we support both n_gsm and 
gatmux, or we fall back to /dev/gsmtty1 as base if GSMIOC_GETBASE isn't 
defined.


// Martin
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono