Re: [PATCH] Fix: simplify isimodem call-barring driver.

ti, 2010-03-23 kello 22:53 +0100, ext Denis Kenzior kirjoitti: Secondly, please keep your patches whitespace clean, there are several cases of spaces being used instead of tabs for indentation. Pekka is an emacs guy, and emacs likes syntactic indentation a lot. I'm using this custom mode with

[PATCH 3/6] Unify some macro names of ber-tlv and comprehension tlv

--- src/stkutil.h | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index 4b7c382..5724d29 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -54,7 +54,7 @@ enum stk_command_type { STK_COMMAND_TYPE_GET_INPUT =

[PATCH 4/6] Add macro name of comprehension tlv cdma sms tpdu

--- src/stkutil.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index 5724d29..d2cbee0 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -151,6 +151,7 @@ enum stk_data_object_type { STK_DATA_OBJECT_TYPE_SERVICE_AVAILABILITY =

[PATCH 6/6] Add parser for help request objects

--- src/stkutil.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 3e423b5..215013d 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -50,6 +50,23 @@ struct gsm_sms_tpdu { unsigned char tpdu[164]; };

[PATCH 5/6] Add parser for imei objects

--- src/stkutil.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index a6b0284..3e423b5 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -549,6 +549,28 @@ static gboolean parse_dataobj_location_info( return

[PATCH 1/3] fix memory leaks in option handling

free the data as well as the link when deleting options lists. --- gatchat/ppp_cp.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c index e8d6e30..0f04fa1 100644 --- a/gatchat/ppp_cp.c +++ b/gatchat/ppp_cp.c @@ -201,6

[PATCH 0/3] fix memory leaks in PPP

Fix a few memory leaks in PPP Kristen Carlson Accardi (3): fix memory leaks in option handling fix memory leaks after ppp_transmit fix memory leak in ppp_auth gatchat/ppp_auth.c |1 + gatchat/ppp_cp.c | 51 +-- 2 files changed, 42

Re: [PATCH 2/6] Add macro for ber-tlv more time

Hi Yang, --- src/stkutil.h |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 4/6] Add macro name of comprehension tlv cdma sms tpdu

Hi Yang, --- src/stkutil.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 5/6] Add parser for imei objects

Hi Yang, --- src/stkutil.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index a6b0284..3e423b5 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -549,6 +549,28 @@ static gboolean

Re: [PATCH 6/6] Add parser for help request objects

Hi Yang, --- src/stkutil.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 3e423b5..215013d 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -50,6 +50,23 @@ struct gsm_sms_tpdu { unsigned

Re: [PATCH 0/3] fix memory leaks in PPP

Hi Kristen, Fix a few memory leaks in PPP Kristen Carlson Accardi (3): fix memory leaks in option handling fix memory leaks after ppp_transmit fix memory leak in ppp_auth gatchat/ppp_auth.c |1 + gatchat/ppp_cp.c | 51 +--

Issue with PPP auth and empty username/password

Hi Kristen, I started tested the PPP code and run into a simple crash when not providing username and password. This should be possible. Program terminated with signal 11, Segmentation fault. #0 0x003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6 (gdb) bt #0 0x003457e7f2f2 in

Quick report from PPP testing

Hi Kristen, so I just downloaded the Linux kernel via the PPP connection with my Rogers' Novatel UMTS stick. : \r\n+CGREG: 2,1,FE38,EBA6\r\n\r\nOK\r\n Registered to GPRS network, roaming=False : ATD*99***1#\r : \r\nCONNECT HSDPA 7.2\r\n oops -- found acked option 2 we didn't request Unknown

[PATCH 0/2] fix PPP timer issues

These patches fix a few problems with the way timeouts are handled in PPP. Kristen Carlson Accardi (2): switch to g_timeout_add_seconds() use separate timers for PPP config and terminate gatchat/ppp_cp.c | 103 - gatchat/ppp_cp.h | 15

[PATCH 1/2] switch to g_timeout_add_seconds()

we don't care that much about the exactness of our timer, so use the more power efficient call. --- gatchat/ppp_cp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c index 3132af5..de72066 100644 --- a/gatchat/ppp_cp.c +++

[PATCH 2/2] use separate timers for PPP config and terminate

Prevent conflicts between config timer information and terminate timer information by providing a new data structure which keeps timer information for config and terminate requests separate. --- gatchat/ppp_cp.c | 101 - gatchat/ppp_cp.h | 15

[PATCH 1/4] remove unneeded debug statement

cleanup old debug print statement --- gatchat/ppp.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/gatchat/ppp.c b/gatchat/ppp.c index 4612976..f3bfba7 100644 --- a/gatchat/ppp.c +++ b/gatchat/ppp.c @@ -328,10 +328,8 @@ gboolean ppp_cb(GIOChannel *channel,

[PATCH 0/4] add PPP_DEAD and PPP_TERMINATE support

These patches complete implementation of the PPP_DEAD and PPP_TERMINATE phases, as well as allow this to be tested via gsmdial. Kristen Carlson Accardi (4): remove unneeded debug statement add tracing for PPP terminate path separate memory cleanup from PPP shutdown gsmdial: shutdown ppp

[PATCH 2/4] add tracing for PPP terminate path

Insert some calls to pppcp_trace() for future debugging needs. --- gatchat/ppp_cp.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c index 4cc6c13..df14a33 100644 --- a/gatchat/ppp_cp.c +++ b/gatchat/ppp_cp.c @@ -399,6 +399,8

[PATCH 3/4] separate memory cleanup from PPP shutdown

don't free memory at PPP shutdown, because we need to be able to send terminate traffic. Free memory when we have reached the PPP_DEAD phase instead. --- gatchat/gatppp.c | 25 +++-- gatchat/ppp.c| 23 ++- 2 files changed, 29 insertions(+), 19

[PATCH 4/4] gsmdial: shutdown ppp link if we have one.

If we have created a ppp link, shut it down when the signal handler is called. --- gatchat/gsmdial.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/gatchat/gsmdial.c b/gatchat/gsmdial.c index aee9eea..a18f486 100644 --- a/gatchat/gsmdial.c +++ b/gatchat/gsmdial.c @@