[PATCH 3/9] stk: Handle the More Time command as a nop.

2010-06-29 Thread Andrzej Zaborowski
--- src/stk.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index e513b06..4edf05b 100644 --- a/src/stk.c +++ b/src/stk.c @@ -154,6 +154,15 @@ void ofono_stk_proactive_command_cancel(struct ofono_stk *stk) stk->cancel_cmd(stk);

[PATCH 9/9] stk: Handle the Display Text command.

2010-06-29 Thread Andrzej Zaborowski
--- src/stk.c | 108 + 1 files changed, 108 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index fd6dcb0..ff47649 100644 --- a/src/stk.c +++ b/src/stk.c @@ -63,6 +63,7 @@ enum stk_agent_state { STK_AGENT_IDLE =

[PATCH 8/9] stk: Handle Select Item and Set Up Menu commands.

2010-06-29 Thread Andrzej Zaborowski
--- src/stk.c | 261 + 1 files changed, 261 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index 9136732..fd6dcb0 100644 --- a/src/stk.c +++ b/src/stk.c @@ -61,6 +61,8 @@ struct stk_app_agent { enum stk_agent_state

[PATCH 7/9] stk: Add menu related utilities.

2010-06-29 Thread Andrzej Zaborowski
--- src/stk.c | 92 + 1 files changed, 92 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index e24897f..9136732 100644 --- a/src/stk.c +++ b/src/stk.c @@ -40,6 +40,17 @@ static GSList *g_drivers = NULL; +struct s

[PATCH 6/9] Add SimToolkit and SimApplicationAgent interfaces.

2010-06-29 Thread Andrzej Zaborowski
The interface is as outlined in http://lists.ofono.org/pipermail/ofono/2010-June/003040.html This patch adds a skeleton that command implementations will use. --- include/dbus.h |2 + src/stk.c | 468 +++- 2 files changed, 465 insertion

[PATCH 5/9] stk: Handle ENVELOPEs in a queue, retry on sim busy.

2010-06-29 Thread Andrzej Zaborowski
Some envelope types should be retried when sim reports busy status. Envelopes such as Event Download need to be returned in the order of the event occurences, so need to be handled in a queue. --- src/stk.c | 110 +--- 1 files changed, 90 in

[PATCH 4/9] Make sim operations return sim error codes to core.

2010-06-29 Thread Andrzej Zaborowski
--- drivers/atmodem/stk.c | 20 include/types.h |1 + 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/atmodem/stk.c b/drivers/atmodem/stk.c index 8cff4a2..aede668 100644 --- a/drivers/atmodem/stk.c +++ b/drivers/atmodem/stk.c @@ -74,11 +74,1

[PATCH 1/9] stk: Utilities for proactive command/envelope handling

2010-06-29 Thread Andrzej Zaborowski
--- include/stk.h |2 + src/stk.c | 144 ++--- 2 files changed, 129 insertions(+), 17 deletions(-) diff --git a/include/stk.h b/include/stk.h index ad3f6c5..4e5d01e 100644 --- a/include/stk.h +++ b/include/stk.h @@ -65,6 +65,8 @@ void *

[PATCH 2/9] mbmmodem: Cancel running command on *STKEND.

2010-06-29 Thread Andrzej Zaborowski
--- drivers/mbmmodem/stk.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/mbmmodem/stk.c b/drivers/mbmmodem/stk.c index 77bd7b5..53b5adf 100644 --- a/drivers/mbmmodem/stk.c +++ b/drivers/mbmmodem/stk.c @@ -179,6 +179,14 @@ static void stkn_notify(GAtResult

Re: [PATCH 1/2] huawei: reopen the GPRS context when the modem closes it after PPP

2010-06-29 Thread Denis Kenzior
Hi Kalle, > Huawei always closes the tty port after PPP disconnect. Handle this in > huawei plugin, similarly as done with novatel. Now there's no need > to unplug the modem after disconnection. > > Tested with Huawei E1552. > > Based on a patch by Marcel Holtmann: > > commit 0329a6ceaf8f69857c

Re: [PATCH] atmodem: Don't unregister *EPEV in *EPEV handler.

2010-06-29 Thread Denis Kenzior
Hi Andrew, > Handlers are called when looping over the unsolicited responses hash, > registering or unregistering modifies that hash and confuses glib. > --- Good catch. Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://li

[PATCH 1/3] stkutil: display text attributes as html

2010-06-29 Thread Kristen Carlson Accardi
--- src/stkutil.c | 190 + src/stkutil.h | 23 +++ 2 files changed, 213 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 6f072e7..843e06b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -5819,3 +5819,19

[PATCH 3/3] test-stkutil: add html attribute test for Display Text tests

2010-06-29 Thread Kristen Carlson Accardi
--- unit/test-stkutil.c | 204 +++ 1 files changed, 204 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 57e894b..bc0e018 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -524,6 +524,7 @@ struc

[PATCH 2/3] test-stkutil: add unit test for html text attributes

2010-06-29 Thread Kristen Carlson Accardi
--- unit/test-stkutil.c | 76 +++ 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 8b7e254..57e894b 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -472,6 +472,22 @@ stati

[PATCH 0/3] html text attribute patches

2010-06-29 Thread Kristen Carlson Accardi
Modified stkutil per last review. Added unit tests for Display Text tests. I will add the rest of the unit tests after this patch series is reviewed. Kristen Carlson Accardi (3): stkutil: display text attributes as html test-stkutil: add unit test for html text attributes test-stkutil: add

Re: [PATCH] mbm: use CPIN? to check if SIM is missing

2010-06-29 Thread Denis Kenzior
Hi Pekka, > AT+CRSM=242 is not supported by all mbm models. > --- > plugins/mbm.c | 28 ++-- > 1 files changed, 6 insertions(+), 22 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofo

Re: [PATCH 1/2] Documented Present property in sim-api.txt.

2010-06-29 Thread Denis Kenzior
Hi Pekka, > --- > doc/sim-api.txt | 15 ++- > 1 files changed, 10 insertions(+), 5 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] atmodem: Don't unregister *EPEV in *EPEV handler.

2010-06-29 Thread Andrzej Zaborowski
Handlers are called when looping over the unsolicited responses hash, registering or unregistering modifies that hash and confuses glib. --- drivers/atmodem/sim.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/

Crash in at_gprs_context_remove()

2010-06-29 Thread Kalle Valo
Hi, I was testing my huawei disconnect patch on top of commit ca41d63a305c. Basically I was just connecting and disconnecting in a row from connman and ofono crashed: Entering new phase: 0 ofonod[2365]: drivers/atmodem/gprs-context.c:ppp_disconnect() ofonod[2365]: Pcui:< \r\n^BOOT:38645652,0,0,0

Re: [PATCH 2/2] mbm: use cpin? to check if SIM is missing

2010-06-29 Thread Pekka Pessi
2010/6/28 Andrzej Zaborowski : > On 28 June 2010 20:20, Pekka Pessi wrote: >> Use AT+CPIN? in case AT+CRSM=242 is not supported. > > On the model where AT+CRSM works, AT+CPIN also works, so I propose to > use it always.  The firmware may cache information but when card is > extracted it notices.

[PATCH] mbm: use CPIN? to check if SIM is missing

2010-06-29 Thread Pekka Pessi
AT+CRSM=242 is not supported by all mbm models. --- plugins/mbm.c | 28 ++-- 1 files changed, 6 insertions(+), 22 deletions(-) diff --git a/plugins/mbm.c b/plugins/mbm.c index 9193539..864b0df 100644 --- a/plugins/mbm.c +++ b/plugins/mbm.c @@ -48,7 +48,7 @@ #include

[PATCH 2/2] PPP GPRS context is now done, update documentation

2010-06-29 Thread Kalle Valo
--- TODO |7 --- doc/overview.txt |6 -- 2 files changed, 0 insertions(+), 13 deletions(-) diff --git a/TODO b/TODO index a25394a..470d4a6 100644 --- a/TODO +++ b/TODO @@ -200,13 +200,6 @@ Flight Mode GPRS -- PPP gprs-context driver support. Add an implement

[PATCH 1/2] huawei: reopen the GPRS context when the modem closes it after PPP

2010-06-29 Thread Kalle Valo
Huawei always closes the tty port after PPP disconnect. Handle this in huawei plugin, similarly as done with novatel. Now there's no need to unplug the modem after disconnection. Tested with Huawei E1552. Based on a patch by Marcel Holtmann: commit 0329a6ceaf8f69857cb5f8437b9db86ca327ef1d Author

[PATCH 3/3] huawei: Remove call meter support for EM770

2010-06-29 Thread Zhenhua Zhang
EM770W returns "COMMAND NOT SUPPORT" when we send "AT+CCWE=1" to initialize call meter atom. So disable it. --- plugins/huawei.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 0dc6ae4..98ce65b 100644 --- a/plugins/huawei.c +++ b/

[PATCH 2/3] huawei: Add Huawei EM770 modem support

2010-06-29 Thread Zhenhua Zhang
Huawei EM770W is a 3G WCDMA modem that supports HSPA/UMTS/EDGE/GPRS/GSM data service and WCDMA/GSM short message services. It also has voice call capability that supports both 2G and 3G network. --- plugins/huawei.c| 31 ++- plugins/ofono.rules |3 +++ plugins

[PATCH 1/3] huawei: Remove existing Huawei EM770 plugin

2010-06-29 Thread Zhenhua Zhang
--- Makefile.am |3 - plugins/em770.c | 229 --- plugins/ofono.rules |2 - plugins/udev.c | 26 -- 4 files changed, 0 insertions(+), 260 deletions(-) delete mode 100644 plugins/em770.c diff --git a/Makefile.am b/Make

[PATCH 0/3] Merge Huawei EM770 into plugins/huawei.c

2010-06-29 Thread Zhenhua Zhang
This series merges existing plugins/em770.c with plugins/huawei.c. The most part of EM770 is the same as plugins/huawei.c, except EM770 has voicecall capability. The idea is to get modem model from udev. If it is EM770, we enable voicecall and related features for EM770 only. Best Regards, Zhen