[PATCH] test-server: Use cfmakeraw to set TTY raw mode

2010-07-06 Thread Zhenhua Zhang
Use cfmakeraw to disable echoing and special characters processing. If we don't turn off ICRNL, TTY layer translates \r\n to \n\n. --- gatchat/test-server.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/gatchat/test-server.c b/gatchat/test-server.c index

RE: Modem emulator and DUN server side for oFono and BlueZ

2010-07-06 Thread Zhang, Zhenhua
Hi Suraj, suraj wrote: Hi Zhenhua, On Wed, 2010-05-05 at 06:27 +0530, Zhang, Zhenhua wrote: Hi Padovan, Gustavo F. Padovan wrote: Hi Zhenhua, * Zhang, Zhenhua zhenhua.zh...@intel.com [2010-04-27 15:53:54 +0800]: Hi, I am now working on modem emulator and one usage is for DUN

[PATCH 2/2] gathdlc: Unset disconnect function in unref

2010-07-06 Thread Zhenhua Zhang
If we destroy PPP instance from g_at_ppp_unref, we should not invoke io disconnect function. --- gatchat/gathdlc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gatchat/gathdlc.c b/gatchat/gathdlc.c index 08a1939..0186e46 100644 --- a/gatchat/gathdlc.c +++

[PATCH 1/2] gatppp: Check ppp instance before unref it

2010-07-06 Thread Zhenhua Zhang
--- gatchat/gatppp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c index 1d41ded..d9b1627 100644 --- a/gatchat/gatppp.c +++ b/gatchat/gatppp.c @@ -446,6 +446,9 @@ void g_at_ppp_unref(GAtPPP *ppp) { gboolean is_zero; +

Atmodem PPP Link establishment issues

2010-07-06 Thread Arun.Ravindran
Hi, We are using atmodem plugin and are trying to get the PPP up and running. I am able to create and activate context, but the PPP link establishment seems to have issues. The list-context script returns: [ /generic ] [ /generic/primarycontext3 ] Username =

Re: Atmodem PPP Link establishment issues

2010-07-06 Thread Marcel Holtmann
Hi Arun, please try to compose proper emails and not just forward or reply to your own message to send it again. We are using atmodem plugin and are trying to get the PPP up and running. I am able to create and activate context, but the PPP link establishment seems to have issues. The

Re: [PATCH 1/2] gatppp: Check ppp instance before unref it

2010-07-06 Thread Marcel Holtmann
Hi Zhenhua, --- gatchat/gatppp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c index 1d41ded..d9b1627 100644 --- a/gatchat/gatppp.c +++ b/gatchat/gatppp.c @@ -446,6 +446,9 @@ void g_at_ppp_unref(GAtPPP *ppp) {

Re: [PATCH] test-server: Use cfmakeraw to set TTY raw mode

2010-07-06 Thread Marcel Holtmann
Hi Zhenhua, Use cfmakeraw to disable echoing and special characters processing. If we don't turn off ICRNL, TTY layer translates \r\n to \n\n. --- gatchat/test-server.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/gatchat/test-server.c

Re: Question about set modem power state to off

2010-07-06 Thread Denis Kenzior
Hi Caiwen, On 07/05/2010 09:51 PM, Zhang, Caiwen wrote: Hi all, When set modem power state to off, all atoms and interfaces except 'org.ofono.Modem' are removed and unregistered. So all APIs execpt 'org.ofono.Modem' can not be used after that. But, when modem power state is off

Re: Reg. SMS sent status

2010-07-06 Thread Denis Kenzior
Hi Satya, How an application notified that SMS is sent status (i.e success or failure) ? You should really be using the history plugin for this. You will get much more information about the message this way. Because storage of SMS in some database is application responsibility. Once SMS

Re: [PATCH] gatserver: Don't free twice after user disconnect

2010-07-06 Thread Denis Kenzior
Hi Zhenhua, @@ -1019,9 +1019,6 @@ static void io_disconnect(gpointer user_data) if (server-user_disconnect) server-user_disconnect(server-user_disconnect_data); - - if (server-destroyed) - g_free(server); } static void

Re: [PATCH] Voicecall gaps.

2010-07-06 Thread Denis Kenzior
Hi Pekka, On 07/05/2010 08:40 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com Missing voicecall functionality pieces from tp-ring point-of-view. --- TODO | 27 +++ doc/voicecallmanager-api.txt |8 2

Re: [PATCH 2/2] gathdlc: Unset disconnect function in unref

2010-07-06 Thread Denis Kenzior
Hi Zhenhua, @@ -278,6 +278,7 @@ void g_at_hdlc_unref(GAtHDLC *hdlc) hdlc-record_fd = -1; } + g_at_io_set_disconnect_function(hdlc-io, NULL, NULL); Since GAtHDLC does not set the disconnect function, this really belongs in GAtPPP. g_at_io_unref(hdlc-io);

Re: [PATCH 2/2] gathdlc: Unset disconnect function in unref

2010-07-06 Thread Denis Kenzior
Hi Zhenhua, Here the problem is that disconnect function could be invoked if remote IO is disconnected after our ppp instance is freed. So we should avoid to invoke io_disconnect() in below case. Entering new phase: 5 PPP: lcp: pppcp_timeout: current state 5:STOPPING PPP: lcp:

[PATCH 1/2] Voicecall gaps.

2010-07-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Missing voicecall functionality pieces from tp-ring point-of-view. --- TODO | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 470d4a6..fc539a7 100644 --- a/TODO +++ b/TODO @@ -265,6

[PATCH 1/2] Voicecall gaps.

2010-07-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Missing voicecall functionality pieces from tp-ring point-of-view. --- TODO | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 470d4a6..fc539a7 100644 --- a/TODO +++ b/TODO @@ -265,6

[PATCH 2/2] Clarified VoiceCallManager.SendTones documentation.

2010-07-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- doc/voicecallmanager-api.txt |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt index 7877ac5..bc79fc3 100644 --- a/doc/voicecallmanager-api.txt +++

[PATCH] test-server: Refactor set_raw_mode

2010-07-06 Thread Zhenhua Zhang
Rename variable 'options' to 'ti' and use sizeof(ti). --- gatchat/test-server.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gatchat/test-server.c b/gatchat/test-server.c index 2911978..49012dc 100644 --- a/gatchat/test-server.c +++ b/gatchat/test-server.c @@

RE: [PATCH] test-server: Use cfmakeraw to set TTY raw mode

2010-07-06 Thread Zhang, Zhenhua
Hi Marcel, Marcel Holtmann wrote: Hi Zhenhua, Use cfmakeraw to disable echoing and special characters processing. If we don't turn off ICRNL, TTY layer translates \r\n to \n\n. --- gatchat/test-server.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git