Re: [n900 PATCH 2/5] isigen: generic modem driver plugin for isimodems

2010-09-16 Thread Aki Niemi
Hi Rémi, 2010/9/16 Rémi Denis-Courmont r...@remlab.net: That is the goal if and when we have up-to-date kernel, but we are not there yet. I don't see the point of adding temporary cruft to the main oFono repository then. Well, I see value in having oFono upstream work as-is with the current

Re: [n900 PATCH 2/5] isigen: generic modem driver plugin for isimodems

2010-09-16 Thread Marcel Holtmann
Hi Aki, That is the goal if and when we have up-to-date kernel, but we are not there yet. I don't see the point of adding temporary cruft to the main oFono repository then. Well, I see value in having oFono upstream work as-is with the current MeeGo kernel. The plugin could of

[PATCH] isimodem/ussd: clean const casts

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/ussd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/isimodem/ussd.c b/drivers/isimodem/ussd.c index 19ba30e..2f4091c 100644 --- a/drivers/isimodem/ussd.c +++ b/drivers/isimodem/ussd.c @@ -119,7

Re: [PATCH] isimodem/ussd: clean const casts

2010-09-16 Thread Denis Kenzior
Hi Pekka, On 09/16/2010 08:50 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/ussd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Patch has been applied, thanks. Regards, -Denis

[n900-v5 3/5] n900: modem driver plugin for Nokia N900

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi ppe...@hamsa.research.nokia.com The n900 plugin has a modem driver for the N900 internal modem based on isimodem. It controls the modem using the appropriate GPIO lines. The plugin can run natively on N900 with Maemo or Meego kernel. However, it conflicts with the Maemo

[n900-v5 5/5] usbpnmodem: plug in either n900 or isigen

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com The usbpnmodem is a stop gap solution until we get udev to support isimodems. Currently it does the basic configuration of the phonet interface. --- plugins/usbpnmodem.c | 54 - 1 files changed, 35

[n900-v5 4/5] modemconf: use isigen and n900

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Allow basic configuration of phonet links, too. --- plugins/modemconf.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/plugins/modemconf.c b/plugins/modemconf.c index d7b1354..3a823e3 100644 ---

[n900-v5 2/5] isimodem: remove the modem driver parts

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi ppe...@hamsa.research.nokia.com The isimodem driver is now part of isigen (just like atmodem and atgen). --- drivers/isimodem/isimodem.c | 401 --- 1 files changed, 0 insertions(+), 401 deletions(-) diff --git

[n900-v5 0/5] n900 and isigen modem driver

2010-09-16 Thread Pekka . Pessi
Hi all, I did more restructuring on the patches. The new isigen plugin is modeled after atgen. The isimodem modem driver is removed. The n900 modem driver seems to run on Nokia N900 with meego kernel and userspace. All the naughty bits that Rémi complained about are now moved into uspnmodem

[isimodem-ussd PATCH 2/5] ussd: debug log notifys

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- src/ussd.c | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) diff --git a/src/ussd.c b/src/ussd.c index 57390f1..bbb9aed 100644 --- a/src/ussd.c +++ b/src/ussd.c @@ -350,6 +350,43 @@ static int

[isimodem-ussd PATCH 5/5] isimodem/ussd: fix mobile-terminated cases

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com ACK notifys. Handle mobile-terminated requests gracefully. --- drivers/isimodem/ussd.c | 130 +++--- 1 files changed, 76 insertions(+), 54 deletions(-) diff --git a/drivers/isimodem/ussd.c b/drivers/isimodem/ussd.c

[isimodem-ussd PATCH 0/5] USSD fixes

2010-09-16 Thread Pekka . Pessi
Hi all, I've updated the isimodem ussd implementation to allow network-initiated operations. I've added some debug logging to the core ussd, too. The isimodem ussd now works with simple USSD applications with puSS-Request and uSS-Requests, but uSS-Notifys while a mobile-originated puSS-Request

[isimodem-ussd PATCH 4/5] isimodem/debug: debug USSD type

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/debug.c | 13 + drivers/isimodem/debug.h |1 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/debug.c b/drivers/isimodem/debug.c index b398797..d226c51 100644 ---

[isimodem-ussd PATCH 1/5] ussd.h: +CUSD is documented in 27.007 section 7.15

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- include/ussd.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/ussd.h b/include/ussd.h index 360ef00..82057f2 100644 --- a/include/ussd.h +++ b/include/ussd.h @@ -28,6 +28,7 @@ extern C { #include ofono/types.h +/*

[isimodem-ussd PATCH 3/5] test-ussd: read stdin for Response()s

2010-09-16 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- test/test-ussd | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/test/test-ussd b/test/test-ussd index 6e24de8..d4c1e27 100755 --- a/test/test-ussd +++ b/test/test-ussd @@ -2,10 +2,13 @@ import sys import

[PATCH] phonesim: simulate language notification in sim app

2010-09-16 Thread Jeevaka Badrappan
--- src/qsimcommand.cpp| 38 src/qsimcommand.h |3 ++ src/simapplication.cpp | 76 src/simapplication.h |2 + 4 files changed, 119 insertions(+), 0 deletions(-) diff --git a/src/qsimcommand.cpp

Re: [isimodem-ussd PATCH 0/5] USSD fixes

2010-09-16 Thread Denis Kenzior
Hi Pekka, On 09/16/2010 12:32 PM, pekka.pe...@nokia.com wrote: Hi all, I've updated the isimodem ussd implementation to allow network-initiated operations. I've added some debug logging to the core ussd, too. The isimodem ussd now works with simple USSD applications with puSS-Request and

Re: [PATCH] phonesim: simulate language notification in sim app

2010-09-16 Thread Denis Kenzior
Hi Jeevaka, On 09/16/2010 01:39 PM, Jeevaka Badrappan wrote: --- src/qsimcommand.cpp| 38 src/qsimcommand.h |3 ++ src/simapplication.cpp | 76 src/simapplication.h |2 + 4 files changed, 119

Re: [n900 PATCH 2/5] isigen: generic modem driver plugin for isimodems

2010-09-16 Thread Rémi Denis-Courmont
On Thu, 16 Sep 2010 15:26:34 +0900, Marcel Holtmann mar...@holtmann.org wrote: That is the goal if and when we have up-to-date kernel, but we are not there yet. I don't see the point of adding temporary cruft to the main oFono repository then. Well, I see value in having oFono

[PATCH] plugins: Adding implementation for persisting voice call history

2010-09-16 Thread Rajyalakshmi Bommaraju
--- Makefile.am |3 + plugins/callhistory.c | 594 + 2 files changed, 597 insertions(+), 0 deletions(-) create mode 100644 plugins/callhistory.c diff --git a/Makefile.am b/Makefile.am index aa66907..1b7f4d4 100644 --- a/Makefile.am

Re: [PATCH] plugins: Adding implementation for persisting voice call history

2010-09-16 Thread Marcel Holtmann
Hi Rajyalakshmi, Makefile.am |3 + plugins/callhistory.c | 594 + 2 files changed, 597 insertions(+), 0 deletions(-) create mode 100644 plugins/callhistory.c diff --git a/Makefile.am b/Makefile.am index aa66907..1b7f4d4

Re: [n900 PATCH 2/5] isigen: generic modem driver plugin for isimodems

2010-09-16 Thread Marcel Holtmann
Hi Remi, That is the goal if and when we have up-to-date kernel, but we are not there yet. I don't see the point of adding temporary cruft to the main oFono repository then. Well, I see value in having oFono upstream work as-is with the current MeeGo kernel. The plugin could

Re: Description of Voice call history plugin patch

2010-09-16 Thread Denis Kenzior
Hi Raji, Design : Plugin uses memory mapped file for high performance input/output operations. File is used as cyclic queue for storing or reading records, it store s 50 records of 78bytes,hence fixed size file of 3916 bytes is used. File's first 16 bytes were used for storing header, and