support of emergency call when SIM not inserted ?

2010-09-23 Thread Anthony CROLAIS
Hi all, I am new to oFono. It seems an important challenge to design a telephony system that will support several 3GPP modems. I would like to participate. I have read documentation (ofono-paper, coding-style, api for oFono Interfaces). I have started to cover source code: modem part, sim

Re: support of emergency call when SIM not inserted ?

2010-09-23 Thread Marcel Holtmann
Hi Anthony, new rule for everybody, no more HTML emails on this mailing list. Actually not really a new rule, but I forgot to enforce it. So please fix your mail clients. I am new to oFono. It seems an important challenge to design a telephony system that will support several 3GPP modems. I

Re: support of emergency call when SIM not inserted ?

2010-09-23 Thread Pekka Pessi
Hi everyone, 2010/9/23 Marcel Holtmann mar...@holtmann.org: I need a clarification about SIM: Most GSM mobile phones can dial emergency calls even when the phone is without a SIM card. But it seems that oFono does not support an emergency call if the sim driver is present but no SIM is

Re: [PATCH] Fix test-sms.

2010-09-23 Thread Pekka Pessi
Hi Marcel, +if smsc: +     manager.SetProperty(ServiceCenterAddress, dbus.String(smsc)) the SMSC is a global message manager property, I prefer to just have a test script that just modifies it. Using set-service-center-address would be way better then trying to include this in this test

Re: [PATCH] Fix valid_ussd_string()

2010-09-23 Thread Marcel Holtmann
Hi Pekka, this is not an acceptable patch. You are removing functionality and lengthy comment without providing a comment in the commit message from equal length and detail. We can not do it like this since 1 month later nobody remembers what has been done here and why. This needs

[PATCH] Add GPRS suspension to doc/features.txt

2010-09-23 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- doc/features.txt |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/doc/features.txt b/doc/features.txt index 534b8de..601d58c 100644 --- a/doc/features.txt +++ b/doc/features.txt @@ -96,3 +96,10 @@ Short Messaging Service

Re: support of emergency call when SIM not inserted ?

2010-09-23 Thread Denis Kenzior
Hi Anthony, I need a clarification about SIM: Most GSM mobile phones can dial emergency calls even when the phone is without a SIM card. But it seems that oFono does not support an emergency call if the sim driver is present but no SIM is inserted: This used to be supported, but

RE: support of emergency call when SIM not inserted ?

2010-09-23 Thread Anthony CROLAIS
Hi Denis, It is Ok for me, thanks. I read the Emergency Calls section in the TODO but I though the scope was limited to a SIM lock. As you suggest, it can also be applied to the case when no sim is inserted. Regards, Anthony -Message d'origine- De : Denis Kenzior

[PATCH 1/2] Fix valid_ussd_string()

2010-09-23 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com The valid_ussd_string() returns true if MMI input is to be sent as USSD. The USSD routing is out of scope of oFono. The cellular network routes the USSD requests based on the rules laid out in the 22.090, however, any string that can be encoded according

[PATCH 2/2] Fix __ofono_voicecall_is_busy()

2010-09-23 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Return true if call is being dialed by stk, too. --- src/voicecall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index f6ed988..b4017d1 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@

Re: [PATCH] Add GPRS suspension to doc/features.txt

2010-09-23 Thread Denis Kenzior
Hi Pekka, On 09/23/2010 10:11 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- doc/features.txt |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) When marking a task done, please send a patch for both TODO and doc/features.txt. This is easier to

Re: [PATCH 1/2] Fix valid_ussd_string()

2010-09-23 Thread Denis Kenzior
Hi Pekka, - * According to 22.030 Figure 3.5.3.2 USSD strings can be: - * - * Supplementary service control - * SIM control - * Manufacturer defined - * Terminated by '#' - * Short String - This can be any 2 digit short string. If the string - *

Re: [PATCH 2/2] Fix __ofono_voicecall_is_busy()

2010-09-23 Thread Denis Kenzior
Hi Pekka, @@ -2171,7 +2171,7 @@ int ofono_voicecall_get_next_callid(struct ofono_voicecall *vc) ofono_bool_t __ofono_voicecall_is_busy(struct ofono_voicecall *vc, enum ofono_voicecall_interaction type) { - if (vc-pending) + if (vc-pending ||

Please comment on callhistory API

2010-09-23 Thread rajyalakshmi bommaraju
Hello, Attached Callhistory API , please send me your feedback on it, I will extend this include SmsHistory once callhistory API looks good. Thanks Raji Callhistory Adapter-Agent CallHistoryAdapter is a built in plugin for

Re: Please comment on callhistory API

2010-09-23 Thread Marcel Holtmann
Hi Raji, Attached Callhistory API , please send me your feedback on it, I will extend this include SmsHistory once callhistory API looks good. please include such text in the email and not as attachment. We wanna review it and not bother with just having to save it to disk first, then copy it