CDMA SMS Handling

2010-10-06 Thread Rajesh.Nagaiah
Hi, There was a discussion about the CDMA SMS handling and CDMA PDUs in the IRC channel couple of days before. I would like to highlight the differences between CDMA and GSM PDU and how we should proceed with this from my understanding. Let me know your opinion. Even though oFono supports +CMT

Re: [RFC online/offline atoms PATCH 2/4] sms: watch modem state

2010-10-06 Thread Marcel Holtmann
Hi Denis, Allow use of SMS atom in online and offline states. The messages are queued but not sent in offline mode. Errors occurring when an SMS is being sent while transition from online to offline are handled gracefully. do we really want this? How is this suppose to work from the

Re: CDMA SMS Handling

2010-10-06 Thread Marcel Holtmann
Hi Rajesh. There was a discussion about the CDMA SMS handling and CDMA PDUs in the IRC channel couple of days before. I would like to highlight the differences between CDMA and GSM PDU and how we should proceed with this from my understanding. Let me know your opinion. thanks for the

[PATCH] isimodem/voicecall: fix hangup_active

2010-10-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/voicecall.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 4b720be..ace2346 100644 --- a/drivers/isimodem/voicecall.c +++

Re: [PATCH] isimodem/voicecall: fix hangup_active

2010-10-06 Thread Marcel Holtmann
Hi Pekka, --- drivers/isimodem/voicecall.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 4b720be..ace2346 100644 --- a/drivers/isimodem/voicecall.c +++ b/drivers/isimodem/voicecall.c @@

Re: [PATCH] isimodem/voicecall: fix hangup_active

2010-10-06 Thread Pekka Pessi
Hi Marcel, 2010/10/6 Marcel Holtmann mar...@holtmann.org: +static void isi_hangup_active(struct ofono_voicecall *ovc,                       ofono_voicecall_cb_t cb, void *data)  {       /* AT+CHUP */ -     isi_call_release_req(ovc, CALL_ID_ALL, CALL_CAUSE_TYPE_CLIENT, +    

[PATCH-v2] isimodem/voicecall: fix hangup_active

2010-10-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/voicecall.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 4b720be..146390c 100644 --- a/drivers/isimodem/voicecall.c +++

Re: [PATCH-v2] isimodem/voicecall: fix hangup_active

2010-10-06 Thread Marcel Holtmann
Hi Pekka, --- drivers/isimodem/voicecall.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) patch has been applied. Thanks. However there are more AT command references in the code that you might wanna remove and replace with proper ISI specific comments. Regards Marcel

[RFC PATCH 2/3] modem: some debugs added for indicating modem state change

2010-10-06 Thread Petteri Tikander
--- src/modem.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 7a29edf..583b79f 100644 --- a/src/modem.c +++ b/src/modem.c @@ -330,6 +330,8 @@ static void flush_atoms(struct ofono_modem *modem, enum modem_state new_state)

[RFC PATCH 3/3] sim: ensure existence of imsi-code when handling sim_get_properties

2010-10-06 Thread Petteri Tikander
--- src/sim.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/sim.c b/src/sim.c index 930d6bf..5f4f90e 100644 --- a/src/sim.c +++ b/src/sim.c @@ -311,7 +311,7 @@ static DBusMessage *sim_get_properties(DBusConnection *conn, ofono_dbus_dict_append(dict,

RE: [PATCH 2/2] n900: Enable audio settings atom

2010-10-06 Thread Kai.Vehmanen
Hi, On 01 Oct 2010, Kai Vehmanen wrote: Subject: [PATCH 2/2] n900: Enable audio settings atom plugins/n900.c |2 ++ FYI, I've now added a minimal test/example application, cmtspeech_test_ofono, to upstream libcmtspeechdata repository [1]. The app uses oFono (and the new audio settings atom)

[ussd-mmi PATCH 0/4]

2010-10-06 Thread Pekka . Pessi
Hi all, Here is a patch for MMI checking of USSD strings, now mentioning 22.030. At the same time I also took liberty to streamline the stk voicecall interface. --Pekka ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[ussd-mmi PATCH 2/4] Check stk requests in __ofono_voicecall_is_busy()

2010-10-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com Return true if a call is being dialed by stk. Use __ofono_voicecall_is_busy() in __ofono_voicecall_dial(). --- src/voicecall.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index

[ussd-mmi PATCH 1/4] Fix valid_ussd_string()

2010-10-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com The valid_ussd_string() returns now true if MMI input is to be sent as USSD. The comment about USSD routing is removed, it is out of scope of oFono. The cellular network routes the USSD requests based on the rules laid out in the 22.090, however, any

[PATCH 1/2] gisi/verify: check g_try_new0 return value

2010-10-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- gisi/verify.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gisi/verify.c b/gisi/verify.c index fae9d13..322f1d1 100644 --- a/gisi/verify.c +++ b/gisi/verify.c @@ -116,6 +116,9 @@ GIsiRequest *g_isi_verify(GIsiClient

[PATCH 2/2] ussd: check g_try_new0 return value

2010-10-06 Thread Pekka . Pessi
From: Pekka Pessi pekka.pe...@nokia.com --- src/ussd.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/ussd.c b/src/ussd.c index aad7d32..c80d247 100644 --- a/src/ussd.c +++ b/src/ussd.c @@ -888,6 +888,9 @@ int __ofono_ussd_initiate(struct ofono_ussd *ussd, int

Re: [PATCH 1/2] gisi/verify: check g_try_new0 return value

2010-10-06 Thread Marcel Holtmann
Hi Pekka, gisi/verify.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/2] ussd: check g_try_new0 return value

2010-10-06 Thread Marcel Holtmann
Hi Pekka, src/ussd.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: Handling of Fixed Dialing

2010-10-06 Thread Marcel Holtmann
Hi Petteri, First patch checks if Fixed Dialing is enabled in the SIM-card by reading FD-activated bit from EFsst or EFest. If FDN is enabled, SIM initialization procedure is stopped, and modem will stay in the PRE-SIM state. If FD is enabled, this is signaled via DBUS. don't forget to

[PATCH] doc: Play Tone command proposed d-bus API.

2010-10-06 Thread Andrzej Zaborowski
--- doc/stk-api.txt | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index 3b47819..f5b9ebc 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -203,6 +203,46 @@ Methodsbyte

[PATCH 3/3][RfC] atmodem: Handle pauses in DTMF string

2010-10-06 Thread Andrzej Zaborowski
--- drivers/atmodem/voicecall.c | 162 +++ 1 files changed, 134 insertions(+), 28 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index 8b43865..cc75803 100644 --- a/drivers/atmodem/voicecall.c +++

Re: [PATCH] doc: Play Tone command proposed d-bus API.

2010-10-06 Thread Denis Kenzior
Hi Andrew, On 10/06/2010 05:35 AM, Andrzej Zaborowski wrote: --- doc/stk-api.txt | 40 1 files changed, 40 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing