Re: [PATCH 1/2] stemodem: Create network interfaces statically

2010-11-22 Thread Denis Kenzior
Hi Sjur, On 11/18/2010 02:03 AM, Sjur Brændeland wrote: Hi Denis Marcel. From: Sjur Brændeland sjur.brandel...@stericsson.com Changes: o Restructure code so interfaces are created statically when probe is called. o Removed some of the unnecessary initializations at declaration. o No

Re: [PATCH] stkutil: mask the DCS value to keep only the intersting bits

2010-11-22 Thread Denis Kenzior
Hi Guillaume, - switch (dcs) { + switch (dcs 0x06) { Do you mean to bitwise and with 0xc here? Otherwise you break the UCS2 case. Also do any SIMs use the '' Coding Bits Entry entry from 23.038 Section 4? If so, then we need to use sms_dcs_decode to retrieve the character set.

Re: [RFC PATCH 1/2] common: add long dial string support

2010-11-22 Thread Denis Kenzior
Hi Andras, On 11/18/2010 05:38 AM, Arun Ravindran wrote: Hi Denis, Marcel, Andras, include/types.h |2 +- src/common.c| 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/types.h b/include/types.h index ba2481f..b3d2247 100644 ---

Re: [PATCH] doc: fix typos

2010-11-22 Thread Denis Kenzior
Hi Rémi, On 11/18/2010 09:11 AM, Rémi Denis-Courmont wrote: --- doc/voicecallmanager-api.txt |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] src: coding style fixes - rule M6

2010-11-22 Thread Denis Kenzior
Hi Jeevaka, On 11/19/2010 07:57 AM, Jeevaka Badrappan wrote: --- src/audio-settings.c |4 ++-- src/call-barring.c|4 ++-- src/call-forwarding.c |4 ++-- src/call-meter.c |4 ++-- src/call-settings.c |4 ++-- src/cbs.c | 10 +-

Re: [PATCH] build: Update glib version in configure.ac

2010-11-22 Thread Denis Kenzior
Hi George, On 11/19/2010 03:18 AM, George Matveev wrote: function g_mkstemp_full in src/storage.c requires glib version 2.22 or higher --- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 1/3] Add TTY (hearing impaired) support

2010-11-22 Thread Denis Kenzior
Hi Lucas, On 11/18/2010 05:30 AM, Lucas De Marchi wrote: On Thu, Nov 18, 2010 at 9:26 AM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: + Changes the value of the specified property. Only + properties that are listed as read-write are A

Re: [isi-voicecall-fix PATCHv3 1/6] voicecall: fix dial result handling

2010-11-22 Thread Denis Kenzior
Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com If there is an existing active call when dialing the existing call will be automatically put on hold. The dialing result handling depended on the voicecall driver putting the call on hold

RE: [PATCH] doc: Add Location Services API

2010-11-22 Thread Simon LETHBRIDGE
-Original Message- From: Bastian, Waldo [mailto:waldo.bast...@intel.com] Sent: 20 November 2010 02:04 To: ofono@ofono.org; Simon LETHBRIDGE Cc: Sjur BRENDELAND Subject: RE: [PATCH] doc: Add Location Services API Conformance testing per 3GPP 34.109s5.4.1.3 requires that

Re: [isi-voicecall-fix PATCHv3 2/6] isi/voicecall: fix status reporting

2010-11-22 Thread Denis Kenzior
Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com Report early incoming calls as waiting or incoming, depending on the state of other calls. Report MT_RELEASED or MO_RELEASED via ofono_voicecall_notify(), TERMINATED calls via

Re: [isi-voicecall-fix PATCHv3 3/6] isi/voicecall: save call id when queueing requests

2010-11-22 Thread Denis Kenzior
Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/voicecall.c | 64 +++--- 1 files changed, 41 insertions(+), 23 deletions(-) diff --git a/drivers/isimodem/voicecall.c

Re: [isi-voicecall-fix PATCHv3 4/6] isi/voicecall: fix answering early incoming calls

2010-11-22 Thread Denis Kenzior
Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com The voicecall driver must wait until the incoming call is mt-alerting or waiting before answering. --- drivers/isimodem/voicecall.c | 49 +-

Re: [PATCH] Add responses for TTY commands

2010-11-22 Thread Denis Kenzior
Hi Lucas, On 11/17/2010 08:00 PM, Lucas De Marchi wrote: --- src/default.xml | 16 1 files changed, 16 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] Simulate provide local info command

2010-11-22 Thread Denis Kenzior
Hi Yang, On 11/18/2010 04:43 AM, Yang Gu wrote: --- src/simapplication.cpp | 263 src/simapplication.h |2 + 2 files changed, 265 insertions(+), 0 deletions(-) +#define LocalInfoMenu_Loc 1 +#define LocalInfoMenu_IMEI

Re: [PATCH 3/4] phonesim: Add Timer Management commands to sim app menu.

2010-11-22 Thread Denis Kenzior
Hi Andrew, On 11/21/2010 09:51 AM, Andrzej Zaborowski wrote: --- src/qsimcommand.cpp | 83 src/qsimcommand.h|3 + src/qsimterminalresponse.cpp | 59 ++ src/qsimterminalresponse.h |3 + src/simapplication.cpp | 171

[RFCv2] doc: Assisted Satellite Navigation API and Agent API

2010-11-22 Thread Sjur Brændeland
From: Simon Lethbridge simon.lethbri...@stericsson.com This is our second proposal for the Assisted Satellite Navigation API, this time including an Agent API. Hopefully most of the review comments on our last proposal are included here. As you can see we have changed the name again, this time

Re: [PATCH 1/4] phonesim: Add Send Short Message commands to sim app menu.

2010-11-22 Thread Denis Kenzior
Hi Andrew, On 11/21/2010 09:51 AM, Andrzej Zaborowski wrote: --- src/simapplication.cpp | 148 +++- src/simapplication.h |5 ++ 2 files changed, 152 insertions(+), 1 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 2/4] phonesim: Add SIM Polling commands to sim app menu.

2010-11-22 Thread Denis Kenzior
Hi Andrew, On 11/21/2010 09:51 AM, Andrzej Zaborowski wrote: --- src/simapplication.cpp | 66 src/simapplication.h |2 + 3 files changed, 72 insertions(+), 4 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [RFC PATCH 1/5] history: expand history API include file

2010-11-22 Thread Denis Kenzior
Hi Andras, On 11/15/2010 05:50 AM, Andras Domokos wrote: --- include/history.h |3 +++ src/ofono.h |4 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/history.h b/include/history.h index c1c4aa1..a2490f6 100644 --- a/include/history.h +++

Re: [RFC PATCH 4/5] voicecall: add call counters

2010-11-22 Thread Denis Kenzior
Hi Andras, On 11/15/2010 05:50 AM, Andras Domokos wrote: --- src/callcounters.c | 388 1 files changed, 388 insertions(+), 0 deletions(-) create mode 100644 src/callcounters.c diff --git a/src/callcounters.c b/src/callcounters.c

Re: [PATCH] Add SIM reset button

2010-11-22 Thread Denis Kenzior
Hi Gustavo, On 11/16/2010 02:48 PM, Gustavo F. Padovan wrote: +CRST now send a reset resquest command --- src/control.cpp|6 ++ src/control.h |1 + src/controlbase.ui | 40 3 files changed, 47 insertions(+), 0 deletions(-)

[PATCH] gatchat: make sure to unsubscribe the GAtIO write handler on disconnect.

2010-11-22 Thread Andrzej Zaborowski
There's a small probability that we call chat_wakeup_writer just before the channel disonnects and for some reason glib then calls can_write_data after we have unrefed the io and freed all the resources. Calling at_chat_suspend unsubscribes can_write_data from the io. --- gatchat/gatchat.c |

Re: [RFC PATCH 1/4] modem: add modem online-offline watch

2010-11-22 Thread Denis Kenzior
Hi Andras, On 11/15/2010 10:57 AM, Andras Domokos wrote: From: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 46 ++ src/ofono.h |8 2 files changed, 54 insertions(+), 0 deletions(-) Patch has been applied, but I

Re: [isi-voicecall-fix PATCHv3 2/6] isi/voicecall: fix status reporting

2010-11-22 Thread Pekka Pessi
Hi Denis, +enum clcc_status { +     CLCC_STATUS_ACTIVE = 0, +     CLCC_STATUS_HOLD = 1, +     CLCC_STATUS_DIALING = 2, +     CLCC_STATUS_ALERTING = 3, +     CLCC_STATUS_INCOMING = 4, +     CLCC_STATUS_WAITING = 5, +     CLCC_STATUS_DISCONNECTED = 6, /* Nonstandard */ +}; Please follow

[PATCH 0/5] Call Counters (2nd)

2010-11-22 Thread Andras Domokos
Here a proposal for call counters implementation for keeping track of the total incoming and outgoing call duration counters. Each established call instance is contributing to either of the call duration counters. The 2 counters are updated periodically when there is an established call and the

[RFC PATCH 2/5] history: expand history API

2010-11-22 Thread Andras Domokos
--- src/history.c | 24 src/ofono.h |4 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/src/history.c b/src/history.c index 0229cf5..31efadb 100644 --- a/src/history.c +++ b/src/history.c @@ -114,6 +114,30 @@ void

[RFC PATCH 3/5] voicecall: take into use the new history function

2010-11-22 Thread Andras Domokos
--- src/voicecall.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index bd64432..b40d284 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -630,6 +630,7 @@ static void voicecall_emit_multiparty(struct voicecall *call, gboolean

[RFC PATCH 1/3] common: add long dial string support

2010-11-22 Thread Andras Domokos
--- include/types.h |2 +- src/common.c| 38 +- src/common.h|1 + 3 files changed, 35 insertions(+), 6 deletions(-) diff --git a/include/types.h b/include/types.h index ba2481f..b3d2247 100644 --- a/include/types.h +++ b/include/types.h @@

[RFC PATCH 3/3] isimodem/voicecall: add long dial string support

2010-11-22 Thread Andras Domokos
--- drivers/isimodem/voicecall.c | 83 +- 1 files changed, 65 insertions(+), 18 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index c3365f6..b0dad72 100644 --- a/drivers/isimodem/voicecall.c +++

[RFC PATCH 2/3] voicecall: add long dial string support

2010-11-22 Thread Andras Domokos
--- src/voicecall.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index bd64432..4022f36 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -408,7 +408,7 @@ static DBusMessage *voicecall_deflect(DBusConnection *conn,

Re: [isi-voicecall-fix PATCHv3 1/6] voicecall: fix dial result handling

2010-11-22 Thread Pekka Pessi
Hi Denis, 2010/11/22 Denis Kenzior denk...@gmail.com: If there is an existing active call when dialing the existing call will be automatically put on hold. The dialing result handling depended on the voicecall driver putting the call on hold before the dial command callback is called.

Re: [isi-voicecall-fix PATCHv3 1/6] voicecall: fix dial result handling

2010-11-22 Thread Denis Kenzior
Hi Pekka, + gboolean dial_result_handled; }; So I'm finally beginning to understand where you're going with this.. struct dial_request { @@ -1096,9 +1097,20 @@ static struct voicecall *dial_handle_result(struct ofono_voicecall *vc, v = l-data; if

RE: [RFC 1/3] doc: addidng documentation for basic assisted gps

2010-11-22 Thread Joly, Frederic
Hi gentelmen, I apologise for this very comment. -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Marcel Holtmann Sent: Friday, November 05, 2010 9:47 PM To: ofono@ofono.org Cc: Ahmed, Suhail Subject: RE: [RFC 1/3] doc: addidng

RE: [PATCH 0/3] Long dial string support (2nd)

2010-11-22 Thread Rajesh.Nagaiah
Hi Andras, Dial strings can now be as long as 120 digits (not counting '+'). This feature is going to be needed by the FDN feature. An FDN may consist of a phone number plus a DTMF string. In order to have the call succeed when FDN is enabled, both parts need to be provided when making

RE: [PATCH] doc: Add Location Services API (resending now that I am on ofono mailing list)

2010-11-22 Thread Joly, Frederic
Hi Simon, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Simon LETHBRIDGE Sent: Thursday, November 18, 2010 10:50 AM To: Denis Kenzior; ofono@ofono.org Cc: Sjur BRENDELAND Subject: RE: [PATCH] doc: Add Location Services API (resending now

[PATCH] Add modem silent reset button

2010-11-22 Thread Gustavo F. Padovan
+CRST now send a reset resquest command --- src/control.cpp|6 ++ src/control.h |1 + src/controlbase.ui | 40 3 files changed, 47 insertions(+), 0 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index ab71752..75dae98

RE: [RFC] AGPS Support

2010-11-22 Thread Joly, Frederic
Hi, Once again I apologise, I have not been able to react before on this. -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Marcel Holtmann Sent: Wednesday, November 03, 2010 11:40 AM To: Sjur Brændeland Cc: Ahmed, Suhail; Simon

RE: [PATCH] doc: Add Location Services API

2010-11-22 Thread Joly, Frederic
Hi Marko, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of marko.ova...@nokia.com Sent: Monday, November 22, 2010 10:01 AM To: ofono@ofono.org; simon.lethbri...@stericsson.com Cc: sjur.brandel...@stericsson.com Subject: RE: [PATCH] doc: Add

[RFC 0/3] Add support of Neighbor Cell Info inside ifxmodem driver and plugin

2010-11-22 Thread jun . wei
From: Jun Wei jun@intel.com Hello, These 3 RFCs are submit to add support of Neighbor Cell Info inside ifxmodem driver and plugin, and we are not provindg support in ofono core. Jun Wei (1): Add support of Neighbor Cell Info inside ifxmodem driver and plugin

RE: [PATCH] TODO: Add vCard export to SM/ME stores

2010-11-22 Thread Marcel Holtmann
Hi Jaakko, no index number. We will never use them. It is either the full phonebook at once or nothing. The write function has to empty out left over entries. ... Actually I prefer we use proper Dict field names. We never use anything literally from the specifications in this area.