Re: [RFC v4 10/10] emulator: Update supported features

2012-04-23 Thread Denis Kenzior
Hi Frederic, >> I think it would be better for the features to be modified based on what >> command handlers are registered. E.g. if NREC handler is registered in >> ofono_emulator_add_handler then add ECNR to local features, etc. > > Local features are sent during reply to AT+BRSF command (afte

Re: [RFC v4 10/10] emulator: Update supported features

2012-04-23 Thread Frederic Danis
Hello Denis, Le 06/04/2012 19:38, Denis Kenzior a écrit : Hi Frédéric, On 04/06/2012 08:17 AM, Frédéric Danis wrote: Add ECNR (Echo Cancelation/Noise Reduction) and Inband Ringtone capabilities to supported features (+BRSF event) --- src/emulator.c |2 ++ 1 files changed, 2 insertions(+

Re: [PATCH v3 0/2] mmsd: bug fix

2012-04-23 Thread Marcel Holtmann
Hi Sebastien, > mmsutil: add mms_message_status_get_string API > service: use proper status value string > > src/mmsutil.c | 18 ++ > src/mmsutil.h |1 + > src/service.c |2 +- > 3 files changed, 20 insertions(+), 1 deletions(-) both patches have been applied. Reg

RE: [PATCH v6 03/16] dundee: Add test scripts

2012-04-23 Thread Zheng, Wu
Hi Daniel, I try to test your patches. > -Original Message- > From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf > Of Daniel Wagner > Sent: Tuesday, April 03, 2012 12:20 AM > To: ofono@ofono.org > Cc: Daniel Wagner > Subject: [PATCH v6 03/16] dundee: Add test scripts

[PATCH v3 2/2] service: use proper status value string

2012-04-23 Thread Sébastien Bianti
--- src/service.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index 469393a..f89fd3f 100644 --- a/src/service.c +++ b/src/service.c @@ -1502,7 +1502,7 @@ static void append_sr_msg_properties(DBusMessageIter *dict,

[PATCH v3 1/2] mmsutil: add mms_message_status_get_string API

2012-04-23 Thread Sébastien Bianti
--- src/mmsutil.c | 18 ++ src/mmsutil.h |1 + 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/mmsutil.c b/src/mmsutil.c index c507d6f..89f1c29 100644 --- a/src/mmsutil.c +++ b/src/mmsutil.c @@ -1661,3 +1661,21 @@ gboolean mms_message_encode(struct mms_mes

[PATCH v3 0/2] mmsd: bug fix

2012-04-23 Thread Sébastien Bianti
Sébastien Bianti (2): mmsutil: add mms_message_status_get_string API service: use proper status value string src/mmsutil.c | 18 ++ src/mmsutil.h |1 + src/service.c |2 +- 3 files changed, 20 insertions(+), 1 deletions(-) -- 1.7.4.4 __

Re: [PATCH v2 0/2] mmsd: bug fix

2012-04-23 Thread Sébastien bianti
Please forget this, I forgot to change the return value. Le 23/04/2012 10:31, Sébastien Bianti a écrit : Sébastien Bianti (2): mmsutil: add mms_message_status_get_string API service: use proper status value string src/mmsutil.c | 18 ++ src/mmsutil.h |1 + src/se

[PATCH v2 2/2] service: use proper status value string

2012-04-23 Thread Sébastien Bianti
--- src/service.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index 469393a..f89fd3f 100644 --- a/src/service.c +++ b/src/service.c @@ -1502,7 +1502,7 @@ static void append_sr_msg_properties(DBusMessageIter *dict,

[PATCH v2 1/2] mmsutil: add mms_message_status_get_string API

2012-04-23 Thread Sébastien Bianti
--- src/mmsutil.c | 18 ++ src/mmsutil.h |1 + 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/mmsutil.c b/src/mmsutil.c index c507d6f..8809f54 100644 --- a/src/mmsutil.c +++ b/src/mmsutil.c @@ -1661,3 +1661,21 @@ gboolean mms_message_encode(struct mms_mes

[PATCH v2 0/2] mmsd: bug fix

2012-04-23 Thread Sébastien Bianti
Sébastien Bianti (2): mmsutil: add mms_message_status_get_string API service: use proper status value string src/mmsutil.c | 18 ++ src/mmsutil.h |1 + src/service.c |2 +- 3 files changed, 20 insertions(+), 1 deletions(-) -- 1.7.4.4 __