Re: [PATCH_v2] unit: Update test_invalid() unit test

Hi Guillaume, On 07/18/2012 10:18 AM, Guillaume Zajac wrote: --- unit/test-util.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) I applied this patch, but simplified it slightly in a follow-on commit. Regards, -Denis __

[PATCH_v2] unit: Update test_invalid() unit test

--- unit/test-util.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/unit/test-util.c b/unit/test-util.c index 079d775..d3bbf8c 100644 --- a/unit/test-util.c +++ b/unit/test-util.c @@ -345,7 +345,9 @@ static void test_invalid(void) { long

Re: [PATCH] unit: Update test_invalid() unit test

Hi, On 18/07/2012 17:13, Guillaume Zajac wrote: --- unit/test-util.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/unit/test-util.c b/unit/test-util.c index 079d775..f65f3ee 100644 --- a/unit/test-util.c +++ b/unit/test-util.c @@ -345,7 +3

[PATCH] unit: Update test_invalid() unit test

--- unit/test-util.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/unit/test-util.c b/unit/test-util.c index 079d775..f65f3ee 100644 --- a/unit/test-util.c +++ b/unit/test-util.c @@ -345,7 +345,9 @@ static void test_invalid(void) { lon

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

Hi Guillaume, and can someone please run the unit tests if we are touching this: /testutil/Invalid Conversions: ** ERROR:unit/test-util.c:362:test_invalid: assertion failed: (res == NULL) Aborted (core dumped) The purpose of this test was to check if we were failing to convert an invalid GSM

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

Hi, On 18/07/2012 14:31, Marcel Holtmann wrote: Hi Guillaume, + /* + * According to the 3GPP specifications 23.038 + * section 6.2.1.1: + * In the case there is no character in the extension + * table, the character of the main default alphabet + * table or the character from the National Lang

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

Hi Guillaume, > + /* > + * According to the 3GPP specifications 23.038 > + * section 6.2.1.1: > + * In the case there is no character in the extension > + * table, the character of the main default alphabet > + * table or the character from the National Language > >>>

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

Hi Denis, On 17/07/2012 04:09, Denis Kenzior wrote: Hi Guillaume, + /* + * According to the 3GPP specifications 23.038 + * section 6.2.1.1: + * In the case there is no character in the extension + * table, the character of the main default alphabet + * table or the character from the National