Re: [PATCH 2/8] telit: add additional port for data connection

Hi Christopher, * Christopher Vogl [2012-08-13 15:17:39 +0200]: > Use MDM port for data service and AUX for the AT chat. > Disable DCD so that the modem does not hangup after a data connection. > Add vendor for sim and gprs. > > udevng: rename aux port from Data to Aux for telit. > > Telit sof

Re: [PATCH 3/8] sim: support PIN retry counters for telit modems

Hi Christopher/August, On 08/13/2012 08:21 AM, Christopher Vogl wrote: From: August Mayer --- drivers/atmodem/sim.c | 57 + include/sim.h |2 + src/sim.c |8 +++ 3 files changed, 67 insertions(+), 0 deletions

Re: [PATCH 7/8] netreg: adapt CMER and CIEV for telit

Hi Christopher, On 08/13/2012 08:23 AM, Christopher Vogl wrote: Telit uses a 2 to enable indicator event reporting and indicators in a +CIEV URC are identified by strings, not numbers. Yikes, can you include a sample AT trace? It sounds like something is going terribly wrong with CIEVs. -

[PATCH ell 2/2] io: Fix not considering that watch_modify() may fail

--- ell/io.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ell/io.c b/ell/io.c index 8a17b94..bc0bf86 100644 --- a/ell/io.c +++ b/ell/io.c @@ -236,6 +236,7 @@ LIB_EXPORT bool l_io_set_read_handler(struct l_io *io, l_io_read_cb_t callback,

[PATCH ell 1/2] io: Fix not returning an error when watch_add() fails

--- ell/io.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ell/io.c b/ell/io.c index f4ce174..8a17b94 100644 --- a/ell/io.c +++ b/ell/io.c @@ -149,6 +149,7 @@ static void io_callback(int fd, uint32_t events, void *user_data) LIB_EXPORT struct l_io *l_io_new(int fd) {

Re: [PATCH 8/8] gprs: fix bearer dbus signal interface

Hi Christopher, On 08/13/2012 08:23 AM, Christopher Vogl wrote: According to the documentation the data bearer property should be located on interface org.ofono.ConnectionManager. --- src/gprs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Good catch. Patch has been applied,

Re: [PATCH 6/8] gprs: data bearer for telit with PSNT

Hi Christopher, On 08/13/2012 08:23 AM, Christopher Vogl wrote: From: August Mayer Telit neither supports '+CPSB' nor reports the data bearer through '+CGREG'. It has its own +PSNT command. --- drivers/atmodem/gprs.c | 76 1 files changed, 7

Re: [PATCH 5/8] gprs-context: print reason for ppp disconnect

Hi Christopher, On 08/13/2012 08:22 AM, Christopher Vogl wrote: --- drivers/atmodem/gprs-context.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.or

Re: [PATCH 4/8] gprs: add quirk for Telit modems

Hi Christopher, On 08/13/2012 08:22 AM, Christopher Vogl wrote: Telit does not support AT+CGAUTO, use AT#AUTOATT=0 instead. --- drivers/atmodem/gprs.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c index 65a8b7b.

Re: [PATCH 1/8] telit: notify sim inserted when sim ready

Hi Christopher, On 08/13/2012 08:16 AM, Christopher Vogl wrote: Use AT#QSS=2 instead of AT#QSS=1 to get an URC when the SIM is not only inserted but ready to be used. Remove sim_inserted_source and sim_inserted_timeout_cb which are not needed anymore as a consequence. By the way the 1 second ti

[PATCH] dundee: disconnect bluetooth link in case dial fails

From: Gustavo Padovan If the ATD*99# dial fails for some reason, NO CARRIER, for example, we need to disconnect the bluetooth link and do further clean up on disconnect_callback(). --- dundee/device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dundee/device.c b/dundee/device.c index 7

Re: [PATCH] doc: Trivial whitespace fixes

Hi Mikel, > Always use tabs instead of spaces for indentation in documentation > files. > --- > doc/location-reporting-api.txt |2 +- > doc/voicecallmanager-api.txt | 12 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) patch has been applied. Regards Marcel __

[PATCH 8/8] gprs: fix bearer dbus signal interface

According to the documentation the data bearer property should be located on interface org.ofono.ConnectionManager. --- src/gprs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 0286e52..e379f7b 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -2

[PATCH 7/8] netreg: adapt CMER and CIEV for telit

Telit uses a 2 to enable indicator event reporting and indicators in a +CIEV URC are identified by strings, not numbers. --- drivers/atmodem/network-registration.c | 46 +--- 1 files changed, 36 insertions(+), 10 deletions(-) diff --git a/drivers/atmodem/network-regi

[PATCH 6/8] gprs: data bearer for telit with PSNT

From: August Mayer Telit neither supports '+CPSB' nor reports the data bearer through '+CGREG'. It has its own +PSNT command. --- drivers/atmodem/gprs.c | 76 1 files changed, 76 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/gprs.c

[PATCH 5/8] gprs-context: print reason for ppp disconnect

--- drivers/atmodem/gprs-context.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c index 58a829b..3694c27 100644 --- a/drivers/atmodem/gprs-context.c +++ b/drivers/atmodem/gprs-context.c @@ -105,7 +105,7 @@ s

[PATCH 4/8] gprs: add quirk for Telit modems

Telit does not support AT+CGAUTO, use AT#AUTOATT=0 instead. --- drivers/atmodem/gprs.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c index 65a8b7b..f87548e 100644 --- a/drivers/atmodem/gprs.c +++ b/drivers/atmodem/gp

[PATCH 3/8] sim: support PIN retry counters for telit modems

From: August Mayer --- drivers/atmodem/sim.c | 57 + include/sim.h |2 + src/sim.c |8 +++ 3 files changed, 67 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 7b48cd9

[PATCH 2/8] telit: add additional port for data connection

Use MDM port for data service and AUX for the AT chat. Disable DCD so that the modem does not hangup after a data connection. Add vendor for sim and gprs. udevng: rename aux port from Data to Aux for telit. Telit software user guide says: USB AUX doesn’t support any flow control method. Therefore

[PATCH 1/8] telit: notify sim inserted when sim ready

Use AT#QSS=2 instead of AT#QSS=1 to get an URC when the SIM is not only inserted but ready to be used. Remove sim_inserted_source and sim_inserted_timeout_cb which are not needed anymore as a consequence. By the way the 1 second timeout was an ugly hack. Don't query current SIM status in cfun_ena

[PATCH] doc: Trivial whitespace fixes

From: Mikel Astiz Always use tabs instead of spaces for indentation in documentation files. --- doc/location-reporting-api.txt |2 +- doc/voicecallmanager-api.txt | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/location-reporting-api.txt b/doc/locati