[PATCH 2/2] modem: Implement ofono_modem_get_voicecall

[Slava Monich]

---
 src/modem.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/modem.c b/src/modem.c
index 9409347..9e25448 100644
--- a/src/modem.c
+++ b/src/modem.c
@@ -194,6 +194,11 @@ struct ofono_gprs *ofono_modem_get_gprs(struct ofono_modem 
*modem)
return __ofono_atom_find(OFONO_ATOM_TYPE_GPRS, modem);
 }
 
+struct ofono_voicecall *ofono_modem_get_voicecall(struct ofono_modem *modem)
+{
+   return __ofono_atom_find(OFONO_ATOM_TYPE_VOICECALL, modem);
+}
+
 struct ofono_atom *__ofono_modem_add_atom(struct ofono_modem *modem,
enum ofono_atom_type type,
void (*destruct)(struct ofono_atom *),
-- 
1.9.1

___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

[PATCH 1/2] include: Add ofono_modem_get_voicecall

[Slava Monich]

---
 include/modem.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/modem.h b/include/modem.h
index 005a42e..bed46c2 100644
--- a/include/modem.h
+++ b/include/modem.h
@@ -31,6 +31,7 @@ extern "C" {
 struct ofono_modem;
 struct ofono_gprs;
 struct ofono_sim;
+struct ofono_voicecall;
 
 enum ofono_modem_type {
OFONO_MODEM_TYPE_HARDWARE = 0,
@@ -84,6 +85,7 @@ void ofono_modem_remove_interface(struct ofono_modem *modem,
 const char *ofono_modem_get_path(struct ofono_modem *modem);
 struct ofono_sim *ofono_modem_get_sim(struct ofono_modem *modem);
 struct ofono_gprs *ofono_modem_get_gprs(struct ofono_modem *modem);
+struct ofono_voicecall *ofono_modem_get_voicecall(struct ofono_modem *modem);
 
 void ofono_modem_set_data(struct ofono_modem *modem, void *data);
 void *ofono_modem_get_data(struct ofono_modem *modem);
-- 
1.9.1

___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Re: HE910-G - Can't activate context

[Jason Tribe]

Hi Denis,

>> The current problem we are having is that we cannot activate the context
>> with ofono or connman. Any attempt fails with:
>>
>> Error activating /telit_1/context1: org.ofono.Error.NotImplemented:
>> Implementation not provided.
>
> You might want to enable debugging (-d command line option) and see what
> it says.  HE910 uses the 'atmodem' gprs-context driver, which in turn
> depends on tun/tap being loaded.  Most likely your kernel is missing
> this functionality or you forgot to load the required module.

Thanks very much for the feedback. You were 100% correct, we did not have
TUN/TAP enabled in our kernel build.

Kind regards
Jason

On Sun, 24 Jun 2018 at 22:14, Denis Kenzior  wrote:

> Hi Jason,
>
> > enable/power the modem through ofono and even register the SIM on the
> > network. From what I can tell, this bug seems to be present in all ofono
> > versions that don't use the he910.c plugin.
>
> Maybe just the newer firmware behaves differently.  I think the people
> who merged the various telit drivers were using LE/UE 910 which is a bit
> newer than the HE910.
>
> > The current problem we are having is that we cannot activate the context
> > with ofono or connman. Any attempt fails with:
> >
> > Error activating /telit_1/context1: org.ofono.Error.NotImplemented:
> > Implementation not provided.
>
> You might want to enable debugging (-d command line option) and see what
> it says.  HE910 uses the 'atmodem' gprs-context driver, which in turn
> depends on tun/tap being loaded.  Most likely your kernel is missing
> this functionality or you forgot to load the required module.
>
> Regards,
> -Denis
>
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono