Re: [PATCH 1/2] include: Add ofono_modem_get_voicecall

[Denis Kenzior]

Hi Slava,


I kind of like these getters for type safety but it's all up to you of 
course.




Right, I can see value in getters for the common ones like sim, gprs & 
voicecall.  But I don't really want to have 20-30 of these functions 
(one for each atom.)  So at some point we have to draw the line.


Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH 1/2] include: Add ofono_modem_get_voicecall

[Slava Monich]

On 02/07/18 18:34, Denis Kenzior wrote:

Hi Slava,

On 06/29/2018 08:57 AM, Slava Monich wrote:

---
  include/modem.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/include/modem.h b/include/modem.h
index 005a42e..bed46c2 100644
--- a/include/modem.h
+++ b/include/modem.h
@@ -31,6 +31,7 @@ extern "C" {
  struct ofono_modem;
  struct ofono_gprs;
  struct ofono_sim;
+struct ofono_voicecall;
    enum ofono_modem_type {
  OFONO_MODEM_TYPE_HARDWARE = 0,
@@ -84,6 +85,7 @@ void ofono_modem_remove_interface(struct 
ofono_modem *modem,

  const char *ofono_modem_get_path(struct ofono_modem *modem);
  struct ofono_sim *ofono_modem_get_sim(struct ofono_modem *modem);
  struct ofono_gprs *ofono_modem_get_gprs(struct ofono_modem *modem);
+struct ofono_voicecall *ofono_modem_get_voicecall(struct ofono_modem 
*modem);

    void ofono_modem_set_data(struct ofono_modem *modem, void *data);
  void *ofono_modem_get_data(struct ofono_modem *modem);



I went ahead and applied this one.  But if we need any more of these I 
would seriously consider exposing __ofono_atom_find to the public API 
instead.





I kind of like these getters for type safety but it's all up to you of 
course.


Regards,
-Slava
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH 1/2] include: Add ofono_modem_get_voicecall

[Denis Kenzior]

Hi Slava,

On 06/29/2018 08:57 AM, Slava Monich wrote:

---
  include/modem.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/include/modem.h b/include/modem.h
index 005a42e..bed46c2 100644
--- a/include/modem.h
+++ b/include/modem.h
@@ -31,6 +31,7 @@ extern "C" {
  struct ofono_modem;
  struct ofono_gprs;
  struct ofono_sim;
+struct ofono_voicecall;
  
  enum ofono_modem_type {

OFONO_MODEM_TYPE_HARDWARE = 0,
@@ -84,6 +85,7 @@ void ofono_modem_remove_interface(struct ofono_modem *modem,
  const char *ofono_modem_get_path(struct ofono_modem *modem);
  struct ofono_sim *ofono_modem_get_sim(struct ofono_modem *modem);
  struct ofono_gprs *ofono_modem_get_gprs(struct ofono_modem *modem);
+struct ofono_voicecall *ofono_modem_get_voicecall(struct ofono_modem *modem);
  
  void ofono_modem_set_data(struct ofono_modem *modem, void *data);

  void *ofono_modem_get_data(struct ofono_modem *modem);



I went ahead and applied this one.  But if we need any more of these I 
would seriously consider exposing __ofono_atom_find to the public API 
instead.


Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono