[PATCHv2] sms: Implement text and datagram watch

Allow setting a watch for incoming text and datagram messages on the sms atom. --- src/ofono.h | 25 + src/sms.c | 163 -- 2 files changed, 171 insertions(+), 17 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 6c7f649.

Re: [PATCH 1/2] isimodem: Add support for audio settings

Hi Kai, 2010/10/1 Kai Vehmanen : > diff --git a/drivers/isimodem/audio-settings.c > b/drivers/isimodem/audio-settings.c > new file mode 100644 > index 000..0ec768d > --- /dev/null > +++ b/drivers/isimodem/audio-settings.c > @@ -0,0 +1,148 @@ > +/* > + * > + *  oFono - Open Source Telephony >

[PATCH] sms: Implement text and datagram watch

This patch allows adding a watch for incoming text and datagram messages on the sms atom. --- src/ofono.h | 20 +++ src/sms.c | 159 -- 2 files changed, 162 insertions(+), 17 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index

[PATCH] smart_messaging: Remove interface on atom removal

--- plugins/smart_messaging.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/plugins/smart_messaging.c b/plugins/smart_messaging.c index fb44cc1..27f88e7 100644 --- a/plugins/smart_messaging.c +++ b/plugins/smart_messaging.c @@ -99,6 +99,9 @@ static void sms_watch(struc

Re: [PATCH 3/7] Add message agent interface documentation

Hi Marcel, 2010/9/29 Marcel Holtmann : > I just don't see text message going directly to the SMS application. > That application has to integrate with the storage. > > The UI needs to do too much work if it has to track SMS coming from an > agent, SMS inside the history and have to keep matching t

Re: [PATCH 3/7] Add message agent interface documentation

On Wed, 2010-09-29 at 04:27 +0200, ext Denis Kenzior wrote: > Hi Aki, > > On 09/27/2010 11:54 AM, Aki Niemi wrote: > > --- > > doc/message-api.txt | 51 > > +++ > > 1 files changed, 51 insertions(+), 0 delet

[PATCH 7/7] Add test sms agent implementation

--- test/sms-agent | 59 1 files changed, 59 insertions(+), 0 deletions(-) create mode 100755 test/sms-agent diff --git a/test/sms-agent b/test/sms-agent new file mode 100755 index 000..58b33c3 --- /dev/null +++ b/test/sms-agent @@ -

[PATCH 6/7] Add agent interface to sms atom

--- src/sms.c | 146 +++- 1 files changed, 143 insertions(+), 3 deletions(-) diff --git a/src/sms.c b/src/sms.c index e6a2f9c..d86b5ec 100644 --- a/src/sms.c +++ b/src/sms.c @@ -38,6 +38,8 @@ #include "smsutil.h" #include "storage.h" +#

[PATCH 5/7] Add message agent implementation

--- Makefile.am|2 +- src/smsagent.c | 344 src/smsagent.h | 56 + 3 files changed, 401 insertions(+), 1 deletions(-) create mode 100644 src/smsagent.c create mode 100644 src/smsagent.h diff --git a/Makefile.am b/Makefi

[PATCH 3/7] Add message agent interface documentation

--- doc/message-api.txt | 51 +++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 9e8d02f..5bdc98d 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -38,6 +38,29 @@ Methods

[PATCH 4/7] Add message agent interface definition

--- include/dbus.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 363bae2..bf945f1 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -42,6 +42,7 @@ extern "C" { #define OFONO_CONNECTION_MANAGER_INTERFACE "org.ofono.ConnectionManage

[PATCH 1/7] Include datagram support to history API

--- include/history.h |5 + src/history.c | 47 ++- src/ofono.h |8 3 files changed, 59 insertions(+), 1 deletions(-) diff --git a/include/history.h b/include/history.h index c1c4aa1..e661f24 100644 --- a/include/history

[PATCH 2/7] Add datagram dispatch to sms atom

--- src/sms.c | 41 +++-- 1 files changed, 27 insertions(+), 14 deletions(-) diff --git a/src/sms.c b/src/sms.c index 9bf7feb..e6a2f9c 100644 --- a/src/sms.c +++ b/src/sms.c @@ -1064,12 +1064,24 @@ static gboolean compute_incoming_msgid(GSList *sms_list,

SMS agent interface

Hi all, This following set of patches introduces an agent interface for receiving text messages as well as vCard and vCal objects. It grows a pair of methods on the org.ofono.MessageManager interface for registering and unregistering such agents. I've included the patches introducing datagram sup

[PATCHv2] Fix 8bit port handling

--- src/sms.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 303d673..99b0812 100644 --- a/src/sms.c +++ b/src/sms.c @@ -1333,8 +1333,8 @@ static void sms_dispatch(struct ofono_sms *sms, GSList *sms_list) }

[PATCH 1/2] Include datagram support to history API

--- include/history.h |5 + src/history.c | 47 ++- src/ofono.h |8 3 files changed, 59 insertions(+), 1 deletions(-) diff --git a/include/history.h b/include/history.h index c1c4aa1..e661f24 100644 --- a/include/history

[PATCH 2/2] Add datagram dispatch to sms atom

--- src/sms.c | 41 +++-- 1 files changed, 27 insertions(+), 14 deletions(-) diff --git a/src/sms.c b/src/sms.c index 9bf7feb..e6a2f9c 100644 --- a/src/sms.c +++ b/src/sms.c @@ -1064,12 +1064,24 @@ static gboolean compute_incoming_msgid(GSList *sms_list,

[PATCH] Fix 8bit port handling

--- src/sms.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 9bf7feb..6143aa2 100644 --- a/src/sms.c +++ b/src/sms.c @@ -1197,8 +1197,8 @@ static void sms_dispatch(struct ofono_sms *sms, GSList *sms_list) }

Re: Reg: Memory capacity exceeded

On Mon, 2010-09-20 at 14:29 +0200, ext Pekka Pessi wrote: > I'm afraid there is a PICS case for this thing. I cannot recall how we > got N900 through this particular hoop, but probably we just waived > this particular test case irrelevant. I know we have the machinery in place in N900 to report me

RE: Reg: Memory capacity exceeded

Hi, On Mon, 2010-09-20 at 13:09 +0200, ext jeevaka.badrap...@elektrobit.com wrote: > Class 2 Messages are stored in the SIM whereas Class 1 Messages are > stored in the device storage which can be host storage or SIM storage. Right now, oFono doesn't store class 2 messages at all, which is a good

Re: [n900 PATCH 2/5] isigen: generic modem driver plugin for isimodems

Hi Rémi, 2010/9/16 Rémi Denis-Courmont : >> That is the goal if and when we have up-to-date kernel, but >> we are not there yet. > > I don't see the point of adding temporary cruft to the main oFono > repository then. Well, I see value in having oFono upstream work as-is with the current MeeGo ke

Re: [PATCH 2/6] Fix common misspellings in drivers

Hi, 2010/9/14 Marcel Holtmann : > Hi Lucas, > >> - * Copyright (C) 2010  Nokia Corporation and/or its subsidary(-ies). >> + * Copyright (C) 2010  Nokia Corporation and/or its subsidiary(-ies). > > for these kind of changes, I prefer if you have buy in from the Nokia > guys. Some companies have str

Re: [RFC PATCH v2 1/4] sms_util: status_report_expiration

Hi Denis, 2010/9/10 Denis Kenzior : > I've been hearing reports that some networks actually rewrite the > address (e.g. change national number to international, etc) which causes > our status reports to not match. That happens. > We can do two things: > 1. Rely on message reference only.  This s

[PATCH] Fix wrong code point in Portuguese table

--- src/util.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util.c b/src/util.c index fd8b305..bb90f6c 100644 --- a/src/util.c +++ b/src/util.c @@ -400,7 +400,7 @@ static const unsigned short por_gsm[] = { 0x0028, 0x0029, 0x002A, 0x002B, 0x002C, 0x002D, 0x0

[PATCHv3 6/6] Add test message agent

--- test/sms-agent | 84 1 files changed, 84 insertions(+), 0 deletions(-) create mode 100755 test/sms-agent diff --git a/test/sms-agent b/test/sms-agent new file mode 100755 index 000..2fea2a6 --- /dev/null +++ b/test/sms-agent @@ -

[PATCHv2 6/6] Add test message agent

--- test/sms-agent | 84 1 files changed, 84 insertions(+), 0 deletions(-) create mode 100755 test/sms-agent diff --git a/test/sms-agent b/test/sms-agent new file mode 100755 index 000..c3630fa --- /dev/null +++ b/test/sms-agent @@ -

[PATCHv2 3/6] Add message agent implementation

--- src/smsagent.c | 416 src/smsagent.h | 66 + 2 files changed, 482 insertions(+), 0 deletions(-) create mode 100644 src/smsagent.c create mode 100644 src/smsagent.h diff --git a/src/smsagent.c b/src/smsagent.c new file mode

[PATCHv2 5/6] Add message agent support to sms atom

--- src/sms.c | 207 +++-- 1 files changed, 187 insertions(+), 20 deletions(-) diff --git a/src/sms.c b/src/sms.c index 461606d..7ef2d12 100644 --- a/src/sms.c +++ b/src/sms.c @@ -36,6 +36,7 @@ #include "util.h" #include "smsutil.h" #inc

[PATCHv2 4/6] Add message agent implementation to build

--- Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index f31180e..fddcaad 100644 --- a/Makefile.am +++ b/Makefile.am @@ -282,7 +282,8 @@ src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) \ src/storage.

[PATCHv2 2/6] Add message agent interface definition

--- include/dbus.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 8cd214d..fb8109f 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -41,6 +41,7 @@ extern "C" { #define OFONO_CONNECTION_CONTEXT_INTERFACE "org.ofono.ConnectionContex

[PATCHv2 1/6] Add message agent interface documentation

--- doc/message-api.txt | 63 +++ 1 files changed, 63 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 693a111..e1baf7a 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -26,6 +26,35 @@ Methods

[PATCHv2 0/6] Add message agent interface

Hi All, Here the same set with a whitespace fix and fix for a discrepancy in the method name in documentation and in code. Here is the diffstat: Makefile.am |3 +- doc/message-api.txt | 63 include/dbus.h |1 + src/sms.c | 207 +++--

[PATCH] Add test message agent

--- test/sms-agent | 84 1 files changed, 84 insertions(+), 0 deletions(-) create mode 100755 test/sms-agent diff --git a/test/sms-agent b/test/sms-agent new file mode 100755 index 000..e627602 --- /dev/null +++ b/test/sms-agent @@ -

[PATCH 4/5] Add message agent implementation to build

--- Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index f31180e..fddcaad 100644 --- a/Makefile.am +++ b/Makefile.am @@ -282,7 +282,8 @@ src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) \ src/storage.

[PATCH 3/5] Add message agent implementation

--- src/smsagent.c | 416 src/smsagent.h | 66 + 2 files changed, 482 insertions(+), 0 deletions(-) create mode 100644 src/smsagent.c create mode 100644 src/smsagent.h diff --git a/src/smsagent.c b/src/smsagent.c new file mode

[PATCH 2/5] Add message agent interface definition

--- include/dbus.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 8cd214d..fb8109f 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -41,6 +41,7 @@ extern "C" { #define OFONO_CONNECTION_CONTEXT_INTERFACE "org.ofono.ConnectionContex

[PATCH 5/5] Add message agent support to sms atom

--- src/sms.c | 207 +++-- 1 files changed, 187 insertions(+), 20 deletions(-) diff --git a/src/sms.c b/src/sms.c index 461606d..7ef2d12 100644 --- a/src/sms.c +++ b/src/sms.c @@ -36,6 +36,7 @@ #include "util.h" #include "smsutil.h" #inc

[PATCH 1/5] Add message agent interface documentation

--- doc/message-api.txt | 63 +++ 1 files changed, 63 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 693a111..e1baf7a 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -26,6 +26,35 @@ Methods

[PATCH 0/5] Add message agent interface

This patch series adds support for run-time registration of message agents that handle certain types of binary SMSs as well as regular text messages. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] Fix port number handling

Remove unnecessary bit shift. --- src/sms.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 088119d..461606d 100644 --- a/src/sms.c +++ b/src/sms.c @@ -804,8 +804,6 @@ static void sms_dispatch(struct ofono_sms *sms, GSList *sms_list)

Re: [PATCH] Default to using 8bit reference numbers

2010/9/2 Aki Niemi : > Just like the rest of the world is doing. > --- >  src/sms.c |    5 +++-- >  1 files changed, 3 insertions(+), 2 deletions(-) Any objections to pushing this patch? Cheers, Aki ___ ofono mailing list ofono@of

Re: [RFCv3] Add message agent API

Hi Marcel, 2010/9/8 Marcel Holtmann : >> Example: a voice and video over IP client that doesn't drain the >> battery in half a day. My server sends a wakeup over SMS on an >> incoming call. > > isn't this most likely done better via WAP Push? Do you have any concert > specification of an VoIP clie

Re: [RFCv3] Add message agent API

Hi Marcel, 2010/9/8 Marcel Holtmann : >> +             void RegisterAgent(object path, string type) >> + >> +                     Registers an agent to handle received messages. >> + >> +                     The object path defines the path of the agent that >> +                     will be called

[RFCv3] Add message agent API

--- doc/message-api.txt | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 693a111..4b7c287 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -26,6 +26,43 @@ Methods

[RFCv2] Add message agent API

--- doc/message-api.txt | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 693a111..10055a3 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -26,6 +26,43 @@ Methods

Re: Update on "Source/Destination port addressing scheme from 3GPP 23.040" TODO task?

Hi Chris, 2010/9/4 Schoppa, Chris : > As we start to flesh out thinking on how to handle SMS notifications, and > WAP Push à MMS message notification in particular, the need for the proposed > SMS message routing to handlers based on Destination Port becomes more > urgent. > > Is there any current

Re: [PATCH 2/4] Enable alphabets in smsutils

Hi, 2010/9/3 Pekka Pessi : > Morjes Aki, > > 2010/9/2 Aki Niemi : >> +       case SMS_ALPHABET_TURKISH: >> +               gsm_encoded = convert_utf8_to_gsm_with_lang(utf8, -1, NULL, >> +                                      

Re: [PATCH 2/4] Enable alphabets in smsutils

On Fri, 2010-09-03 at 16:05 +0200, ext Denis Kenzior wrote: > I see what you're doing now. I'd rather you left out setting udhi in > the dialect switch/case labels and changed this line to set UDHI to TRUE. Ah, then I missed your point. Yes, it's better to set UDHI outside the switch, I agree. C

[alphabets-PATCHv2 4/5] Add alphabet support to SMS atom

Adds a new "Alphabet" D-Bus property. --- src/sms.c | 89 +++- 1 files changed, 87 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 088119d..c5b1bc6 100644 --- a/src/sms.c +++ b/src/sms.c @@ -65,6 +65,7 @@ struct ofon

[alphabets-PATCHv2 3/5] Enable alphabets when encoding

Allows preparing a message list using one of the GSM dialects. --- src/smsutil.c | 108 - src/smsutil.h | 13 +++ 2 files changed, 112 insertions(+), 9 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 6c42e75..1ba4071 100

[alphabets-PATCHv2 5/5] Add documentation for the Alphabet property

--- doc/message-api.txt | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 693a111..bd8e960 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -64,3 +64,19 @@ Properties string ServiceCenterAddress

[alphabets-PATCHv2 1/5] Add so called reduced charset support to SMS

This "reduced" charset support is available in some current phones to reduce the number of segments that a message takes. Normally, when characters are encountered that don't have a representation in the GSM 7 bit alphabet, the encoding switches to UCS-2 that takes roughly twice as much space. Th

[alphabets-PATCHv2 2/5] Unit test for reduced charset

--- unit/test-util.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/unit/test-util.c b/unit/test-util.c index de62848..4d9282a 100644 --- a/unit/test-util.c +++ b/unit/test-util.c @@ -486,6 +486,25 @@ static void test_valid_turkish() } } +st

Re: [PATCH 2/4] Enable alphabets in smsutils

On Thu, 2010-09-02 at 18:55 +0200, ext Denis Kenzior wrote: > > - if (offset != 0) > > - template.submit.udhi = FALSE; > > - > > This part doesn't look right. The check should actually set udhi to > TRUE, since we can be issuing a return in the next if statement... That's why it's re

[PATCHv2] Fix adding 8bit reference number

--- src/sms.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7298563..088119d 100644 --- a/src/sms.c +++ b/src/sms.c @@ -522,7 +522,7 @@ static gboolean tx_next(gpointer user_data) } static void set_ref_and_to(GSList *msg_l

Re: [PATCH 4/4] Add documentation for the Alphabet property

Hi, 2010/9/2 Marcel Holtmann : > If we think we wanna expose this inside the UI, then of course we have > to ask ourselves if this is something a user should be really exposed > to. So this needs use cases and justification for it. Ideally, you'd want none of these parameters exposed to the user.

[PATCH] Default to using 8bit reference numbers

Just like the rest of the world is doing. --- src/sms.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 8262d0c..cdaa629 100644 --- a/src/sms.c +++ b/src/sms.c @@ -687,6 +687,7 @@ static DBusMessage *sms_send_message(DBusConnection *conn, D

[PATCH 4/4] Add documentation for the Alphabet property

--- doc/message-api.txt | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 693a111..9e8ea33 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -64,3 +64,18 @@ Properties string ServiceCenterAddress

[PATCH 3/4] Add alphabet support to SMS atom

--- src/sms.c | 87 +++- 1 files changed, 85 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 2012fe5..8262d0c 100644 --- a/src/sms.c +++ b/src/sms.c @@ -65,6 +65,7 @@ struct ofono_sms { GKeyFile *settings;

[PATCH 2/4] Enable alphabets in smsutils

Add a new function allowing preparing a message list using alphabets. --- src/smsutil.c | 108 - src/smsutil.h | 14 +++ 2 files changed, 113 insertions(+), 9 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 0de420b..7da7

[PATCH 1/4] Add so called reduced charset support to SMS

This "reduced" charset support is available in some current phones to reduce the number of segments that a message takes. Normally, when characters are encountered that don't have a representation in the GSM 7 bit alphabet, the encoding switches to UCS-2 that takes roughly twice as much space. Th

[PATCHv2] Fix adding 8bit reference number

--- src/sms.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7298563..2012fe5 100644 --- a/src/sms.c +++ b/src/sms.c @@ -522,7 +522,7 @@ static gboolean tx_next(gpointer user_data) } static void set_ref_and_to(GSList *msg

[PATCH] Fix adding 8bit reference number

--- src/sms.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7298563..e3582e1 100644 --- a/src/sms.c +++ b/src/sms.c @@ -522,7 +522,7 @@ static gboolean tx_next(gpointer user_data) } static void set_ref_and_to(GSList *msg

Re: [g_isi_send PATCH 3/3] isimodem/ussd: use g_isi_send()

On Wed, 2010-09-01 at 14:03 +0200, Pessi Pekka (Nokia-MS/Helsinki) wrote: > From: Pekka Pessi > > --- > drivers/isimodem/ussd.c | 21 ++--- > 1 files changed, 10 insertions(+), 11 deletions(-) Pushed, thanks. Cheers, Aki ___ ofono

Re: [g_isi_send PATCH 2/3] isimodem/gprs: use g_isi_send()

On Wed, 2010-09-01 at 13:47 +0200, Pessi Pekka (Nokia-MS/Helsinki) wrote: > From: Pekka Pessi > > --- > drivers/isimodem/gprs.c | 48 -- > 1 files changed, 21 insertions(+), 27 deletions(-) Pushed, thanks. Cheers, Aki _

Re: [g_isi_send PATCH 1/3] gisi: added g_isi_send() and g_isi_vsend()

On Wed, 2010-09-01 at 13:47 +0200, Pessi Pekka (Nokia-MS/Helsinki) wrote: > From: Pekka Pessi > > Include a finalize function in GIsiRequest > --- > gisi/client.c | 81 ++-- > gisi/client.h | 12 > 2 files changed, 84 insertions(+)

Re: [g_isi_send RFC 0/3] g_isi_send()

Hi Pekka, 2010/8/30 : > I've added the function g_isi_send() to the gisi client API.  It has been > modeled after g_at_chat_send(), in other words, it includes a GDestroyNotify > function. Looks good to me. This does simplify the client code quite a bit. In fact, I don't see why we would want to

Re: [RFC] Add agent API to message atom

Hi Marcel, 2010/8/31 Marcel Holtmann : >> This was basically what I was thinking, too, with the addition of ^ >> and $ for matching at the end or beginning of a message. > > within GLib we have glob pattern matching functions, but nothing that > additionally takes ^ and $. Why do you think this wo

Re: [RFC] Add agent API to message atom

Hi, 2010/8/31 Zhang, Caiwen : >> +             void RegisterApplicationAgent(object path, uint dest, uint >> src) >> + >> +                     Registers an agent to receive application messages. >> + >> +                     The object path defines the path of the agent that >> +                

Re: [RFC] Add agent API to message atom

Hi, 2010/8/31 Marcel Holtmann : >> +             void RegisterApplicationAgent(object path, uint dest, uint src) >> + >> +                     Registers an agent to receive application messages. >> + >> +                     The object path defines the path of the agent that >> +                  

[RFC] Add agent API to message atom

--- doc/message-api.txt | 97 +++ 1 files changed, 97 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 693a111..ce96315 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -26,6 +26,66 @@ Methods

[PATCH] Fix crash in voicecall atom

Hot-unplugging isimodem causes a crash in the voicecall atom. --- src/voicecall.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 6ad58ad..52311b9 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -220,6 +220,9 @@ static void d

Re: [PATCH 2/2] Add: n900modem driver

Hi, 2010/8/17 Denis Kenzior : > Why are we doing this inside n900modem?  Can't we simply: > > 1. Make isimodem/isimodem.c register these (just like atmodem, stemodem, > mbmmodem, etc does) > 2. Rip out the actual modem driver out of isimodem/isimodem.c > 3. Have plugins/n900.c contain the modem dr

Re: [PATCH 06/12] Refactor ussd parser

On Thu, 2010-06-17 at 00:49 +0200, ext Denis Kenzior wrote: > Aki, > > > --- > > drivers/isimodem/ussd.c | 36 +++- > > 1 files changed, 7 insertions(+), 29 deletions(-) > > > > Please review this patch and comment on whether ISI modems can indeed support > UC

Re: [PATCH 06/12] Refactor ussd parser

On Sun, 2010-06-13 at 11:43 +0200, ext Yang Gu wrote: > --- > drivers/isimodem/ussd.c | 36 +++- > 1 files changed, 7 insertions(+), 29 deletions(-) Looks good. Cheers, Aki ___ ofono mailing list ofono@ofono.org http:

Re: Running ofono on n900 natively

Hi Niko, 2010/6/1 Nicola Mfb : > I'm trying to run ofono on n900 natively, with debian sid installed on > an external SD card (not using meego just to have an easy build > environment directly on the device, kernel, modules and firmware > copied from maemo pr 1.2). > > I activated the phonet0 with

Re: E63 as generic At Modem?

Hi Arun, 2010/5/31 Arun Ravindran : > Hello All, > > I am running the latest ofono in my ubuntu 9.10, under virtual box. > > I have connected my E63 through USB and I can see that the isimodem up and > working. Good, are you able to make calls with it? > I tried to use E63 as a generic modem by

[PATCH] Volunteering for a task

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index d949210..25b6688 100644 --- a/TODO +++ b/TODO @@ -51,6 +51,7 @@ SMS Priority: High Complexity: C2 + Owner: Aki Niemi - Smart Messaging Service. This is a separate standard from Nokia

Re: [PATCH 06/11] Made it possible to ask for status report via SendMessage method parameters. True=status report on, false=off.

On Thu, 2010-05-27 at 13:39 +0200, ext Marcel Holtmann wrote: > > I don't like this being an argument to SendMessage(). I think it needs > > to be exposed, but as a property instead. Is there a use case for > > setting this per message? I think majority of current phones either > > provide a globa

Re: [PATCH 04/11] Changes for SMS statur report.

On Thu, 2010-05-27 at 12:54 +0200, ext pasi.mietti...@ixonos.com wrote: > diff --git a/include/sms.h b/include/sms.h > index daaec37..c007675 100644 > --- a/include/sms.h > +++ b/include/sms.h > @@ -54,7 +54,7 @@ struct ofono_sms_driver { > > void ofono_sms_deliver_notify(struct ofono_sms *sms,

Re: [PATCH 06/11] Made it possible to ask for status report via SendMessage method parameters. True=status report on, false=off.

On Thu, 2010-05-27 at 12:54 +0200, ext pasi.mietti...@ixonos.com wrote: > diff --git a/src/sms.c b/src/sms.c > index b4a5364..d079ece 100644 > --- a/src/sms.c > +++ b/src/sms.c > @@ -400,6 +400,7 @@ static DBusMessage *sms_send_message(DBusConnection > *conn, DBusMessage *msg, > struct ofono

Re: [PATCH 3/4] Add: set_online and post_online methods to isimodem driver

On Thu, 2010-05-27 at 04:08 +0200, ext Denis Kenzior wrote: > Hi Pekka, > > > +static bool mtc_state_cb(GIsiClient *client, const void *restrict data, > > + size_t len, uint16_t object, void *opaque) > > We don't use bools in oFono, please fix this to use gboolean or an

[PATCH] Fix more-messages-to-send indicator

Set the mms indicator based on remaining segment count and not on the message transmit queue status alone. --- src/sms.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/sms.c b/src/sms.c index 3a1cff0..7d4a099 100644 --- a/src/sms.c +++ b/src/sms.c @@ -58,7 +58,

Re: [PATCH 1/4] Add: support for EF_ICCID in isimodem.

Hi Pekka, On Tue, 2010-05-25 at 22:37 +0200, Pessi Pekka (Nokia-D/Helsinki) wrote: > --- > drivers/isimodem/sim.c | 180 +++ > drivers/isimodem/sim.h |1 + > 2 files changed, 104 insertions(+), 77 deletions(-) > > diff --git a/drivers/isimodem/sim

Re: [PATCH 3/3] Add: online and post_online methods to isimodem driver

On Tue, 2010-05-25 at 23:01 +0200, ext Rémi Denis-Courmont wrote: > > bool not_online = isi->online != TRUE; > > bool not_normal = mtc_state != MTC_NORMAL; > > > > struct ofono_error error = { > > not_normal && not_online ? NO_ERROR : FAILURE; > > }; > > Err no. You've put a logical AND where

Re: [PATCH 3/3] Add: online and post_online methods to isimodem driver

Hi Rémi, On Tue, 2010-05-25 at 22:32 +0200, ext Rémi Denis-Courmont wrote: > > > - switch (isi->mtc_state = state) { > > > + ofono_modem_online_cb cb = isi->online_request.callback; > > > + struct ofono_error error = { > > > + (isi->online > > > + ? mtc_state == MTC_NORMAL

Re: Testing asset for oFono

On Tue, 2010-03-30 at 16:22 +0200, Niemi Aki (Nokia-D/Helsinki) wrote: > There are currently a bunch of helper scripts under /test for the D-Bus > API in addition to unit tests, and I'm wondering if there are any plans > to automate especially the former into a suite that could be run > semi-regula

Re: [PATCH 3/3] Add: online and post_online methods to isimodem driver

Hi Pekka, On Fri, 2010-05-21 at 16:25 +0200, Pessi Pekka (Nokia-D/Helsinki) wrote: > --- > drivers/isimodem/isimodem.c | 120 > +-- > 1 files changed, 115 insertions(+), 5 deletions(-) > > diff --git a/drivers/isimodem/isimodem.c b/drivers/isimodem/isimo

Re: [PATCH 1/3] Add: Online property to modem

On Tue, 2010-05-25 at 15:48 +0200, Niemi Aki (Nokia-D/Helsinki) wrote: > Let's refactor this. It's not obvious why we need both these for loops. > How about something like this instead: > > > struct ofono_atom *atom; > > GSList *l = modem->atoms; > > GSList *next; > > > > f

Re: [PATCH 1/3] Add: Online property to modem

Hi Pekka, On Fri, 2010-05-21 at 16:25 +0200, Pessi Pekka (Nokia-D/Helsinki) wrote: > The online/offline state is changed with the new online() modem driver > method. > > In order to track atoms, there are modem states as follows: > - OFONO_MODEM_STATE_POWER_OFF > - OFONO_MODEM_STATE_PRE_SIM > - O

Re: [PATCH] Add: support for EF_ICCID in isimodem.

Hi Pekka, On Fri, 2010-05-21 at 17:54 +0200, Pessi Pekka (Nokia-D/Helsinki) wrote: > --- > drivers/isimodem/sim.c | 160 > +--- > 1 files changed, 96 insertions(+), 64 deletions(-) > > diff --git a/drivers/isimodem/sim.c b/drivers/isimodem/sim.c > in

[PATCH] Fix more-messages-to-send indicator

Set the mms indicator based on remaining segment count and not on the message transmit queue status. --- src/sms.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/sms.c b/src/sms.c index 3a1cff0..9a03b0a 100644 --- a/src/sms.c +++ b/src/sms.c @@ -58,7 +58,6 @@ s

Re: Reg. Request for ISI modem details

Hi, 2010/5/19 satya kishore : > I trying to find the modem source code in oFono source code. I am unable to > get it. Here in oFono code we got only interface to the ISI modem. The modem firmware is not open source. > Where can I get the oFono ISI modem related information like source code or >

[PATCH 1/2] Add network time support

Adding a new notify function in the netreg atom for notifying a received Network Identification and Timezone (NITZ) indication. This data is consumed via a nettime plugin, of which there is also an example. --- Makefile.am | 10 ++-- include/netreg.h |2 + include/nett

[PATCH 2/2] Add isimodem support for network time

--- drivers/isimodem/debug.c|2 + drivers/isimodem/network-registration.c | 39 +++ drivers/isimodem/network.h |3 ++ 3 files changed, 44 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/debug.c b/drivers/isimodem/debug

Network time patches, take two

Resending, as the first patch of the two was failing make distcheck. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 2/2] Add isimodem network time support

--- drivers/isimodem/debug.c|2 + drivers/isimodem/network-registration.c | 39 +++ drivers/isimodem/network.h |3 ++ 3 files changed, 44 insertions(+), 0 deletions(-) diff --git a/drivers/isimodem/debug.c b/drivers/isimodem/debug

[PATCH 1/2] Add network time support

Adding a new notify function in the netreg atom for notifying a received Network Identification and Timezone (NITZ) indication. This data is consumed via a nettime plugin, of which there is also an example. --- Makefile.am | 10 ++-- include/netreg.h |2 + include/nett

Re: oFono status?

On Tue, 2010-05-04 at 13:41 +0200, ext Mats BERGSTROM wrote: > What is the plans for the oFono in conjunction with the MeeGo project? It's clear that oFono is the host telephony stack on MeeGo. Details are still open, though. For instance, which version of oFono will ship with which version of Mee

Re: Access to SIM card when Modem is not "Powered"

to, 2010-04-01 kello 11:14 +0200, ext Pekka Pessi kirjoitti: > It seems to me that Marcel and Aki want to control TX power with the > Powered property. (BTW, there already is a post-sim mechanism to > control the RX/TX, namely Register/Deregister.) But then Register()'s meaning is overloaded to me

<    1   2   3   4   >