Re: [PATCH 3/4] quectel: rework sim detection

Hi Martin, On 9/26/19 2:27 PM, Martin Hundebøll wrote: Simplify sim handling by querying cpin state directly from quectel_pre_sim(). Don't initiate commands from pre_sim/post_sim/post_online callbacks please. There's almost never a reason to. The query is conducted by issuing a

Re: [PATCH 1/4] atmodem: sim: remove quectel serial vendor quirk

Hi Martin, On 9/26/19 2:27 PM, Martin Hundebøll wrote: The sim inserted/initialized state is handled properly in the quectel plugin now, so remove the "auto-initialized" quirk from the atmodem sim driver. --- drivers/atmodem/sim.c | 1 - 1 file changed, 1 deletion(-) Patch 1 & 2 applied,

Re: [PATCH] gprs: free interface name in gprs_context_remove()

Hi Martin, On 9/26/19 2:45 PM, Martin Hundebøll wrote: --- src/gprs.c | 1 + 1 file changed, 1 insertion(+) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH v3 0/3] ublox device initialisation

Hi Jonas, On 9/24/19 11:35 PM, Jonas Bonn wrote: Changed in v3: - consolidate device closing into a common helper - remove timeout in disable function Jonas Bonn (3): ublox: consolidate teardown in common function ublox: use common close_devices when modem disabled ublox: rework

Re: [PATCH] udev: Adding PCIe as a subsystem in udev

Hi Antara, On 9/25/19 4:55 AM, Antara Borwankar wrote: Adding support for enumerating PCIe types of modems in ofono --- plugins/udevng.c | 195 +-- 1 file changed, 174 insertions(+), 21 deletions(-) diff --git a/plugins/udevng.c

Re: [PATCH] ublox: network-registration: Check ureg for tech also for L2 modems

Hi Richard, On 9/24/19 11:11 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors It seems like the CREG reporting from the L2 modems are quite buggy. An example for a L210 where CREG reports UTRAN while COPS and UREG reports LTE. A manual poll also indicates LTE. I also found that the

Re: [PATCHv3] quectel: handle sim states

Hi Martin, I tried implementing what you suggest - see the attached patch. But I still get "SMS not supported by this modem.". The attached log shows quectel_post_sim() being called (line 584) way before QINISTAT returns 3 (line 686). Is this because my SIM isn't locked, and so the

Re: [PATCH v2 1/1] ublox: rework device initialization sequence

Hi Jonas, Furthermore, there's not an AT command sent every 500 ms.  The command gets requeued after 500ms, but it doesn't actually go out until the modem responds to the first one... not quite sure why this works, to be honest. Funny. But not real confidence inspiring :) Martin, any

Re: [PATCH 3/3] ublox: rework device initialization sequence

Hi Jonas, Can data->init_cmd be 0 here? Yes... init_cmd gets cleared in init_cmd_cb when the command succeeds. We reuse the callback to get an extra 1 second delay (which we require) before continuing with the initialization.  There's a comment about this in init_cmd_cb above. Ah

Re: [PATCH 1/3] quectel: remove unused variable

Hi Jonas, On 9/24/19 6:33 AM, Jonas Bonn wrote: --- plugins/quectel.c | 1 - 1 file changed, 1 deletion(-) So this is the 6th instance of this fix now. I get the hint guys :) Anyway, the version from Richard got pushed out. Regards, -Denis

Re: [PATCH 2/3] ublox: raise call to open device

Hi Jonas, On 9/24/19 6:33 AM, Jonas Bonn wrote: --- plugins/ublox.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] quectel: remove unused variable in quectel_pre_sim

Hi Nicola, On 9/24/19 2:15 AM, Nicola Lunghi wrote: From: Nicola Lunghi This variable was left over by a previous commit and in gcc 9.1 was throwing an error an error (unused variable) --- plugins/quectel.c | 1 - 1 file changed, 1 deletion(-) Thanks for the patch. I pushed the one

Re: [PATCH v2] gprs: Do nothing on detached when attaching.

Hi Richard, On 9/23/19 2:15 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors Its incorrect to fiddle with the driver attach state when attaching. When attaching the state is transitioning, and the correct state will now always be assigned in the end of the attach process, regardless

Re: [PATCH] plugins: quectel: Fix compiler warning

Hi Richard, On 9/22/19 3:53 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors plugins/quectel.c: In function ‘quectel_pre_sim’: plugins/quectel.c:1150:20: error: unused variable ‘sim’ [-Werror=unused-variable] struct ofono_sim *sim; --- plugins/quectel.c | 1 - 1 file changed,

Re: [PATCHv3] quectel: handle sim states

Yes I'm with you.  I thought it weird to send CPIN: READY uninitialized.  But okay, I got this part. And of course I meant 'uninitialized' to be 'unsolicited' :) Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCHv3] quectel: handle sim states

Hi Martin, I don't know what you're doing here?  So sim_initialized_notify is meant to be called after PIN entry by the user, e.g. via +CPIN.  Many modems need some time to actually read the SIM file system and perform other initializations prior to functioning properly.  So oFono lets the

Re: [PATCH v2] gprs: Only release detachable context on de-attach

Hi Richard, On 9/17/19 11:25 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors Currently there is an issue if the attach state changes and there are active contexts of which the driver does not implement the detach_shutdown. In that case we just release the context (clears CID and

Re: Issue where a non-active context remains active

Hi Richard, On 9/15/19 12:58 PM, Richard Röjfors wrote: Hi, I would like to discuss this issue before I try to fix it. I might not have the full picture since I don't know how all modems work. The context 4 gets activated: Sep 15 16:06:00 daemon.debug ofonod[542]:

Re: Infinitely calling at_gprs_activate_primary after suspend and resume

Hi Christo, On 9/5/19 5:35 AM, Christo Labuschagne wrote: Good day all We are running ofono 1.29 with a Telit HE910 modem connected via HSIC (USB).  When I suspend the kernel and wake again the following events happen: gatio.c – read_watcher_destroy_notify gatchat.c – io_disconnect So

Re: [PATCH] gprs: deattach driver when gprs status indicates unregistered

Hi Richard, On 9/17/19 4:48 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors In the same way as we consider the driver attached when the gprs status indicates we are registered, we should consider it deattached when the status indicates unregistration. If we don't, then we would

Re: [PATCH] xmm7modem: Fix to set gateway in pdp context

Hi Antara, On 9/18/19 7:53 AM, Antara Borwankar wrote: gateway was not being listed in context settings. Fixed teh bug to show correct gateway address. --- drivers/ifxmodem/gprs-context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Regards, -Denis

Re: [PATCHv3] quectel: handle sim states

Hi Martin, On 9/5/19 5:33 AM, Martin Hundebøll wrote: The quectel M95 and MC60 modems are picky about when the sim is properly initialized, so the logic to detect this needs to be in the quectel plugin. After doing basic initialization, a CPIN query is issued to detect sim state. If the sim

Re: [RFC] gatchat: implement timeout setting for commands

Hi Martin, On 9/5/19 6:41 AM, Martin Hundebøll wrote: Hi Denis, On 02/09/2019 23.25, Denis Kenzior wrote: Hi Martin, On 9/2/19 4:10 PM, Martin Hundebøll wrote: The adds a function to the set a chat-wide timeout for at commands. It allows plugins to handle cases where the modem fails

Re: [PATCH] atmodem: sms: don't request URC buffering for Quectel UC15 modems

Hi Martin, On 9/5/19 4:16 AM, Martin Hundebøll wrote: Add a vendor quirk to avoid an error being returned when setting up sms notification for Quectel UC15 modems. --- drivers/atmodem/sms.c | 1 + 1 file changed, 1 insertion(+) Applied, thanks. Regards, -Denis

Re: [PATCH] ublox: gprs: React on context deactivation

Hi Richard, On 9/3/19 9:06 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors In case a context get deactivated when a AT+CGACT=0 is not issued, indicate that to gprs core. This can happen if the device has an auto activated LTE context and modem switches over to for instance UTRAN.

Re: [PATCHv2] quectel: handle sim states

Hi Martin, On 9/2/19 4:16 PM, Martin Hundebøll wrote: The quectel M95 and MC60 modems are picky about when the sim is properly initialized, so the logic to detect this needs to be in the quectel plugin. After doing basic initialization, a CPIN query is issued to detect sim state. If the sim

Re: [RFC] gatchat: implement timeout setting for commands

Hi Martin, On 9/2/19 4:10 PM, Martin Hundebøll wrote: The adds a function to the set a chat-wide timeout for at commands. It allows plugins to handle cases where the modem fails to respond with either an OK or an error. Okay, this is sort of a known problem without a really good solution...

Re: [PATCH v2 3/3] Revert "gprs: _cid_activated is an 'attaching' state"

Hi Richard, Jonas, On 8/21/19 1:01 AM, Jonas Bonn wrote: Hi Richard, On 20/08/2019 17:56, richard.rojf...@gmail.com wrote: From: Richard Röjfors This reverts commit 1fd419e5b4b3a87673f8e0219edb0f3ed9fca774. This patch is fine and certainly necessary in the context of this series. 

Re: Handle broken AT command process

Hi Martin, On 8/19/19 2:29 PM, Martin Hundebøll wrote: Hi, Does ofono have a way to handle lacking OK/error messages? I seems like my modem (Quectel M95) is buggy when it comes to unsolicited indications and (as far as I have seen) SIM commands:  > AT+CRSM=178,28614,3,4,8  < +CRSM:

Re: [PATCH 1/4] gprs: Check for LTE in gprs_attached_update

Hi Richard, As I said, I'm afraid I have no logs for this. I tried to visualize how it could happen. Sorry for the repeat. Just take it as a strong hint for the "next time" :) But anyway I think it makes more sense to "calculate" the attached state in one place, (gprs_attached_update)

Re: atmodem: introduce send_clcc() to reduce code duplication

On 8/16/19 3:27 PM, Pavel Machek wrote: Reduce code duplication by introducing send_clcc function. Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [rfc] Motorola Droid 4 voice: integrate into atmodem or completely separate?

Hi Pavel, The send_clcc change does sort of make sense separately. Yes, you should have it separate in your inbox ;-). If not, let me know and I'll resend. Doesn't look like I do? Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/4] gprs: Check for LTE in gprs_attached_update

Hi Richard, On 8/16/19 5:44 AM, Richard Röjfors wrote: Hi Denis, Den tors 15 aug. 2019 kl 22:47 skrev Denis Kenzior <mailto:denk...@gmail.com>>: Hi Richard, On 8/14/19 1:24 PM, richard.rojf...@gmail.com <mailto:richard.rojf...@gmail.com> wrote: > Fro

Re: [PATCH 2/4] gprs: Always call gprs_attached_update on context deactivation.

Hi Richard, > attached, and connection managers (at least connman) start > to hammer us to connect a context, eventhough it happens > automatically in LTE. What happens automatically?  Yes, it is true that you need a default context to attach to LTE.  So activating a

Re: [PATCH 1/4] gprs: Check for LTE in gprs_attached_update

Hi Richard, On 8/14/19 1:24 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors Since we have a different condition for the attach state when running on LTE, we should consider it in gprs_attached_update. Previously it's done in some instances. But for instance if the driver got

Re: [PATCH 2/4] gprs: Always call gprs_attached_update on context deactivation.

Hi Richard, On 8/14/19 1:24 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors Since its registered context is a condition for being attached when running LTE, we might need to update the attached state when a context is deactivated. Otherwise we might remain Well, by definition if

Re: [PATCH 1/2] doc: convert quectel power event reasons to lower case

Hi Martin, On 8/13/19 1:08 PM, Martin Hundebøll wrote: --- doc/quectel-hardware-api.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Both applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 2/2] quectel: replace g_at_chat_set_wakeup_command() with g_at_chat_retry()

Hi Martin, On 8/12/19 3:38 PM, Martin Hundebøll wrote: If the modem isn't powered on, the use of g_at_chat_set_wakeup_command() makes ofono send out AT strings in an endless loop. Avoid this by using g_at_chat_retry() in a timer instead. --- plugins/quectel.c | 64

Re: [PATCH 1/2] gatchat: add g_at_chat_retry()

Hi Martin, On 8/12/19 3:38 PM, Martin Hundebøll wrote: The current API doesn't support canceling an in-progress command; instead g_at_chat_cancel() simply removes the callback. In cases where the modem doesn't respond at all to a command, a chat is simply stalled without any way to write new

Re: [PATCH v2 3/3] atmodem: Implement the list_activated_contexts callback

Hi Richard, On 8/12/19 4:31 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors The callback calls cgact and cgdcont to get information regarding any activate context. --- drivers/atmodem/gprs.c | 167 + 1 file changed, 134 insertions(+), 33

Re: [PATCH v2 2/3] gprs: Ignore activated contexts during init, list them later

Hi Richard, On 8/12/19 4:31 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors There is an issue if an context gets auto activated early, then provisioning might not have run yet for instance, so a "new" context is created, which might be duplicated by a provisioning context later. So

Re: [PATCH v2 1/3] gprs: Add list_active_contexts

Hi Richard, On 8/12/19 4:31 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors This is useful for instance during startup where early activated contexts can be listed at a suitable point in time. --- include/gprs.h | 2 ++ 1 file changed, 2 insertions(+) Applied, thanks.

Re: [PATCH v2] gprs: Do not detach when running LTE and GPRS is unavailable.

Hi Richard, On 8/12/19 3:37 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors There are cases where the gprs status might updated to for instance "unknown" while LTE is the bearer. In that case we should not set the attach state to FALSE, since then running LTE the conext activation

Re: [PATCH 3/3] atmodem: Implement the list_activated_contexts callback

Hi Richard, On 8/12/19 3:18 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors The callback calls cgact and cgdcont to get information regarding any activate context. --- drivers/atmodem/gprs.c | 149 - 1 file changed, 116 insertions(+), 33

Re: [PATCH 1/3] gprs: Add list_active_contexts

Hi Richard, On 8/12/19 3:18 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors This is useful for instance during startup where early activated contexts can be listed at a suitable point in time. --- include/gprs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] gprs: Do not detach when running LTE and GPRS is unavailable.

Hi Richard, I have more in the pipeline regarding this, I'm kind of working step by step to get LTE to work properly and with hand over to come. Nice! About time someone looked into this :) Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/2] gprs: Ignore activated contexts during init, list them later

Hi Richard, list_active_contexts?  Also, since there can in theory be multiple ones of these, I'd do something like: typedef void (*ofono_gprs_active_context_cb_t)(int cid, const char *apn,                                                 void *data); void

Re: [PATCH] gprs: Do not detach when running LTE and GPRS is unavailable.

Hi Richard, So I don't get this.  We have CREG telling us: "we're on LTE" and CGREG telling us "Oh we don't know what our status is".  Why do you trust one and not the other?  Are you sure this doesn't belong in a driver quirk somewhere? When CREG tells us we are on LTE, we

Re: [PATCH 1/2] gprs: Ignore activated contexts during init, list them later

Hi Richard, +    void (*get_active_auto_context)(struct ofono_gprs *gprs, +    ofono_gprs_active_context_cb_t cb, +    void *data); list_active_contexts?  Also, since there can in theory be multiple ones of these, I'd do something like: typedef void

Re: [PATCH 1/2] gprs: Ignore activated contexts during init, list them later

Hi Richard, On 8/11/19 11:46 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors There is an issue if an context gets auto activated early, then provisioning might not have run yet for instance, so a "new" context is created, which might be duplicated by a provisioning context later.

Re: [PATCH] gprs: Do not detach when running LTE and GPRS is unavailable.

Hi Richard, On 8/11/19 9:58 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors There are cases where the gprs status might updated to for instance "unknown" while LTE is the bearer. In that case we should not set the attach state to FALSE, since then running LTE the conext activation

Re: [rfc] Motorola Droid 4 voice: integrate into atmodem or completely separate?

Hi Pavel, On 8/12/19 3:22 AM, Pavel Machek wrote: Hi! Droid 4 has ... something similar to AT commands, but not quite. For voice calls, I modified atmodem... but I guess there are so many changes that creating separate motorolamodem/voicecall.c might be an option? (send_clcc() changes make

Re: Motorola Droid 4 SMS sending

Hi Pavel, On 8/10/19 6:14 PM, Pavel Machek wrote: Hi! Motorola Droid 4 runs packet protocol over serial... and its kernel driver requires explicit "write()" boundaries at places where packet boundaries should be. So I can send SMS using low level g_at... functions (that are not normally

Re: Duplicated contexts...

Hi Richard, 21:01:52 daemon.info ofonod[547]: Aux: < \r\n+CIEV: 2,2\r\n 21:01:52 daemon.info ofonod[547]: Aux: < \r\n+CGEV: ME PDN ACT 4\r\n 21:01:52 daemon.info ofonod[547]: Aux: < \r\n+CGEV: NW CLASS "B"\r\n 21:01:52 daemon.info

Re: [PATCH] gprs: Do not leak CID on failure to assign context

Hi Richard, On 8/6/19 6:11 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors --- src/gprs.c | 3 +++ 1 file changed, 3 insertions(+) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: Duplicated contexts...

Hi Richard, On 8/7/19 4:44 PM, Richard Röjfors wrote: Hi, Just want to hear your thoughts of how to fix an issue I saw. The modem was told to activate with COPS=0, that took time. And a context was activated ME PDN ACT, almost immediately when registered (LTE). Interesting. How'd you get

Re: [PATCH v2] gprs: Use -1 as netreg status during init.

Hi Richard, On 8/6/19 3:33 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors Previously the valid "unknown" netreg status was set during startup, but its a bit problematic for gprs. There might be cases where a LTE context is activated before netreg is finished updating its status.

Re: [PATCH] netreg, gprs: Use -1 as netreg status during init.

Hi Richard, > +     gprs->netreg_status = -1; >       gprs->used_pids = l_uintset_new(MAX_CONTEXTS); > Wouldn't changes to gprs.c be sufficient, without touching netreg.c? No unfortunately not. gprs reads the netreg status when it attaches to the atom. Which would be

Re: [PATCH] netreg, gprs: Use -1 as netreg status during init.

Hi Richard, On 8/1/19 6:48 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors Previously the valid "unknown" registration status was set during startup, but its a bit problematic for gprs. There might be cases where a LTE context is activated before netreg is finished updating its

Re: [PATCH] gprs: Postpone attach decisions until netreg is finished

Hi Richard, On 7/24/19 12:02 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors In case the gprs_netreg_update is called from somewhere else than the actual netreg update before any netreg updates have happened. It can not make proper decisions. For instance we might run on EUTRAN but

Re: [PATCH] atmodem: Check for auto activated contexts during init

Hi Richard, On 7/24/19 12:24 PM, richard.rojf...@gmail.com wrote: From: Richard Röjfors To detect if a context gets activated before we register for unsolicited events we need to check if any is already activated, and flag it auto activated. --- drivers/atmodem/gprs.c | 47

Re: Setting "RoamingAllowed" on by default; or storing persistently

Hi Tarmo, 2. if not, can I at least store RoamingAllowed persistently per SIM card? This should already work... Thank you for the quick reply. I'll begin by upgrading ofono to see if the persistence starts to work for me. I would doubt it. The code in question has been in there way

Re: Setting "RoamingAllowed" on by default; or storing persistently

Hi Tarmo, On 7/24/19 9:15 AM, Tarmo Kuuse wrote: Hi! I'd like for my device to automatically connect to 3G data in roaming wherever the GSM network permits it. I'd very much like to set this up as default during manufacturing regardless of the SIM inserted. ofono version 1.21 (debian

Re: [PATCHv3 4/4] doc: document power-event signals for quectel Hardware API

Hi Martin, On 7/19/19 7:39 AM, Martin Hundebøll wrote: --- Changes since v2: * Use Voltage{High,Low} instead of {High,Low}Power Changes since v1: * new patch split out from PATCHv1 7/7 doc/quectel-hardware-api.txt | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: [PATCHv3 2/4] doc: add documentaion for Quectel hardware API

Hi Martin, On 7/19/19 7:39 AM, Martin Hundebøll wrote: --- Changes since v2: * none Changes since v1: * new patch split out from PATCHv1 6/7 * added documentation of charge status and level doc/quectel-hardware-api.txt | 33 + 1 file changed, 33

Re: [PATCHv2] test: process-context-settings: add argument for default connection

Hi Martin, On 7/19/19 3:48 AM, Martin Hundebøll wrote: Add an optional argument to specify an interface to as default connection for the system. This changes the constructed commands so that the gateway is configured as default route, and nameservers are written to resolv.conf. Actually, I

Re: [PATCH 1/2] atmodem: gprs-context: parse list-less CGDATA response

Hi Martin, On 7/19/19 5:27 AM, Martin Hundebøll wrote: The Quectel M95 and MC60 modems respond to AT+CGDATA=? with a single +CGDATA="PPP", but the callback in gprs-context expects a list of protocols. Avoid falling back to the old-style ATD*99 by not expecting a list of protocols for serial

Re: Detecting if a modem has dialing support

Hi Matt, It is in the qmimodem driver, and not sure if any modem using that driver is implementing dialing support. I believe there are some people using a QMI modems for voicecall testing. Don't recall offhand if they're using a hacked firmware or just specific devices. So there are

Re: [PATCH 1/1] ublox: detect and support LARA R2 series

Hi Jonas, On 7/19/19 2:04 AM, Jonas Bonn wrote: --- drivers/ubloxmodem/ubloxmodem.c | 9 + drivers/ubloxmodem/ubloxmodem.h | 3 ++- plugins/udevng.c| 2 ++ 3 files changed, 13 insertions(+), 1 deletion(-) I split this up into two commits and applied, thanks.

Re: [PATCH 1/2] ublox: network-registration atom

Hi Jonas, On 7/19/19 1:51 AM, Jonas Bonn wrote: For uBlox modems, a bit of custom setup is required, but after that the generic "atmodem" (27.007-compatible) method implementations are sufficient. This driver, therefore, just puts the custom probe method into place and defers remaining

Re: [PATCH 06/10] ublox: determine gprs-context driver from network interface

Hi Jonas, On 7/18/19 5:23 AM, Jonas Bonn wrote: Some u-blox devices present a USB network class device for data and some just switch to PPP on (one of) the communication channel(s). Whether the atmodem or ubloxmodem gprs-context driver should be used depends on whether or not the network

Re: [PATCH 01/10] atmodem: export generic netreg funcs

Hi Jonas, On 7/18/19 5:23 AM, Jonas Bonn wrote: An upcoming netreg driver for uBlox modems will need to override the probe method in order to set itself up, but for further functionality the "generic" AT implementations are sufficient. The easiest way to do this is to just set up a vtable with

Re: [PATCH 03/10] ublox: network-registration atom

On 7/18/19 5:23 AM, Jonas Bonn wrote: For uBlox modems, a bit of custom setup is required, but after that the generic "atmodem" (27.007-compatible) method implementations are sufficient. This driver, therefore, just puts the custom probe method into place and defers remaining functionality to

Re: [PATCH 3/4] test: process-context-settings: print commands instead of running them

Hi Martin, On 7/18/19 6:49 AM, Martin Hundebøll wrote: Collect the setup commands and print them to stdout at the end of the script. This allows users to evaluate the standard output to apply settings. --- test/process-context-settings | 12 +--- 1 file changed, 9 insertions(+), 3

Re: [PATCH 1/4] test: process-context-settings: use ip instead of ifconfig/route

Hi Martin, On 7/18/19 6:49 AM, Martin Hundebøll wrote: --- test/process-context-settings | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Patch 1 & 2 applied. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/1] qmimodem: remember lac and cellid

Hi Christophe, On 7/17/19 8:29 AM, Christophe Ronco wrote: Lac and cellid information are optional in ss_info notifications. Remember them in order to give a correct information each time a notification is received. --- drivers/qmimodem/network-registration.c | 53

Re: [PATCH 7/7] quectel: implement dbus signals for modem power notifications

Hi Martin, On 7/16/19 2:10 PM, Martin Hundebøll wrote: The Quectel modems issues unsolicited strings in case of power related events. The UC15 uses +QIND: for the events, while M95 and MC60 uses descriptive strings. (UC15 also uses a string for normal power down). Register listeners for these

Re: [PATCH 6/7] quectel: add dbus hardware interface

Hi Martin, On 7/16/19 2:10 PM, Martin Hundebøll wrote: For now the interface only exposes the modem supply voltage, but is added as a preparation for signaling power events. --- doc/quectel-hardware-api.txt | 15 plugins/quectel.c| 154 +++

Re: [PATCH 1/7] gatresult: strip trailing spaces from unquoted strings

Hi Martin, On 7/16/19 2:10 PM, Martin Hundebøll wrote: Some vendors might print trailing spaces after unsolicited result codes. Avoid duplicating and stripping the string after calling g_at_result_iter_next_unquoted_string() by stripping the spaces in gatresult instead. ---

Re: Detecting if a modem has dialing support

Hi Matt, On 7/18/19 1:53 AM, Matt Ranostay wrote: Hello et al, So there are a few modems that org.ofono.VoiceCallManager interfaces but don't have Dial support, and there is no programmatic way to check without dialing attempting to dial a valid phone number. If a modem driver creates a

Re: [PATCHv3 9/9] quectel: initialize call, phonebook and sms when ready

Hi Martin, On 7/10/19 4:51 PM, Martin Hundebøll wrote: The Quectel M95 modem issues a "Call ready" notification when call and phonebook are ready, so set up a listener for that. The only way to know when sms is ready is to issue QINITSTAT queries. Since sms is always ready after call and

Re: [PATCHv3 7/9] quectel: configure flow control when enabled

Hi Martin, On 7/10/19 4:51 PM, Martin Hundebøll wrote: --- plugins/quectel.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Patch 7 & 8 applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCHv3 6/9] quectel: support gpio to power on/off the modem

Hi Martin, On 7/10/19 4:51 PM, Martin Hundebøll wrote: This adds support for configuring a gpio in udev to control the modem power. To enable gpio control, specify OFONO_QUECTEL_GPIO_CHIP and OFONO_QUECTEL_GPIO_OFFSET in the udev environment, for example: KERNEL=="ttymxc0",

Re: [PATCHv3 5/9] quectel: add basic support for serial connected modems

Hi Martin, On 7/10/19 4:51 PM, Martin Hundebøll wrote: Setup GSM 07.10 multiplexing using the kernel n_gsm line discpline driver, and use the virtual tty devices as Aux and Modem channels. The driver supports rts/cts on the underlying serial device. This is enabled with OFONO_QUECTED_RTSCTS

Re: [PATCHv3 0/9] Quectel M95 support

Hi Martin, On 7/10/19 5:21 PM, Martin Hundebøll wrote: Hi, The modem supports an unsolicited notification for voltage level warnings and errors. I.e it can send   UNDER_VOLTAGE POWER DOWN   UNDER_VOLTAGE WARNING   OVER_VOLTAGE WARNING   OVER_VOLTAGE POWER DOWN The power down messages

Re: [PATCHv3 1/9] atmodem: sms: add quectel m95 quirks

Hi Martin, On 7/10/19 4:51 PM, Martin Hundebøll wrote: CNMA isn't mentioned in the m95 documentation, but trial'n'error has revealed some details: * the CSMS query returns the list (0,128) instead of a range * CNMA is enabled by setting 128 as CSMS service * once enabled, SMS deliveries

Re: [PATCH 09/10] quectel: add basic support for serial connected modems

Hi Martin, On 07/09/2019 01:50 AM, Martin Hundebøll wrote: Hi Denis, On 08/07/2019 18.12, Denis Kenzior wrote: However, there is still the fundamental issue of not being able to correlate the created ttys to the original one...  If we can fix that in the kernel, then a strong argument can

Re: [PATCH 09/10] quectel: add basic support for serial connected modems

Hi Lars, On 07/08/2019 04:05 AM, Lars Poeschel wrote: On Fri, Jul 05, 2019 at 05:57:05PM -0500, Denis Kenzior wrote: Hi Martin, On 07/03/2019 01:09 PM, Martin Hundebøll wrote: Setup GSM 07.10 multiplexing using the kernel n_gsm line discpline driver, and use the virtual tty devices as Aux

Re: [PATCHv2 10/10] quectel: support gpio to power on/off the modem

Hi Martin, On 07/04/2019 06:03 AM, Martin Hundebøll wrote: This adds support for configuring a gpio in udev to control the modem power. To enable gpio control, specify OFONO_QUECTEL_GPIO_CHIP and OFONO_QUECTEL_GPIO_OFFSET in the udev environment, for example: KERNEL=="ttymxc0",

Re: [PATCH 09/10] quectel: add basic support for serial connected modems

Hi Martin, On 07/03/2019 01:09 PM, Martin Hundebøll wrote: Setup GSM 07.10 multiplexing using the kernel n_gsm line discpline driver, and use the virtual tty devices as Aux and Modem channels. The driver supports rts/cts on the underlying serial device. This is enabled with

Re: [PATCHv2 08/10] quectel: fix initial channel/device configuration

Hi Martin, On 07/04/2019 06:03 AM, Martin Hundebøll wrote: The three-commands-in-one-go results in error on some quectel devices (e.g. m95). Add semicolons between the commands to fix it. --- plugins/quectel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks.

Re: [PATCH 07/10] quectel: replace glib uses with ell

Hi Martin, On 07/03/2019 01:09 PM, Martin Hundebøll wrote: --- plugins/quectel.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/plugins/quectel.c b/plugins/quectel.c index 83197991..3c6b9d9f 100644 --- a/plugins/quectel.c +++ b/plugins/quectel.c @@ -27,7 +27,7

Re: [PATCH 04/10] quectel: use plain c-types over glib/ofono typedefs

Hi Martin, On 07/03/2019 01:09 PM, Martin Hundebøll wrote: --- plugins/quectel.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/plugins/quectel.c b/plugins/quectel.c index f99b1ff8..50657265 100644 --- a/plugins/quectel.c +++

Re: [PATCH 01/10] gatresult: include glib header

Hi Martin, On 07/03/2019 01:09 PM, Martin Hundebøll wrote: The gatresult data types embeds GSList members, and the function prototypes uses glib types. Add include of glib.h to allow use of gatresult.h without also including glib.h --- gatchat/gatresult.h | 2 ++ 1 file changed, 2

Re: [PATCH] ubloxmodem: fix maybe-unitialized error

Hi Martin, On 06/21/2019 03:21 PM, Martin Hundebøll wrote: Hi Denis, On 21/06/2019 19.54, Denis Kenzior wrote: What compiler are you using?  gcc really needs to make up its mind whether it warns about enums or doesn't.  The behavior between versions is nuts. % arm-oe-linux-gnueabi-gcc

Re: [PATCH] ubloxmodem: fix maybe-unitialized error

Hi Martin, On 06/21/2019 04:56 AM, Martin Hundebøll wrote: Fixes: ../git/drivers/ubloxmodem/gprs-context.c: In function ‘ublox_gprs_activate_primary’: ../git/drivers/ubloxmodem/gprs-context.c:339:2: error: ‘auth’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]

Hi Martin, On 06/21/2019 04:52 AM, Martin Hundebøll wrote: Hi Denis, On 08/02/2019 21.15, Denis Kenzior wrote: Hi, On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:    CC       drivers/mbimmodem/mbim-message.o drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’: drivers

Re: [PATCH] xmm7modem: disabling reporting of intermediate results for CGDATA

Hi Antara, On 06/20/2019 07:07 AM, Antara Borwankar wrote: Setting in AT+XDATACHANNEL set command to 0. This will disable intermediate result reporting of "CONNECT" and "NO CARRIER" on control channel. This resolves the issue of getting failure response for offline-modem since "NO CARRIER" is

Re: qmimodems: netreg properties CellId and LocationAreaCode sometimes not present

Hi Christophe, On 06/20/2019 05:18 AM, Christophe Ronco wrote: Hi, With qmi modems I am using (quectel EG25, sierra MC7304), sometimes I don't have CellId and LocationAreaCode properties in netreg properties while I am registered. Example: root@klk-wiis-020001:~ # dbus-send --system

Re: [PATCH] udev: Adding PCIe as a subsystem in udev

Hi Varun, On 06/18/2019 08:05 AM, Varun Gargi wrote: Adding support for enumerating PCIe types of modems in ofono --- plugins/udevng.c | 190 --- 1 file changed, 168 insertions(+), 22 deletions(-) mode change 100644 => 100755

<    1   2   3   4   5   6   7   8   9   10   >