Hi Giacinto,
+static int gemalto_get_auth_type(enum ofono_gprs_auth_method auth_method)
+{
+ switch (auth_method) {
+ case OFONO_GPRS_AUTH_METHOD_PAP:
+ return 1;
+ case OFONO_GPRS_AUTH_METHOD_CHAP:
+ return 2;
+ case OFONO_GPRS_AUTH_METHOD_NONE:
+
Hi Nandini,
On 10/12/2018 03:12 AM, Nandini Rebello wrote:
Adding new language support to set "alphabet" parameter.
---
test/set-sms-alphabet | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
___
ofono
On 10/12/2018 03:12 AM, Nandini Rebello wrote:
Adding national language tables for hindi,kannada,malayalam,
oriya,punjabi,tamil,telugu and urdu.
---
src/smsutil.c |4 +-
src/smsutil.h |8 +
src/util.c| 1867 +
src/util.h
Hi Nandini,
On 10/12/2018 03:11 AM, Nandini Rebello wrote:
Adding support for 8 additional languages for GSM 7 bit.
---
src/sms.c | 32
1 file changed, 32 insertions(+)
Applied, thanks.
Regards,
-Denis
___
Hi Giacinto,
+static const char *none_prefix[] = { NULL };
+
+/* According to 27.007 COLP is an intermediate status for ATD */
+static const char *atd_prefix[] = { "+COLP:", NULL };
+
+#define FLAG_NEED_CLIP 1
Do you even need this?
+
+struct voicecall_data {
+ GAtChat *chat;
+
Hi Giacinto,
Given that, polluting atutil.c with vendor-specific code is not a great
idea. Even though you don't want to repeat the same code in lte.c and
gprs-context.c, it's not a big deal to do so, and the code is probably
easier to follow that way anyway.
What about introducing a
Hi Giacinto,
On 10/13/2018 03:09 AM, Giacinto Cifelli wrote:
Added a vendor-specific extension for handling PDP context creation
and authentication, using the actual formats for the vendor.
No, please don't do this. atutil is only for generic / utility code
that is vendor neutral. E.g.
Hi Jonas,
+
The above isn't wrong, but I question the need for the atomic
constructs. ofono isn't a thread-safe library.
I see that there other uses of atomic accessors in the codebase, but I
believe these are remnants of a past approach with other ambitions...
Denis will set me right
Hi Giacinto,
+ cbd->cb = cb;
+ cbd->data = data;
+ cbd->ldd = ldd;
You can't really do that. There's no guarantee that the core atom will
keep this object around for the lifetime of the driver transaction.
That's interesting. Can I pass const struct ofono_lte *lte, or the
same
Hi Giacinto,
On 10/12/2018 01:15 PM, Giacinto Cifelli wrote:
I have already added it.
I have just greped through the code, here are some examples, from the
end of the output:
plugins/phonesim.c:18187: if (g_at_chat_send(data->chat, buf, none_prefix,
plugins/phonesim.c-18237- set_online_cb,
Hi Giacinto,
On 10/12/2018 08:16 AM, Giacinto Cifelli wrote:
The ofono_lte_default_attach_info now handles also the protocol and the
authentication method, username and password.
Co-authored-by: Martin Baschin
---
drivers/atmodem/lte.c | 94 ++-
1
Hi Giacinto,
On 10/12/2018 11:54 AM, Giacinto Cifelli wrote:
Hi,
I trust you, but I have checked the code :)
you are right, the at_command_create may fail (on allocation error
from g_try_new0) and in this case it doesn't call the g_free.
However I have to say that the code leaks alot:
Hi Giacinto,
Ugh. I'm not really liking this at all. The property name and the new
value are already available inside the dbus_message object (e.g.
lte->pending). There's nothing wrong with parsing that message again or
simply store pointers to the data inside the dbus-message.
ah no!
Hi Giacinto,
On 10/10/2018 01:54 AM, Giacinto Cifelli wrote:
---
AUTHORS | 3 +++
1 file changed, 3 insertions(+)
Please don't send me patches to AUTHORS. The maintainers will take care
of it. If I forget, send me a nudge to do so.
diff --git a/AUTHORS b/AUTHORS
index
Hi Giacinto,
Reading through your patches, I'm missing an overarching explanation of
why we need this. Do you really have an LTE network in range that
requires authentication for the default APN?
yes, quite a few of them actually.
And all private APN I have seen so far require
Hi Giacinto,
+static void at_set_reg_info(const struct ofono_lte *lte,
+ const struct ofono_lte_default_attach_info *info)
{
- struct cb_data *cbd = user_data;
- ofono_lte_cb_t cb = cbd->cb;
- struct ofono_error error;
+ struct lte_driver_data
Hi Giacinto,
@@ -69,19 +78,57 @@ static void lte_load_settings(struct ofono_lte *lte)
return;
}
- apn = g_key_file_get_string(lte->settings, SETTINGS_GROUP ,
- DEFAULT_APN_KEY, NULL);
- if (apn) {
+ apn =
Hi Nandini,
On 10/11/2018 06:23 AM, Nandini Rebello wrote:
Fix a missing char in the nation language set in single shift table
for a special character. Character set again validated.
Future language table to carry this fix.
---
src/util.c | 2 ++
1 file changed, 2 insertions(+)
Applied,
Hi Giacinto,
On 10/09/2018 02:32 PM, Giacinto Cifelli wrote:
ofono_gprs_proto and ofono_gprs_auth_method, and related length consts,
moved to types.h from gprs-context.h,
so that they can be shared also with lte core functions
---
include/gprs-context.h | 21 -
Hi Antara,
diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c
index 066e2e7..243738e 100644
--- a/plugins/xmm7xxx.c
+++ b/plugins/xmm7xxx.c
I also added '#include ' at the top of this file.
@@ -356,6 +356,7 @@ static void xmm7xxx_post_online(struct ofono_modem *modem)
Hi Antara,
On 10/09/2018 06:41 AM, Antara Borwankar wrote:
From: Antara
adding netmon driver for xmm7modem which uses intel proprietary
AT command +XMCI
---
drivers/xmm7modem/netmon.c| 264 ++
drivers/xmm7modem/xmm7modem.c | 3 +-
Hi Giacinto,
I applied a modified version of this patch, see below:
diff --git a/drivers/mbimmodem/gprs-context.c b/drivers/mbimmodem/gprs-context.c
index 79793c92..be256e43 100644
--- a/drivers/mbimmodem/gprs-context.c
+++ b/drivers/mbimmodem/gprs-context.c
@@ -75,9 +75,11 @@ static uint32_t
Hi Giacinto,
On 10/06/2018 12:45 AM, Giacinto Cifelli wrote:
support of 'none' in file-provisioning:
the default authentication method is set to NONE
support of 'none' in mbpi:
the default method remains CHAP, but it is overridden by NONE after
parsing the entire key for the apn and detecting
Hi Giacinto,
On 10/06/2018 12:45 AM, Giacinto Cifelli wrote:
---
doc/connman-api.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Patch 1 & 2 applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
Hi Giacinto,
On 10/06/2018 12:45 AM, Giacinto Cifelli wrote:
---
src/gprs.c | 7 +++
1 file changed, 7 insertions(+)
Applied, see below:
diff --git a/src/gprs.c b/src/gprs.c
index 79fafdbc..235c8884 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -261,6 +261,10 @@ static const char
Hi Giacinto,
Not according to any compiler I tried. I literally tested this before
sending the above email on both GCC 7.3 and GCC 8.2. So what compiler
are you using?
default ubuntu 18.04 compiler:
gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
This was the same on my box. I bet you were just
Hi Giacinto,
On 10/04/2018 12:20 AM, Giacinto Cifelli wrote:
support of 'none' in file-provisioning and in mbpi.
The default authentication method is set to 'none'.
---
plugins/file-provision.c | 7 +--
plugins/mbpi.c | 5 -
2 files changed, 9 insertions(+), 3 deletions(-)
Hi Giacinto,
this is in a function that assigns the variable for sure:
static uint32_t auth_method_to_auth_protocol(enum ofono_gprs_auth_method method)
{
switch (method) {
case OFONO_GPRS_AUTH_METHOD_CHAP:
return 2; /* MBIMAuthProtocolChap */
case OFONO_GPRS_AUTH_METHOD_PAP:
return 1; /*
Hi Giacinto,
You are not giving any choice here, other than rewriting gcc.
The function I have tried, and the compiler still complains.
I need a way out: please decide for the lesser evil, and I'll do it.
I already gave you two way out actually. So tell me why either of the
below wouldn't
Hi Giacinto,
I prefer we set a good example :)
Then the cleanest way is to set a default in the switch, without any function.
Ok?
That is not really great either. We want to make sure that the compiler
warns us if we add a new enumeration and don't take care of it in the
code. In fact
Hi Giacinto,
Ugh. I really hate GCC people sometimes. While the warning is strictly
correct, it is useless for 99% of the code and forces us to jump through
hoops. Anyway, I would propose we use the following pattern:
int auth_method_to_qmi(enum ofono_auth_method method, uint8_t *out_auth)
Hi Giacinto,
All right. But do you also want to mention this behavior in the D-Bus
documentation? E.g. something to the effect of if AuthenticationMethod
is set to None, then username / password values are ignored?
gladly, but I didn't find a document for this.
We are going to add it in the
Hi Giacinto,
I suppose your comments on [PATCH 2/4]. I have addressed them on the
[PATCH 2/6].
Basically, as you can also see from the code, the user-set value are stored,
but the driver changes them internally if suited:
- if no username it changes to AUTH_NONE, this is already in place for
Hi Giacinto,
On 10/02/2018 01:26 AM, Giacinto Cifelli wrote:
Added the explicit support for auth NONE.
It is added in all drivers/*/gprs-context.c atoms that support
authentication.
The support for no-authentication case is already present in all
drivers. This patch allows to use it
On 10/02/2018 10:32 PM, Giacinto Cifelli wrote:
Added authentication method G_AT_PPP_AUTH_METHOD_NONE and its handling.
---
gatchat/gatppp.c | 3 ++-
gatchat/gatppp.h | 1 +
gatchat/ppp_lcp.c | 3 +++
3 files changed, 6 insertions(+), 1 deletion(-)
I went ahead and applied this one.
H Anirudh,
On 10/03/2018 01:37 AM, Anirudh Gargi wrote:
Enable SMS and Phonebook atom for the xmm7xxx series modem.
SMS send and CREG eutran states fixed in atmodem driver to support
sms and phonebook feature for xmm7xxx based modems.
---
plugins/xmm7xxx.c | 10 +-
1 file changed, 9
Hi Giacinto,
On 10/02/2018 01:26 AM, Giacinto Cifelli wrote:
Added authentication method G_AT_PPP_AUTH_METHOD_NONE and its handling.
This method is already used in the code, and
Hmm, I don't think so?
the patch is just allowing its explicit use, on top of the implicit
selection done when
Hi James,
On 10/02/2018 05:41 PM, James Prestwood wrote:
The input to the comp128 algorithm was relying on QSTRING_TO_BUF
returning a pointer to persistant memory. This was not the case
as it was returning a pointer to an intermediate object which was
being freed once out of scope. It just
Hi Antara,
On 10/01/2018 06:04 AM, Antara Borwankar wrote:
From: Antara
adding netmon driver for xmm7modem which uses intel propreitory
typo -> proprietary
AT command +XMCI
---
Makefile.am | 3 +-
drivers/xmm7modem/netmon.c| 329
Hi Antara,
On 10/01/2018 05:33 AM, Antara Borwankar wrote:
From: Antara
Added coex-api.txt which defines the generic coex dbus inteface
and coex agent interface.
So I don't mind this living inside doc, but lets make sure to make it
clear that this is an intel only feature.
So perhaps
Hi Antara,
On 10/01/2018 05:33 AM, Antara Borwankar wrote:
From: Antara
Added coex.h which describes the includes of coex atom
---
include/coex.h | 119 +
1 file changed, 119 insertions(+)
create mode 100644 include/coex.h
Since
On 10/01/2018 05:02 AM, Nandini Rebello wrote:
Adding support for bengali and gujrati for GSM 7 bit. More 8 to
follow soon. Adding script to set the sms alphabet.
---
doc/messagemanager-api.txt | 2 +
src/sms.c | 8 +
src/smsutil.c | 4 +-
src/smsutil.h
Hi Anirudh,
On 10/01/2018 01:19 AM, Anirudh Gargi wrote:
In case of AT callback if callback handler is NULL, check for null
before calling the success macro.
Logs:
ofonod[32496]: src/network.c:current_operator_callback() 0x157ad60, (nil)
ofonod[32496]: src/gprs.c:netreg_status_changed() 0
Hi Anirudh,
On 09/28/2018 12:46 AM, Anirudh Gargi wrote:
Patch to be considered, if support for EUTRAN SMS states accepted.
SMS registered flag while sending sms to consider the new EUTRAN
registered status also.
---
src/sms.c | 2 ++
1 file changed, 2 insertions(+)
Applied, thanks.
Hi Anirudh,
On 09/28/2018 12:31 AM, Anirudh Gargi wrote:
EUTRAN SMS states mapped to registered and roaming respectively.
For the new CREG status (9/10) of CREG, it can be map to a new Dbus
CSFB property.
Added clarity in API doc for voice calling in case of lte.
---
doc/network-api.txt | 4
Hi Daniel,
While we have DHCP code in ConnMan I wouldn't recommend to port it as it
is. Patrik reimplemented DHCP for systemd-netword using ConnMan's
version as blueprint. That code looks much saner. Propably, it would
make sense to carve out a library (using ELL as support library) from
the
Hi Giacinto,
Err, why? We should get a proper status from +CREG. And the
network-registration state overrides whatever status the gprs atom
thinks it is in.
yes and no. In case of handover things get messy today.
I will try to collect a log to show this.
Great, that would be useful.
Hi Giacinto,
You can't really do that though. It is fully possible for a modem to
roam off LTE onto 3G and not be attached... So we still need tosend
+CGATT in this case.
You can't really do that, either. It is possible that the module hops
off LTE for a CSFB call of for a simple SMS, and
Hi Pavel,
On 09/27/2018 04:47 PM, Pavel Machek wrote:
Move debug print to more useful place in setup_gobi().
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Pavel,
On 09/27/2018 04:47 PM, Pavel Machek wrote:
Fix typo in location-reporting-api.txt.
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Pavel,
On 09/27/2018 04:47 PM, Pavel Machek wrote:
Explain "delivery report" parameter in send-sms.
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Pavel,
On 09/27/2018 04:47 PM, Pavel Machek wrote:
at_cmt_notify() calls ofono_error even in case stuff is
okay. Fix that.
I think this was already fixed upstream.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
Hi Giacinto,
For the gemaltomodem/gprs-context, it is not clear how to proceed. Would
you kindly give some suggestion other than "these modules don't exist in
my world"?
I did give you a suggestion on how to proceed. Lets get the sane ones
supported first. That should be mostly easy.
Hi Giacinto,
On 09/25/2018 08:20 AM, Giacinto Cifelli wrote:
Default value for gprs authentication method:
for most of the atoms, there is already a default, that is either
no authentication or error.
In case of error (only PAP and CHAP supported), this is unchanged, like
for atmodem PPP. This
Hi Giacinto,
On 09/25/2018 08:20 AM, Giacinto Cifelli wrote:
---
src/gprs.c | 7 +++
1 file changed, 7 insertions(+)
I don't believe this patch is complete. It doesn't address certain
issues that arise from the introduction of this auth method. For
example, what happens if a
Hi Giacinto,
On 09/23/2018 12:23 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/gprs.c | 128 +++--
1 file changed, 123 insertions(+), 5 deletions(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index fc0d8aa3..84ee5c7d 100644
---
Hii Giacinto,
On 09/23/2018 12:21 AM, Giacinto Cifelli wrote:
In case of LTE modem, attaching manually is normally unneeded.
Forcing a detach (in case of gprs-context activation failure) is
actually a mistake, also because this will also trigger a technology
reselection and a possible invalid
Hi Giacinto,
On 09/23/2018 12:15 AM, Giacinto Cifelli wrote:
According to the 27.007 CGREG (both as URC and command) is no longer
sufficient to determine the registration state.
What does CGREG have to do with the overall registration state? CGREG
is only used for packet domain
Hi Jörg,
On 09/27/2018 08:57 AM, Jörg Rebenstorf wrote:
I tried to use the org.ofono.LocationReporting service to get NMEA data.
Is there some working example available how to use the location service
(with this modem) or any recommendations what to check for?
Is it possible that ...
Hi Anirudh,
On 09/27/2018 06:19 AM, Anirudh Gargi wrote:
Add handling for CREG's status to get the technology type. CREG
notify URC does not need additional handling as 'AcT' is mapped
one-on-one to tech.
---
drivers/atmodem/network-registration.c | 4
1 file changed, 4 insertions(+)
Hi Giacinto,
On 09/26/2018 09:43 PM, Giacinto Cifelli wrote:
---
drivers/atmodem/sms.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
Applied after tweaking the coding style.
Regards,
-Denis
___
ofono mailing list
Hi Giacinto,
On 09/26/2018 06:32 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/sms.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
This patch doesn't apply. I'm guessing it is on top of your local tree
and not on top of origin/master.
Regards,
-Denis
Hi Clement,
I ran a quick diff between this and sim900 driver and there's really not
enough differences to warrant a completely separate plugin. Can't we just
simply query the model version and act accordingly?
My opinion is that the sim800 driver is much to be needed as Simcom considers
Hi Clement,
On 09/24/2018 05:43 PM, Clement Viel wrote:
From: clem
Your author information is still broken for the actual commits. Please
fix that.
---
Makefile.am | 4 +
plugins/sim800.c | 463 +++
2 files changed, 467
Hi Giacinto,
On 09/25/2018 08:19 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/sms.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index 64169086..64d0f6e8 100644
--- a/drivers/atmodem/sms.c
+++
Hi Giacinto,
On 09/25/2018 02:13 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/sms.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Both applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
On 09/25/2018 02:12 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/sim.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Both applied. Can you make sure that your patches are also
sequence-numbered.
e.g.
git format-patch -2
git send-email 000*
Regards,
-Denis
Hi Giacinto,
It is not taken out. It is:
case OFONO_VENDOR_CINTERION:
case OFONO_VENDOR_GEMALTO:
if (g_at_chat_send(sd->chat, "AT^SPIC", gemalto_spic_prefix,
gemalto_spic_cb, cbd, g_free) > 0)
both are there, and the
Hi Giacinto,
But the VENDOR_CINTERION remains in the code, there are no changes for
the plugin.
That's exactly the point. You have taken out all VENDOR_CINTERION
logic, yet plugins/gemalto.c still sets VENDOR_CINTERION for the sim
atom. So now you broke that driver. Your change set is
Hi Giacinto,
Besides, several modules use the option linux driver, which blocks in
case the port doesn't answer.
This single call:
g_at_chat_unref(port);
blocks either 30s or 1 minute, depending on the system. I might step
into it twice during my hardware initialization for several 3G models.
Hi Giacinto,
On 09/24/2018 12:45 AM, Giacinto Cifelli wrote:
Dear all,
I have stepped into a very slow networks, that takes almost 1 minute to
assign an IP address once the MBIM CONNECT DONE is returned.
Under these conditions, the call to IP_CONFIGURATION returns all empty
values, and the
Hi Giacinto,
On 09/23/2018 01:19 AM, Giacinto Cifelli wrote:
The GNSS receiver configuration is highly proprietary.
Some are configured through the GNSS port itself, some through other
ports. The properties themselves vary among the manufacturers, with no
standard available. Besides, ofono
On 09/23/2018 12:31 AM, Giacinto Cifelli wrote:
Cinterion and Gemalto overlap for now, but
eventually Cinterion will be removed.
Yes, but some explanation of why CMMS is being taken out for gemalto
(but not cinterion?) devices might be nice.
---
drivers/atmodem/sms.c | 18
Hi Giacinto,
On 09/23/2018 12:28 AM, Giacinto Cifelli wrote:
also renamed the cinterion_* functions in gemalto_*.
Eventually, the vendor cinterion will be removed.
---
drivers/atmodem/sim.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
This is all great and all, but where
Hi Giacinto,
On 09/23/2018 12:26 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/cbs.c | 1 +
1 file changed, 1 insertion(+)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Giacinto,
On 09/22/2018 11:41 PM, Giacinto Cifelli wrote:
this function can be used in the drivers to query the functions
ofono_modem_get_* to retrieve modem-specific properties
---
include/lte.h | 2 ++
1 file changed, 2 insertions(+)
Both applied after tweaking the commit
Hi Giacinto,
So until the GPRS_AUTH_METHOD_NONE is actually introduced, you might
want to just get this upstream with the existing enumeration. E.g.
just
assume that if username & password is empty, the auth method is none.
I have pushed the new method NONE again, and I
Hi Giacinto,
On 09/22/2018 04:49 AM, Giacinto Cifelli wrote:
---
src/lte.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
Hi Giacinto,
On 09/19/2018 10:32 PM, Giacinto Cifelli wrote:
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
Please squash this commit into the previous one. If you're adding new
files into the project, modifications to Makefile.am are exempted from
the 1 subdirectory / commit
Hi Giacinto,
On 09/19/2018 10:32 PM, Giacinto Cifelli wrote:
---
drivers/gemaltomodem/gemaltomodem.c | 3 +-
drivers/gemaltomodem/gemaltomodem.h | 3 +
drivers/gemaltomodem/voicecall.c| 965
3 files changed, 970 insertions(+), 1 deletion(-)
Hi Giacinto,
I will check about the is_ready false, but definitely the
disconnect_handler is not called, I can tell you,
because on a special condition I have received a OPEN DONE with failure,
and the driver remained hanging.
However, after calling it, there is a second call to
Hi Giacinto,
On 09/20/2018 12:03 PM, Giacinto Cifelli wrote:
hi Denis,
On Thu, 20 Sep 2018, 18:31 Denis Kenzior, <mailto:denk...@gmail.com>> wrote:
Hi Giacinto,
> The idea would be to just store the values in the driver but not
in the
> module,
>
Hi Giacinto,
The idea would be to just store the values in the driver but not in the
module,
and then send them before attaching, so that the verification can be
consistent and all,
just like for the gprs-context atom.
Yes, but that is not what you outlined in the code. You were watching
Hi Giacinto,
If you can apply directly it would be great, thanks.
Okay, applied with just the first chunk and a tweaked commit message.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
Hi Giacinto,
static DBusMessage *lte_set_property(DBusConnection *conn,
DBusMessage *msg, void *data)
{
[...]
if (lte->driver->set_property)
lte->driver->set_property(...);
What is this buying you?
else if (lte->driver->set_default_attach_info)
lte->driver->set_default_attach_info(...);
Hi Giacinto,
I got this change from external branches.
I doubted it was needed anymore, but couldn't be sure that I had tested
all cases.
thank you for checking it, and it can then be left out.
I can apply this patch without the chunk in question. Or do you want to
resubmit?
Regards,
Hi Giacinto,
On 09/20/2018 12:08 AM, Giacinto Cifelli wrote:
---
drivers/atmodem/sms.c | 1 +
1 file changed, 1 insertion(+)
Applied after tweaking the commit description.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
Hi Giacinto,
On 09/19/2018 11:49 PM, Giacinto Cifelli wrote:
---
drivers/mbimmodem/mbimmodem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied after tweaking the commit description.
Regards,
-Denis
___
ofono mailing list
Hi Giacinto,
An actual description of what is happening would be helpful
On 09/19/2018 11:47 PM, Giacinto Cifelli wrote:
---
drivers/mbimmodem/mbim.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mbimmodem/mbim.c b/drivers/mbimmodem/mbim.c
index 9fcf44b..f4132d0 100644
---
Hi Giacinto,
On 09/19/2018 11:39 PM, Giacinto Cifelli wrote:
according to g_thread documentation, this call is no longer needed,
and starting from g_thread version 2.32 it must not be used
---
src/main.c | 5 -
1 file changed, 5 deletions(-)
Both applied after tweaking the commit
Hi Giacinto,
On 09/19/2018 11:42 PM, Giacinto Cifelli wrote:
---
src/gprs.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gprs.c b/src/gprs.c
index 8f5d195..40f43e3 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -1642,6 +1642,9 @@ static void release_active_contexts(struct
Hi Giacinto,
On 09/19/2018 11:26 PM, Giacinto Cifelli wrote:
---
src/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied after tweaking the commit message.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
Hi Giacinto,
On 09/19/2018 10:25 PM, Giacinto Cifelli wrote:
---
drivers/atmodem/vendor.h | 1 +
1 file changed, 1 insertion(+)
Applied, thanks.
Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
Hi Giacinto,
So just to make sure:
- Your commit header should be no longer than 50 characters
Your commit description can be as long as you need, but broken down into
72 character wide lines.
It looks like your description is included in the header. I can't apply
this :)
On 09/19/2018
Hi Anirudh,
On 09/11/2018 03:32 AM, Anirudh Gargi wrote:
added CREG 'status' 6 and 7 for sms only registered state on E-UTRAN
for CREG cmd reply callback and URC notfiy.
---
drivers/atmodem/network-registration.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff
Hi Anirudh,
On 09/10/2018 10:52 PM, Anirudh Gargi wrote:
CREG status 6 and 7 added in network registration status, sms atom
to consider new states also.
---
src/common.h | 14 --
src/sms.c| 2 ++
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/common.h
Hi Slava,
On 09/19/2018 06:14 PM, Slava Monich wrote:
On 20/09/18 00:45, Denis Kenzior wrote:
(ANY = PAP_CHAP, and don't ask me why we added new values to the
beginning of the enum - it was before we started using binary
plugins). I would be more than happy if upstream started to use
Hi Frank,
Please stop top-posting on this mailing list. We follow the accepted
best practice of open source mailing lists and require replies to be
in-line.
Sep 19 20:17:41 gateway daemon.warn ofonod[152]: Context activated for
driver that doesn't support automatic context activation.
So
Hi Slava,
I understand that! It makes things easier for you guys.
But we had to avoid certain compile-time dependencies in ofono, and a
straightforward (and perhaps the only) way to achieve that was to use
binary plugins. For us plugin API is not subject to change (plugins
don't necessarily
Hi,
So I'm confused now. If sim800 is a serial device, why do you have all this
here? Shouldn't this be handled by setup_serial_modem ?
Because the modem was seen through a serial/USB converter, my kernel sees it as
a USB device. So I used this function.
Should this be coded in a more
501 - 600 of 3897 matches
Mail list logo
