Re: [PATCH 1/2] Internal and Driver API changes for Send USSD proactive command

2010-09-07 Thread Denis Kenzior
Hi Jeevaka, On 09/06/2010 04:21 AM, Jeevaka Badrappan wrote: --- drivers/atmodem/atutil.c | 111 + drivers/atmodem/atutil.h | 25 + drivers/atmodem/ussd.c | 136 +++--- drivers/isimodem/ussd.c |

Re: [PATCH 2/2] stk and stkutil changes for Send USSD proactive command

2010-09-07 Thread Denis Kenzior
On 09/06/2010 04:21 AM, Jeevaka Badrappan wrote: --- src/stk.c | 137 +++- src/stkutil.c | 22 + src/stkutil.h | 13 + 3 files changed, 169 insertions(+), 3 deletions(-) Changes to stkutil should come in a separate

Re: [PATCH 1/2] Internal and Driver API changes for Send USSD proactive command

2010-09-07 Thread Denis Kenzior
Hi Jeevaka, On 09/07/2010 12:29 PM, jeevaka.badrap...@elektrobit.com wrote: Hi Denis, -else if (charset == SMS_CHARSET_8BIT) { -/* TODO: Figure out what to do with 8 bit data */ +if (charset == SMS_CHARSET_7BIT) { +switch (data-charset) { +

Re: [originated PATCH 0/2]

2010-09-08 Thread Denis Kenzior
Hi Pekka, On 09/06/2010 10:09 AM, pekka.pe...@nokia.com wrote: Hi all, This patch adds the Originated property to the VoiceCall interface. It is used to determine if the call is originated from the mobile or not. Just throwing ideas, but would 'string Direction' with possible values in or

Re: [PATCH] Check if ussd is busy when doing ss

2010-09-09 Thread Denis Kenzior
Hi Yang, On 09/05/2010 09:19 PM, Yang Gu wrote: It's still not clear how ss and ussd interfere with each other. Current decision is each ss (call-barring, call-forwarding, etc.) has interference with ussd, but there is no interference within these ss. That is, call-barring has interference

Re: [PATCH] test: Update test-voicecall to reflect DBus types

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/04/2010 07:35 AM, Jeevaka Badrappan wrote: --- test/test-voicecall | 55 ++ 1 files changed, 29 insertions(+), 26 deletions(-) Patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH] TODO: update owner persist outgoing SMS messages task

2010-09-09 Thread Denis Kenzior
Hi Kristen, On 09/08/2010 09:47 AM, Kristen Carlson Accardi wrote: --- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index c4853ad..0c39da4 100644 --- a/TODO +++ b/TODO @@ -78,6 +78,7 @@ SMS Priority: High Complexity: C1 + Owner:

Re: [PATCH 1/3] sim: read EFiidf

2010-09-09 Thread Denis Kenzior
Hi Kristen, On 08/27/2010 11:19 AM, Kristen Carlson Accardi wrote: EFiidf can be larger than 256 bytes, so allow callers to read portions of the EFiidf from a specified offset. Cache EFiidf files as blocks of 256 bytes so that it's not necessary to read the entire (potentially large) file.

Re: [PATCH 2/3] sim: Implement GetIcon

2010-09-09 Thread Denis Kenzior
Hi Kristen, On 08/27/2010 11:19 AM, Kristen Carlson Accardi wrote: --- src/sim.c | 220 + 1 files changed, 220 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index bbcf609..d8c0d37 100644 --- a/src/sim.c

Re: Ofono and BT interaction

2010-09-09 Thread Denis Kenzior
Hi Emmanuel, On 09/09/2010 08:19 AM, Berthier, Emmanuel wrote: After pairing a Handset BT device with my Meego Handset board, ofono sees a new modem called /hfp/XX and can start a voice call on it. It is an interesting feature from a Netbook perspective, but could be very confusing from

Re: [PATCH] phonesim: Simulate a Send DTMF command in sim app.

2010-09-09 Thread Denis Kenzior
Hi Andrew, On 09/08/2010 12:54 PM, Andrzej Zaborowski wrote: --- src/qsimcommand.cpp|6 -- src/simapplication.cpp | 23 +++ src/simapplication.h |1 + 3 files changed, 28 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH] Fix sending User Cancel response to Set Up Call.

2010-09-09 Thread Denis Kenzior
Hi Andrew, On 09/08/2010 12:59 PM, Andrzej Zaborowski wrote: One of the clean-up commits changed the semantics of the dial request callback's parameter (NULL if call setup failed, non-NULL if success or user cancelled). --- src/stk.c |2 +- src/voicecall.c | 14 ++

Re: [PATCH 01/12] atutil changes for parsing cscs query and cscs support

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- drivers/atmodem/atutil.c | 78 ++ drivers/atmodem/atutil.h | 26 +++ 2 files changed, 104 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/atutil.c

Re: [PATCH 02/12] atgen changes for setting TE character set

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- plugins/atgen.c | 59 +++ 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/plugins/atgen.c b/plugins/atgen.c index 1ce2467..a8ca177 100644 ---

Re: [PATCH 05/12] Add internal api __ofono_call_barring_is_busy

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- src/call-barring.c |5 + src/ofono.h|3 +++ 2 files changed, 8 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH 06/12] Add internal api __ofono_call_forwarding_is_busy

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- src/call-forwarding.c |5 + src/ofono.h |3 +++ 2 files changed, 8 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono

Re: [PATCH 07/12] Add internal api __ofono_call_settings_is_busy

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- src/call-settings.c |5 + src/ofono.h |3 +++ 2 files changed, 8 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH 09/12] Add Send USSD terminal response data structures

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- src/stkutil.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) This patch has been applied, but I reworded the commit message somewhat. Regards, -Denis ___

Re: [PATCH 10/12] Add build_dataobj_ussd_text for ussd specific text string handling

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- src/stkutil.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ae4cc32..e953ead 100644 --- a/src/stkutil.c +++ b/src/stkutil.c

Re: [PATCH 12/12] Handling of Send USSD proactive command

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- src/stk.c | 141 - 1 files changed, 140 insertions(+), 1 deletions(-) diff --git a/src/stk.c b/src/stk.c index 3fda2af..ff194f1 100644 --- a/src/stk.c +++

Re: [PATCH 11/12] Internal and Driver api changes for Send USSD proactive command

2010-09-09 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 07:31 AM, Jeevaka Badrappan wrote: --- drivers/atmodem/ussd.c | 81 ++--- drivers/isimodem/ussd.c | 44 include/types.h |1 + include/ussd.h |8 ++- src/ofono.h | 17 + src/ussd.c

Re: [RFC PATCH 1/2] sms_util: status_report_expiration

2010-09-09 Thread Denis Kenzior
Hi Petteri, On 09/08/2010 05:31 AM, Petteri Tikander wrote: --- src/smsutil.c | 55 ++- src/smsutil.h |3 +-- unit/test-sms.c |7 +++ Could you please split up the smsutil changes and unit test changes into separate

Re: [RFC PATCH 2/2] sms_util: remove unused parameter

2010-09-09 Thread Denis Kenzior
Hi Petteri, On 09/08/2010 05:31 AM, Petteri Tikander wrote: --- src/smsutil.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) This one looks good to me. Thanks, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/2] Add Suspended property to GPRS atom

2010-09-09 Thread Denis Kenzior
Hi Mika, On 09/09/2010 07:08 AM, Mika Liljeberg wrote: Signed-off-by: Mika Liljeberg mika.liljeb...@nokia.com We don't use Signed-off-by, could you please configure your git not to include it? The only other nitpick I have is on your commit header, it should include gprs: prefix. E.g.

Re: [PATCH 2/2] isimodem: implement Suspended property

2010-09-09 Thread Denis Kenzior
Hi Mika, On 09/09/2010 07:08 AM, Mika Liljeberg wrote: Signed-off-by: Mika Liljeberg mika.liljeb...@nokia.com --- drivers/isimodem/debug.c | 25 drivers/isimodem/debug.h |2 + drivers/isimodem/gpds.h | 17 ++ drivers/isimodem/gprs.c | 56

Re: [PATCH] Fix sending User Cancel response to Set Up Call.

2010-09-09 Thread Denis Kenzior
Hi Andrew, On 09/08/2010 12:59 PM, Andrzej Zaborowski wrote: One of the clean-up commits changed the semantics of the dial request callback's parameter (NULL if call setup failed, non-NULL if success or user cancelled). Patch has been applied, thanks. Regards, -Denis

Re: Ofono and BT interaction

2010-09-10 Thread Denis Kenzior
Hi Emmanuel, On 09/10/2010 09:35 AM, Berthier, Emmanuel wrote: Hi Marcel, If you power on the HFP modem. If not, then oFono will do nothing. Yes, that's one solution. How to do that at BlueZ level? no idea actually. You can always start ofonod with -P hfp and then the HFP support should

Re: [RFC PATCH v2 1/4] sms_util: status_report_expiration

2010-09-10 Thread Denis Kenzior
Hi Petteri, On 09/10/2010 09:28 AM, Petteri Tikander wrote: --- src/smsutil.c | 51 --- src/smsutil.h |3 +-- 2 files changed, 49 insertions(+), 5 deletions(-) All four patches have been applied. Thanks :) The only thing pending on

Re: [PATCH 0/4] Add Suspended property to GPRS (take 3)

2010-09-10 Thread Denis Kenzior
Hi Mika, On 09/10/2010 08:50 AM, Mika Liljeberg wrote: Comments from Denis applied. Br, MikaL [PATCH 1/4] TODO: Claim ownership of Suspended property for GPRS [PATCH 2/4] gprs: add Suspended property [PATCH 3/4] isimodem: implement Suspended property [PATCH 4/4] test: add

Re: [PATCH 03/13] phonesim changes for setting TE character set

2010-09-10 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 02:01 PM, Jeevaka Badrappan wrote: --- plugins/phonesim.c | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) We use pretty strict git settings, your patch does not apply due to whitespace corruption: Applying:

Re: [PATCH 01/13] atutil changes for parsing cscs query and cscs support

2010-09-10 Thread Denis Kenzior
Hi Jeevaka, On 09/09/2010 01:56 PM, Jeevaka Badrappan wrote: --- drivers/atmodem/atutil.c | 83 ++ drivers/atmodem/atutil.h | 25 ++ 2 files changed, 108 insertions(+), 0 deletions(-) This patch has been applied, thanks.

Re: [PATCH 4/7] Add build_dataobj_ussd_text for ussd specific text string handling

2010-09-10 Thread Denis Kenzior
Hi Jeevaka, On 09/10/2010 03:19 PM, Jeevaka Badrappan wrote: --- src/stkutil.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH v2 1/1] Simulate send ss command in sim app

2010-09-10 Thread Denis Kenzior
Hi Yang, On 09/10/2010 01:09 AM, Yang Gu wrote: --- src/simapplication.cpp | 672 src/simapplication.h | 16 ++ 2 files changed, 688 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis

Re: RFC: Supporting STK without PDUs

2010-09-10 Thread Denis Kenzior
Hi Waldo, I propose to add a set of additional (optional) STK functions that a modem plugin can chose to use/implement instead: void (*envelope_parsed)(struct ofono_stk *stk, struct stk_envelope *e, ofono_stk_envelope_cb_t cb, void *data); /* if

Re: [PATCH 5/6] dun_gw: Add DUN server plugin for oFono

2010-09-13 Thread Denis Kenzior
Hi Zhenhua, + if (g_str_equal(property, Online) == TRUE) { + const char *path = dbus_message_get_path(msg); + struct ofono_modem *modem; + struct ofono_atom *gprs; + gboolean online; + + if (!dbus_message_iter_next(iter)) +

Re: [PATCH] Fix common misspellings

2010-09-13 Thread Denis Kenzior
Hi Lucas, On 09/13/2010 09:32 PM, Lucas De Marchi wrote: On Mon, Sep 13, 2010 at 10:35 PM, Marcel Holtmann mar...@holtmann.org wrote: no signed-off-by please. We don't use it. Sorry, I forgot this project follows the same rules as for connman. While in general I am all for fixing spelling

Re: [PATCH] phonesim: Fix multiple proactive command ind issue

2010-09-14 Thread Denis Kenzior
Hi Jeevaka, On 09/14/2010 11:22 AM, Jeevaka Badrappan wrote: --- src/phonesim.cpp | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/8] smsutil: Add USSD encoding function

2010-09-14 Thread Denis Kenzior
Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: --- src/smsutil.c | 29 + src/smsutil.h |1 + 2 files changed, 30 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis

Re: [PATCH 2/8] util: Add UCS2 to GSM 7bit converion function

2010-09-14 Thread Denis Kenzior
Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: --- src/util.c | 108 src/util.h | 10 + 2 files changed, 118 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis

Re: [PATCH 3/8] test-util: Add function for validating UCS2 to GSM bit conversion

2010-09-14 Thread Denis Kenzior
Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: --- unit/test-util.c | 80 ++ 1 files changed, 80 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis

Re: [PATCH 4/8] USSD atom driver changes to read current character setting

2010-09-14 Thread Denis Kenzior
Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: --- drivers/atmodem/ussd.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH 6/8] Add __ofono_ussd_initiate internal api for Sending USSD

2010-09-14 Thread Denis Kenzior
Hi Jeevaka, On 09/13/2010 06:00 PM, Jeevaka Badrappan wrote: --- src/ofono.h |7 + src/ussd.c | 86 ++- 2 files changed, 92 insertions(+), 1 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index f1c0973..8ab6a2e

Re: [PATCH 1/4] Internal and Driver API changes for Send USSD

2010-09-15 Thread Denis Kenzior
Hi Jeevaka, On 09/14/2010 04:23 PM, Jeevaka Badrappan wrote: --- drivers/atmodem/ussd.c | 115 --- drivers/isimodem/ussd.c | 42 +++-- include/ussd.h |8 ++- src/ussd.c | 39 +--- 4 files

Re: [PATCH 2/4] Add __ofono_ussd_initiate internal api for Sending USSD

2010-09-15 Thread Denis Kenzior
Hi Jeevaka, On 09/14/2010 04:31 PM, Jeevaka Badrappan wrote: --- src/ofono.h |8 + src/ussd.c | 101 --- 2 files changed, 104 insertions(+), 5 deletions(-) This patch has been applied, but simplified a bit afterward.

Re: [PATCH 3/4] stk: Handling of Send USSD proactive command

2010-09-15 Thread Denis Kenzior
Hi Jeevaka, On 09/14/2010 04:49 PM, Jeevaka Badrappan wrote: --- src/stk.c | 173 - 1 files changed, 172 insertions(+), 1 deletions(-) This patch has been applied, but refactored afterward. +

Re: [PATCH] phonesim: simulate language notification in sim app

2010-09-15 Thread Denis Kenzior
Hi Jeevaka, On 09/14/2010 05:27 PM, Jeevaka Badrappan wrote: --- src/qsimcommand.cpp| 11 src/simapplication.cpp | 68 src/simapplication.h |2 + 3 files changed, 81 insertions(+), 0 deletions(-) diff --git

Re: [PATCH] isimodem/ussd: clean const casts

2010-09-16 Thread Denis Kenzior
Hi Pekka, On 09/16/2010 08:50 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- drivers/isimodem/ussd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [isimodem-ussd PATCH 0/5] USSD fixes

2010-09-16 Thread Denis Kenzior
Hi Pekka, On 09/16/2010 12:32 PM, pekka.pe...@nokia.com wrote: Hi all, I've updated the isimodem ussd implementation to allow network-initiated operations. I've added some debug logging to the core ussd, too. The isimodem ussd now works with simple USSD applications with puSS-Request and

Re: [PATCH] phonesim: simulate language notification in sim app

2010-09-16 Thread Denis Kenzior
Hi Jeevaka, On 09/16/2010 01:39 PM, Jeevaka Badrappan wrote: --- src/qsimcommand.cpp| 38 src/qsimcommand.h |3 ++ src/simapplication.cpp | 76 src/simapplication.h |2 + 4 files changed, 119

Re: Description of Voice call history plugin patch

2010-09-16 Thread Denis Kenzior
Hi Raji, Design : Plugin uses memory mapped file for high performance input/output operations. File is used as cyclic queue for storing or reading records, it store s 50 records of 78bytes,hence fixed size file of 3916 bytes is used. File's first 16 bytes were used for storing header, and

Re: [PATCH 1/1] Enable some atoms for hso modem

2010-09-17 Thread Denis Kenzior
Hi Yang, @@ -257,24 +266,40 @@ static void hso_pre_sim(struct ofono_modem *modem) ofono_devinfo_create(modem, 0, atmodem, data-control); sim = ofono_sim_create(modem, OFONO_VENDOR_OPTION_HSO, atmodem, data-control); +

Re: Reg: Memory capacity exceeded

2010-09-20 Thread Denis Kenzior
Hi Jeevaka, On 09/20/2010 07:39 AM, jeevaka.badrap...@elektrobit.com wrote: Hi, Of course, one can argue whether this feature really has some real world relevance or is purely theoretical. I wonder if it is a type approval requirement to support? I'm afraid there is a PICS case for

Re: ofono gprs_primary_context description

2010-09-20 Thread Denis Kenzior
Hi Laurent, On 09/20/2010 04:20 AM, Laurent THOMAS wrote: Hi, According to the interface org.ofono.ConnectionContext description, the property “Name” is a free short string used to describe the context. Extract from “conman-api.txt” /Properties string Name [readwrite]/

Re: Reg: Memory capacity exceeded

2010-09-20 Thread Denis Kenzior
Hi Jeevaka, On 09/20/2010 09:08 AM, jeevaka.badrap...@elektrobit.com wrote: Hi Denis, The thing is, oFono configures SMS for direct delivery (e.g. no SM/ME storage). And even if direct delivery does not work (e.g. crappy modem or Class 2 / Class 3 messages) oFono still removes the SMS

Re: [PATCH] stk: Language Notification proactive cmd support

2010-09-21 Thread Denis Kenzior
Hi Jeevaka, On 09/16/2010 11:40 PM, Jeevaka Badrappan wrote: --- src/stk.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] Fix multi-line comment style issues

2010-09-21 Thread Denis Kenzior
Hi Jeevaka, On 09/21/2010 02:18 PM, Jeevaka Badrappan wrote: --- src/call-barring.c|9 ++--- src/call-forwarding.c | 15 ++- src/call-meter.c |6 -- src/call-settings.c |3 ++- src/cbs.c | 15 ++- src/common.c

Re: [RFC PATCH 1/2] smsutil: add fuzzy address check for status report

2010-09-22 Thread Denis Kenzior
On 09/21/2010 12:12 PM, Petteri Tikander wrote: --- src/smsutil.c | 103 - 1 files changed, 87 insertions(+), 16 deletions(-) Both patches have been applied, thanks! I reflowed the first patch a bit just to make it a little easier to

Re: support of emergency call when SIM not inserted ?

2010-09-23 Thread Denis Kenzior
Hi Anthony, I need a clarification about SIM: Most GSM mobile phones can dial emergency calls even when the phone is without a SIM card. But it seems that oFono does not support an emergency call if the sim driver is present but no SIM is inserted: This used to be supported, but

Re: [PATCH] Add GPRS suspension to doc/features.txt

2010-09-23 Thread Denis Kenzior
Hi Pekka, On 09/23/2010 10:11 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com --- doc/features.txt |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) When marking a task done, please send a patch for both TODO and doc/features.txt. This is easier to

Re: [PATCH 1/2] Fix valid_ussd_string()

2010-09-23 Thread Denis Kenzior
Hi Pekka, - * According to 22.030 Figure 3.5.3.2 USSD strings can be: - * - * Supplementary service control - * SIM control - * Manufacturer defined - * Terminated by '#' - * Short String - This can be any 2 digit short string. If the string - *

Re: [PATCH 2/2] Fix __ofono_voicecall_is_busy()

2010-09-23 Thread Denis Kenzior
Hi Pekka, @@ -2171,7 +2171,7 @@ int ofono_voicecall_get_next_callid(struct ofono_voicecall *vc) ofono_bool_t __ofono_voicecall_is_busy(struct ofono_voicecall *vc, enum ofono_voicecall_interaction type) { - if (vc-pending) + if (vc-pending ||

Re: [PATCH 0/1] Patch Description

2010-09-26 Thread Denis Kenzior
Hi Yang, On 09/24/2010 10:49 AM, Yang Gu wrote: Phonesim is most of time a convenient way to test oFono. For example, it can be used to test MO call, as well as MT call. And talking about test area, test automation is quite important regarding to both efficiency and effectiveness. In the

Re: Using ofono HFP

2010-09-26 Thread Denis Kenzior
Hi Moises, I was advised by padovan on IRC that I should try dbus = 1.3 ... I am going to try that today, I was putting that off cuz this seemed like a lower level issue and upgrading dbus seemed like non-trivial since many things depend on dbus and fedora 13 does not seem to include rpm for

Re: [PATCH 2/5] stk: Support send ss response

2010-09-26 Thread Denis Kenzior
Hi Yang, On 09/21/2010 05:21 AM, Yang Gu wrote: --- src/stkutil.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index cdd6b4e..d35094b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -5449,6 +5449,8 @@ const unsigned char

Re: [PATCH 4/5] ss: Use errno for ssc handling functions

2010-09-26 Thread Denis Kenzior
Hi Yang, + if (__ofono_call_barring_is_busy(cb)) + return EBUSY; Please use negative errno values, e.g. return -EBUSY, etc. if (strlen(sic) 0) - goto bad_format; + return EINVAL; here if (strlen(dn) 0) - goto

Re: [PATCH 3/5] ss: Use function to judge if it's busy

2010-09-26 Thread Denis Kenzior
Hi Yang, On 09/21/2010 05:21 AM, Yang Gu wrote: --- src/call-barring.c| 12 ++-- src/call-forwarding.c | 11 +++ src/call-settings.c | 12 ++-- 3 files changed, 19 insertions(+), 16 deletions(-) This patch has been applied, thanks. Regards, -Denis

Re: Please comment on callhistory API

2010-09-27 Thread Denis Kenzior
Hi Marcel, On 09/27/2010 12:50 PM, Marcel Holtmann wrote: Hi Raji, CallHistory hierarchy = Service : org.ofono Interface : org.ofono.CallHistory Object path : [variable prefix]/{modem0,modem1,...}/CallHistory the object path is wrong here. This should be pretty much on the

Re: Please comment on callhistory API

2010-09-27 Thread Denis Kenzior
Hi Marcel, On 09/27/2010 06:14 PM, Marcel Holtmann wrote: Hi Denis, CallHistory hierarchy = Service : org.ofono Interface : org.ofono.CallHistory Object path : [variable prefix]/{modem0,modem1,...}/CallHistory the object path is wrong here. This should be pretty much on the

Re: [PATCHv2] Fix 8bit port handling

2010-09-27 Thread Denis Kenzior
Hi Aki, On 09/27/2010 10:45 AM, Aki Niemi wrote: --- src/sms.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) This one looks good to me. Thanks, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] calypso: update power and reset path

2010-09-27 Thread Denis Kenzior
Hi Frank, On 09/27/2010 09:05 AM, Frank Gau wrote: --- plugins/calypso.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Patch has been applied, thanks. I'm assuming this will work with the latest Freerunner kernels only? Regards, -Denis

Re: [PATCH] hso : swap username and password for PAP

2010-09-27 Thread Denis Kenzior
Hi Benoit, On 09/27/2010 07:38 AM, Benoit Monin wrote: The parameters for the AT command AT$QCPDPP must be swapped for PAP in order to make to work with an Option modem. Tested with a GTM382 development kit. No idea about CHAP parameters. --- drivers/hsomodem/gprs-context.c | 2 +- 1 files

Re: [PATCH 1/7] Include datagram support to history API

2010-09-27 Thread Denis Kenzior
Hi Aki, --- a/src/history.c +++ b/src/history.c @@ -47,7 +47,15 @@ struct history_call_foreach_data { struct history_sms_foreach_data { const struct ofono_uuid *uuid; const char *address; - const char *text; + union { + const char *text; +

Re: Using ofono HFP

2010-09-28 Thread Denis Kenzior
Hi Moises, On 09/28/2010 09:33 PM, Moises Silva wrote: On Mon, Sep 27, 2010 at 9:26 PM, Zhang, Zhenhua zhenhua.zh...@intel.com wrote: Right. See bluez/audio/unix.c for BlueZ part SCO code that cooperate with pulseaudio. BlueZ sends SCO fd to pulseaudio via UNIX type socks. This put me

Re: [PATCH] stk: Additional info for failed Send USSD case

2010-09-30 Thread Denis Kenzior
Hi Jeevaka, + unsigned char addnl; Lets try to be consistent with other parts of stk.c. Use unsigned char no_cause[] = { 0x00 }; if (stk-pending_cmd-send_ussd.alpha_id stk-pending_cmd-send_ussd.alpha_id[0]) @@ -1661,7 +1662,14 @@ static void

Re: [PATCH] smart_messaging: Remove interface on atom removal

2010-09-30 Thread Denis Kenzior
Hi Aki, On 09/30/2010 03:22 AM, Aki Niemi wrote: --- plugins/smart_messaging.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: Query related to UDUB for voice calls.

2010-10-01 Thread Denis Kenzior
Hi Rajesh, Please, NO top posting on this list. On 10/01/2010 04:31 PM, rajesh.naga...@elektrobit.com wrote: Hi Sankar, My understanding is that when a call is rejected by the user, irrespective of whether its an incoming call or a waiting call, the cause value for the release call should

Re: [PATCH] stk: Additional info for failed Send USSD case

2010-10-02 Thread Denis Kenzior
Hi Jeevaka, On 10/01/2010 01:32 AM, Jeevaka Badrappan wrote: --- src/stk.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: Query related to UDUB for voice calls.

2010-10-04 Thread Denis Kenzior
Hi Sankar, This is your final reminder about not top-posting on this list. All further Emails like this will be ignored. On 10/04/2010 01:58 AM, Sankar wrote: HI Denis, Thanks for the response. I feel like due to the limitation of the AT modem interface through 27007, we are missing the

Re: [RFC PATCH 1/4] sim: check if FD is enabled in the SIM-card

2010-10-04 Thread Denis Kenzior
Hi Petteri, You did not necessarily missed anything:) So logically presim-state in SIM- enabled FDN has sense (or even switching to OFF_LINE-state). It can be my misunderstanding. We had some discussion with Denis of this issue, and I understood it so, that oFono-api has to remove rest of

Re: [RFC online/offline atoms PATCH 2/4] sms: watch modem state

2010-10-05 Thread Denis Kenzior
Hi Marcel, On 10/05/2010 06:59 AM, Marcel Holtmann wrote: Hi Pekka, Allow use of SMS atom in online and offline states. The messages are queued but not sent in offline mode. Errors occurring when an SMS is being sent while transition from online to offline are handled gracefully. do we

Re: [RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim

2010-10-05 Thread Denis Kenzior
Hi Marcel, what advantage to we have from moving SMS and GPRS atom into the post_sim state? I am trying to really understand what this is trying to do and what is the difference of just doing it when in post_online state. We'd like to be able to toggle GPRS settings even if in offline state.

Re: Error in setting VoiceNoReplyTimeout property in call-forwarding

2010-10-05 Thread Denis Kenzior
Hi Sai, On 10/05/2010 09:49 AM, sai koushik wrote: Hi, we are working on use-case to activate call-forwarding rule when no reply , but ofono is returning error Invalid arguments in method call when trying to set the reply-timeout value. below is the code for the use-case GValue

Re: [PATCH] doc: Play Tone command proposed d-bus API.

2010-10-06 Thread Denis Kenzior
Hi Andrew, On 10/06/2010 05:35 AM, Andrzej Zaborowski wrote: --- doc/stk-api.txt | 40 1 files changed, 40 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH] TODO: long phone numbers

2010-10-08 Thread Denis Kenzior
Hi Pekka, +- Long phone numbers. According to 3GPP TS 24.008, the callee address + can be up to 80 digits long. Is the goal here to only enable this on ATD or are we also talking about using EFext chaining here? Either way, a better description of the task scope might be helpful. Regards,

Re: [ussd-mmi PATCH 2/4] Check stk requests in __ofono_voicecall_is_busy()

2010-10-10 Thread Denis Kenzior
Hi Pekka, On 10/06/2010 09:52 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com Return true if a call is being dialed by stk. Use __ofono_voicecall_is_busy() in __ofono_voicecall_dial(). --- src/voicecall.c |9 ++--- 1 files changed, 2 insertions(+), 7

Re: [ussd-mmi PATCH 3/4] voicecall: remove dial_request_finish() cb param

2010-10-10 Thread Denis Kenzior
Hi Pekka, On 10/06/2010 09:52 AM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com There is no need for callback param anymore. --- src/voicecall.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) Patch has been applied, thanks. Regards,

Re: [PATCH 3/4] simfs: fix incorrect math when calculating length to copy

2010-10-13 Thread Denis Kenzior
Hi Kristen, On 10/04/2010 05:33 PM, Kristen Carlson Accardi wrote: --- src/simfs.c | 21 - 1 files changed, 12 insertions(+), 9 deletions(-) I fixed this slightly differently, can you check that my fix is correct? Regards, -Denis

Re: [PATCH] Add Ericsson c3607w and HP f3607gw/f3307 devices to udev rules file

2010-10-13 Thread Denis Kenzior
Hi Torgny, On 10/12/2010 07:41 AM, Torgny Johansson wrote: --- plugins/ofono.rules | 16 1 files changed, 16 insertions(+), 0 deletions(-) Patch has been applied with a slightly modified commit header. Regards, -Denis ___

Re: [PATCH 1/2] stk: Expose icon IDs on D-Bus.

2010-10-13 Thread Denis Kenzior
Hi Andrew, On 10/07/2010 09:20 AM, Andrzej Zaborowski wrote: Update the docs to match the properties in stk.c. --- doc/stk-api.txt | 16 ++- src/stk.c | 112 ++- src/stkagent.c | 41 src/stkagent.h

Re: [PATCH v2 0/3] Patch Description

2010-10-13 Thread Denis Kenzior
Hi Yang, On 09/30/2010 12:52 PM, Yang Gu wrote: This series of patches fix the compilation problem, as well as some memory leak. But the main focus is to enable Qt script so that phonesim GUI can be controlled using JavaScript. In the meantime, D-Bus support is added for the sake of test

Re: [PATCH 04/13] doc: Update property name to match code.

2010-10-13 Thread Denis Kenzior
Hi Andrew, On 10/13/2010 08:54 AM, Andrzej Zaborowski wrote: --- doc/stk-api.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 01/13] voicecall: __ofono_voicecall_send_tone internal api.

2010-10-14 Thread Denis Kenzior
Hi Andrew, On 10/13/2010 08:54 AM, Andrzej Zaborowski wrote: This provides a way for other atoms to send DTMF tones during a call. --- src/ofono.h |4 src/voicecall.c | 16 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/ofono.h

Re: [PATCH 02/13] stk: Handle the Send DTMF proactive command.

2010-10-14 Thread Denis Kenzior
Hi Andrew, On 10/13/2010 08:54 AM, Andrzej Zaborowski wrote: In this version 'p' is used as the pause character in DTMF strings as it seems in more widespread use than comma. ISImodem already understands 'p'. atmodem support comes in the next patch. --- I cannibalized this patch a little

Re: [PATCH 09/13] stk: Simplify and add icon to alphaId api.

2010-10-14 Thread Denis Kenzior
Hi Andrew, On 10/13/2010 08:54 AM, Andrzej Zaborowski wrote: The assumption is now that stk_alpha_id_set will handle NULL or empty alphaIds or icons. --- src/stk.c | 36 ++-- 1 files changed, 10 insertions(+), 26 deletions(-) I applied most of the chunks

Re: [PATCH 11/13] stkagent: Add PlayTone and LoopTone requests.

2010-10-14 Thread Denis Kenzior
Hi Andrew, On 10/13/2010 08:54 AM, Andrzej Zaborowski wrote: --- src/stkagent.c | 94 src/stkagent.h | 13 2 files changed, 107 insertions(+), 0 deletions(-) This patch has been applied. Thanks. Regards, -Denis

Re: [PATCH 13/13] [RfC] API for STK driver to signal executed commands.

2010-10-14 Thread Denis Kenzior
Hi Andrew, On 10/13/2010 08:54 AM, Andrzej Zaborowski wrote: Some modems are able to handle some proactive commands in their firmware or otherwise, if the command doesn't require input from user. Nevertheles ofono may need to update internal state or notify the user where necessary. With

Re: [RFC PATCH 3/8] simutil: response-handler returns now also file-status

2010-10-14 Thread Denis Kenzior
Hi Petteri, On 10/12/2010 10:18 AM, Petteri Tikander wrote: --- src/simutil.c |5 - src/simutil.h | 11 ++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/simutil.c b/src/simutil.c index 65ce1ac..04ba975 100644 --- a/src/simutil.c +++

Re: [RFC PATCH 6/8] simutil: add ID of EFadn

2010-10-14 Thread Denis Kenzior
Hi Petteri, On 10/12/2010 10:18 AM, Petteri Tikander wrote: --- src/simutil.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [RFC PATCH 7/8] sim: check if Fixed Dialing is enabled in the SIM-card

2010-10-14 Thread Denis Kenzior
Hi Petteri, On 10/12/2010 10:18 AM, Petteri Tikander wrote: If FD is enabled, halt SIM initialization procedure. New property (FixedDialing) is added. If FD is enabled, this has been signalled via DBUS. --- src/sim.c | 81 ++--- 1

Re: [PATCH v2 0/3] Patch Description

2010-10-14 Thread Denis Kenzior
Hi Yang, On 10/14/2010 06:17 AM, Gu, Yang wrote: Hi Denis, Then we set the path of script and run the script with its name dbus-send --system --print-reply --dest=org.phonesim / org.phonesim.Script.SetPath string:/tmp/call dbus-send --system --print-reply --dest=org.phonesim /

<    2   3   4   5   6   7   8   9   10   11   >